Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix invalid snowplow schema (#67250)

Mahatthana (Kelvin) Nomsawadie44789763f6a
diff --git a/e2e/test/scenarios/embedding/sdk-iframe-embedding/sdk-iframe-embedding.cy.spec.ts b/e2e/test/scenarios/embedding/sdk-iframe-embedding/sdk-iframe-embedding.cy.spec.ts
index eae295e0564..89ebf4a962f 100644
--- a/e2e/test/scenarios/embedding/sdk-iframe-embedding/sdk-iframe-embedding.cy.spec.ts
+++ b/e2e/test/scenarios/embedding/sdk-iframe-embedding/sdk-iframe-embedding.cy.spec.ts
@@ -330,6 +330,7 @@ describe("scenarios > embedding > Modular embedding", () => {
component: "metabase-dashboard",
attributes: {
dashboardId: ORDERS_DASHBOARD_ID,
+ "with-subscriptions": true,
},
},
{
@@ -376,6 +377,10 @@ describe("scenarios > embedding > Modular embedding", () => {
false: 0,
true: 1,
},
+ with_subscriptions: {
+ false: 0,
+ true: 1,
+ },
},
question: {
drills: {
diff --git a/frontend/src/metabase/lib/analytics.ts b/frontend/src/metabase/lib/analytics.ts
index 5ee338e31f3..f9df514c4a9 100644
--- a/frontend/src/metabase/lib/analytics.ts
+++ b/frontend/src/metabase/lib/analytics.ts
@@ -23,7 +23,7 @@ const VERSIONS: Record<SchemaType, SchemaVersion> = {
downloads: "1-0-0",
embed_flow: "1-0-3",
embed_share: "1-0-1",
- embedded_analytics_js: "1-0-0",
+ embedded_analytics_js: "2-0-0",
embedding_homepage: "1-0-0",
simple_event: "1-0-0",
invite: "1-0-1",
diff --git a/snowplow/iglu-client-embedded/schemas/com.metabase/embedded_analytics_js/jsonschema/1-0-1 b/snowplow/iglu-client-embedded/schemas/com.metabase/embedded_analytics_js/jsonschema/2-0-0
similarity index 73%
rename from snowplow/iglu-client-embedded/schemas/com.metabase/embedded_analytics_js/jsonschema/1-0-1
rename to snowplow/iglu-client-embedded/schemas/com.metabase/embedded_analytics_js/jsonschema/2-0-0
index d8722840e66..5fbc6708ee1 100644
--- a/snowplow/iglu-client-embedded/schemas/com.metabase/embedded_analytics_js/jsonschema/1-0-1
+++ b/snowplow/iglu-client-embedded/schemas/com.metabase/embedded_analytics_js/jsonschema/2-0-0
@@ -5,7 +5,7 @@
"vendor": "com.metabase",
"name": "embedded_analytics_js",
"format": "jsonschema",
- "version": "1-0-1"
+ "version": "2-0-0"
},
"type": "object",
"properties": {
@@ -23,7 +23,10 @@
"properties": {
"auth_method": {
"description": "Authentication method used for the modular embedding.",
- "type": "string",
+ "type": [
+ "string",
+ "null"
+ ],
"enum": [
"session",
"api_key",
@@ -35,7 +38,7 @@
}
},
"dashboard": {
- "description": "Counts of <metabase-dashboard> component properties.",
+ "description": "Aggregated configuration counts for <metabase-dashboard>",
"type": [
"object",
"null"
@@ -43,7 +46,10 @@
"properties": {
"drills": {
"description": "Counts of dashboards with drills enabled or disabled.",
- "type": "object",
+ "type": [
+ "object",
+ "null"
+ ],
"properties": {
"true": {
"description": "Number of dashboards with drills enabled.",
@@ -57,11 +63,18 @@
"minimum": 0,
"maximum": 2147483647
}
- }
+ },
+ "required": [
+ "true",
+ "false"
+ ]
},
"with_downloads": {
"description": "Counts of dashboards with downloads enabled or disabled.",
- "type": "object",
+ "type": [
+ "object",
+ "null"
+ ],
"properties": {
"true": {
"description": "Number of dashboards with downloads enabled.",
@@ -75,14 +88,21 @@
"minimum": 0,
"maximum": 2147483647
}
- }
+ },
+ "required": [
+ "true",
+ "false"
+ ]
},
"with_title": {
- "description": "Counts of dashboards with title shown or hidden.",
- "type": "object",
+ "description": "Counts of dashboards with title visible or hidden.",
+ "type": [
+ "object",
+ "null"
+ ],
"properties": {
"true": {
- "description": "Number of dashboards with title shown.",
+ "description": "Number of dashboards with title visible.",
"type": "integer",
"minimum": 0,
"maximum": 2147483647
@@ -93,11 +113,18 @@
"minimum": 0,
"maximum": 2147483647
}
- }
+ },
+ "required": [
+ "true",
+ "false"
+ ]
},
"with_subscriptions": {
"description": "Counts of dashboards with subscriptions enabled or disabled.",
- "type": "object",
+ "type": [
+ "object",
+ "null"
+ ],
"properties": {
"true": {
"description": "Number of dashboards with subscriptions enabled.",
@@ -111,12 +138,16 @@
"minimum": 0,
"maximum": 2147483647
}
- }
+ },
+ "required": [
+ "true",
+ "false"
+ ]
}
}
},
"question": {
- "description": "Counts of <metabase-question> component properties.",
+ "description": "Aggregated configuration counts for <metabase-question>",
"type": [
"object",
"null"
@@ -124,7 +155,10 @@
"properties": {
"drills": {
"description": "Counts of questions with drills enabled or disabled.",
- "type": "object",
+ "type": [
+ "object",
+ "null"
+ ],
"properties": {
"true": {
"description": "Number of questions with drills enabled.",
@@ -138,11 +172,18 @@
"minimum": 0,
"maximum": 2147483647
}
- }
+ },
+ "required": [
+ "true",
+ "false"
+ ]
},
"with_downloads": {
"description": "Counts of questions with downloads enabled or disabled.",
- "type": "object",
+ "type": [
+ "object",
+ "null"
+ ],
"properties": {
"true": {
"description": "Number of questions with downloads enabled.",
@@ -156,14 +197,21 @@
"minimum": 0,
"maximum": 2147483647
}
- }
+ },
+ "required": [
+ "true",
+ "false"
+ ]
},
"with_title": {
- "description": "Counts of questions with title shown or hidden.",
- "type": "object",
+ "description": "Counts of questions with title visible or hidden.",
+ "type": [
+ "object",
+ "null"
+ ],
"properties": {
"true": {
- "description": "Number of questions with title shown.",
+ "description": "Number of questions with title visible.",
"type": "integer",
"minimum": 0,
"maximum": 2147483647
@@ -174,11 +222,18 @@
"minimum": 0,
"maximum": 2147483647
}
- }
+ },
+ "required": [
+ "true",
+ "false"
+ ]
},
"is_save_enabled": {
"description": "Counts of questions with save enabled or disabled.",
- "type": "object",
+ "type": [
+ "object",
+ "null"
+ ],
"properties": {
"true": {
"description": "Number of questions with save enabled.",
@@ -192,12 +247,16 @@
"minimum": 0,
"maximum": 2147483647
}
- }
+ },
+ "required": [
+ "true",
+ "false"
+ ]
}
}
},
"exploration": {
- "description": "Counts of <metabase-question> component with question-id=\"new\" properties.",
+ "description": "Aggregated configuration counts for <metabase-question> with question-id=\"new\"",
"type": [
"object",
"null"
@@ -205,7 +264,10 @@
"properties": {
"is_save_enabled": {
"description": "Counts of explorations with save enabled or disabled.",
- "type": "object",
+ "type": [
+ "object",
+ "null"
+ ],
"properties": {
"true": {
"description": "Number of explorations with save enabled.",
@@ -219,12 +281,16 @@
"minimum": 0,
"maximum": 2147483647
}
- }
+ },
+ "required": [
+ "true",
+ "false"
+ ]
}
}
},
"browser": {
- "description": "Counts of <metabase-browser> component properties.",
+ "description": "Aggregated configuration counts for <metabase-browser>",
"type": [
"object",
"null"
@@ -232,7 +298,10 @@
"properties": {
"read_only": {
"description": "Counts of browsers with read-only mode enabled or disabled.",
- "type": "object",
+ "type": [
+ "object",
+ "null"
+ ],
"properties": {
"true": {
"description": "Number of browsers with read-only mode enabled.",
@@ -246,7 +315,11 @@
"minimum": 0,
"maximum": 2147483647
}
- }
+ },
+ "required": [
+ "true",
+ "false"
+ ]
}
}
}
@@ -254,5 +327,6 @@
"required": [
"event",
"global"
- ]
+ ],
+ "additionalProperties": true
}