Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

remove quarantine-engine paramater from test-driver action (#82107)

Chris Vandoodewaarde49b98186b17
diff --git a/.github/actions/test-driver/action.yml b/.github/actions/test-driver/action.yml
index 9cf72695e9f..4cdcf1c8f82 100644
--- a/.github/actions/test-driver/action.yml
+++ b/.github/actions/test-driver/action.yml
@@ -20,8 +20,6 @@ inputs:
required: false
default: "ee"
description: Edition to test (oss or ee)
- quarantine-engine:
- required: false
granular-rerun:
required: false
default: "true"
@@ -199,4 +197,4 @@ runs:
with:
adapter: backend
test-suite: ${{ inputs.junit-name }}
- enforce-quarantine: ${{ inputs.quarantine-engine == 'ci-conductor' }}
+ enforce-quarantine: "true"
diff --git a/.github/workflows/app-db.yml b/.github/workflows/app-db.yml
index 8e5ce6c6482..fa0e02a53ec 100644
--- a/.github/workflows/app-db.yml
+++ b/.github/workflows/app-db.yml
@@ -217,7 +217,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-mysql:
needs: app-db-matrix
@@ -311,7 +310,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-postgres:
needs: app-db-matrix
@@ -388,7 +386,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
app-db-tests-result:
needs:
diff --git a/.github/workflows/drivers.yml b/.github/workflows/drivers.yml
index b7c783b8d33..86611faf95d 100644
--- a/.github/workflows/drivers.yml
+++ b/.github/workflows/drivers.yml
@@ -74,6 +74,7 @@ jobs:
# All decision logic is consolidated in mage driver-decisions.
determine-driver-skips:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
+ timeout-minutes: 10
outputs:
# All driver run decisions (from mage driver-decisions)
h2-should-run: ${{ steps.driver-decisions.outputs.h2-should-run }}
@@ -162,7 +163,6 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-bigquery-cloud-sdk-ee:
needs: determine-driver-skips
@@ -216,7 +216,6 @@ jobs:
junit-name: 'be-tests-bigquery-cloud-sdk-ee'
test-args: ${{ matrix.job.test-args }}
artifact-suffix: ${{ matrix.job.name }}
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -279,7 +278,6 @@ jobs:
junit-name: 'be-tests-clickhouse-ee'
test-args: ${{ matrix.job.test-args }}
artifact-suffix: ${{ matrix.job.name }}
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -313,7 +311,6 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-databricks-ee:
needs: determine-driver-skips
@@ -376,7 +373,6 @@ jobs:
junit-name: 'be-tests-databricks-ee'
artifact-suffix: ${{ matrix.job.name }}
test-args: ${{ matrix.job.test-args }}
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-h2:
needs: determine-driver-skips
@@ -396,7 +392,6 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-h2-oss:
needs: determine-driver-skips
@@ -417,7 +412,6 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-mysql-mariadb:
needs: determine-driver-skips
@@ -536,7 +530,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Cleanup python-runner
if: always()
uses: ./.github/actions/cleanup-python-runner
@@ -596,7 +589,6 @@ jobs:
junit-name: ${{ matrix.version.junit-name }}
test-args: ${{ matrix.job.test-args }}
artifact-suffix: ${{ matrix.version.name }}-${{ matrix.job.name }}
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -658,7 +650,6 @@ jobs:
test-args: >-
:exclude-tags '[:mongo-sharded-cluster-tests :mb/transforms-python-test]'
:only-tags [:mb/driver-tests]
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-mongo-sharded-cluster-ee:
needs: determine-driver-skips
@@ -683,7 +674,6 @@ jobs:
junit-name: 'be-tests-mongo-sharded-cluster-ee'
test-args: >-
:only metabase.driver.mongo.sharded-cluster-test
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-oracle:
needs: determine-driver-skips
@@ -748,7 +738,6 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-postgres:
needs: determine-driver-skips
@@ -841,7 +830,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Cleanup python-runner
if: always()
uses: ./.github/actions/cleanup-python-runner
@@ -908,7 +896,6 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-redshift-ee:
needs: determine-driver-skips
@@ -999,7 +986,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
artifact-suffix: ${{ matrix.job.name }}
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -1062,7 +1048,6 @@ jobs:
junit-name: 'be-tests-snowflake-ee'
test-args: ${{ matrix.job.test-args }}
artifact-suffix: ${{ matrix.job.name }}
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -1094,7 +1079,6 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-sqlite-ee:
needs: determine-driver-skips
@@ -1115,7 +1099,6 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-sqlserver:
needs: determine-driver-skips
@@ -1171,7 +1154,6 @@ jobs:
junit-name: ${{ matrix.version.junit-name }}
test-args: ${{ matrix.job.test-args }}
artifact-suffix: ${{ matrix.version.name }}-${{ matrix.job.name }}
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -1268,7 +1250,6 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
drivers-tests-result:
needs:
diff --git a/.github/workflows/semantic-search.yml b/.github/workflows/semantic-search.yml
index e3435cf1823..f9202256126 100644
--- a/.github/workflows/semantic-search.yml
+++ b/.github/workflows/semantic-search.yml
@@ -96,7 +96,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
semantic-search-tests-mariadb:
if: ${{ !inputs.skip && (inputs.suite == '' || inputs.suite == 'mariadb') }}
@@ -162,7 +161,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
semantic-search-tests-mysql:
if: ${{ !inputs.skip && (inputs.suite == '' || inputs.suite == 'mysql') }}
@@ -235,7 +233,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
semantic-search-tests-postgres:
if: ${{ !inputs.skip && (inputs.suite == '' || inputs.suite == 'postgres') }}
@@ -300,7 +297,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
# pgvector-on-the-app-db mode: the app db itself is a pgvector-capable Postgres and
# MB_PGVECTOR_DB_URL is deliberately unset. The dedicated-harness tests gate themselves off; the
@@ -355,7 +351,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
semantic-search-tests-result:
needs: