Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Avoid extra interval with single interval in Bar chart (#64175)

Romeo Van Snicke50317d86dd2
diff --git a/.loki/reference/chrome_laptop_Viz_Static_Viz_ComboChart_No_Good_Axis_Split.png b/.loki/reference/chrome_laptop_Viz_Static_Viz_ComboChart_No_Good_Axis_Split.png
index e339b284c9f..b7e4ea148fc 100644
Binary files a/.loki/reference/chrome_laptop_Viz_Static_Viz_ComboChart_No_Good_Axis_Split.png and b/.loki/reference/chrome_laptop_Viz_Static_Viz_ComboChart_No_Good_Axis_Split.png differ
diff --git a/e2e/test/scenarios/visualizations-charts/visualizations-charts-reproductions.cy.spec.js b/e2e/test/scenarios/visualizations-charts/visualizations-charts-reproductions.cy.spec.js
index 66f8bfd19f2..1e4b0af55a0 100644
--- a/e2e/test/scenarios/visualizations-charts/visualizations-charts-reproductions.cy.spec.js
+++ b/e2e/test/scenarios/visualizations-charts/visualizations-charts-reproductions.cy.spec.js
@@ -1282,3 +1282,42 @@ describe("issue 54271", () => {
H.assertQueryBuilderRowCount(1076);
});
});
+
+describe("issue 63671", () => {
+ beforeEach(() => {
+ H.restore();
+ cy.signInAsAdmin();
+
+ H.createQuestion(
+ {
+ query: {
+ "source-table": PRODUCTS_ID,
+ aggregation: [["count"]],
+ breakout: [
+ [
+ "field",
+ PRODUCTS.CREATED_AT,
+ {
+ "temporal-unit": "year",
+ },
+ ],
+ ],
+ filter: [
+ "between",
+ ["field", PRODUCTS.CREATED_AT, null],
+ "2025-01-01",
+ "2025-12-31",
+ ],
+ },
+ display: "bar",
+ },
+ { visitQuestion: true },
+ );
+ });
+
+ it("should not show an extra value on bar charts when there is only value on the x axis (metabase#63671)", () => {
+ cy.findByTestId("query-visualization-root")
+ .findByText("2025")
+ .should("have.length", 1);
+ });
+});
diff --git a/frontend/src/metabase/visualizations/echarts/cartesian/option/ticks.ts b/frontend/src/metabase/visualizations/echarts/cartesian/option/ticks.ts
index 9d1d918ddf8..114cd9a40d8 100644
--- a/frontend/src/metabase/visualizations/echarts/cartesian/option/ticks.ts
+++ b/frontend/src/metabase/visualizations/echarts/cartesian/option/ticks.ts
@@ -18,7 +18,7 @@ import {
// will be rendered without the second tick. However, for ["2022-01-02", "2022-01-03"] ECharts would corectly render two ticks as needed.
// The workaround is to add more padding on sides for this corner case.
const getPadding = (intervalsCount: number) => {
- if (intervalsCount === 1) {
+ if (intervalsCount <= 1) {
return 5 / 6;
}