Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Show EmptyState with `publish` button on the GetCode step when an entity is not published (#66789)

Timofey Kachalove52c6c5717f2
diff --git a/e2e/support/helpers/e2e-embedding-helpers.js b/e2e/support/helpers/e2e-embedding-helpers.js
index b8d518e7967..cd70fb4b84a 100644
--- a/e2e/support/helpers/e2e-embedding-helpers.js
+++ b/e2e/support/helpers/e2e-embedding-helpers.js
@@ -294,7 +294,7 @@ export function publishChanges(apiPath, callback) {
/**
* Unpublish a static dashboard or question
* @param {"card" | "dashboard"} apiPath
- * @param callback
+ * @param [callback]
*/
export function unpublishChanges(apiPath, callback) {
cy.intercept("PUT", `/api/${apiPath}/*`, (req) => {
diff --git a/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/common.cy.spec.ts b/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/common.cy.spec.ts
index 9ea9a363c49..a583007453b 100644
--- a/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/common.cy.spec.ts
+++ b/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/common.cy.spec.ts
@@ -1,4 +1,8 @@
-import { completeWizard, navigateToEntitySelectionStep } from "./helpers";
+import {
+ getEmbedSidebar,
+ navigateToEntitySelectionStep,
+ navigateToGetCodeStep,
+} from "./helpers";
const { H } = cy;
@@ -34,11 +38,19 @@ describe("scenarios > embedding > sdk iframe embed setup > common", () => {
});
it("should close wizard when clicking `Done` button on the last step", () => {
- completeWizard({
+ navigateToGetCodeStep({
experience: "dashboard",
resourceName: DASHBOARD_NAME,
});
+ H.publishChanges("dashboard");
+
+ cy.button("Unpublish").should("be.visible");
+
+ getEmbedSidebar().within(() => {
+ cy.findByText("Done").click();
+ });
+
H.modal().should("not.exist");
cy.findAllByTestId("sdk-setting-card").should("be.visible");
});
diff --git a/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/get-code.cy.spec.ts b/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/get-code.cy.spec.ts
index 2dea47013ab..7afb99d0c18 100644
--- a/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/get-code.cy.spec.ts
+++ b/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/get-code.cy.spec.ts
@@ -103,6 +103,7 @@ describe(suiteTitle, () => {
navigateToGetCodeStep({
experience: "dashboard",
resourceName: DASHBOARD_NAME,
+ preselectSso: true,
});
getEmbedSidebar().within(() => {
diff --git a/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/guest-embed-ee.cy.spec.ts b/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/guest-embed-ee.cy.spec.ts
index 7eada077be7..efc42a66ebb 100644
--- a/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/guest-embed-ee.cy.spec.ts
+++ b/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/guest-embed-ee.cy.spec.ts
@@ -211,6 +211,24 @@ describe("scenarios > embedding > sdk iframe embed setup > guest-embed", () => {
});
// Get code step
+ getEmbedSidebar().within(() => {
+ cy.findByTestId("publish-guest-embed-link").should("not.exist");
+ });
+
+ H.unpublishChanges("card");
+
+ getEmbedSidebar().within(() => {
+ cy.findByTestId("publish-guest-embed-link").should("be.visible");
+
+ cy.findByText(/Copy code/).should("not.exist");
+ });
+
+ H.publishChanges("card");
+
+ getEmbedSidebar().within(() => {
+ cy.findByTestId("publish-guest-embed-link").should("not.exist");
+ });
+
getEmbedSidebar().within(() => {
cy.findAllByText(/Copy code/)
.first()
diff --git a/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/select-embed-options.cy.spec.ts b/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/select-embed-options.cy.spec.ts
index 5996fe405a7..0c32a5e5dd6 100644
--- a/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/select-embed-options.cy.spec.ts
+++ b/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/select-embed-options.cy.spec.ts
@@ -305,6 +305,10 @@ describe(suiteTitle, () => {
resourceName: DASHBOARD_NAME,
});
+ H.publishChanges("dashboard");
+
+ cy.button("Unpublish").should("be.visible");
+
getEmbedSidebar()
.findByLabelText("Show dashboard title")
.should("be.checked");
@@ -329,7 +333,7 @@ describe(suiteTitle, () => {
H.expectUnstructuredSnowplowEvent({
event: "embed_wizard_options_completed",
event_detail:
- 'settings=custom,experience=dashboard,guestEmbedEnabled=false,authType=guest-embed,drills=false,withDownloads=false,withSubscriptions=false,withTitle=false,params={"disabled":0,"locked":0,"enabled":0},theme=default',
+ 'settings=custom,experience=dashboard,guestEmbedEnabled=true,guestEmbedType=guest-embed,authType=guest-embed,drills=false,withDownloads=false,withSubscriptions=false,withTitle=false,params={"disabled":0,"locked":0,"enabled":0},theme=default',
});
codeBlock().should("contain", 'with-title="false"');
@@ -378,6 +382,10 @@ describe(suiteTitle, () => {
resourceName: QUESTION_NAME,
});
+ H.publishChanges("card");
+
+ cy.button("Unpublish").should("be.visible");
+
getEmbedSidebar()
.findByLabelText("Allow downloads")
.should("not.be.checked");
@@ -402,7 +410,7 @@ describe(suiteTitle, () => {
H.expectUnstructuredSnowplowEvent({
event: "embed_wizard_options_completed",
event_detail:
- 'settings=custom,experience=chart,guestEmbedEnabled=false,authType=guest-embed,drills=false,withDownloads=true,withTitle=true,isSaveEnabled=false,params={"disabled":0,"locked":0,"enabled":0},theme=default',
+ 'settings=custom,experience=chart,guestEmbedEnabled=true,guestEmbedType=guest-embed,authType=guest-embed,drills=false,withDownloads=true,withTitle=true,isSaveEnabled=false,params={"disabled":0,"locked":0,"enabled":0},theme=default',
});
codeBlock().should("contain", 'with-downloads="true"');
@@ -571,6 +579,10 @@ describe(suiteTitle, () => {
resourceName: DASHBOARD_NAME,
});
+ H.publishChanges("dashboard");
+
+ cy.button("Unpublish").should("be.visible");
+
cy.log("brand color should be visible");
getEmbedSidebar().within(() => {
cy.findByText("Brand color").should("be.visible");
@@ -605,7 +617,7 @@ describe(suiteTitle, () => {
H.expectUnstructuredSnowplowEvent({
event: "embed_wizard_options_completed",
event_detail:
- 'settings=custom,experience=dashboard,guestEmbedEnabled=false,authType=guest-embed,drills=false,withDownloads=false,withSubscriptions=false,withTitle=true,params={"disabled":0,"locked":0,"enabled":0},theme=custom',
+ 'settings=custom,experience=dashboard,guestEmbedEnabled=true,guestEmbedType=guest-embed,authType=guest-embed,drills=false,withDownloads=false,withSubscriptions=false,withTitle=true,params={"disabled":0,"locked":0,"enabled":0},theme=custom',
});
codeBlock().should("contain", '"theme": {');
diff --git a/frontend/src/metabase/admin/settings/components/EmbeddingSettings/LinkButton/LinkButton.tsx b/frontend/src/metabase/admin/settings/components/EmbeddingSettings/LinkButton/LinkButton.tsx
deleted file mode 100644
index 58136515351..00000000000
--- a/frontend/src/metabase/admin/settings/components/EmbeddingSettings/LinkButton/LinkButton.tsx
+++ /dev/null
@@ -1,19 +0,0 @@
-import { Link } from "react-router";
-
-import { Button, type ButtonProps } from "metabase/ui";
-
-// component={Link} breaks the styling when the button is disabled
-// disabling a link button doesn't look like a common enough scenario to make an exported component
-export const LinkButton = ({
- to,
- disabled,
- ...buttonProps
-}: { to: string; disabled?: boolean } & ButtonProps) => {
- return disabled ? (
- <Button disabled={disabled} {...buttonProps} />
- ) : (
- <Link to={to}>
- <Button {...buttonProps} />
- </Link>
- );
-};
diff --git a/frontend/src/metabase/admin/settings/components/EmbeddingSettings/LinkButton/index.ts b/frontend/src/metabase/admin/settings/components/EmbeddingSettings/LinkButton/index.ts
deleted file mode 100644
index 6287dc8de6c..00000000000
--- a/frontend/src/metabase/admin/settings/components/EmbeddingSettings/LinkButton/index.ts
+++ /dev/null
@@ -1 +0,0 @@
-export * from "./LinkButton";
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/CodeSnippet/CopyCodeSnippetButton.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/GetCode/CopyCodeSnippetButton.tsx
similarity index 100%
rename from frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/CodeSnippet/CopyCodeSnippetButton.tsx
rename to frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/GetCode/CopyCodeSnippetButton.tsx
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/GetCode/PublishQuestionEmptyState.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/GetCode/PublishQuestionEmptyState.tsx
new file mode 100644
index 00000000000..7ad77023842
--- /dev/null
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/GetCode/PublishQuestionEmptyState.tsx
@@ -0,0 +1,47 @@
+import { c, t } from "ttag";
+
+import EmptyStateImage from "assets/img/empty-states/snippet.svg";
+import EmptyState from "metabase/common/components/EmptyState";
+import { useSdkIframeEmbedSetupContext } from "metabase/embedding/embedding-iframe-sdk-setup/context";
+import { useToggleResourceEmbedding } from "metabase/embedding/embedding-iframe-sdk-setup/hooks/use-toggle-resource-embedding";
+import { getResourceTypeFromExperience } from "metabase/embedding/embedding-iframe-sdk-setup/utils/get-resource-type-from-experience";
+import { Anchor, Flex, Loader } from "metabase/ui";
+
+export const PublishQuestionEmptyState = () => {
+ const { experience, isFetching } = useSdkIframeEmbedSetupContext();
+ const toggleEmbedding = useToggleResourceEmbedding();
+
+ if (!toggleEmbedding) {
+ return null;
+ }
+
+ const { handleSave } = toggleEmbedding;
+
+ return (
+ <Flex direction="column" align="center" justify="center" flex={1}>
+ <EmptyState
+ illustrationElement={<img src={EmptyStateImage} />}
+ message={
+ isFetching ? (
+ <Loader size="xs" />
+ ) : (
+ c(
+ "{0} is a link that publishes an entity to be embeddable via Guest Embedding",
+ ).jt`To get the embedding code, ${(
+ <Anchor
+ key="publish-guest-embed-question"
+ target="_blank"
+ size="md"
+ lh="lg"
+ onClick={handleSave}
+ data-testid="publish-guest-embed-link"
+ >
+ {t`publish this ${getResourceTypeFromExperience(experience)}`}
+ </Anchor>
+ )}.`
+ )
+ }
+ />
+ </Flex>
+ );
+};
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/GetCodeStep.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/GetCodeStep.tsx
index 1c91af62673..3a754dca46c 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/GetCodeStep.tsx
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/GetCodeStep.tsx
@@ -4,7 +4,8 @@ import { useUpdateSettingsMutation } from "metabase/api";
import { CodeEditor } from "metabase/common/components/CodeEditor";
import { MoreServerSnippetExamplesLink } from "metabase/embedding/components/MoreServerSnippetExamplesLink/MoreServerSnippetExamplesLink";
import { MetabaseAccountSection } from "metabase/embedding/embedding-iframe-sdk-setup/components/Authentication/MetabaseAccountSection";
-import { CopyCodeSnippetButton } from "metabase/embedding/embedding-iframe-sdk-setup/components/CodeSnippet/CopyCodeSnippetButton";
+import { CopyCodeSnippetButton } from "metabase/embedding/embedding-iframe-sdk-setup/components/GetCode/CopyCodeSnippetButton";
+import { PublishQuestionEmptyState } from "metabase/embedding/embedding-iframe-sdk-setup/components/GetCode/PublishQuestionEmptyState";
import { useSdkIframeEmbedServerSnippet } from "metabase/embedding/embedding-iframe-sdk-setup/hooks/use-sdk-iframe-embed-server-snippet";
import { EmbedServerSnippetLanguageSelect } from "metabase/public/components/EmbedServerSnippetLanguageSelect/EmbedServerSnippetLanguageSelect";
import { Card, Flex, Stack, Text } from "metabase/ui";
@@ -46,61 +47,67 @@ export const GetCodeStep = () => {
const handleServerSnippetCopied = () => trackSnippetCopied("server");
return (
- <Stack gap="md">
+ <Stack gap="md" flex={1}>
{!isGuestEmbed && <MetabaseAccountSection />}
- <Card p="md">
- <Text size="lg" fw="bold" mb="md">
- {t`Embed code`}
- </Text>
-
- <Stack gap="sm">
- <div onCopy={handleFrontendSnippetCopied}>
- <CodeEditor
- language="html"
- value={snippet}
- readOnly
- lineNumbers={false}
- />
- </div>
-
- <CopyCodeSnippetButton
- snippet={snippet}
- onCopy={handleFrontendSnippetCopied}
- />
- </Stack>
- </Card>
-
- {!!serverSnippetData && (
- <Card p="md">
- <Flex align="baseline" justify="space-between">
+ {!isGuestEmbed || resource?.enable_embedding ? (
+ <>
+ <Card p="md">
<Text size="lg" fw="bold" mb="md">
- {t`Server code`}
+ {t`Embed code`}
</Text>
- <EmbedServerSnippetLanguageSelect
- languageOptions={serverSnippetData.serverSnippetOptions}
- selectedOptionId={serverSnippetData.selectedServerSnippetId}
- onChangeOption={serverSnippetData.setSelectedServerSnippetId}
- />
- </Flex>
-
- <Stack gap="sm">
- <CodeEditor
- language={serverSnippetData.serverSnippetOption.language}
- value={serverSnippetData.serverSnippetOption.source}
- readOnly
- lineNumbers={false}
- />
-
- <CopyCodeSnippetButton
- snippet={serverSnippetData.serverSnippetOption.source}
- onCopy={handleServerSnippetCopied}
- />
-
- <MoreServerSnippetExamplesLink />
- </Stack>
- </Card>
+ <Stack gap="sm">
+ <div onCopy={handleFrontendSnippetCopied}>
+ <CodeEditor
+ language="html"
+ value={snippet}
+ readOnly
+ lineNumbers={false}
+ />
+ </div>
+
+ <CopyCodeSnippetButton
+ snippet={snippet}
+ onCopy={handleFrontendSnippetCopied}
+ />
+ </Stack>
+ </Card>
+
+ {!!serverSnippetData && (
+ <Card p="md">
+ <Flex align="baseline" justify="space-between">
+ <Text size="lg" fw="bold" mb="md">
+ {t`Server code`}
+ </Text>
+
+ <EmbedServerSnippetLanguageSelect
+ languageOptions={serverSnippetData.serverSnippetOptions}
+ selectedOptionId={serverSnippetData.selectedServerSnippetId}
+ onChangeOption={serverSnippetData.setSelectedServerSnippetId}
+ />
+ </Flex>
+
+ <Stack gap="sm">
+ <CodeEditor
+ language={serverSnippetData.serverSnippetOption.language}
+ value={serverSnippetData.serverSnippetOption.source}
+ readOnly
+ lineNumbers={false}
+ />
+
+ <CopyCodeSnippetButton
+ snippet={serverSnippetData.serverSnippetOption.source}
+ onCopy={handleServerSnippetCopied}
+ />
+
+ <MoreServerSnippetExamplesLink />
+ </Stack>
+ </Card>
+ )}
+ </>
+ ) : (
+ <PublishQuestionEmptyState />
)}
</Stack>
);
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/SdkIframeEmbedSetupModal.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/SdkIframeEmbedSetupModal.tsx
index 0fe56e41e90..2dac5571ee0 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/SdkIframeEmbedSetupModal.tsx
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/SdkIframeEmbedSetupModal.tsx
@@ -47,6 +47,7 @@ export const SdkIframeEmbedSetupContent = () => {
handleNext,
handleBack,
canGoBack,
+ resource,
settings,
} = useSdkIframeEmbedSetupContext();
@@ -75,6 +76,7 @@ export const SdkIframeEmbedSetupContent = () => {
.with("get-code", () => (
<Button
variant="filled"
+ disabled={resource?.enable_embedding === false}
onClick={handleEmbedDone}
leftSection={<Icon name="check_filled" />}
>
@@ -108,11 +110,12 @@ export const SdkIframeEmbedSetupContent = () => {
<SidebarResizer>
<Box className={S.Sidebar} component="aside">
<Stack className={S.SidebarContent} gap="md">
- <Stack gap="md">
+ <Stack gap="md" flex={1}>
<SdkIframeStepHeader />
<Stack
gap="md"
+ flex={1}
opacity={allowPreviewAndNavigation ? 1 : 0.5}
className={cx(
!allowPreviewAndNavigation && CS.pointerEventsNone,
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/SdkIframeGuestEmbedStatusBar.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/SdkIframeGuestEmbedStatusBar.tsx
index 73295c3a96c..beafa288ccf 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/SdkIframeGuestEmbedStatusBar.tsx
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/SdkIframeGuestEmbedStatusBar.tsx
@@ -1,90 +1,44 @@
-import {
- useUpdateCardEmbeddingParamsMutation,
- useUpdateCardEnableEmbeddingMutation,
- useUpdateDashboardEmbeddingParamsMutation,
- useUpdateDashboardEnableEmbeddingMutation,
-} from "metabase/api";
-import { useSetting } from "metabase/common/hooks";
-import { GUEST_EMBED_EMBEDDING_TYPE } from "metabase/embedding/constants";
import { useSdkIframeEmbedSetupContext } from "metabase/embedding/embedding-iframe-sdk-setup/context";
-import { getResourceTypeFromExperience } from "metabase/embedding/embedding-iframe-sdk-setup/utils/get-resource-type-from-experience";
+import { useToggleResourceEmbedding } from "metabase/embedding/embedding-iframe-sdk-setup/hooks/use-toggle-resource-embedding";
import { isStepWithResource } from "metabase/embedding/embedding-iframe-sdk-setup/utils/is-step-with-resource";
import { EmbedModalContentStatusBar } from "metabase/public/components/EmbedModal/StaticEmbedSetupPane/EmbedModalContentStatusBar";
-import type { StaticEmbedSetupPaneProps } from "metabase/public/components/EmbedModal/StaticEmbedSetupPane/StaticEmbedSetupPane";
import { getHasParamsChanged } from "metabase/public/components/EmbedModal/StaticEmbedSetupPane/lib/get-has-params-changed";
-import { getStaticEmbedSetupPublishHandlers } from "metabase/public/components/EmbedModal/StaticEmbedSetupPane/lib/get-static-embed-setup-publish-handlers";
-import type { EmbeddingParameters } from "metabase/public/lib/types";
import { Card } from "metabase/ui";
-type Props = Pick<StaticEmbedSetupPaneProps, "resource" | "resourceType"> & {
- initialEmbeddingParameters: EmbeddingParameters;
-};
-
-const SdkIframeGuestEmbedStatusBarInner = ({
- resource,
- resourceType,
- initialEmbeddingParameters,
-}: Props) => {
- const exampleDashboardId = useSetting("example-dashboard-id");
+export const SdkIframeGuestEmbedStatusBar = () => {
const {
- availableParameters: resourceParameters,
+ currentStep,
+ settings,
+ resource,
embeddingParameters,
isFetching,
- onEmbeddingParametersChange,
+ initialEmbeddingParameters,
} = useSdkIframeEmbedSetupContext();
- const [updateDashboardEmbeddingParams] =
- useUpdateDashboardEmbeddingParamsMutation();
- const [updateDashboardEnableEmbedding] =
- useUpdateDashboardEnableEmbeddingMutation();
- const [updateCardEmbeddingParams] = useUpdateCardEmbeddingParamsMutation();
- const [updateCardEnableEmbedding] = useUpdateCardEnableEmbeddingMutation();
+ const toggleEmbedding = useToggleResourceEmbedding();
- const handleEnableEmbedding = async (enableEmbedding: boolean) => {
- const handlersMap = {
- dashboard: updateDashboardEnableEmbedding,
- question: updateCardEnableEmbedding,
- } as const;
+ const isGuestEmbed = !!settings.isGuest;
+ const shouldShowForStep = isStepWithResource(currentStep);
+ const shouldShowForResource =
+ toggleEmbedding?.resourceType === "dashboard" ||
+ toggleEmbedding?.resourceType === "question";
- await handlersMap[resourceType]?.({
- id: resource.id as number,
- enable_embedding: enableEmbedding,
- embedding_type: enableEmbedding ? GUEST_EMBED_EMBEDDING_TYPE : null,
- });
- };
+ if (!isGuestEmbed || !shouldShowForStep || !shouldShowForResource) {
+ return null;
+ }
- const handleUpdateEmbeddingParams = async (
- embeddingParams: EmbeddingParameters,
- ) => {
- const handlersMap = {
- dashboard: updateDashboardEmbeddingParams,
- question: updateCardEmbeddingParams,
- } as const;
+ if (!resource || !toggleEmbedding || !initialEmbeddingParameters) {
+ return null;
+ }
- await handlersMap[resourceType]?.({
- id: resource.id as number,
- embedding_params: embeddingParams,
- embedding_type: GUEST_EMBED_EMBEDDING_TYPE,
- });
- };
+ const { handleSave, handleUnpublish, handleDiscard, resourceType } =
+ toggleEmbedding;
const hasParamsChanged = getHasParamsChanged({
initialEmbeddingParams: initialEmbeddingParameters,
embeddingParams: embeddingParameters,
});
- const { handleSave, handleUnpublish, handleDiscard } =
- getStaticEmbedSetupPublishHandlers({
- resource,
- resourceType,
- resourceParameters,
- onUpdateEnableEmbedding: handleEnableEmbedding,
- onUpdateEmbeddingParams: handleUpdateEmbeddingParams,
- embeddingParams: embeddingParameters,
- setEmbeddingParams: onEmbeddingParametersChange,
- exampleDashboardId,
- });
-
return (
<Card>
<EmbedModalContentStatusBar
@@ -99,37 +53,3 @@ const SdkIframeGuestEmbedStatusBarInner = ({
</Card>
);
};
-
-export const SdkIframeGuestEmbedStatusBar = () => {
- const {
- currentStep,
- settings,
- resource,
- experience,
- initialEmbeddingParameters,
- } = useSdkIframeEmbedSetupContext();
-
- const isGuestEmbed = !!settings.isGuest;
-
- const resourceType = getResourceTypeFromExperience(experience);
-
- const shouldShowForStep = isStepWithResource(currentStep);
- const shouldShowForResource =
- resourceType === "dashboard" || resourceType === "question";
-
- if (!isGuestEmbed || !shouldShowForStep || !shouldShowForResource) {
- return null;
- }
-
- if (!resource || !resourceType || !initialEmbeddingParameters) {
- return null;
- }
-
- return (
- <SdkIframeGuestEmbedStatusBarInner
- resource={resource}
- resourceType={resourceType}
- initialEmbeddingParameters={initialEmbeddingParameters}
- />
- );
-};
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/tests/test-setup.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/tests/test-setup.tsx
index 2306ed079a6..3a2c80e33f6 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/tests/test-setup.tsx
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/tests/test-setup.tsx
@@ -33,7 +33,9 @@ export const setup = (options?: {
const { hasEnterprisePlugins = true } = options ?? {};
const mockDatabase = createMockDatabase();
- const mockDashboard = createMockDashboard();
+ const mockDashboard = createMockDashboard({
+ enable_embedding: true,
+ });
if (hasEnterprisePlugins) {
setupEnterprisePlugins();
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-toggle-resource-embedding.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-toggle-resource-embedding.ts
new file mode 100644
index 00000000000..269ec923770
--- /dev/null
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-toggle-resource-embedding.ts
@@ -0,0 +1,85 @@
+import {
+ useUpdateCardEmbeddingParamsMutation,
+ useUpdateCardEnableEmbeddingMutation,
+ useUpdateDashboardEmbeddingParamsMutation,
+ useUpdateDashboardEnableEmbeddingMutation,
+} from "metabase/api";
+import { useSetting } from "metabase/common/hooks";
+import { GUEST_EMBED_EMBEDDING_TYPE } from "metabase/embedding/constants";
+import { getStaticEmbedSetupPublishHandlers } from "metabase/public/components/EmbedModal/StaticEmbedSetupPane/lib/get-static-embed-setup-publish-handlers";
+import type { EmbeddingParameters } from "metabase/public/lib/types";
+
+import { useSdkIframeEmbedSetupContext } from "../context";
+import { getResourceTypeFromExperience } from "../utils/get-resource-type-from-experience";
+
+export const useToggleResourceEmbedding = () => {
+ const exampleDashboardId = useSetting("example-dashboard-id");
+
+ const {
+ experience,
+ resource,
+ availableParameters: resourceParameters,
+ embeddingParameters,
+ onEmbeddingParametersChange,
+ } = useSdkIframeEmbedSetupContext();
+
+ const resourceType = getResourceTypeFromExperience(experience);
+
+ const [updateDashboardEmbeddingParams] =
+ useUpdateDashboardEmbeddingParamsMutation();
+ const [updateDashboardEnableEmbedding] =
+ useUpdateDashboardEnableEmbeddingMutation();
+ const [updateCardEmbeddingParams] = useUpdateCardEmbeddingParamsMutation();
+ const [updateCardEnableEmbedding] = useUpdateCardEnableEmbeddingMutation();
+
+ if (!resource || !resourceType) {
+ return null;
+ }
+
+ const handleEnableEmbedding = async (enableEmbedding: boolean) => {
+ const handlersMap = {
+ dashboard: updateDashboardEnableEmbedding,
+ question: updateCardEnableEmbedding,
+ } as const;
+
+ await handlersMap[resourceType]?.({
+ id: resource.id as number,
+ enable_embedding: enableEmbedding,
+ embedding_type: enableEmbedding ? GUEST_EMBED_EMBEDDING_TYPE : null,
+ });
+ };
+
+ const handleUpdateEmbeddingParams = async (
+ embeddingParams: EmbeddingParameters,
+ ) => {
+ const handlersMap = {
+ dashboard: updateDashboardEmbeddingParams,
+ question: updateCardEmbeddingParams,
+ } as const;
+
+ await handlersMap[resourceType]?.({
+ id: resource.id as number,
+ embedding_params: embeddingParams,
+ embedding_type: GUEST_EMBED_EMBEDDING_TYPE,
+ });
+ };
+
+ const { handleSave, handleUnpublish, handleDiscard } =
+ getStaticEmbedSetupPublishHandlers({
+ resource,
+ resourceType,
+ resourceParameters,
+ onUpdateEnableEmbedding: handleEnableEmbedding,
+ onUpdateEmbeddingParams: handleUpdateEmbeddingParams,
+ embeddingParams: embeddingParameters,
+ setEmbeddingParams: onEmbeddingParametersChange,
+ exampleDashboardId,
+ });
+
+ return {
+ handleSave,
+ handleUnpublish,
+ handleDiscard,
+ resourceType,
+ };
+};