Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Move question loader components into questions module (#79125)

Frasere61302efefde
diff --git a/enterprise/frontend/src/metabase-enterprise/sandboxes/components/EditSandboxingModal/EditSandboxingModal.tsx b/enterprise/frontend/src/metabase-enterprise/sandboxes/components/EditSandboxingModal/EditSandboxingModal.tsx
index 62dfd0884e9..e5ad4ce7dea 100644
--- a/enterprise/frontend/src/metabase-enterprise/sandboxes/components/EditSandboxingModal/EditSandboxingModal.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/sandboxes/components/EditSandboxingModal/EditSandboxingModal.tsx
@@ -16,11 +16,11 @@ import {
QuestionPickerModal,
getQuestionPickerValue,
} from "metabase/common/components/Pickers/QuestionPicker";
-import { QuestionLoader } from "metabase/common/components/QuestionLoader";
import { QuestionName } from "metabase/common/components/QuestionName";
import { useToggle } from "metabase/common/hooks/use-toggle";
import { useTranslateContent } from "metabase/content-translation/hooks";
import CS from "metabase/css/core/index.css";
+import { QuestionLoader } from "metabase/questions/components/QuestionLoader";
import {
ActionIcon,
Box,
diff --git a/enterprise/frontend/src/metabase-enterprise/sandboxes/containers/QuestionParameterTargetWidget.tsx b/enterprise/frontend/src/metabase-enterprise/sandboxes/containers/QuestionParameterTargetWidget.tsx
index 7e423ab1b00..da0640e708e 100644
--- a/enterprise/frontend/src/metabase-enterprise/sandboxes/containers/QuestionParameterTargetWidget.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/sandboxes/containers/QuestionParameterTargetWidget.tsx
@@ -1,8 +1,8 @@
+import { getParameterMappingOptions } from "metabase/parameters/utils/mapping-options";
import {
type QuestionLoaderChildrenProps,
QuestionLoaderHOC,
-} from "metabase/common/components/QuestionLoader";
-import { getParameterMappingOptions } from "metabase/parameters/utils/mapping-options";
+} from "metabase/questions/components/QuestionLoader";
import type { CardId, ParameterTarget, UnsavedCard } from "metabase-types/api";
import { ParameterTargetWidget } from "../components/ParameterTargetWidget";
diff --git a/frontend/src/metabase/common/components/AdHocQuestionLoader.tsx b/frontend/src/metabase/questions/components/AdHocQuestionLoader.tsx
similarity index 98%
rename from frontend/src/metabase/common/components/AdHocQuestionLoader.tsx
rename to frontend/src/metabase/questions/components/AdHocQuestionLoader.tsx
index 21e6c55b522..8242e18044d 100644
--- a/frontend/src/metabase/common/components/AdHocQuestionLoader.tsx
+++ b/frontend/src/metabase/questions/components/AdHocQuestionLoader.tsx
@@ -41,7 +41,7 @@ type AdHocQuestionLoaderProps = {
* @example
*
* Render prop style
- * import { AdHocQuestionLoader } from 'metabase/common/components/AdHocQuestionLoader'
+ * import { AdHocQuestionLoader } from 'metabase/questions/components/AdHocQuestionLoader'
*
* function ExampleAdHocQuestionFeature({ params }) {
* return (
diff --git a/frontend/src/metabase/common/components/AdHocQuestionLoader.unit.spec.tsx b/frontend/src/metabase/questions/components/AdHocQuestionLoader.unit.spec.tsx
similarity index 100%
rename from frontend/src/metabase/common/components/AdHocQuestionLoader.unit.spec.tsx
rename to frontend/src/metabase/questions/components/AdHocQuestionLoader.unit.spec.tsx
diff --git a/frontend/src/metabase/common/components/QuestionLoader.tsx b/frontend/src/metabase/questions/components/QuestionLoader.tsx
similarity index 93%
rename from frontend/src/metabase/common/components/QuestionLoader.tsx
rename to frontend/src/metabase/questions/components/QuestionLoader.tsx
index 9e1186b7e90..8fa99746fb3 100644
--- a/frontend/src/metabase/common/components/QuestionLoader.tsx
+++ b/frontend/src/metabase/questions/components/QuestionLoader.tsx
@@ -1,9 +1,9 @@
import type { ReactNode } from "react";
-import { AdHocQuestionLoader } from "metabase/common/components/AdHocQuestionLoader";
-import { SavedQuestionLoader } from "metabase/common/components/SavedQuestionLoader";
import { serializeCardForUrl } from "metabase/common/utils/card";
import renderPropToHOC from "metabase/hoc/RenderPropToHOC";
+import { AdHocQuestionLoader } from "metabase/questions/components/AdHocQuestionLoader";
+import { SavedQuestionLoader } from "metabase/questions/components/SavedQuestionLoader";
import type Question from "metabase-lib/v1/Question";
import type { CardId, UnsavedCard } from "metabase-types/api";
diff --git a/frontend/src/metabase/common/components/SavedQuestionLoader.tsx b/frontend/src/metabase/questions/components/SavedQuestionLoader.tsx
similarity index 95%
rename from frontend/src/metabase/common/components/SavedQuestionLoader.tsx
rename to frontend/src/metabase/questions/components/SavedQuestionLoader.tsx
index 12b69071adf..656014306c2 100644
--- a/frontend/src/metabase/common/components/SavedQuestionLoader.tsx
+++ b/frontend/src/metabase/questions/components/SavedQuestionLoader.tsx
@@ -23,7 +23,7 @@ type SavedQuestionLoaderProps = {
* @example
*
* Render prop style
- * import { SavedQuestionLoader } from 'metabase/common/components/SavedQuestionLoader'
+ * import { SavedQuestionLoader } from 'metabase/questions/components/SavedQuestionLoader'
*
* function ExampleSavedQuestionFeature({ questionId }) {
* return (
diff --git a/frontend/src/metabase/common/components/SavedQuestionLoader.unit.spec.tsx b/frontend/src/metabase/questions/components/SavedQuestionLoader.unit.spec.tsx
similarity index 97%
rename from frontend/src/metabase/common/components/SavedQuestionLoader.unit.spec.tsx
rename to frontend/src/metabase/questions/components/SavedQuestionLoader.unit.spec.tsx
index 2857696a7b0..a448e4e7e25 100644
--- a/frontend/src/metabase/common/components/SavedQuestionLoader.unit.spec.tsx
+++ b/frontend/src/metabase/questions/components/SavedQuestionLoader.unit.spec.tsx
@@ -6,7 +6,7 @@ import {
setupUnauthorizedSchemaEndpoints,
} from "__support__/server-mocks";
import { renderWithProviders, screen } from "__support__/ui";
-import type { QuestionLoaderChildrenProps } from "metabase/common/components/QuestionLoader";
+import type { QuestionLoaderChildrenProps } from "metabase/questions/components/QuestionLoader";
import Question from "metabase-lib/v1/Question";
import type { Card, CardId } from "metabase-types/api";
import {