Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

GDGT-3297: Database quick links menu in Browse (#83587)

Will Frye6f6773f2273
diff --git a/e2e/test/scenarios/actions/table-editing.cy.spec.ts b/e2e/test/scenarios/actions/table-editing.cy.spec.ts
index 0aec31386a8..e2dc9b33d04 100644
--- a/e2e/test/scenarios/actions/table-editing.cy.spec.ts
+++ b/e2e/test/scenarios/actions/table-editing.cy.spec.ts
@@ -640,6 +640,7 @@ function getTableEditIcon(tableName: RegExp) {
return cy
.findByTestId("browse-schemas")
.contains(tableName)
+ .closest('[data-testid="browse-card"]')
.realHover()
.findByTestId("edit-table-icon");
}
diff --git a/frontend/src/metabase/admin/utils.ts b/frontend/src/metabase/admin/utils.ts
index 27a7ed4d393..8c7568186cf 100644
--- a/frontend/src/metabase/admin/utils.ts
+++ b/frontend/src/metabase/admin/utils.ts
@@ -2,15 +2,15 @@ import { useLayoutEffect } from "react";
import { shouldShowTenantsUpsell } from "metabase/admin/people/selectors";
import { useSelector } from "metabase/redux";
+import type { AdminPathKey } from "metabase/redux/store";
import { createRedirectGuard } from "metabase/route-guards";
import { useNavigate } from "metabase/router";
-import { getAdminPaths } from "metabase/selectors/admin";
+import { getAdminPaths, getHasAdminPath } from "metabase/selectors/admin";
import { getSetting } from "metabase/settings";
-export const createAdminRouteGuard = (routeKey: string) =>
+export const createAdminRouteGuard = (routeKey: AdminPathKey) =>
createRedirectGuard(
- (state) =>
- getAdminPaths(state)?.find((path) => path.key === routeKey) != null,
+ (state) => getHasAdminPath(state, routeKey),
"/unauthorized",
);
@@ -30,7 +30,7 @@ export const RedirectToAllowedSettings = () => {
export const createTenantsRouteGuard = () =>
createRedirectGuard(
(state) =>
- getAdminPaths(state)?.find((path) => path.key === "people") != null &&
+ getHasAdminPath(state, "people") &&
(getSetting(state, "use-tenants") || shouldShowTenantsUpsell(state)),
"/admin/people",
);
diff --git a/frontend/src/metabase/browse/components/BrowseCard.module.css b/frontend/src/metabase/browse/components/BrowseCard.module.css
new file mode 100644
index 00000000000..bfbfa807b4f
--- /dev/null
+++ b/frontend/src/metabase/browse/components/BrowseCard.module.css
@@ -0,0 +1,38 @@
+.card:has(.link:focus-visible) {
+ outline: 2px solid var(--mb-color-input-focus);
+}
+
+.link {
+ display: block;
+ min-width: 0;
+ max-width: 100%;
+
+ /*
+ * Stretches the link over the whole card so the whole card can be clicked to follow
+ * the link, while allowing the action menu to render outside of the anchor tag
+ */
+ &::before {
+ content: "";
+ position: absolute;
+ inset: 0;
+ }
+
+ &:focus-visible {
+ outline: none;
+ }
+}
+
+.title {
+ position: relative;
+ z-index: 1;
+}
+
+.actions {
+ z-index: 1;
+}
+
+.cornerActions {
+ position: absolute;
+ top: 1.5rem;
+ right: 1.5rem;
+}
diff --git a/frontend/src/metabase/browse/components/BrowseCard.tsx b/frontend/src/metabase/browse/components/BrowseCard.tsx
index f77f8b2f41b..17ccc6bb4ce 100644
--- a/frontend/src/metabase/browse/components/BrowseCard.tsx
+++ b/frontend/src/metabase/browse/components/BrowseCard.tsx
@@ -13,6 +13,8 @@ import {
import type { ColorName } from "metabase/ui/colors/types";
import type { IconName } from "metabase-types/api";
+import S from "./BrowseCard.module.css";
+
const sizeOptions = {
md: {
height: "4rem",
@@ -36,6 +38,7 @@ export const BrowseCard = ({
iconColor = "core-brand",
title,
size = "md",
+ className,
children,
onClick,
}: {
@@ -44,16 +47,15 @@ export const BrowseCard = ({
iconColor?: ColorName;
title: string;
size?: "md" | "lg";
+ className?: string;
children?: React.ReactNode;
onClick?: () => void;
}) => {
return (
<Card
+ data-testid="browse-card"
withBorder
shadow="none"
- component={Link}
- to={to}
- onClick={onClick}
h={sizeOptions[size].height}
p="1.5rem"
classNames={{
@@ -62,6 +64,8 @@ export const BrowseCard = ({
CS.hoverParent,
CS.hoverVisibility,
CS.textBrandHover,
+ S.card,
+ className,
),
}}
>
@@ -78,23 +82,27 @@ export const BrowseCard = ({
c={iconColor}
size={sizeOptions[size].iconSize}
/>
- <Ellipsified>
- <Title
- order={2}
- size="md"
- lh={1.2}
- display="inline"
- style={{ overflow: "hidden" }}
- w="100%"
- >
- {title}
- </Title>
- </Ellipsified>
- {size === "md" && (
- <Box ml="auto" style={{ flexShrink: 0 }}>
- {children}
- </Box>
- )}
+ <Link to={to} onClick={onClick} className={S.link}>
+ <Ellipsified className={S.title}>
+ <Title
+ order={2}
+ size="md"
+ lh={1.2}
+ display="inline"
+ style={{ overflow: "hidden" }}
+ w="100%"
+ >
+ {title}
+ </Title>
+ </Ellipsified>
+ </Link>
+ <Box
+ ml="auto"
+ style={{ flexShrink: 0 }}
+ className={cx(S.actions, { [S.cornerActions]: size === "lg" })}
+ >
+ {children}
+ </Box>
</Flex>
</Card>
);
diff --git a/frontend/src/metabase/browse/components/DatabaseQuickLinksMenu.tsx b/frontend/src/metabase/browse/components/DatabaseQuickLinksMenu.tsx
new file mode 100644
index 00000000000..590b08b0771
--- /dev/null
+++ b/frontend/src/metabase/browse/components/DatabaseQuickLinksMenu.tsx
@@ -0,0 +1,54 @@
+import { t } from "ttag";
+
+import { ForwardRefLink } from "metabase/common/components/Link";
+import { ActionIcon, Icon, Menu } from "metabase/ui";
+import { SAVED_QUESTIONS_VIRTUAL_DB_ID } from "metabase-lib/v1/metadata/utils/saved-questions";
+import type { DatabaseId, SchemaName } from "metabase-types/api";
+
+import { useDatabaseQuickLinks } from "./use-database-quick-links";
+
+type DatabaseQuickLinksMenuProps = {
+ databaseId: DatabaseId;
+ schemaName?: SchemaName;
+ className?: string;
+};
+
+export const DatabaseQuickLinksMenu = ({
+ databaseId,
+ schemaName,
+ className,
+}: DatabaseQuickLinksMenuProps) => {
+ const links = useDatabaseQuickLinks(databaseId, schemaName);
+
+ const isVirtualDatabase = databaseId === SAVED_QUESTIONS_VIRTUAL_DB_ID;
+ if (links.length === 0 || isVirtualDatabase) {
+ return null;
+ }
+
+ return (
+ <Menu position="bottom-end">
+ <Menu.Target>
+ <ActionIcon
+ className={className}
+ size="sm"
+ color="text-secondary"
+ aria-label={t`Database options`}
+ >
+ <Icon name="ellipsis" />
+ </ActionIcon>
+ </Menu.Target>
+ <Menu.Dropdown>
+ {links.map((link) => (
+ <Menu.Item
+ key={link.key}
+ component={ForwardRefLink}
+ to={link.to}
+ leftSection={<Icon name={link.icon} />}
+ >
+ {link.label}
+ </Menu.Item>
+ ))}
+ </Menu.Dropdown>
+ </Menu>
+ );
+};
diff --git a/frontend/src/metabase/browse/components/DatabaseQuickLinksMenu.unit.spec.tsx b/frontend/src/metabase/browse/components/DatabaseQuickLinksMenu.unit.spec.tsx
new file mode 100644
index 00000000000..54500dffa54
--- /dev/null
+++ b/frontend/src/metabase/browse/components/DatabaseQuickLinksMenu.unit.spec.tsx
@@ -0,0 +1,169 @@
+import userEvent from "@testing-library/user-event";
+
+import {
+ createMockAdminAppState,
+ createMockAdminState,
+ createMockState,
+} from "__support__/state";
+import { renderWithProviders, screen } from "__support__/ui";
+import { PLUGIN_APPLICATION_PERMISSIONS_SELECTORS } from "metabase/current-user";
+import { PLUGIN_SCHEMA_VIEWER, reinitialize } from "metabase/plugins";
+import type { AdminPath } from "metabase/redux/store";
+import { SAVED_QUESTIONS_VIRTUAL_DB_ID } from "metabase-lib/v1/metadata/utils/saved-questions";
+import type { DatabaseId, SchemaName } from "metabase-types/api";
+import { createMockUser } from "metabase-types/api/mocks";
+
+import { DatabaseQuickLinksMenu } from "./DatabaseQuickLinksMenu";
+
+const DATABASE_ID = 7;
+
+const DATABASES_ADMIN_PATH: AdminPath = {
+ key: "databases",
+ getName: () => "Databases",
+ path: "/admin/databases",
+};
+
+type SetupOpts = {
+ databaseId?: DatabaseId;
+ schemaName?: SchemaName;
+ isAdmin?: boolean;
+ canManageDatabases?: boolean;
+ canAccessDataModel?: boolean;
+ isSchemaViewerEnabled?: boolean;
+};
+
+const setup = ({
+ databaseId = DATABASE_ID,
+ schemaName,
+ isAdmin = false,
+ canManageDatabases = isAdmin,
+ canAccessDataModel,
+ isSchemaViewerEnabled = false,
+}: SetupOpts = {}) => {
+ if (canAccessDataModel != null) {
+ PLUGIN_APPLICATION_PERMISSIONS_SELECTORS.canAccessDataModel = () =>
+ canAccessDataModel;
+ }
+ PLUGIN_SCHEMA_VIEWER.isEnabled = isSchemaViewerEnabled;
+
+ renderWithProviders(
+ <DatabaseQuickLinksMenu databaseId={databaseId} schemaName={schemaName} />,
+ {
+ storeInitialState: createMockState({
+ currentUser: createMockUser({ is_superuser: isAdmin }),
+ admin: createMockAdminState({
+ app: createMockAdminAppState({
+ paths: canManageDatabases ? [DATABASES_ADMIN_PATH] : [],
+ }),
+ }),
+ }),
+ },
+ );
+};
+
+const openMenu = () =>
+ userEvent.click(screen.getByRole("button", { name: "Database options" }));
+
+describe("DatabaseQuickLinksMenu", () => {
+ afterEach(() => {
+ reinitialize();
+ });
+
+ it("should not render for a user who can't open any of the links", () => {
+ setup();
+
+ expect(
+ screen.queryByRole("button", { name: "Database options" }),
+ ).not.toBeInTheDocument();
+ });
+
+ it("should link an admin to the database's admin page and Data Studio", async () => {
+ setup({ isAdmin: true });
+ await openMenu();
+
+ expect(
+ await screen.findByRole("menuitem", { name: /Manage database/ }),
+ ).toHaveAttribute("href", `/admin/databases/${DATABASE_ID}`);
+ expect(
+ screen.getByRole("menuitem", { name: /Edit metadata/ }),
+ ).toHaveAttribute("href", `/data-studio/data/database/${DATABASE_ID}`);
+ });
+
+ it("should not show the schema viewer without the schema-viewer feature", async () => {
+ setup({ isAdmin: true });
+ await openMenu();
+
+ await screen.findByRole("menuitem", { name: /Manage database/ });
+ expect(
+ screen.queryByRole("menuitem", { name: /View schema/ }),
+ ).not.toBeInTheDocument();
+ });
+
+ it("should link to the schema viewer with the schema-viewer feature", async () => {
+ setup({ isAdmin: true, isSchemaViewerEnabled: true });
+ await openMenu();
+
+ expect(
+ await screen.findByRole("menuitem", { name: /View schema/ }),
+ ).toHaveAttribute(
+ "href",
+ `/data-studio/schema-viewer?database-id=${DATABASE_ID}`,
+ );
+ });
+
+ it("should scope the metadata and schema viewer links to the schema when given one", async () => {
+ setup({ isAdmin: true, isSchemaViewerEnabled: true, schemaName: "public" });
+ await openMenu();
+
+ expect(
+ await screen.findByRole("menuitem", { name: /Manage database/ }),
+ ).toHaveAttribute("href", `/admin/databases/${DATABASE_ID}`);
+ expect(
+ screen.getByRole("menuitem", { name: /Edit metadata/ }),
+ ).toHaveAttribute(
+ "href",
+ `/data-studio/data/database/${DATABASE_ID}/schema/${DATABASE_ID}:public`,
+ );
+ expect(
+ screen.getByRole("menuitem", { name: /View schema/ }),
+ ).toHaveAttribute(
+ "href",
+ `/data-studio/schema-viewer?database-id=${DATABASE_ID}&schema=public`,
+ );
+ });
+
+ it("should not render for the saved questions virtual database", () => {
+ setup({ isAdmin: true, databaseId: SAVED_QUESTIONS_VIRTUAL_DB_ID });
+
+ expect(
+ screen.queryByRole("button", { name: "Database options" }),
+ ).not.toBeInTheDocument();
+ });
+
+ it("should link a non-admin with database management access to the admin page", async () => {
+ setup({ canManageDatabases: true });
+ await openMenu();
+
+ expect(
+ await screen.findByRole("menuitem", { name: /Manage database/ }),
+ ).toHaveAttribute("href", `/admin/databases/${DATABASE_ID}`);
+ expect(
+ screen.queryByRole("menuitem", { name: /Edit metadata/ }),
+ ).not.toBeInTheDocument();
+ });
+
+ it("should link a non-admin with data model access to the admin data model", async () => {
+ setup({ canAccessDataModel: true, isSchemaViewerEnabled: true });
+ await openMenu();
+
+ expect(
+ await screen.findByRole("menuitem", { name: /Edit metadata/ }),
+ ).toHaveAttribute("href", `/admin/datamodel/database/${DATABASE_ID}`);
+ expect(
+ screen.queryByRole("menuitem", { name: /Manage database/ }),
+ ).not.toBeInTheDocument();
+ expect(
+ screen.queryByRole("menuitem", { name: /View schema/ }),
+ ).not.toBeInTheDocument();
+ });
+});
diff --git a/frontend/src/metabase/browse/components/use-database-quick-links.ts b/frontend/src/metabase/browse/components/use-database-quick-links.ts
new file mode 100644
index 00000000000..6a18bd3eb27
--- /dev/null
+++ b/frontend/src/metabase/browse/components/use-database-quick-links.ts
@@ -0,0 +1,54 @@
+import { t } from "ttag";
+
+import { canAccessDataStudio } from "metabase/common/data-studio/selectors";
+import { canAccessDataModel } from "metabase/current-user";
+import { PLUGIN_SCHEMA_VIEWER } from "metabase/plugins";
+import { useSelector } from "metabase/redux";
+import { canManageDatabases } from "metabase/selectors/admin";
+import * as Urls from "metabase/urls";
+import type { DatabaseId, IconName, SchemaName } from "metabase-types/api";
+
+type DatabaseQuickLink = {
+ key: string;
+ label: string;
+ icon: IconName;
+ to: string;
+ isVisible: boolean;
+};
+
+export function useDatabaseQuickLinks(
+ databaseId: DatabaseId,
+ schemaName?: SchemaName,
+): DatabaseQuickLink[] {
+ const hasDatabaseManagementAccess = useSelector(canManageDatabases);
+ const hasDataModelAccess = useSelector(canAccessDataModel);
+ const hasDataStudioAccess = useSelector(canAccessDataStudio);
+
+ const links: DatabaseQuickLink[] = [
+ {
+ key: "manage",
+ label: t`Manage database`,
+ icon: "gear",
+ to: Urls.viewDatabase(databaseId),
+ isVisible: hasDatabaseManagementAccess,
+ },
+ {
+ key: "data-model",
+ label: t`Edit metadata`,
+ icon: "label",
+ to: hasDataStudioAccess
+ ? Urls.dataStudioData({ databaseId, schemaName })
+ : Urls.dataModel({ databaseId, schemaName }),
+ isVisible: hasDataModelAccess,
+ },
+ {
+ key: "schema-viewer",
+ label: t`View schema`,
+ icon: "network",
+ to: Urls.dataStudioSchemaViewer({ databaseId, schema: schemaName }),
+ isVisible: hasDataStudioAccess && PLUGIN_SCHEMA_VIEWER.isEnabled,
+ },
+ ];
+
+ return links.filter((link) => link.isVisible);
+}
diff --git a/frontend/src/metabase/browse/databases/BrowseDatabases.module.css b/frontend/src/metabase/browse/databases/BrowseDatabases.module.css
index cef22b6d757..627e46fb139 100644
--- a/frontend/src/metabase/browse/databases/BrowseDatabases.module.css
+++ b/frontend/src/metabase/browse/databases/BrowseDatabases.module.css
@@ -14,3 +14,14 @@
color: var(--mb-color-text-primary-inverse);
}
}
+
+/* Hidden with opacity rather than visibility so it stays reachable by keyboard */
+.quickLinksTrigger {
+ opacity: 0;
+}
+
+.databaseCard:hover .quickLinksTrigger,
+.databaseCard:focus-within .quickLinksTrigger,
+.quickLinksTrigger[data-expanded] {
+ opacity: 1;
+}
diff --git a/frontend/src/metabase/browse/databases/BrowseDatabases.tsx b/frontend/src/metabase/browse/databases/BrowseDatabases.tsx
index b39c84c925a..02cdc9eff67 100644
--- a/frontend/src/metabase/browse/databases/BrowseDatabases.tsx
+++ b/frontend/src/metabase/browse/databases/BrowseDatabases.tsx
@@ -18,6 +18,7 @@ import { BrowseCard } from "../components/BrowseCard";
import S from "../components/BrowseContainer.module.css";
import { BrowseDataHeader } from "../components/BrowseDataHeader";
import { BrowseGrid } from "../components/BrowseGrid";
+import { DatabaseQuickLinksMenu } from "../components/DatabaseQuickLinksMenu";
import DB from "./BrowseDatabases.module.css";
import { trackAddDatabaseDBList } from "./analytics";
@@ -81,7 +82,13 @@ export const BrowseDatabases = () => {
title={database.name}
icon="database"
size="lg"
- />
+ className={DB.databaseCard}
+ >
+ <DatabaseQuickLinksMenu
+ databaseId={database.id}
+ className={DB.quickLinksTrigger}
+ />
+ </BrowseCard>
);
})}
{isAdmin && <AddDatabaseCard />}
diff --git a/frontend/src/metabase/browse/databases/BrowseDatabases.unit.spec.tsx b/frontend/src/metabase/browse/databases/BrowseDatabases.unit.spec.tsx
index 033b374a517..3b50a734e67 100644
--- a/frontend/src/metabase/browse/databases/BrowseDatabases.unit.spec.tsx
+++ b/frontend/src/metabase/browse/databases/BrowseDatabases.unit.spec.tsx
@@ -44,7 +44,10 @@ describe("BrowseDatabases", () => {
});
describe("opening a database through the UI", () => {
- const renderBrowseDatabasesWithRouter = (databases: Database[]) => {
+ const renderBrowseDatabasesWithRouter = (
+ databases: Database[],
+ { isAdmin = false }: setupOpts = {},
+ ) => {
setupDatabasesEndpoints(databases);
return renderWithProviders(
<>
@@ -52,7 +55,9 @@ describe("BrowseDatabases", () => {
<Route path="/browse/databases/:slug" element={<BrowseSchemas />} />
</>,
{
- storeInitialState: createMockState({ currentUser: createMockUser() }),
+ storeInitialState: createMockState({
+ currentUser: createMockUser({ is_superuser: isAdmin }),
+ }),
withRouter: true,
initialRoute: "/browse/databases",
},
@@ -101,6 +106,22 @@ describe("BrowseDatabases", () => {
},
);
+ it("opens the database options menu without opening the database", async () => {
+ const { router } = renderBrowseDatabasesWithRouter(
+ [databaseWithSchemas(7, "Sales", ["PUBLIC", "ANALYTICS"])],
+ { isAdmin: true },
+ );
+
+ await userEvent.click(
+ await screen.findByRole("button", { name: "Database options" }),
+ );
+
+ expect(
+ await screen.findByRole("menuitem", { name: /Edit metadata/ }),
+ ).toBeInTheDocument();
+ expect(router?.location.pathname).toBe("/browse/databases");
+ });
+
it("opens a database whose name starts with a digit", async () => {
// "7-sales" as a url segment would be read back as database 7
const { router } = renderBrowseDatabasesWithRouter([
@@ -121,6 +142,26 @@ describe("BrowseDatabases", () => {
).toBeInTheDocument();
});
+ describe("database options menu", () => {
+ it("should not render for regular users", async () => {
+ renderBrowseDatabases(2, { isAdmin: false });
+ await waitForLoaderToBeRemoved();
+
+ expect(
+ screen.queryByRole("button", { name: "Database options" }),
+ ).not.toBeInTheDocument();
+ });
+
+ it("should render on each database card for admins", async () => {
+ renderBrowseDatabases(2, { isAdmin: true });
+ await waitForLoaderToBeRemoved();
+
+ expect(
+ screen.getAllByRole("button", { name: "Database options" }),
+ ).toHaveLength(2);
+ });
+ });
+
describe("Add database card", () => {
it("should not render for regular users", async () => {
const modelCount = 2;
diff --git a/frontend/src/metabase/browse/schemas/BrowseSchemas.tsx b/frontend/src/metabase/browse/schemas/BrowseSchemas.tsx
index d6d44624f1f..ca6a1aec38b 100644
--- a/frontend/src/metabase/browse/schemas/BrowseSchemas.tsx
+++ b/frontend/src/metabase/browse/schemas/BrowseSchemas.tsx
@@ -22,6 +22,7 @@ import { BrowseCard } from "../components/BrowseCard";
import S from "../components/BrowseContainer.module.css";
import { BrowseDataHeader } from "../components/BrowseDataHeader";
import { BrowseGrid } from "../components/BrowseGrid";
+import { DatabaseQuickLinksMenu } from "../components/DatabaseQuickLinksMenu";
type Schema = { id: string; name: string };
@@ -61,13 +62,20 @@ const BrowseSchemasContainer = ({
/>
) : (
<>
- <Flex align="center" pt="lg" pr="sm" pb="sm">
+ <Flex
+ align="center"
+ justify="space-between"
+ pt="lg"
+ pr="sm"
+ pb="sm"
+ >
<BrowserCrumbs
crumbs={[
{ title: t`Databases`, to: "/browse/databases" },
{ title: database?.name ?? "" },
]}
/>
+ <DatabaseQuickLinksMenu databaseId={dbId} />
</Flex>
{schemas.length === 0 ? (
<h2
diff --git a/frontend/src/metabase/browse/tables/TableBrowser/TableBrowserInner.tsx b/frontend/src/metabase/browse/tables/TableBrowser/TableBrowserInner.tsx
index 76753ccc8c8..b47b8749858 100644
--- a/frontend/src/metabase/browse/tables/TableBrowser/TableBrowserInner.tsx
+++ b/frontend/src/metabase/browse/tables/TableBrowser/TableBrowserInner.tsx
@@ -4,6 +4,7 @@ import { t } from "ttag";
import { skipToken, useGetDatabaseQuery } from "metabase/api";
import { BrowseCard } from "metabase/browse/components/BrowseCard";
import { BrowseGrid } from "metabase/browse/components/BrowseGrid";
+import { DatabaseQuickLinksMenu } from "metabase/browse/components/DatabaseQuickLinksMenu";
import { BrowserCrumbs } from "metabase/common/components/BrowserCrumbs";
import { Link } from "metabase/common/components/Link";
import CS from "metabase/css/core/index.css";
@@ -55,7 +56,7 @@ export const TableBrowserInner = ({
return (
<>
- <Flex align="center" pt="lg" pr="sm" pb="sm">
+ <Flex align="center" justify="space-between" pt="lg" pr="sm" pb="sm">
<BrowserCrumbs
crumbs={[
{ title: t`Databases`, to: "/browse/databases" },
@@ -63,6 +64,7 @@ export const TableBrowserInner = ({
...(showSchemaInHeader ? [{ title: schemaName }] : []),
]}
/>
+ <DatabaseQuickLinksMenu databaseId={dbId} schemaName={schemaName} />
</Flex>
<BrowseGrid pt="xl">
{tables.map((table) => (
diff --git a/frontend/src/metabase/selectors/admin.ts b/frontend/src/metabase/selectors/admin.ts
index c68f18df517..309bc317c63 100644
--- a/frontend/src/metabase/selectors/admin.ts
+++ b/frontend/src/metabase/selectors/admin.ts
@@ -1,5 +1,11 @@
-import type { State } from "metabase/redux/store";
+import type { AdminPathKey, State } from "metabase/redux/store";
export const getAdminPaths = (state: State) => {
return state.admin?.app?.paths ?? [];
};
+
+export const getHasAdminPath = (state: State, key: AdminPathKey) =>
+ getAdminPaths(state).some((path) => path.key === key);
+
+export const canManageDatabases = (state: State) =>
+ getHasAdminPath(state, "databases");
diff --git a/frontend/src/metabase/selectors/admin.unit.spec.ts b/frontend/src/metabase/selectors/admin.unit.spec.ts
new file mode 100644
index 00000000000..99189f909b4
--- /dev/null
+++ b/frontend/src/metabase/selectors/admin.unit.spec.ts
@@ -0,0 +1,41 @@
+import {
+ createMockAdminAppState,
+ createMockAdminState,
+ createMockState,
+} from "__support__/state";
+import type { AdminPath } from "metabase/redux/store";
+
+import { getHasAdminPath } from "./admin";
+
+const DATABASES_PATH: AdminPath = {
+ key: "databases",
+ getName: () => "Databases",
+ path: "/admin/databases",
+};
+
+const setup = (paths: AdminPath[]) =>
+ createMockState({
+ admin: createMockAdminState({
+ app: createMockAdminAppState({ paths }),
+ }),
+ });
+
+describe("getHasAdminPath", () => {
+ it("returns true when the user has the admin path", () => {
+ const state = setup([DATABASES_PATH]);
+
+ expect(getHasAdminPath(state, "databases")).toBe(true);
+ });
+
+ it("returns false when the user lacks the admin path", () => {
+ const state = setup([DATABASES_PATH]);
+
+ expect(getHasAdminPath(state, "data-model")).toBe(false);
+ });
+
+ it("returns false when the user has no admin paths", () => {
+ const state = setup([]);
+
+ expect(getHasAdminPath(state, "databases")).toBe(false);
+ });
+});