Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Update affected test stats (#76855)

Frasere73f7ecf1bf7
diff --git a/.github/scripts/affected-tests.ts b/.github/scripts/affected-tests.ts
index 124c93895f3..b23de6ca41d 100644
--- a/.github/scripts/affected-tests.ts
+++ b/.github/scripts/affected-tests.ts
@@ -14,7 +14,13 @@ import {
export type TestPlanStats = {
fe_files_changed: number;
+ fe_files_total: number;
be_files_changed: number;
+ be_files_total: number;
+ unit_infra_touched: boolean;
+ loki_infra_touched: boolean;
+ shared_sources_touched: boolean;
+ fe_modules_total: number;
fe_modules_changed: number;
fe_modules_affected_rules: number;
fe_modules_affected_usage: number;
@@ -48,6 +54,8 @@ export type CreateTestPlanInput = {
sharedSourcesTouched: boolean;
feFilesChanged: number;
beFilesChanged: number;
+ feFilesTotal: number;
+ beFilesTotal: number;
};
// Tests whose owning module is affected.
@@ -73,6 +81,8 @@ export function createTestPlan({
sharedSourcesTouched,
feFilesChanged,
beFilesChanged,
+ feFilesTotal,
+ beFilesTotal,
}: CreateTestPlanInput): TestPlan {
const rulesGraph = buildModuleGraph(elements, rules);
const usageGraph = fileDependencies
@@ -80,6 +90,8 @@ export function createTestPlan({
: rulesGraph;
const nodes = rulesGraph.nodes;
+ // Distinct module types (an element type can span several patterns).
+ const totalModules = new Set(elements.map((el) => el.type)).size;
const changedModules = getChangedModules(nodes, changedFiles);
const rulesAffected = getAffectedModules(rulesGraph, changedFiles);
const usageAffected = getAffectedModules(usageGraph, changedFiles);
@@ -104,7 +116,13 @@ export function createTestPlan({
return {
stats: {
fe_files_changed: feFilesChanged,
+ fe_files_total: feFilesTotal,
be_files_changed: beFilesChanged,
+ be_files_total: beFilesTotal,
+ unit_infra_touched: unitInfraTouched,
+ loki_infra_touched: lokiInfraTouched,
+ shared_sources_touched: sharedSourcesTouched,
+ fe_modules_total: totalModules,
fe_modules_changed: changedModules.size,
fe_modules_affected_rules: rulesAffected.size,
fe_modules_affected_usage: usageAffected.size,
diff --git a/.github/scripts/affected-tests.unit.spec.ts b/.github/scripts/affected-tests.unit.spec.ts
index 9dc8b1f1154..1e4eda6694e 100644
--- a/.github/scripts/affected-tests.unit.spec.ts
+++ b/.github/scripts/affected-tests.unit.spec.ts
@@ -33,6 +33,8 @@ const baseInput = {
sharedSourcesTouched: false,
feFilesChanged: 0,
beFilesChanged: 0,
+ feFilesTotal: 0,
+ beFilesTotal: 0,
};
describe("createTestPlan", () => {
diff --git a/.github/scripts/create-test-plan.ts b/.github/scripts/create-test-plan.ts
index 07c88ffdbd0..03cdbc87e03 100644
--- a/.github/scripts/create-test-plan.ts
+++ b/.github/scripts/create-test-plan.ts
@@ -89,6 +89,8 @@ const testPlan = createTestPlan({
sharedSourcesTouched: process.env.SHARED_SOURCES_TOUCHED === "true",
feFilesChanged: csvToList(process.env.FE_CHANGED_FILES).length,
beFilesChanged: csvToList(process.env.BE_CHANGED_FILES).length,
+ feFilesTotal: listFiles(["frontend", "enterprise/frontend"]).length,
+ beFilesTotal: listFiles(["src", "enterprise/backend"]).length,
});
process.stdout.write(JSON.stringify(testPlan) + "\n");
diff --git a/.github/scripts/upload-affected-tests-stats.js b/.github/scripts/upload-affected-tests-stats.js
index ba38b6bffb3..4c9731cec31 100644
--- a/.github/scripts/upload-affected-tests-stats.js
+++ b/.github/scripts/upload-affected-tests-stats.js
@@ -5,7 +5,7 @@
const { uploadCsvToMb } = require("./csv-to-mb.js");
// "FE Affected Tests" uploaded table on stats.metabase.com.
-const TABLE_ID = 79841;
+const TABLE_ID = 81818;
const s = JSON.parse(process.env.STATS_JSON);
console.log("stats", s);
@@ -18,7 +18,13 @@ const row = {
"Head SHA": process.env.HEAD_SHA,
"Base SHA": process.env.BASE_SHA,
"FE Files Changed": s.fe_files_changed,
+ "FE Files Total": s.fe_files_total,
"BE Files Changed": s.be_files_changed,
+ "BE Files Total": s.be_files_total,
+ "Unit Infra Touched": s.unit_infra_touched,
+ "Loki Infra Touched": s.loki_infra_touched,
+ "Shared Sources Touched": s.shared_sources_touched,
+ "FE Modules Total": s.fe_modules_total,
"FE Modules Changed": s.fe_modules_changed,
"FE Modules Affected (Rules)": s.fe_modules_affected_rules,
"FE Modules Affected (Usage)": s.fe_modules_affected_usage,