Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Add guards to semantic search jobs (#63694)

lbrdnke915bf2d403a
diff --git a/enterprise/backend/src/metabase_enterprise/semantic_search/task/index_cleanup.clj b/enterprise/backend/src/metabase_enterprise/semantic_search/task/index_cleanup.clj
index c4588d4a862..191fed820a9 100644
--- a/enterprise/backend/src/metabase_enterprise/semantic_search/task/index_cleanup.clj
+++ b/enterprise/backend/src/metabase_enterprise/semantic_search/task/index_cleanup.clj
@@ -8,8 +8,10 @@
[honey.sql :as sql]
[honey.sql.helpers :as sql.helpers]
[java-time.api :as t]
+ [metabase-enterprise.semantic-search.db.datasource :as semantic.db.datasource]
[metabase-enterprise.semantic-search.env :as semantic.env]
[metabase-enterprise.semantic-search.settings :as semantic.settings]
+ [metabase.premium-features.core :as premium-features]
[metabase.task.core :as task]
[metabase.util.log :as log]
[next.jdbc :as jdbc]
@@ -178,16 +180,18 @@
(cleanup-stale-indexes-and-gate-tombstones!))
(defmethod task/init! ::SemanticIndexCleanup [_]
- (let [job (jobs/build
- (jobs/of-type SemanticIndexCleanup)
- (jobs/with-identity cleanup-job-key))
- trigger (triggers/build
- (triggers/with-identity cleanup-trigger-key)
- (triggers/start-now)
- (triggers/with-schedule
+ (when (and (string? (not-empty semantic.db.datasource/db-url))
+ (premium-features/has-feature? :semantic-search))
+ (let [job (jobs/build
+ (jobs/of-type SemanticIndexCleanup)
+ (jobs/with-identity cleanup-job-key))
+ trigger (triggers/build
+ (triggers/with-identity cleanup-trigger-key)
+ (triggers/start-now)
+ (triggers/with-schedule
;; Run daily at 3 AM
- (cron/cron-schedule "0 0 3 * * ? *")))]
- (task/schedule-task! job trigger)))
+ (cron/cron-schedule "0 0 3 * * ? *")))]
+ (task/schedule-task! job trigger))))
(comment
(task/job-exists? cleanup-job-key)
diff --git a/enterprise/backend/src/metabase_enterprise/semantic_search/task/index_repair.clj b/enterprise/backend/src/metabase_enterprise/semantic_search/task/index_repair.clj
index 64812e86144..05488c24fe2 100644
--- a/enterprise/backend/src/metabase_enterprise/semantic_search/task/index_repair.clj
+++ b/enterprise/backend/src/metabase_enterprise/semantic_search/task/index_repair.clj
@@ -5,6 +5,8 @@
[clojurewerkz.quartzite.schedule.cron :as cron]
[clojurewerkz.quartzite.triggers :as triggers]
[metabase-enterprise.semantic-search.core :as semantic-search.core]
+ [metabase-enterprise.semantic-search.db.datasource :as semantic.db.datasource]
+ [metabase.premium-features.core :as premium-features]
[metabase.search.ingestion :as search.ingestion]
[metabase.task.core :as task]
[metabase.util.log :as log])
@@ -28,13 +30,15 @@
(log/error e "Failed to complete semantic search index repair")))))
(defmethod task/init! ::SemanticIndexRepair [_]
- (let [job (jobs/build
- (jobs/of-type SemanticIndexRepair)
- (jobs/with-identity repair-job-key))
- trigger (triggers/build
- (triggers/with-identity repair-trigger-key)
- (triggers/start-now)
- (triggers/with-schedule
+ (when (and (string? (not-empty semantic.db.datasource/db-url))
+ (premium-features/has-feature? :semantic-search))
+ (let [job (jobs/build
+ (jobs/of-type SemanticIndexRepair)
+ (jobs/with-identity repair-job-key))
+ trigger (triggers/build
+ (triggers/with-identity repair-trigger-key)
+ (triggers/start-now)
+ (triggers/with-schedule
;; Run hourly at minute 15
- (cron/cron-schedule "0 15 * * * ? *")))]
- (task/schedule-task! job trigger)))
+ (cron/cron-schedule "0 15 * * * ? *")))]
+ (task/schedule-task! job trigger))))
diff --git a/enterprise/backend/src/metabase_enterprise/semantic_search/task/indexer.clj b/enterprise/backend/src/metabase_enterprise/semantic_search/task/indexer.clj
index 57ab81c8dec..a0195dc5b59 100644
--- a/enterprise/backend/src/metabase_enterprise/semantic_search/task/indexer.clj
+++ b/enterprise/backend/src/metabase_enterprise/semantic_search/task/indexer.clj
@@ -3,6 +3,7 @@
[clojurewerkz.quartzite.jobs :as jobs]
[clojurewerkz.quartzite.schedule.simple :as simple]
[clojurewerkz.quartzite.triggers :as triggers]
+ [metabase-enterprise.semantic-search.db.datasource :as semantic.db.datasource]
[metabase-enterprise.semantic-search.env :as semantic.env]
[metabase-enterprise.semantic-search.indexer :as semantic-search.indexer]
[metabase.premium-features.core :as premium-features]
@@ -51,7 +52,8 @@
(def ^:private ^Duration run-frequency (Duration/parse "PT20S"))
(defmethod task/init! ::SemanticSearchIndexer [_]
- (when (premium-features/has-feature? :semantic-search)
+ (when (and (string? (not-empty semantic.db.datasource/db-url))
+ (premium-features/has-feature? :semantic-search))
(let [job (jobs/build
(jobs/of-type SemanticSearchIndexer)
(jobs/store-durably)