Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

remove unnecessary uses of skipOn (#78048)

Chris Vandoodewaarde93496629bc0
diff --git a/e2e/test/scenarios/admin-2/people.cy.spec.js b/e2e/test/scenarios/admin-2/people.cy.spec.js
index 7b7c96ec69e..5907ecaf5d4 100644
--- a/e2e/test/scenarios/admin-2/people.cy.spec.js
+++ b/e2e/test/scenarios/admin-2/people.cy.spec.js
@@ -892,7 +892,9 @@ describe("scenarios > admin > people > group managers", () => {
});
});
-describe("issue 23689", () => {
+// TODO: remove skip when this issue gets fixed. Initial attempt: https://github.com/metabase/metabase/pull/23825,
+// reverted in https://github.com/metabase/metabase/pull/24760 to fix a security vulnerability.
+describe("issue 23689", { tags: "@skip" }, () => {
function findUserByFullName(user) {
const { first_name, last_name } = user;
return cy.findByText(`${first_name} ${last_name}`);
@@ -904,9 +906,6 @@ describe("issue 23689", () => {
}
beforeEach(() => {
- // TODO: remove the next line when this issue gets fixed
- cy.skipOn(true);
-
cy.intercept("GET", "/api/permissions/membership").as("membership");
H.restore();
diff --git a/e2e/test/scenarios/dashboard/x-rays.cy.spec.js b/e2e/test/scenarios/dashboard/x-rays.cy.spec.js
index ac465c8e189..db4af961497 100644
--- a/e2e/test/scenarios/dashboard/x-rays.cy.spec.js
+++ b/e2e/test/scenarios/dashboard/x-rays.cy.spec.js
@@ -86,12 +86,6 @@ describe("scenarios > x-rays", { tags: "@slow" }, () => {
["X-ray", "Compare to the rest"].forEach((action) => {
it(`"${action.toUpperCase()}" should work on a nested question made from base native question (metabase#15655)`, () => {
- if (action === "Compare to the rest") {
- cy.log(
- "Skipping Compare to the rest test because it takes 8 minutes in ci",
- );
- cy.skipOn(action === "Compare to the rest");
- }
cy.intercept("GET", "/api/automagic-dashboards/**").as("xray");
H.createNativeQuestion({
diff --git a/e2e/test/scenarios/sharing/downloads/sharing-download-reproductions.cy.spec.js b/e2e/test/scenarios/sharing/downloads/sharing-download-reproductions.cy.spec.js
index 4c9c118a40d..dd52e382827 100644
--- a/e2e/test/scenarios/sharing/downloads/sharing-download-reproductions.cy.spec.js
+++ b/e2e/test/scenarios/sharing/downloads/sharing-download-reproductions.cy.spec.js
@@ -127,9 +127,6 @@ describe("issue 18382", () => {
testCases.forEach((fileType) => {
it(`should handle the old syntax in downloads for ${fileType} (metabase#18382)`, () => {
- // TODO: Please remove this line when issue gets fixed
- cy.skipOn(fileType === "csv");
-
H.downloadAndAssert({ fileType });
});
});
diff --git a/e2e/test/scenarios/visualizations-tabular/scalar.cy.spec.js b/e2e/test/scenarios/visualizations-tabular/scalar.cy.spec.js
index 39e824a8c1c..07ba9fd9b8b 100644
--- a/e2e/test/scenarios/visualizations-tabular/scalar.cy.spec.js
+++ b/e2e/test/scenarios/visualizations-tabular/scalar.cy.spec.js
@@ -21,8 +21,6 @@ describe("scenarios > visualizations > scalar", () => {
it(`should render human readable numbers on ${size} screen size (metabase`, () => {
const [width, height] = viewport;
- cy.skipOn(size === "mobile");
-
cy.viewport(width, height);
H.createQuestionAndDashboard({
questionDetails: {
@@ -41,7 +39,14 @@ describe("scenarios > visualizations > scalar", () => {
},
}).then(({ body: { dashboard_id } }) => {
H.visitDashboard(dashboard_id);
- cy.findByText("1.5T");
+ // cards on mobile take up the full viewport width so there is enough room to display the uncompacted value
+ // If https://github.com/metabase/metabase/issues/6201 is completed this may change but in this instance showing
+ // the uncompacted value for mobile is the expected behaviour.
+ if (size === "mobile") {
+ cy.findByText("1,510,621,683,050.63");
+ } else {
+ cy.findByText("1.5T");
+ }
});
});
});