Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Move embedding types into metabase-types (#73711)

Frasere97dad976ee5
diff --git a/enterprise/frontend/src/metabase-enterprise/resource_downloads/resource_downloads_plugin.ts b/enterprise/frontend/src/metabase-enterprise/resource_downloads/resource_downloads_plugin.ts
index fbb4c85cb04..1369bdad53d 100644
--- a/enterprise/frontend/src/metabase-enterprise/resource_downloads/resource_downloads_plugin.ts
+++ b/enterprise/frontend/src/metabase-enterprise/resource_downloads/resource_downloads_plugin.ts
@@ -1,8 +1,8 @@
import { P, match } from "ts-pattern";
-import type { EmbedResourceDownloadOptions } from "metabase/embedding/types";
import { PLUGIN_RESOURCE_DOWNLOADS } from "metabase/plugins";
import { hasPremiumFeature } from "metabase-enterprise/settings";
+import type { EmbedResourceDownloadOptions } from "metabase-types/api";
/**
* Initialize resource downloads plugin features that depend on hasPremiumFeature.
diff --git a/enterprise/frontend/src/metabase-enterprise/resource_downloads/tests/setup.ts b/enterprise/frontend/src/metabase-enterprise/resource_downloads/tests/setup.ts
index f478f8f7b6d..8722a7221d2 100644
--- a/enterprise/frontend/src/metabase-enterprise/resource_downloads/tests/setup.ts
+++ b/enterprise/frontend/src/metabase-enterprise/resource_downloads/tests/setup.ts
@@ -1,7 +1,9 @@
import { setupEnterpriseOnlyPlugin } from "__support__/enterprise";
import { mockSettings } from "__support__/settings";
-import type { EmbedResourceDownloadOptions } from "metabase/embedding/types";
-import type { TokenFeatures } from "metabase-types/api";
+import type {
+ EmbedResourceDownloadOptions,
+ TokenFeatures,
+} from "metabase-types/api";
import { createMockTokenFeatures } from "metabase-types/api/mocks";
export interface SetupOpts {
diff --git a/frontend/src/metabase-types/analytics/embed-flow.ts b/frontend/src/metabase-types/analytics/embed-flow.ts
index 229ef7617a3..37a440c06b8 100644
--- a/frontend/src/metabase-types/analytics/embed-flow.ts
+++ b/frontend/src/metabase-types/analytics/embed-flow.ts
@@ -1,4 +1,4 @@
-import type { EmbedResourceDownloadOptions } from "metabase/embedding/types";
+import type { EmbedResourceDownloadOptions } from "metabase-types/api";
type EmbedFlowParams = {
locked?: number;
diff --git a/frontend/src/metabase-types/api/card.ts b/frontend/src/metabase-types/api/card.ts
index f7c040ba440..57e16c913fa 100644
--- a/frontend/src/metabase-types/api/card.ts
+++ b/frontend/src/metabase-types/api/card.ts
@@ -1,7 +1,3 @@
-import type {
- EmbeddingParameters,
- EmbeddingType,
-} from "metabase/embedding/types";
import type { CurrencyStyle } from "metabase/utils/formatting";
import type { IconName } from "metabase-types/api";
import type { EntityToken, EntityUuid } from "metabase-types/api/entity";
@@ -18,6 +14,7 @@ import type {
import type { Database, DatabaseId } from "./database";
import type { RowValue } from "./dataset";
import type { Document, DocumentId } from "./document";
+import type { EmbeddingParameters, EmbeddingType } from "./embed";
import type { BaseEntityId } from "./entity-id";
import type { Field } from "./field";
import type { ModerationReview } from "./moderation";
diff --git a/frontend/src/metabase-types/api/dashboard.ts b/frontend/src/metabase-types/api/dashboard.ts
index 1690caff3af..7d9dbee53c1 100644
--- a/frontend/src/metabase-types/api/dashboard.ts
+++ b/frontend/src/metabase-types/api/dashboard.ts
@@ -1,7 +1,3 @@
-import type {
- EmbeddingParameters,
- EmbeddingType,
-} from "metabase/embedding/types";
import type {
BaseEntityId,
CardDisplayType,
@@ -10,6 +6,8 @@ import type {
CollectionAuthorityLevel,
CollectionId,
Database,
+ EmbeddingParameters,
+ EmbeddingType,
Field,
FieldId,
Parameter,
diff --git a/frontend/src/metabase-types/api/embed.ts b/frontend/src/metabase-types/api/embed.ts
new file mode 100644
index 00000000000..835a5446edc
--- /dev/null
+++ b/frontend/src/metabase-types/api/embed.ts
@@ -0,0 +1,10 @@
+export type EmbeddingType = "static-legacy" | "guest-embed";
+
+export type EmbeddingParameterVisibility = "disabled" | "enabled" | "locked";
+
+export type EmbeddingParameters = Record<string, EmbeddingParameterVisibility>;
+
+export type EmbedResourceDownloadOptions = {
+ pdf?: boolean;
+ results?: boolean;
+};
diff --git a/frontend/src/metabase-types/api/index.ts b/frontend/src/metabase-types/api/index.ts
index 985525866c5..cfcd51237b3 100644
--- a/frontend/src/metabase-types/api/index.ts
+++ b/frontend/src/metabase-types/api/index.ts
@@ -21,6 +21,7 @@ export * from "./dataset";
export * from "./dependencies";
export * from "./document";
export * from "./email";
+export * from "./embed";
export * from "./embedding-theme";
export * from "./entity-id";
export * from "./field";
diff --git a/frontend/src/metabase/dashboard/components/ParameterSettings/ParameterSettings.tsx b/frontend/src/metabase/dashboard/components/ParameterSettings/ParameterSettings.tsx
index 18fbca56f3c..10e866cd71e 100644
--- a/frontend/src/metabase/dashboard/components/ParameterSettings/ParameterSettings.tsx
+++ b/frontend/src/metabase/dashboard/components/ParameterSettings/ParameterSettings.tsx
@@ -7,7 +7,6 @@ import {
} from "react";
import { t } from "ttag";
-import type { EmbeddingParameterVisibility } from "metabase/embedding/types";
import { ParameterValueWidget } from "metabase/parameters/components/ParameterValueWidget";
import { RequiredParamToggle } from "metabase/parameters/components/RequiredParamToggle";
import { TemporalUnitSettings } from "metabase/parameters/components/TemporalUnitSettings";
@@ -34,6 +33,7 @@ import {
} from "metabase-lib/v1/parameters/utils/parameter-values";
import type {
DashboardCard,
+ EmbeddingParameterVisibility,
Parameter,
TemporalUnit,
ValuesQueryType,
diff --git a/frontend/src/metabase/dashboard/selectors.ts b/frontend/src/metabase/dashboard/selectors.ts
index 5b201b9fcc9..69936cf1917 100644
--- a/frontend/src/metabase/dashboard/selectors.ts
+++ b/frontend/src/metabase/dashboard/selectors.ts
@@ -8,7 +8,6 @@ import {
DASHBOARD_SLOW_TIMEOUT,
SIDEBAR_NAME,
} from "metabase/dashboard/constants";
-import type { EmbeddingParameterVisibility } from "metabase/embedding/types";
import { isEmbeddingSdk } from "metabase/embedding-sdk/config";
import {
getDashboardQuestions,
@@ -47,6 +46,7 @@ import type {
DashboardId,
DashboardParameterMapping,
DashboardTabId,
+ EmbeddingParameterVisibility,
ParameterId,
VirtualCard,
} from "metabase-types/api";
diff --git a/frontend/src/metabase/dashboard/types/display-options.ts b/frontend/src/metabase/dashboard/types/display-options.ts
index bf150148a8c..1a0b15905d4 100644
--- a/frontend/src/metabase/dashboard/types/display-options.ts
+++ b/frontend/src/metabase/dashboard/types/display-options.ts
@@ -1,4 +1,4 @@
-import type { EmbedResourceDownloadOptions } from "metabase/embedding/types";
+import type { EmbedResourceDownloadOptions } from "metabase-types/api";
export type DashboardFullscreenControls = {
isFullscreen: boolean;
diff --git a/frontend/src/metabase/dashboard/types/embed-display-options.ts b/frontend/src/metabase/dashboard/types/embed-display-options.ts
index be8b1bf7fe8..1ef0aa064d4 100644
--- a/frontend/src/metabase/dashboard/types/embed-display-options.ts
+++ b/frontend/src/metabase/dashboard/types/embed-display-options.ts
@@ -1,8 +1,6 @@
-import type {
- DisplayTheme,
- EmbedResourceDownloadOptions,
-} from "metabase/embedding/types";
+import type { DisplayTheme } from "metabase/embedding/types";
import type { ClickActionModeGetter } from "metabase/visualizations/types";
+import type { EmbedResourceDownloadOptions } from "metabase-types/api";
type EmbedBackground = boolean;
diff --git a/frontend/src/metabase/embedding/components/EmbedModal/EmbedModal.tsx b/frontend/src/metabase/embedding/components/EmbedModal/EmbedModal.tsx
index 636b5e04436..c331be32de9 100644
--- a/frontend/src/metabase/embedding/components/EmbedModal/EmbedModal.tsx
+++ b/frontend/src/metabase/embedding/components/EmbedModal/EmbedModal.tsx
@@ -5,9 +5,9 @@ import { StaticEmbedSetupPane } from "metabase/embedding/components/EmbedModal/S
import type {
EmbedResource,
EmbedResourceParameter,
- EmbeddingParameters,
GuestEmbedResourceType,
} from "metabase/embedding/types";
+import type { EmbeddingParameters } from "metabase-types/api";
import { EmbedModalHeader } from "./EmbedModal.styled";
diff --git a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/ParametersSettings.tsx b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/ParametersSettings.tsx
index 90414a81fd7..22f47dd168d 100644
--- a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/ParametersSettings.tsx
+++ b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/ParametersSettings.tsx
@@ -8,14 +8,16 @@ import CS from "metabase/css/core/index.css";
import type {
EmbedResourceParameter,
EmbedResourceType,
- EmbeddingParameterVisibility,
- EmbeddingParameters,
EmbeddingParametersValues,
} from "metabase/embedding/types";
import { ParameterWidget as StaticParameterWidget } from "metabase/parameters/components/ParameterWidget";
import { getParameterIconName } from "metabase/parameters/utils/ui";
import { Box, Divider, Icon, Stack, Text } from "metabase/ui";
import { getValuePopulatedParameters } from "metabase-lib/v1/parameters/utils/parameter-values";
+import type {
+ EmbeddingParameterVisibility,
+ EmbeddingParameters,
+} from "metabase-types/api";
import { StaticEmbedSetupPaneSettingsContentSection } from "./StaticEmbedSetupPaneSettingsContentSection";
import type { EmbedResourceParameterWithValue } from "./types";
diff --git a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/StaticEmbedSetupPane.tsx b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/StaticEmbedSetupPane.tsx
index 91b55a3bfb8..4c2e9471577 100644
--- a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/StaticEmbedSetupPane.tsx
+++ b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/StaticEmbedSetupPane.tsx
@@ -15,7 +15,6 @@ import type {
EmbedResource,
EmbedResourceParameter,
EmbeddingDisplayOptions,
- EmbeddingParameters,
EmbeddingParametersValues,
GuestEmbedResourceType,
} from "metabase/embedding/types";
@@ -23,6 +22,7 @@ import { useSelector } from "metabase/redux";
import { getCanWhitelabel } from "metabase/selectors/whitelabel";
import { Paper, Stack, Tabs } from "metabase/ui";
import { checkNotNull } from "metabase/utils/types";
+import type { EmbeddingParameters } from "metabase-types/api";
import { EmbedModalContentStatusBar } from "./EmbedModalContentStatusBar";
import { LookAndFeelSettings } from "./LookAndFeelSettings";
diff --git a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-default-embedding-params.ts b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-default-embedding-params.ts
index b375ad841e1..d98326f7c1a 100644
--- a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-default-embedding-params.ts
+++ b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-default-embedding-params.ts
@@ -3,8 +3,8 @@ import _ from "underscore";
import type {
EmbedResource,
EmbedResourceParameter,
- EmbeddingParameters,
} from "metabase/embedding/types";
+import type { EmbeddingParameters } from "metabase-types/api";
export function getDefaultEmbeddingParams(
resource: EmbedResource,
diff --git a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-has-params-changed.ts b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-has-params-changed.ts
index 28d0f0b48a0..c598917643c 100644
--- a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-has-params-changed.ts
+++ b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-has-params-changed.ts
@@ -1,6 +1,6 @@
import _ from "underscore";
-import type { EmbeddingParameters } from "metabase/embedding/types";
+import type { EmbeddingParameters } from "metabase-types/api";
function getNonDisabledEmbeddingParams(
embeddingParams: EmbeddingParameters,
diff --git a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-locked-preview-parameters.ts b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-locked-preview-parameters.ts
index 19e899f06dd..6b151d1472a 100644
--- a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-locked-preview-parameters.ts
+++ b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-locked-preview-parameters.ts
@@ -1,7 +1,5 @@
-import type {
- EmbedResourceParameter,
- EmbeddingParameters,
-} from "metabase/embedding/types";
+import type { EmbedResourceParameter } from "metabase/embedding/types";
+import type { EmbeddingParameters } from "metabase-types/api";
export function getLockedPreviewParameters(
resourceParameters: EmbedResourceParameter[],
diff --git a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-preview-params-by-slug.ts b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-preview-params-by-slug.ts
index 21b55268251..2a563d27f87 100644
--- a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-preview-params-by-slug.ts
+++ b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-preview-params-by-slug.ts
@@ -1,10 +1,10 @@
import { getLockedPreviewParameters } from "metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-locked-preview-parameters";
import type {
EmbedResourceParameter,
- EmbeddingParameters,
EmbeddingParametersValues,
} from "metabase/embedding/types";
import { getParameterValue } from "metabase-lib/v1/parameters/utils/parameter-values";
+import type { EmbeddingParameters } from "metabase-types/api";
export function getPreviewParamsBySlug({
resourceParameters,
diff --git a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-static-embed-setup-publish-handlers.ts b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-static-embed-setup-publish-handlers.ts
index a4288f5f1fc..728b67ca084 100644
--- a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-static-embed-setup-publish-handlers.ts
+++ b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-static-embed-setup-publish-handlers.ts
@@ -5,10 +5,8 @@ import {
trackStaticEmbedUnpublished,
} from "metabase/embedding/lib/analytics";
import { countEmbeddingParameterOptions } from "metabase/embedding/lib/count-embedding-parameter-options";
-import type {
- EmbedResourceParameter,
- EmbeddingParameters,
-} from "metabase/embedding/types";
+import type { EmbedResourceParameter } from "metabase/embedding/types";
+import type { EmbeddingParameters } from "metabase-types/api";
import { getDefaultEmbeddingParams } from "./get-default-embedding-params";
diff --git a/frontend/src/metabase/embedding/constants.ts b/frontend/src/metabase/embedding/constants.ts
index 6f282037efc..5ecce5958db 100644
--- a/frontend/src/metabase/embedding/constants.ts
+++ b/frontend/src/metabase/embedding/constants.ts
@@ -1,4 +1,4 @@
-import type { EmbeddingType } from "metabase/embedding/types";
+import type { EmbeddingType } from "metabase-types/api";
export const STATIC_LEGACY_EMBEDDING_TYPE: EmbeddingType = "static-legacy";
export const GUEST_EMBED_EMBEDDING_TYPE: EmbeddingType = "guest-embed";
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/analytics.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/analytics.ts
index 123f057f75e..3e1aaa90176 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/analytics.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/analytics.ts
@@ -8,9 +8,8 @@ import type {
import { getAuthSubTypeForSettings } from "metabase/embedding/embedding-iframe-sdk-setup/utils/get-auth-sub-type-for-settings";
import { getAuthTypeForSettings } from "metabase/embedding/embedding-iframe-sdk-setup/utils/get-auth-type-for-settings";
import { countEmbeddingParameterOptions } from "metabase/embedding/lib/count-embedding-parameter-options";
-import type { EmbeddingParameters } from "metabase/embedding/types";
import type { SdkIframeEmbedSetupModalInitialState } from "metabase/plugins";
-import type { Card, Dashboard } from "metabase-types/api";
+import type { Card, Dashboard, EmbeddingParameters } from "metabase-types/api";
import type {
SdkIframeEmbedSetupExperience,
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/context.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/context.ts
index 4196ef65693..0f0856075df 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/context.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/context.ts
@@ -1,11 +1,13 @@
import { createContext, useContext } from "react";
+import type { EmbeddingParametersValues } from "metabase/embedding/types";
+import type { SdkIframeEmbedSetupModalInitialState } from "metabase/plugins";
import type {
+ Card,
+ Dashboard,
EmbeddingParameters,
- EmbeddingParametersValues,
-} from "metabase/embedding/types";
-import type { SdkIframeEmbedSetupModalInitialState } from "metabase/plugins";
-import type { Card, Dashboard, Parameter } from "metabase-types/api";
+ Parameter,
+} from "metabase-types/api";
import type {
SdkIframeEmbedSetupExperience,
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters-conversion.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters-conversion.ts
index 359c536e1be..4eddcba62e5 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters-conversion.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters-conversion.ts
@@ -1,8 +1,7 @@
import { useCallback } from "react";
import type { SdkIframeEmbedSetupSettings } from "metabase/embedding/embedding-iframe-sdk-setup/types";
-import type { EmbeddingParameters } from "metabase/embedding/types";
-import type { Parameter } from "metabase-types/api";
+import type { EmbeddingParameters, Parameter } from "metabase-types/api";
export const useEmbeddingParametersConversion = () => {
const convertToEmbedSettings = useCallback(
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters-conversion.unit.spec.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters-conversion.unit.spec.ts
index 55ca82807c1..4feb89e93ca 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters-conversion.unit.spec.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters-conversion.unit.spec.ts
@@ -1,8 +1,7 @@
import { renderHook } from "@testing-library/react";
import { useEmbeddingParametersConversion } from "metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters-conversion";
-import type { EmbeddingParameters } from "metabase/embedding/types";
-import type { Parameter } from "metabase-types/api";
+import type { EmbeddingParameters, Parameter } from "metabase-types/api";
import { createMockParameter } from "metabase-types/api/mocks";
describe("useEmbeddingParametersConversion", () => {
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters.ts
index 365a580f65c..604120d2db5 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters.ts
@@ -4,8 +4,12 @@ import { usePrevious } from "react-use";
import { getDefaultEmbeddingParams } from "metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-default-embedding-params";
import type { SdkIframeEmbedSetupContextType } from "metabase/embedding/embedding-iframe-sdk-setup/context";
import { useEmbeddingParametersConversion } from "metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters-conversion";
-import type { EmbeddingParameters } from "metabase/embedding/types";
-import type { Card, Dashboard, Parameter } from "metabase-types/api";
+import type {
+ Card,
+ Dashboard,
+ EmbeddingParameters,
+ Parameter,
+} from "metabase-types/api";
export const useEmbeddingParameters = ({
settings,
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters.unit.spec.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters.unit.spec.ts
index 8ba6deb80d9..8cb867315bf 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters.unit.spec.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters.unit.spec.ts
@@ -2,8 +2,12 @@ import { renderHook } from "@testing-library/react";
import { useEmbeddingParameters } from "metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters";
import type { SdkIframeEmbedSetupSettings } from "metabase/embedding/embedding-iframe-sdk-setup/types";
-import type { EmbeddingParameters } from "metabase/embedding/types";
-import type { Card, Dashboard, Parameter } from "metabase-types/api";
+import type {
+ Card,
+ Dashboard,
+ EmbeddingParameters,
+ Parameter,
+} from "metabase-types/api";
import {
createMockCard,
createMockDashboard,
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-parameters-values.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-parameters-values.ts
index c905d837915..8ddc3b25ab6 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-parameters-values.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-parameters-values.ts
@@ -3,8 +3,7 @@ import { useMemo } from "react";
import { getPreviewParamsBySlug } from "metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-preview-params-by-slug";
import type { SdkIframeEmbedSetupSettings } from "metabase/embedding/embedding-iframe-sdk-setup/types";
import { convertParameterValuesBySlugToById } from "metabase/embedding/embedding-iframe-sdk-setup/utils/convert-parameter-values-by-slug-to-by-id";
-import type { EmbeddingParameters } from "metabase/embedding/types";
-import type { Parameter } from "metabase-types/api";
+import type { EmbeddingParameters, Parameter } from "metabase-types/api";
interface UseParametersValuesProps {
settings: SdkIframeEmbedSetupSettings;
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-toggle-resource-embedding.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-toggle-resource-embedding.ts
index c136ae4d6d7..ccd803200cc 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-toggle-resource-embedding.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-toggle-resource-embedding.ts
@@ -7,7 +7,7 @@ import {
import { useSetting } from "metabase/common/hooks";
import { getStaticEmbedSetupPublishHandlers } from "metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-static-embed-setup-publish-handlers";
import { GUEST_EMBED_EMBEDDING_TYPE } from "metabase/embedding/constants";
-import type { EmbeddingParameters } from "metabase/embedding/types";
+import type { EmbeddingParameters } from "metabase-types/api";
import { useSdkIframeEmbedSetupContext } from "../context";
import { getResourceTypeFromExperience } from "../utils/get-resource-type-from-experience";
diff --git a/frontend/src/metabase/embedding/lib/analytics.ts b/frontend/src/metabase/embedding/lib/analytics.ts
index 7eef727cbc7..d324b063e7c 100644
--- a/frontend/src/metabase/embedding/lib/analytics.ts
+++ b/frontend/src/metabase/embedding/lib/analytics.ts
@@ -1,13 +1,15 @@
import { trackSchemaEvent } from "metabase/analytics";
import type { ExportFormat } from "metabase/common/types/export";
+import type {
+ EmbedResourceDownloadOptions,
+ EmbeddingParameterVisibility,
+} from "metabase-types/api";
import type {
DisplayTheme,
EmbedResource,
- EmbedResourceDownloadOptions,
EmbedResourceType,
EmbeddingDisplayOptions,
- EmbeddingParameterVisibility,
} from "../types";
const SCHEMA_NAME = "embed_flow";
diff --git a/frontend/src/metabase/embedding/lib/count-embedding-parameter-options.ts b/frontend/src/metabase/embedding/lib/count-embedding-parameter-options.ts
index 38091bff64c..d69decd346c 100644
--- a/frontend/src/metabase/embedding/lib/count-embedding-parameter-options.ts
+++ b/frontend/src/metabase/embedding/lib/count-embedding-parameter-options.ts
@@ -1,7 +1,7 @@
import type {
EmbeddingParameterVisibility,
EmbeddingParameters,
-} from "metabase/embedding/types";
+} from "metabase-types/api";
export const countEmbeddingParameterOptions = (
embeddingParams: EmbeddingParameters,
diff --git a/frontend/src/metabase/embedding/types.ts b/frontend/src/metabase/embedding/types.ts
index 0462958fd11..1c94221f2e2 100644
--- a/frontend/src/metabase/embedding/types.ts
+++ b/frontend/src/metabase/embedding/types.ts
@@ -2,6 +2,8 @@ import type { CodeLanguage } from "metabase/common/components/CodeEditor";
import type {
Card,
Dashboard,
+ EmbedResourceDownloadOptions,
+ EmbeddingParameters,
ParameterValueOrArray,
} from "metabase-types/api";
@@ -23,17 +25,6 @@ export type EmbedResourceParameter = {
default?: ParameterValueOrArray | null;
};
-export type EmbedResourceDownloadOptions = {
- pdf?: boolean;
- results?: boolean;
-};
-
-export type EmbeddingType = "static-legacy" | "guest-embed";
-
-export type EmbeddingParameterVisibility = "disabled" | "enabled" | "locked";
-
-export type EmbeddingParameters = Record<string, EmbeddingParameterVisibility>;
-
export type EmbeddingParametersValues = Record<
string,
number | string | string[] | null | undefined
diff --git a/frontend/src/metabase/plugins/oss/resource-downloads.ts b/frontend/src/metabase/plugins/oss/resource-downloads.ts
index 43cd20c9f9f..823073feb48 100644
--- a/frontend/src/metabase/plugins/oss/resource-downloads.ts
+++ b/frontend/src/metabase/plugins/oss/resource-downloads.ts
@@ -1,4 +1,4 @@
-import type { EmbedResourceDownloadOptions } from "metabase/embedding/types";
+import type { EmbedResourceDownloadOptions } from "metabase-types/api";
const getDefaultPluginResourceDownloads = () => ({
areDownloadsEnabled: (_args: {
diff --git a/frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestionView.tsx b/frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestionView.tsx
index 173f4be0f3a..93dff767bf6 100644
--- a/frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestionView.tsx
+++ b/frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestionView.tsx
@@ -4,10 +4,7 @@ import type { Dispatch, SetStateAction } from "react";
import { LoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErrorWrapper";
import CS from "metabase/css/core/index.css";
-import type {
- DisplayTheme,
- EmbedResourceDownloadOptions,
-} from "metabase/embedding/types";
+import type { DisplayTheme } from "metabase/embedding/types";
import { PLUGIN_CONTENT_TRANSLATION } from "metabase/plugins";
import { EmbedFrame } from "metabase/public/components/EmbedFrame";
import { PublicOrEmbeddedQuestionDownloadPopover } from "metabase/query_builder/components/QuestionDownloadPopover/QuestionDownloadPopover";
@@ -19,6 +16,7 @@ import type { UiParameter } from "metabase-lib/v1/parameters/types";
import type {
Card,
Dataset,
+ EmbedResourceDownloadOptions,
ParameterId,
ParameterValuesMap,
RawSeries,
diff --git a/frontend/src/metabase/query_builder/components/template_tags/TagEditorParam.tsx b/frontend/src/metabase/query_builder/components/template_tags/TagEditorParam.tsx
index d3d09e0102a..4d247ee3405 100644
--- a/frontend/src/metabase/query_builder/components/template_tags/TagEditorParam.tsx
+++ b/frontend/src/metabase/query_builder/components/template_tags/TagEditorParam.tsx
@@ -2,7 +2,6 @@ import { Component } from "react";
import { t } from "ttag";
import _ from "underscore";
-import type { EmbeddingParameterVisibility } from "metabase/embedding/types";
import { TemporalUnitSettings } from "metabase/parameters/components/TemporalUnitSettings";
import { ValuesSourceSettings } from "metabase/parameters/components/ValuesSourceSettings";
import { isSingleOrMultiSelectable } from "metabase/parameters/utils/parameter-type";
@@ -25,6 +24,7 @@ import {
} from "metabase-lib/v1/parameters/utils/template-tag-options";
import type {
DimensionReference,
+ EmbeddingParameterVisibility,
FieldId,
Parameter,
ParameterValuesConfig,
diff --git a/frontend/src/metabase/query_builder/components/template_tags/TagEditorSidebar.tsx b/frontend/src/metabase/query_builder/components/template_tags/TagEditorSidebar.tsx
index 7c7b1c3b3cd..e328bfad7e1 100644
--- a/frontend/src/metabase/query_builder/components/template_tags/TagEditorSidebar.tsx
+++ b/frontend/src/metabase/query_builder/components/template_tags/TagEditorSidebar.tsx
@@ -3,13 +3,13 @@ import { t } from "ttag";
import _ from "underscore";
import { SidebarContent } from "metabase/common/components/SidebarContent";
-import type { EmbeddingParameterVisibility } from "metabase/embedding/types";
import { Box, Tabs } from "metabase/ui";
import type Question from "metabase-lib/v1/Question";
import type Database from "metabase-lib/v1/metadata/Database";
import type NativeQuery from "metabase-lib/v1/queries/NativeQuery";
import type {
DatabaseId,
+ EmbeddingParameterVisibility,
NativeDatasetQuery,
Parameter,
ParameterId,
diff --git a/frontend/src/metabase/query_builder/components/view/View/NativeQueryRightSidebar/NativeQueryRightSidebar.tsx b/frontend/src/metabase/query_builder/components/view/View/NativeQueryRightSidebar/NativeQueryRightSidebar.tsx
index 071fc866a4a..731e9883f12 100644
--- a/frontend/src/metabase/query_builder/components/view/View/NativeQueryRightSidebar/NativeQueryRightSidebar.tsx
+++ b/frontend/src/metabase/query_builder/components/view/View/NativeQueryRightSidebar/NativeQueryRightSidebar.tsx
@@ -1,6 +1,5 @@
import { match } from "ts-pattern";
-import type { EmbeddingParameterVisibility } from "metabase/embedding/types";
import { AIQuestionAnalysisSidebar } from "metabase/metabot/components/AIQuestionAnalysisSidebar";
import { TagEditorSidebar } from "metabase/query_builder/components/template_tags/TagEditorSidebar";
import { QuestionInfoSidebar } from "metabase/query_builder/components/view/sidebars/QuestionInfoSidebar";
@@ -13,6 +12,7 @@ import type Question from "metabase-lib/v1/Question";
import type Database from "metabase-lib/v1/metadata/Database";
import type {
DatabaseId,
+ EmbeddingParameterVisibility,
NativeDatasetQuery,
RowValue,
TemplateTag,