Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Don't show CORS settings in OSS/Starter editions (#68564)

Timofey Kachalovea203102e653
diff --git a/e2e/test/scenarios/embedding/embedding-admin-settings-oss.cy.spec.ts b/e2e/test/scenarios/embedding/embedding-admin-settings-oss.cy.spec.ts
index 6583073c4e9..655aa86b177 100644
--- a/e2e/test/scenarios/embedding/embedding-admin-settings-oss.cy.spec.ts
+++ b/e2e/test/scenarios/embedding/embedding-admin-settings-oss.cy.spec.ts
@@ -54,5 +54,15 @@ describe(
);
});
});
+
+ it("should not show CORS setting", () => {
+ cy.visit("/admin/embedding");
+
+ cy.findByTestId("admin-layout-content").within(() => {
+ cy.findByTestId("embedding-app-origins-sdk-setting").should(
+ "not.exist",
+ );
+ });
+ });
},
);
diff --git a/e2e/test/scenarios/embedding/embedding-admin-settings-starter.cy.spec.ts b/e2e/test/scenarios/embedding/embedding-admin-settings-starter.cy.spec.ts
index 07a15d2eb89..d917bacaa34 100644
--- a/e2e/test/scenarios/embedding/embedding-admin-settings-starter.cy.spec.ts
+++ b/e2e/test/scenarios/embedding/embedding-admin-settings-starter.cy.spec.ts
@@ -46,4 +46,12 @@ describe("scenarios > embedding > admin settings > starter", () => {
cy.icon("gem").should("be.visible");
});
});
+
+ it("should not show CORS setting", () => {
+ cy.visit("/admin/embedding");
+
+ cy.findByTestId("admin-layout-content").within(() => {
+ cy.findByTestId("embedding-app-origins-sdk-setting").should("not.exist");
+ });
+ });
});
diff --git a/frontend/src/metabase/admin/settings/components/EmbeddingSettings/EmbeddingSettings/EmbeddingSettings.tsx b/frontend/src/metabase/admin/settings/components/EmbeddingSettings/EmbeddingSettings/EmbeddingSettings.tsx
index f71101802b3..b8b285920c6 100644
--- a/frontend/src/metabase/admin/settings/components/EmbeddingSettings/EmbeddingSettings/EmbeddingSettings.tsx
+++ b/frontend/src/metabase/admin/settings/components/EmbeddingSettings/EmbeddingSettings/EmbeddingSettings.tsx
@@ -116,12 +116,7 @@ function EmbeddingSettingsEE() {
}
function EmbeddingSettingsOSS() {
- return (
- <SharedCombinedEmbeddingSettings
- showCorsSettings
- showContentTranslationSettings
- />
- );
+ return <SharedCombinedEmbeddingSettings showContentTranslationSettings />;
}
export const EmbeddingSettings = () => {
diff --git a/frontend/src/metabase/admin/settings/components/EmbeddingSettings/SharedCombinedEmbeddingSettings/SharedCombinedEmbeddingSettings.tsx b/frontend/src/metabase/admin/settings/components/EmbeddingSettings/SharedCombinedEmbeddingSettings/SharedCombinedEmbeddingSettings.tsx
index d055b2538e4..45336cc679c 100644
--- a/frontend/src/metabase/admin/settings/components/EmbeddingSettings/SharedCombinedEmbeddingSettings/SharedCombinedEmbeddingSettings.tsx
+++ b/frontend/src/metabase/admin/settings/components/EmbeddingSettings/SharedCombinedEmbeddingSettings/SharedCombinedEmbeddingSettings.tsx
@@ -40,7 +40,7 @@ export function SharedCombinedEmbeddingSettings({
<>
<EmbeddingSettingsCard
title={t`Enable guest embeds`}
- description={t`A secure way to embed charts and dashboards, without single sign-on, when you don’t want to offer ad-hoc querying or chart drill-through. Enables modular embedding and static embedding.`}
+ description={t`A secure way to embed charts and dashboards, without single sign-on, when you don’t want to offer ad-hoc querying or chart drill-through.`}
settingKey="enable-embedding-static"
actionButton={<NewEmbedButton />}
sdk-setting-card