Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Update related settings copy and alignment on embedding hub (#63660)

Phoomparin Manoea7eeeb15e3d
diff --git a/enterprise/frontend/src/metabase-enterprise/embedding/components/InteractiveEmbeddingSettings.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/embedding/components/InteractiveEmbeddingSettings.unit.spec.tsx
index ec3e7d4ba53..073d7060b97 100644
--- a/enterprise/frontend/src/metabase-enterprise/embedding/components/InteractiveEmbeddingSettings.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/embedding/components/InteractiveEmbeddingSettings.unit.spec.tsx
@@ -102,7 +102,7 @@ describe("InteractiveEmbeddingSettings", () => {
expect(await screen.findByText("Databases")).toBeInTheDocument();
expect(await screen.findByText("People")).toBeInTheDocument();
expect(await screen.findByText("Permissions")).toBeInTheDocument();
- expect(await screen.findByText("Metabot")).toBeInTheDocument();
+ expect(await screen.findByText("Embedded Metabot")).toBeInTheDocument();
expect(await screen.findByText("Appearance")).toBeInTheDocument();
});
});
diff --git a/frontend/src/metabase/admin/components/RelatedSettingsSection/constants.ts b/frontend/src/metabase/admin/components/RelatedSettingsSection/constants.ts
index bfa6b663a2c..3bb7066b32a 100644
--- a/frontend/src/metabase/admin/components/RelatedSettingsSection/constants.ts
+++ b/frontend/src/metabase/admin/components/RelatedSettingsSection/constants.ts
@@ -87,7 +87,7 @@ export const getInteractiveEmbeddingRelatedSettingItems =
},
{
icon: "metabot",
- name: t`Metabot`,
+ name: t`Embedded Metabot`,
to: "/admin/metabot/2",
},
{
diff --git a/frontend/src/metabase/embedding/embedding-hub/components/EmbeddingHub.tsx b/frontend/src/metabase/embedding/embedding-hub/components/EmbeddingHub.tsx
index 26ed7af00f6..992c1e929fd 100644
--- a/frontend/src/metabase/embedding/embedding-hub/components/EmbeddingHub.tsx
+++ b/frontend/src/metabase/embedding/embedding-hub/components/EmbeddingHub.tsx
@@ -73,7 +73,6 @@ export const EmbeddingHub = () => {
return (
<>
<StepperWithCards steps={stepperSteps} />
-
<AddDataModal
opened={openedModal?.type === "add-data"}
onClose={closeModal}
diff --git a/frontend/src/metabase/embedding/embedding-hub/components/EmbeddingHubAdminSettingsPage.tsx b/frontend/src/metabase/embedding/embedding-hub/components/EmbeddingHubAdminSettingsPage.tsx
index afd1c5eec3d..41fac70e497 100644
--- a/frontend/src/metabase/embedding/embedding-hub/components/EmbeddingHubAdminSettingsPage.tsx
+++ b/frontend/src/metabase/embedding/embedding-hub/components/EmbeddingHubAdminSettingsPage.tsx
@@ -22,9 +22,11 @@ export const EmbeddingHubAdminSettingsPage = () => {
<EmbeddingHub />
- <RelatedSettingsSection
- items={getModularEmbeddingRelatedSettingItems()}
- />
+ <Stack ml="2.9rem">
+ <RelatedSettingsSection
+ items={getModularEmbeddingRelatedSettingItems()}
+ />
+ </Stack>
</Stack>
);
};