Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix unreferenced dependency flakes (#69535)

Romeo Van Snickead4e7d4d9ac
diff --git a/e2e/support/helpers/e2e-dependency-helpers.ts b/e2e/support/helpers/e2e-dependency-helpers.ts
index a79cb7a37c7..881477d35a9 100644
--- a/e2e/support/helpers/e2e-dependency-helpers.ts
+++ b/e2e/support/helpers/e2e-dependency-helpers.ts
@@ -14,8 +14,10 @@ export const DependencyGraph = {
export const DependencyDiagnostics = {
visitBrokenDependencies: () =>
cy.visit("/data-studio/dependency-diagnostics/broken"),
- visitUnreferencedEntities: () =>
- cy.visit("/data-studio/dependency-diagnostics/unreferenced"),
+ visitUnreferencedEntities: () => {
+ cy.visit("/data-studio/dependency-diagnostics/unreferenced");
+ DependencyDiagnostics.list().should("be.visible");
+ },
list: () => cy.findByTestId("dependency-list"),
searchInput: () => cy.findByTestId("dependency-list-search-input"),
filterButton: () => cy.findByTestId("dependency-filter-button"),
diff --git a/e2e/test/scenarios/dependencies/dependency-unreferenced-list.cy.spec.ts b/e2e/test/scenarios/dependencies/dependency-unreferenced-list.cy.spec.ts
index f921eae7c73..e7452f8f017 100644
--- a/e2e/test/scenarios/dependencies/dependency-unreferenced-list.cy.spec.ts
+++ b/e2e/test/scenarios/dependencies/dependency-unreferenced-list.cy.spec.ts
@@ -1070,7 +1070,7 @@ function checkList({
}) {
H.DependencyDiagnostics.list().within(() => {
visibleEntities.forEach((name) => {
- cy.findByText(name).should("be.visible");
+ cy.findByText(name).scrollIntoView().should("be.visible");
});
hiddenEntities.forEach((name) => {
cy.findByText(name).should("not.exist");
@@ -1108,7 +1108,10 @@ function checkSidebar({
H.DependencyDiagnostics.sidebar().within(() => {
Sidebar.header().findByText(title).should("be.visible");
if (location) {
- Sidebar.locationSection().findByText(location).should("be.visible");
+ Sidebar.locationSection()
+ .findByText(location)
+ .scrollIntoView()
+ .should("be.visible");
}
if (description) {
Sidebar.infoSection().should("contain.text", description);
@@ -1122,7 +1125,7 @@ function checkSidebar({
if (fields.length > 0) {
Sidebar.fieldsSection().within(() => {
fields.forEach((field) => {
- cy.findByText(field).should("be.visible");
+ cy.findByText(field).scrollIntoView().should("be.visible");
});
});
}