The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Fix broken pie chart colors for some strings in static-viz (#70640)
Kevin Kellehereadbd4b00df6
diff --git a/frontend/src/metabase/visualizations/shared/settings/pie.ts b/frontend/src/metabase/visualizations/shared/settings/pie.tsindex d31fa6e803c..8ee3f550e2d 100644--- a/frontend/src/metabase/visualizations/shared/settings/pie.ts+++ b/frontend/src/metabase/visualizations/shared/settings/pie.ts@@ -209,7 +209,7 @@ export function getColors(return Object.fromEntries(Object.entries(colors).map(([key, value]) => [key === "null" ? NULL_DISPLAY_VALUE : key,- value,+ getHexColor(value),]),);}diff --git a/frontend/src/metabase/visualizations/shared/settings/pie.unit.spec.ts b/frontend/src/metabase/visualizations/shared/settings/pie.unit.spec.tsindex 0db3990083d..ea35af433ba 100644--- a/frontend/src/metabase/visualizations/shared/settings/pie.unit.spec.ts+++ b/frontend/src/metabase/visualizations/shared/settings/pie.unit.spec.ts@@ -143,4 +143,34 @@ describe("getColors", () => {Widget: "#000000",});});+ it("should return hex values for colors", () => {+ // getPreferredColor returns hsla values for strings like "active"+ // make sure getColors is correctly converting them to hex values+ // because hsla is not supported in static-viz+ const columns = [+ createMockColumn({ name: "Category" }),+ createMockColumn({ name: "Count" }),+ ];+ const rawSeries = [+ {+ data: createMockDatasetData({+ rows: [+ ["active", 1],+ ["other", 2],+ ],+ cols: columns,+ }),+ },+ ] as RawSeries;+ const settings = {+ "pie.metric": "Count",+ "pie.dimension": "Category",+ };+ const result = getColors(rawSeries, settings);+ expect(+ Object.values(result).every(+ (color) => color.startsWith("#") && color.length === 7,+ ),+ ).toBe(true);+ });});