Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Reject invalid queries for admins on impersonated DBs (#73168)

Riley Thompsonebaa93ef414c
diff --git a/e2e/test/scenarios/admin/database-routing/database-routing-usage.cy.spec.ts b/e2e/test/scenarios/admin/database-routing/database-routing-usage.cy.spec.ts
index e44d9f7a4d5..75fbc7e15f0 100644
--- a/e2e/test/scenarios/admin/database-routing/database-routing-usage.cy.spec.ts
+++ b/e2e/test/scenarios/admin/database-routing/database-routing-usage.cy.spec.ts
@@ -393,7 +393,16 @@ describe("admin > database > database routing", { tags: ["@external"] }, () => {
});
signInAs(DB_ROUTER_USERS.userA);
- H.visitQuestion(questionId);
+ const alias = "cardQuery" + questionId;
+ const metadataAlias = `${alias}-queryMetadata`;
+ cy.intercept("POST", `/api/card/**/${questionId}/query`).as(alias);
+ cy.intercept("GET", `/api/card/**/${questionId}/query_metadata`).as(
+ metadataAlias,
+ );
+ cy.visit(`/question/${questionId}`);
+ // Longer timeout: first impersonation validation triggers cold Python context init
+ cy.wait("@" + metadataAlias, { timeout: 30000 });
+ cy.wait("@" + alias, { timeout: 30000 });
cy.get('[data-column-id="name"]').should("contain", "destination_one");
cy.get('[data-column-id="color"]').should("contain", "blue");
cy.get('[data-column-id="color"]').should("not.contain", "red");
diff --git a/enterprise/backend/src/metabase_enterprise/impersonation/middleware.clj b/enterprise/backend/src/metabase_enterprise/impersonation/middleware.clj
index aca331556a6..23bb27614e9 100644
--- a/enterprise/backend/src/metabase_enterprise/impersonation/middleware.clj
+++ b/enterprise/backend/src/metabase_enterprise/impersonation/middleware.clj
@@ -10,19 +10,26 @@
[metabase.util.i18n :refer [tru]]))
(defenterprise apply-impersonation
- "Pre-processing middleware. Adds a key to the query. Currently used solely for caching."
+ "Pre-processing middleware. Validates that native queries on impersonated databases are single SELECT statements,
+ and adds an impersonation role key to the query for non-admin users. Currently used solely for caching."
;; run this even when the `:advanced-permissions` feature is not enabled, so that we can assert that it *is* enabled
;; if impersonation is configured. (Throwing here is better than silently ignoring the configured impersonation.)
:feature :none
[query]
- (if-let [role (when-not qp.i/*skip-middleware-because-app-db-access*
- (impersonation.driver/connection-impersonation-role
- (lib.metadata/database (qp.store/metadata-provider))))]
- (do
- (premium-features/assert-has-feature :advanced-permissions (tru "Advanced Permissions"))
- (-> (driver/validate-impersonated-query driver/*driver* query)
- (assoc :impersonation/role role)))
- query))
+ (if qp.i/*skip-middleware-because-app-db-access*
+ query
+ (let [database (lib.metadata/database (qp.store/metadata-provider))
+ impersonation-enabled? (impersonation.driver/impersonation-enabled-for-db? database)
+ role (impersonation.driver/connection-impersonation-role database)]
+ (cond-> query
+ ;; Validate for ALL users if impersonation is configured on this DB
+ impersonation-enabled?
+ (as-> q
+ (do (premium-features/assert-has-feature :advanced-permissions (tru "Advanced Permissions"))
+ (driver/validate-impersonated-query driver/*driver* q)))
+ ;; Only assign the role for non-admin impersonated users
+ role
+ (assoc :impersonation/role role)))))
(defenterprise apply-impersonation-postprocessing
"Post-processing middleware. Binds the impersonation role dynamic var for driver use."
diff --git a/enterprise/backend/test/metabase_enterprise/impersonation/driver_test.clj b/enterprise/backend/test/metabase_enterprise/impersonation/driver_test.clj
index 9bfa7e68176..fe96c97dada 100644
--- a/enterprise/backend/test/metabase_enterprise/impersonation/driver_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/impersonation/driver_test.clj
@@ -971,3 +971,47 @@
"SET ROLE NONE; DROP TABLE table"
"SELECT set_config('role', 'none', false); DROP TABLE table"
"DO $$ BEGIN EXECUTE 'SET ROLE NONE; DROP TABLE table'; END $$;")))))))))))
+
+(deftest reject-non-select-statements-for-admin-on-impersonated-db-test
+ (testing "Admin users are also validated on impersonated databases"
+ (mt/test-drivers (mt/normal-drivers-with-feature :connection-impersonation)
+ (mt/with-premium-features #{:advanced-permissions}
+ (let [venues-table (sql.tx/qualify-and-quote driver/*driver* "test-data" "venues")
+ role-a (u/lower-case-en (mt/random-name))]
+ (tx/with-temp-roles! driver/*driver*
+ (impersonation-granting-details driver/*driver* (mt/db))
+ {role-a {venues-table {}}}
+ (impersonation-default-user driver/*driver*)
+ (impersonation-default-role driver/*driver*)
+ (mt/with-temp [:model/Database database {:engine driver/*driver*,
+ :details (impersonation-details driver/*driver* (mt/db))}]
+ (mt/with-db database
+ (when (driver/database-supports? driver/*driver* :connection-impersonation-requires-role nil)
+ (t2/update! :model/Database :id (mt/id) (assoc-in (mt/db) [:details :role] (impersonation-default-role driver/*driver*))))
+ (sync/sync-database! database {:scan :schema})
+ (impersonation.util-test/with-impersonations-for-user! :crowberto
+ {:impersonations [{:db-id (mt/id) :attribute "impersonation_attr"}]
+ :attributes {"impersonation_attr" role-a}}
+ (testing "A single SELECT statement works for admin"
+ (let [mp (mt/metadata-provider)
+ run-native-query (fn [table] (->> (-> (lib/query mp (lib.metadata/table mp (mt/id table)))
+ (lib/aggregate (lib/count)))
+ (qp.compile/compile-with-inline-parameters)
+ :query
+ (lib/native-query mp)
+ (qp/process-query)
+ (mt/rows)))]
+ (is (= [[100]] (run-native-query :venues)))))
+ (testing "Invalid queries are rejected for admin too"
+ (are [sql] (thrown?
+ java.lang.Exception
+ (-> (lib/native-query (mt/metadata-provider) sql)
+ (qp/process-query)
+ (mt/rows)))
+ "SELECT ("
+ "SELECT 1; SELECT 2"
+ "SET ROLE NONE"
+ "DROP TABLE table"
+ "SET ROLE NONE; DROP TABLE table"
+ "SELECT set_config('role', 'none', false); DROP TABLE table"
+ "DO $$ BEGIN EXECUTE 'SET ROLE NONE; DROP TABLE table'; END $$;")))))))))))
diff --git a/src/metabase/driver/sql.clj b/src/metabase/driver/sql.clj
index 781567b5c34..e1825a92b64 100644
--- a/src/metabase/driver/sql.clj
+++ b/src/metabase/driver/sql.clj
@@ -14,6 +14,7 @@
[metabase.driver.sql.util :as sql.u]
[metabase.driver.util :as driver.u]
[metabase.lib.util :as lib.util]
+ [metabase.query-processor.error-type :as qp.error-type]
[metabase.sql-tools.core :as sql-tools]
[metabase.util.i18n :refer [tru]]
[metabase.util.log :as log]
@@ -250,12 +251,17 @@
(if (lib.util/native-stage? stage)
(let [{:keys [is-single-select? sql error]}
(sql-tools/is-single-select-stmt? driver (:native stage))]
- (when error
- (log/warnf "Failed to parse native query: %s\n: Query: %s" error (:native stage)))
- (if is-single-select?
- (assoc stage :native sql)
- (throw (ex-info (tru "Invalid impersonated native query. Must be a single select statement.")
- {:sql (:native stage)}))))
+ (cond error
+ (do
+ (log/warnf "Failed to parse native query: %s\n: Query: %s" error (:native stage))
+ (throw (ex-info (tru "Unable to parse native query. There might be something wrong with your query.")
+ {:type qp.error-type/invalid-query
+ :sql (:native stage)})))
+ (not is-single-select?)
+ (throw (ex-info (tru "Invalid impersonated native query. Must be a single select statement.")
+ {:type qp.error-type/invalid-query
+ :sql (:native stage)}))
+ :else (assoc stage :native sql)))
stage))
stages))))