The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Allow content-disposition header in cross-origin requests (#65918)
Phoomparin Manoec73bb3bae03
diff --git a/e2e/test-component/scenarios/embedding-sdk/interactive-dashboard.cy.spec.tsx b/e2e/test-component/scenarios/embedding-sdk/interactive-dashboard.cy.spec.tsxindex eea4824e9cf..72b11893dab 100644--- a/e2e/test-component/scenarios/embedding-sdk/interactive-dashboard.cy.spec.tsx+++ b/e2e/test-component/scenarios/embedding-sdk/interactive-dashboard.cy.spec.tsx@@ -318,6 +318,23 @@ describe("scenarios > embedding-sdk > interactive-dashboard", () => {cy.wait("@dashcardDownload").then((interception) => {expect(interception.response?.statusCode).to.equal(200);++ cy.log(+ "content-disposition is allowed in cross-origin requests (metabase#61708)",+ );+ expect(+ interception.response?.headers?.["access-control-expose-headers"],+ ).to.include("Content-Disposition");++ cy.log(+ "question name is prefixed in the downloaded file name (metabase#61708)",+ );+ expect(+ interception.response?.headers?.["content-disposition"],+ ).to.include('filename="orders_');+ expect(+ interception.response?.headers?.["content-disposition"],+ ).not.to.include('filename="query_result_');});});});diff --git a/src/metabase/server/middleware/security.clj b/src/metabase/server/middleware/security.cljindex 57782b67e6a..d2e54fba7db 100644--- a/src/metabase/server/middleware/security.clj+++ b/src/metabase/server/middleware/security.clj@@ -262,7 +262,7 @@"Vary" "Origin"}){"Access-Control-Allow-Headers" "*""Access-Control-Allow-Methods" "*"- "Access-Control-Expose-Headers" "X-Metabase-Anti-CSRF-Token, X-Metabase-Version"+ "Access-Control-Expose-Headers" "Content-Disposition, X-Metabase-Anti-CSRF-Token, X-Metabase-Version";; Needed for Embedding SDK. Should cache preflight requests for the specified number of seconds."Access-Control-Max-Age" "60"}))))