Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Update Checkbox Styling (#72375)

Nick Fitzpatrickee9e271af6aa
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List.png
index 9870af7c001..de80e9658e0 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_With_Value.png
index a54152d608c..de28438ad40 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search.png
index 9870af7c001..de80e9658e0 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search_With_Value.png
index 4677eccd0ef..39ba605317b 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List.png
index 6d1ecdb1294..a9dc82bea79 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_With_Value.png
index e5d8938ebcc..5db0cc52d27 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search.png
index 6d1ecdb1294..15958098b08 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search_With_Value.png
index 62304fe8fc3..e6b4cde1f17 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week.png b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week.png
index bd259f7ceca..4133c629fe5 100644
Binary files a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week.png and b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week_Dark_Theme.png b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week_Dark_Theme.png
index 98722bb4de7..b3bad432ea4 100644
Binary files a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week_Dark_Theme.png and b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week_Dark_Theme.png differ
diff --git a/frontend/src/metabase/parameters/components/ParameterSettings/TemporalUnitSettings/TemporalUnitSettings.tsx b/frontend/src/metabase/parameters/components/ParameterSettings/TemporalUnitSettings/TemporalUnitSettings.tsx
index d5e1eb2360a..724e2c1cfc1 100644
--- a/frontend/src/metabase/parameters/components/ParameterSettings/TemporalUnitSettings/TemporalUnitSettings.tsx
+++ b/frontend/src/metabase/parameters/components/ParameterSettings/TemporalUnitSettings/TemporalUnitSettings.tsx
@@ -102,7 +102,7 @@ function TemporalUnitDropdown({
variant="stacked"
onChange={handleAllToggle}
/>
- <Text c="text-secondary" ml="sm">{t`Select all`}</Text>
+ <Text c="text-secondary" ml="sm" lh="inherit">{t`Select all`}</Text>
</label>
<Divider />
{availableUnits.map((unit) => {
diff --git a/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/FieldValuesWidget/ListField/ListField.tsx b/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/FieldValuesWidget/ListField/ListField.tsx
index a4e4fff31df..b3ca8823b52 100644
--- a/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/FieldValuesWidget/ListField/ListField.tsx
+++ b/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/FieldValuesWidget/ListField/ListField.tsx
@@ -209,7 +209,7 @@ export const ListField = ({
<Checkbox
variant="stacked"
label={
- <Text c="text-secondary">
+ <Text c="text-secondary" lh="inherit">
{debouncedFilter ? t`Select these` : t`Select all`}
</Text>
}
diff --git a/frontend/src/metabase/querying/common/components/DatePicker/ExcludeDatePicker/ExcludeDatePicker.tsx b/frontend/src/metabase/querying/common/components/DatePicker/ExcludeDatePicker/ExcludeDatePicker.tsx
index 885afbae0b3..a0f5b2853e9 100644
--- a/frontend/src/metabase/querying/common/components/DatePicker/ExcludeDatePicker/ExcludeDatePicker.tsx
+++ b/frontend/src/metabase/querying/common/components/DatePicker/ExcludeDatePicker/ExcludeDatePicker.tsx
@@ -222,7 +222,7 @@ function ExcludeValuePicker({
<Stack p="md">
<Checkbox
checked={isAll}
- label={<Text c="text-secondary">{t`Select all`}</Text>}
+ label={<Text c="text-secondary" lh="inherit">{t`Select all`}</Text>}
onChange={(event) => handleToggleAll(event.target.checked)}
/>
<Divider />
diff --git a/frontend/src/metabase/querying/common/components/FieldValuePicker/ListValuePicker/ListValuePicker.tsx b/frontend/src/metabase/querying/common/components/FieldValuePicker/ListValuePicker/ListValuePicker.tsx
index e4e9a701ef9..5e96a40db29 100644
--- a/frontend/src/metabase/querying/common/components/FieldValuePicker/ListValuePicker/ListValuePicker.tsx
+++ b/frontend/src/metabase/querying/common/components/FieldValuePicker/ListValuePicker/ListValuePicker.tsx
@@ -71,7 +71,7 @@ function CheckboxListPicker({
<Checkbox
variant="stacked"
label={
- <Text c="text-secondary">
+ <Text c="text-secondary" lh="inherit">
{searchValue ? t`Select these` : t`Select all`}
</Text>
}
diff --git a/frontend/src/metabase/ui/components/inputs/Checkbox/Checkbox.config.ts b/frontend/src/metabase/ui/components/inputs/Checkbox/Checkbox.config.ts
index 03ba8516352..3065af52580 100644
--- a/frontend/src/metabase/ui/components/inputs/Checkbox/Checkbox.config.ts
+++ b/frontend/src/metabase/ui/components/inputs/Checkbox/Checkbox.config.ts
@@ -21,8 +21,10 @@ export const checkboxOverrides = {
input: CheckboxStyles.input,
icon: CheckboxStyles.icon,
label: CheckboxStyles.label,
+ labelWrapper: CheckboxStyles.labelWrapper,
description: CheckboxStyles.description,
inner: CheckboxStyles.inner,
+ error: CheckboxStyles.error,
},
vars: (_theme, { size }) => {
return {
diff --git a/frontend/src/metabase/ui/components/inputs/Checkbox/Checkbox.module.css b/frontend/src/metabase/ui/components/inputs/Checkbox/Checkbox.module.css
index b1481e12b1c..9ea41b42c51 100644
--- a/frontend/src/metabase/ui/components/inputs/Checkbox/Checkbox.module.css
+++ b/frontend/src/metabase/ui/components/inputs/Checkbox/Checkbox.module.css
@@ -61,7 +61,7 @@
}
.body {
- align-items: center;
+ align-items: start;
}
.input {
@@ -86,7 +86,9 @@
&:disabled {
border-color: var(--mb-color-background-disabled);
- background-color: var(--mb-color-background-disabled);
+ background-color: var(
+ --mb-color-background-tertiary
+ ); /* Opaque color needed here */
}
}
@@ -100,9 +102,20 @@
color: var(--mb-color-text-primary);
font-size: var(--mantine-font-size-sm);
line-height: var(--mantine-line-height-sm);
- margin-top: var(--mantine-spacing-xs);
+ margin-top: 0 !important;
+ margin-bottom: 0 !important;
+}
+
+.error {
+ margin-top: 0 !important;
+ margin-bottom: 0 !important;
}
.icon {
color: var(--mb-color-text-primary-inverse);
}
+
+.labelWrapper {
+ gap: 0.25rem;
+ align-self: center;
+}
diff --git a/frontend/src/metabase/ui/components/inputs/Checkbox/Checkbox.stories.tsx b/frontend/src/metabase/ui/components/inputs/Checkbox/Checkbox.stories.tsx
index f7a0cbe9512..c6b8465084c 100644
--- a/frontend/src/metabase/ui/components/inputs/Checkbox/Checkbox.stories.tsx
+++ b/frontend/src/metabase/ui/components/inputs/Checkbox/Checkbox.stories.tsx
@@ -72,6 +72,12 @@ const StateTemplate = (args: CheckboxProps) => (
disabled
defaultChecked
/>
+ <Checkbox
+ {...args}
+ label="With an error"
+ defaultChecked
+ error="Oh nooooo something has gone terribly wrong"
+ />
</Stack>
);
@@ -103,6 +109,9 @@ export const LabelLeftPosition = {
export const Description = {
render: StateTemplate,
+ args: {
+ description: "How do I look with a description?",
+ },
};
export const DescriptionLeftPosition = {
@@ -110,6 +119,7 @@ export const DescriptionLeftPosition = {
name: "Description, left position",
args: {
labelPosition: "left",
+ description: "How do I look with a description?",
},
};