Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

remove .local reference from rspack as .local lookup is slow and we can (#65060)

Nicolò Prettoeeb44b4b5a03
diff --git a/rspack.main.config.js b/rspack.main.config.js
index 9c52ce198ca..26dfeabc2f0 100644
--- a/rspack.main.config.js
+++ b/rspack.main.config.js
@@ -48,8 +48,9 @@ const isDevMode = IS_DEV_MODE;
const shouldEnableHotRefresh = WEBPACK_BUNDLE === "hot";
// If you want to test metabase locally with a custom domain, either use
-// `metabase.local` or add your custom domain via the `MB_TEST_CUSTOM_DOMAINS`
-// environment variable so that rspack will allow requests from them.
+// `metabase.localhost` (anything .localhost should work out of the box) or add
+// your custom domain via the `MB_TEST_CUSTOM_DOMAINS` environment variable so
+// that rspack will allow requests from them.
const TEST_CUSTOM_DOMAINS =
process.env.MB_TEST_CUSTOM_DOMAINS?.split(",")
.map((domain) => domain.trim())
@@ -354,7 +355,7 @@ if (shouldEnableHotRefresh) {
headers: {
"Access-Control-Allow-Origin": "*",
},
- allowedHosts: ["localhost", "metabase.local", ...TEST_CUSTOM_DOMAINS],
+ allowedHosts: ["localhost", ...TEST_CUSTOM_DOMAINS],
// tweak stats to make the output in the console more legible
devMiddleware: {
stats: { preset: "errors-warnings", timings: true },