The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Move card slowness into viz types (#72846)
Fraserf0b01b187b6f
diff --git a/frontend/src/metabase/dashboard/components/DashCard/DashCard.tsx b/frontend/src/metabase/dashboard/components/DashCard/DashCard.tsxindex b8ff6bebade..968c9da6c16 100644--- a/frontend/src/metabase/dashboard/components/DashCard/DashCard.tsx+++ b/frontend/src/metabase/dashboard/components/DashCard/DashCard.tsx@@ -27,6 +27,7 @@ import { isQuestionCard, isQuestionDashCard } from "metabase/utils/dashboard";import { useDispatch, useSelector, useStore } from "metabase/utils/redux";import { getVisualizationRaw } from "metabase/visualizations";import { extendCardWithDashcardSettings } from "metabase/visualizations/lib/settings/typed-utils";+import type { CardSlownessStatus } from "metabase/visualizations/types";import {getInitialStateForCardDataSource,getInitialStateForMultipleSeries,@@ -45,10 +46,7 @@ import type {import S from "./DashCard.module.css";import { DashCardActionsPanel } from "./DashCardActionsPanel/DashCardActionsPanel";import { DashCardVisualization } from "./DashCardVisualization";-import type {- CardSlownessStatus,- DashCardOnChangeCardAndRunHandler,-} from "./types";+import type { DashCardOnChangeCardAndRunHandler } from "./types";function preventDragging(event: React.SyntheticEvent) {event.stopPropagation();diff --git a/frontend/src/metabase/dashboard/components/DashCard/DashCardVisualization.tsx b/frontend/src/metabase/dashboard/components/DashCard/DashCardVisualization.tsxindex 1ebcd4e8f40..ecbac87f7ba 100644--- a/frontend/src/metabase/dashboard/components/DashCard/DashCardVisualization.tsx+++ b/frontend/src/metabase/dashboard/components/DashCard/DashCardVisualization.tsx@@ -48,7 +48,10 @@ import {import ChartSkeleton from "metabase/visualizations/components/skeletons/ChartSkeleton";import { extendCardWithDashcardSettings } from "metabase/visualizations/lib/settings/typed-utils";import { getComputedSettingsForSeries } from "metabase/visualizations/lib/settings/visualization";-import type { ComputedVisualizationSettings } from "metabase/visualizations/types";+import type {+ CardSlownessStatus,+ ComputedVisualizationSettings,+} from "metabase/visualizations/types";import {createDataSource,isVisualizerDashboardCard,@@ -81,10 +84,7 @@ import { DashCardMenu } from "./DashCardMenu/DashCardMenu";import { DashCardParameterMapper } from "./DashCardParameterMapper/DashCardParameterMapper";import S from "./DashCardVisualization.module.css";import { getDashcardTokenId, getDashcardUuid } from "./dashcard-ids";-import type {- CardSlownessStatus,- DashCardOnChangeCardAndRunHandler,-} from "./types";+import type { DashCardOnChangeCardAndRunHandler } from "./types";import {getMissingColumnsFromVisualizationSettings,shouldShowParameterMapper,diff --git a/frontend/src/metabase/dashboard/components/DashCard/types.ts b/frontend/src/metabase/dashboard/components/DashCard/types.tsindex 37bb85b8aee..c289427a41a 100644--- a/frontend/src/metabase/dashboard/components/DashCard/types.ts+++ b/frontend/src/metabase/dashboard/components/DashCard/types.ts@@ -1,7 +1,5 @@import type { Card, DashboardCard } from "metabase-types/api";-export type CardSlownessStatus = "usually-fast" | "usually-slow" | boolean;-export type NavigateToNewCardFromDashboardOpts = {nextCard: Card;previousCard: Card;diff --git a/frontend/src/metabase/visualizations/components/Visualization/LoadingView/LoadingView.tsx b/frontend/src/metabase/visualizations/components/Visualization/LoadingView/LoadingView.tsxindex 93059f9d9aa..acda282f6c7 100644--- a/frontend/src/metabase/visualizations/components/Visualization/LoadingView/LoadingView.tsx+++ b/frontend/src/metabase/visualizations/components/Visualization/LoadingView/LoadingView.tsx@@ -1,7 +1,7 @@import { jt, t } from "ttag";-import type { CardSlownessStatus } from "metabase/dashboard/components/DashCard/types";import { duration } from "metabase/utils/formatting";+import type { CardSlownessStatus } from "metabase/visualizations/types";import {Duration,diff --git a/frontend/src/metabase/visualizations/components/Visualization/Visualization.tsx b/frontend/src/metabase/visualizations/components/Visualization/Visualization.tsxindex 570d249dda4..7a533450e51 100644--- a/frontend/src/metabase/visualizations/components/Visualization/Visualization.tsx+++ b/frontend/src/metabase/visualizations/components/Visualization/Visualization.tsx@@ -18,7 +18,6 @@ import { SmallGenericError } from "metabase/common/components/ErrorPages";import { ExplicitSize } from "metabase/common/components/ExplicitSize";import CS from "metabase/css/core/index.css";import DashboardS from "metabase/css/dashboard.module.css";-import type { CardSlownessStatus } from "metabase/dashboard/components/DashCard/types";import { isEmbeddingSdk } from "metabase/embedding-sdk/config";import type { ContentTranslationFunction } from "metabase/i18n/types";import { getIsDownloadingToImage } from "metabase/redux/downloads";@@ -46,6 +45,7 @@ import {import { getComputedSettingsForSeries } from "metabase/visualizations/lib/settings/visualization";import { getCardKey, isSameSeries } from "metabase/visualizations/lib/utils";import {+ type CardSlownessStatus,type ClickActionModeGetter,type ClickActionsMode,type ClickObject,diff --git a/frontend/src/metabase/visualizations/types/visualization.ts b/frontend/src/metabase/visualizations/types/visualization.tsindex 92a71c67cc4..073abce6714 100644--- a/frontend/src/metabase/visualizations/types/visualization.ts+++ b/frontend/src/metabase/visualizations/types/visualization.ts@@ -65,6 +65,8 @@ export type TableCellFormatter = (value: RowValue) => ReactNode;export type Extent = [number, number];+export type CardSlownessStatus = "usually-fast" | "usually-slow" | boolean;+export interface RenderingContext {getColor: ColorGetter;measureText: TextWidthMeasurer;