Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

GDGT-3352: Incremental transforms: "Learn more" link opens the docs at the top of the page instead of the incremental section (#84070)

Anna Tomkaf108060eb83c
diff --git a/frontend/src/metabase/transforms/components/IncrementalTransform/IncrementalTransformSettings.tsx b/frontend/src/metabase/transforms/components/IncrementalTransform/IncrementalTransformSettings.tsx
index 394cea57acc..3a6c0ddb0eb 100644
--- a/frontend/src/metabase/transforms/components/IncrementalTransform/IncrementalTransformSettings.tsx
+++ b/frontend/src/metabase/transforms/components/IncrementalTransform/IncrementalTransformSettings.tsx
@@ -68,8 +68,14 @@ export const IncrementalTransformSettings = ({
const { url: incrementalTransformsDocsUrl, showMetabaseLinks } = useDocsUrl(
transformType === "python"
- ? "data-studio/transforms/python-transforms#incremental-python-transforms"
- : "data-studio/transforms/query-transforms#incremental-query-transforms",
+ ? "data-modeling/transforms/python"
+ : "data-modeling/transforms/query",
+ {
+ anchor:
+ transformType === "python"
+ ? "incremental-python-transforms"
+ : "incremental-query-transforms",
+ },
);
const renderIncrementalSwitch = () => {
diff --git a/frontend/src/metabase/transforms/components/IncrementalTransform/IncrementalTransformSettings.unit.spec.tsx b/frontend/src/metabase/transforms/components/IncrementalTransform/IncrementalTransformSettings.unit.spec.tsx
index 7d63635eac8..d0470c08e46 100644
--- a/frontend/src/metabase/transforms/components/IncrementalTransform/IncrementalTransformSettings.unit.spec.tsx
+++ b/frontend/src/metabase/transforms/components/IncrementalTransform/IncrementalTransformSettings.unit.spec.tsx
@@ -118,4 +118,26 @@ describe("IncrementalTransformSettings", () => {
setup({ incremental: false });
expect(screen.queryByText("Merge key")).not.toBeInTheDocument();
});
+
+ it("links to the incremental section of the query transforms docs", () => {
+ setup();
+
+ expect(screen.getByRole("link", { name: "Learn more." })).toHaveAttribute(
+ "href",
+ expect.stringContaining(
+ "data-modeling/transforms/query.html#incremental-query-transforms",
+ ),
+ );
+ });
+
+ it("links to the incremental section of the Python transforms docs", () => {
+ setup({ hookOverrides: { transformType: "python" } });
+
+ expect(screen.getByRole("link", { name: "Learn more." })).toHaveAttribute(
+ "href",
+ expect.stringContaining(
+ "data-modeling/transforms/python.html#incremental-python-transforms",
+ ),
+ );
+ });
});