The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Add snowplow events when creating new job (#70279)
Andersonf2164af918d4
diff --git a/e2e/test/scenarios/data-studio/transforms/transforms.cy.spec.ts b/e2e/test/scenarios/data-studio/transforms/transforms.cy.spec.tsindex 453c2cd0b0e..7016d2c8c66 100644--- a/e2e/test/scenarios/data-studio/transforms/transforms.cy.spec.ts+++ b/e2e/test/scenarios/data-studio/transforms/transforms.cy.spec.ts@@ -2740,6 +2740,7 @@ describe("scenarios > admin > transforms > jobs", () => {beforeEach(() => {H.restore("postgres-writable");H.resetTestTable({ type: "postgres", table: "many_schemas" });+ H.resetSnowplow();cy.signInAsAdmin();H.activateToken("bleeding-edge");H.resyncDatabase({ dbId: WRITABLE_DB_ID, tableName: SOURCE_TABLE });@@ -2756,6 +2757,14 @@ describe("scenarios > admin > transforms > jobs", () => {H.DataStudio.Jobs.editor().button("Save").click();cy.wait("@createJob");++ cy.log("verify transform_job_created event was tracked");+ H.expectUnstructuredSnowplowEvent({+ event: "transform_job_created",+ triggered_from: "transform_job_new",+ result: "success",+ });+H.undoToast().findByText("New job created").should("be.visible");H.DataStudio.Jobs.editor().within(() => {@@ -2781,6 +2790,14 @@ describe("scenarios > admin > transforms > jobs", () => {H.popover().findByText("daily").click();H.DataStudio.Jobs.editor().button("Save").click();cy.wait("@createJob");++ cy.log("verify transform_job_created event was tracked");+ H.expectUnstructuredSnowplowEvent({+ event: "transform_job_created",+ triggered_from: "transform_job_new",+ result: "success",+ });+H.undoToast().findByText("New job created").should("be.visible");H.DataStudio.Jobs.editor().within(() => {diff --git a/frontend/src/metabase-types/analytics/event.ts b/frontend/src/metabase-types/analytics/event.tsindex d7fd2cbf4d8..29b9e46462b 100644--- a/frontend/src/metabase-types/analytics/event.ts+++ b/frontend/src/metabase-types/analytics/event.ts@@ -309,6 +309,13 @@ export type TransformRunTagsUpdated = ValidateEvent<{target_id: number;}>;+export type TransformJobCreatedEvent = ValidateEvent<{+ event: "transform_job_created";+ triggered_from: "transform_job_new";+ result: "success" | "failure";+ target_id: number | null;+}>;+export type TransformInspectLensLoadedEvent = ValidateEvent<{event: "transform_inspect_lens_loaded";target_id: TransformId;@@ -764,6 +771,7 @@ export type SimpleEvent =| TransformCreatedEvent| TransformCreateEvent| TransformRunTagsUpdated+ | TransformJobCreatedEvent| TransformInspectEvent| DocumentAddCardEvent| DocumentAddSmartLinkEventdiff --git a/frontend/src/metabase/transforms/analytics.ts b/frontend/src/metabase/transforms/analytics.tsindex 86843c604c6..a78f5a30979 100644--- a/frontend/src/metabase/transforms/analytics.ts+++ b/frontend/src/metabase/transforms/analytics.ts@@ -73,6 +73,21 @@ export function trackTransformRunTagsUpdated({});}+export function trackTransformJobCreated({+ result,+ jobId,+}: {+ result: "success" | "failure";+ jobId?: TransformJobId;+}) {+ trackSimpleEvent({+ event: "transform_job_created",+ triggered_from: "transform_job_new",+ result,+ target_id: jobId ?? null,+ });+}+export function trackTransformInspectLensLoaded({transformId,lensKey,diff --git a/frontend/src/metabase/transforms/pages/NewJobPage/NewJobPage.tsx b/frontend/src/metabase/transforms/pages/NewJobPage/NewJobPage.tsxindex 2e6beac05c6..fe0a0d7b61a 100644--- a/frontend/src/metabase/transforms/pages/NewJobPage/NewJobPage.tsx+++ b/frontend/src/metabase/transforms/pages/NewJobPage/NewJobPage.tsx@@ -15,6 +15,7 @@ import * as Urls from "metabase/lib/urls";import { useMetadataToasts } from "metabase/metadata/hooks";import type { ScheduleDisplayType, TransformTagId } from "metabase-types/api";+import { trackTransformJobCreated } from "../../analytics";import { JobEditor, type TransformJobInfo } from "../../components/JobEditor";type NewJobPageProps = {@@ -51,8 +52,10 @@ export function NewJobPage({ route }: NewJobPageProps) {const { data: newJob, error } = await createJob(job);if (error) {+ trackTransformJobCreated({ result: "failure" });sendErrorToast(t`Failed to create a job`);} else if (newJob != null) {+ trackTransformJobCreated({ result: "success", jobId: newJob.id });// prefetch the job to avoid the loader on the job details pageawait fetchJob(newJob.id);sendSuccessToast(t`New job created`);