Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Uxw 3547 add analytics events for metrics viewer and metrics homepage (#72091)

Nick Fitzpatrickf31336e11331
diff --git a/e2e/test/scenarios/metrics/metric-page.cy.spec.ts b/e2e/test/scenarios/metrics/metric-page.cy.spec.ts
index 9ccce6f167c..159b06074b0 100644
--- a/e2e/test/scenarios/metrics/metric-page.cy.spec.ts
+++ b/e2e/test/scenarios/metrics/metric-page.cy.spec.ts
@@ -42,6 +42,12 @@ describe("scenarios > metrics > metric page", () => {
beforeEach(() => {
H.restore();
cy.signInAsAdmin();
+ H.resetSnowplow();
+ H.enableTracking();
+ });
+
+ afterEach(() => {
+ H.expectNoBadSnowplowEvents();
});
it("should display scalar metric, edit name and description, explore link, and more menu actions", () => {
@@ -208,7 +214,13 @@ describe("scenarios > metrics > metric page", () => {
cy.findAllByText(/^By /).should("have.length", 4);
cy.findByText("Show more").scrollIntoView().click();
+ });
+ H.expectUnstructuredSnowplowEvent({
+ event: "metric_page_show_more_clicked",
+ });
+
+ H.MetricPage.overviewPage().within(() => {
cy.findByText("By Name").should("exist");
cy.findByText("By Source").should("exist");
cy.findByText("By Title").should("exist");
diff --git a/e2e/test/scenarios/metrics/metrics-explorer.cy.spec.ts b/e2e/test/scenarios/metrics/metrics-explorer.cy.spec.ts
index 5e1881e5d8a..a863bdb70f6 100644
--- a/e2e/test/scenarios/metrics/metrics-explorer.cy.spec.ts
+++ b/e2e/test/scenarios/metrics/metrics-explorer.cy.spec.ts
@@ -122,6 +122,12 @@ describe("scenarios > metrics > explorer", () => {
beforeEach(() => {
H.restore(SNAPSHOT_NAME as any);
cy.signInAsAdmin();
+ H.resetSnowplow();
+ H.enableTracking();
+ });
+
+ afterEach(() => {
+ H.expectNoBadSnowplowEvents();
});
// ============================================================================
@@ -243,8 +249,15 @@ describe("scenarios > metrics > explorer", () => {
it("should add multiple metrics", () => {
H.MetricsViewer.goToViewer();
+
addMetric("Count of products");
cy.wait("@dataset");
+
+ H.expectUnstructuredSnowplowEvent({
+ event: "metrics_viewer_metric_added",
+ event_detail: "metric",
+ });
+
addMetric("Count of orders");
cy.wait("@dataset");
verifyMetricCount(2);
@@ -266,6 +279,11 @@ describe("scenarios > metrics > explorer", () => {
cy.log("Should allow me to add measures");
H.MetricsViewer.searchInput().clear();
addMetric("Test Measure");
+
+ H.expectUnstructuredSnowplowEvent({
+ event: "metrics_viewer_metric_added",
+ event_detail: "measure",
+ });
});
it("Should not show me metrics that live in collections I do not have permissions to see", () => {
@@ -407,6 +425,9 @@ describe("scenarios > metrics > explorer", () => {
H.MetricsViewer.assertVizType("Line");
switchToTab("State");
+ H.expectUnstructuredSnowplowEvent({
+ event: "metrics_viewer_dimension_tab_switched",
+ });
H.MetricsViewer.assertVizType("Map");
switchToTab("Category");
@@ -487,6 +508,10 @@ describe("scenarios > metrics > explorer", () => {
"Source",
]);
+ H.expectUnstructuredSnowplowEvent({
+ event: "metrics_viewer_dimension_tab_added",
+ });
+
cy.log("new tab should be selected and show correct viz type");
H.MetricsViewer.tablist()
.findByRole("tab", { name: "Source" })
@@ -552,6 +577,10 @@ describe("scenarios > metrics > explorer", () => {
"Category",
]);
+ H.expectUnstructuredSnowplowEvent({
+ event: "metrics_viewer_dimension_tab_removed",
+ });
+
cy.log("navigating back should undo changes");
cy.go("back");
@@ -652,15 +681,32 @@ describe("scenarios > metrics > explorer", () => {
.should("contain.text", "Gadget")
.should("contain.text", "Category");
+ H.expectUnstructuredSnowplowEvent({
+ event: "metrics_viewer_filter_added",
+ triggered_from: "metric_filter",
+ });
+
+ cy.log("edit the filter to change the selection");
+ H.MetricsViewer.getAllFilterPills().eq(0).click();
+ H.popover().findByText("Gizmo").click();
+ H.popover().findByRole("button", { name: "Update filter" }).click();
+
+ H.expectUnstructuredSnowplowEvent({
+ event: "metrics_viewer_filter_edited",
+ triggered_from: "metric_filter",
+ });
+
H.MetricsViewer.breakoutLegend()
.should("contain.text", "Doohickey")
- .should("contain.text", "Gadget");
+ .should("contain.text", "Gadget")
+ .should("contain.text", "Gizmo");
switchToTab("Category");
H.MetricsViewer.getMetricVisualization().should(
"contain.text",
"Doohickey",
);
+ H.MetricsViewer.getMetricVisualization().should("contain.text", "Gizmo");
cy.log("filter on a per tab level");
@@ -671,14 +717,26 @@ describe("scenarios > metrics > explorer", () => {
H.popover().findByText("Doohickey").click();
H.popover().findByRole("button", { name: "Add filter" }).click();
+ H.MetricsViewer.getMerticControls().findByRole("button", {
+ name: /is Doohickey/,
+ });
H.MetricsViewer.getMetricVisualization().should(
- "not.contain.text",
+ "contain.text",
"Doohickey",
);
+ H.MetricsViewer.getMetricVisualization().should(
+ "not.contain.text",
+ "Gizmo",
+ );
+
+ H.expectUnstructuredSnowplowEvent({
+ event: "metrics_viewer_filter_added",
+ triggered_from: "dimension_filter",
+ });
cy.log("remove filter");
switchToTab("State");
- H.MetricsViewer.getAllMetricVisualizations().should("have.length", 2);
+ H.MetricsViewer.getAllMetricVisualizations().should("have.length", 3);
H.MetricsViewer.getAllFilterPills()
.should("have.length", 1)
@@ -686,38 +744,67 @@ describe("scenarios > metrics > explorer", () => {
.findByRole("button", { name: "Remove" })
.click();
H.MetricsViewer.getAllMetricVisualizations().should("have.length", 4);
+ H.MetricsViewer.getAllFilterPills().should("have.length", 0);
+
+ H.expectUnstructuredSnowplowEvent({
+ event: "metrics_viewer_filter_removed",
+ triggered_from: "metric_filter",
+ });
cy.log("navigating back should undo changes");
+
+ // re-apply global filter
cy.go("back");
- H.MetricsViewer.getAllMetricVisualizations().should("have.length", 2);
+
+ H.MetricsViewer.getAllMetricVisualizations().should("have.length", 3);
+ H.MetricsViewer.getAllFilterPills().should("have.length", 1);
+
+ // switch back to category tab
cy.go("back");
H.MetricsViewer.getTab("Category").should(
"have.attr",
"aria-selected",
"true",
);
+
+ // Remove tab filter
cy.go("back");
H.MetricsViewer.getMetricVisualization().should(
"contain.text",
"Doohickey",
);
+ H.MetricsViewer.getMetricVisualization().should("contain.text", "Gizmo");
+ H.MetricsViewer.getMerticControls()
+ .findByRole("button", { name: /All values/ })
+ .should("exist");
cy.log("navigating forward should re-apply changes");
+ // re-apply tab filter
cy.go("forward");
+ H.MetricsViewer.getMerticControls()
+ .findByRole("button", { name: /is Doohickey/ })
+ .should("exist");
H.MetricsViewer.getMetricVisualization().should(
- "not.contain.text",
+ "contain.text",
"Doohickey",
);
+ H.MetricsViewer.getMetricVisualization().should(
+ "not.contain.text",
+ "Gizmo",
+ );
+ // change tab back to state
cy.go("forward");
H.MetricsViewer.getTab("State").should(
"have.attr",
"aria-selected",
"true",
);
- H.MetricsViewer.getAllMetricVisualizations().should("have.length", 2);
+ H.MetricsViewer.getAllMetricVisualizations().should("have.length", 3);
+ // remove global filter
cy.go("forward");
H.MetricsViewer.getAllMetricVisualizations().should("have.length", 4);
+ H.MetricsViewer.getAllFilterPills().should("have.length", 0);
});
it("Should allow me to apply filters to each metric individually", () => {
@@ -790,14 +877,35 @@ describe("scenarios > metrics > explorer", () => {
10,
);
+ cy.log("edit the dimension filter to change the date range");
H.MetricsViewer.getMerticControls()
.findByRole("button", { name: /February/i })
.click();
+ H.popover().within(() => {
+ cy.findByRole("textbox", { name: "Start date" })
+ .clear()
+ .type("January 1, 2024");
+ cy.button("Update filter").click();
+ });
+
+ H.expectUnstructuredSnowplowEvent({
+ event: "metrics_viewer_filter_edited",
+ triggered_from: "dimension_filter",
+ });
+
+ H.MetricsViewer.getMerticControls()
+ .findByRole("button", { name: /January/i })
+ .click();
H.popover().findByRole("button", { name: "Clear" }).click();
H.MetricsViewer.getMetricVisualizationDataPoints().should(
"have.length",
85,
);
+
+ H.expectUnstructuredSnowplowEvent({
+ event: "metrics_viewer_filter_removed",
+ triggered_from: "dimension_filter",
+ });
});
});
diff --git a/frontend/src/metabase-types/analytics/event.ts b/frontend/src/metabase-types/analytics/event.ts
index 29b9e46462b..5666ab1ea98 100644
--- a/frontend/src/metabase-types/analytics/event.ts
+++ b/frontend/src/metabase-types/analytics/event.ts
@@ -733,6 +733,60 @@ export type UnsavedChangesWarningDisplayedEvent = ValidateEvent<{
target_id: number | null;
}>;
+export type MetricPageShowMoreClickedEvent = ValidateEvent<{
+ event: "metric_page_show_more_clicked";
+ target_id: number;
+}>;
+
+export type MetricsViewerMetricAddedEvent = ValidateEvent<{
+ event: "metrics_viewer_metric_added";
+ target_id: number | null;
+ event_detail: "metric" | "measure";
+}>;
+
+export type MetricsViewerMetricRemovedEvent = ValidateEvent<{
+ event: "metrics_viewer_metric_removed";
+ target_id: number | null;
+ event_detail: "metric" | "measure";
+}>;
+
+export type MetricsViewerFilterAddedEvent = ValidateEvent<{
+ event: "metrics_viewer_filter_added";
+ triggered_from: "metric_filter" | "dimension_filter";
+}>;
+
+export type MetricsViewerFilterEditedEvent = ValidateEvent<{
+ event: "metrics_viewer_filter_edited";
+ triggered_from: "metric_filter" | "dimension_filter";
+}>;
+
+export type MetricsViewerFilterRemovedEvent = ValidateEvent<{
+ event: "metrics_viewer_filter_removed";
+ triggered_from: "metric_filter" | "dimension_filter";
+}>;
+
+export type MetricsViewerDimensionTabAddedEvent = ValidateEvent<{
+ event: "metrics_viewer_dimension_tab_added";
+}>;
+
+export type MetricsViewerDimensionTabSwitchedEvent = ValidateEvent<{
+ event: "metrics_viewer_dimension_tab_switched";
+}>;
+
+export type MetricsViewerDimensionTabRemovedEvent = ValidateEvent<{
+ event: "metrics_viewer_dimension_tab_removed";
+}>;
+
+export type MetricsViewerEvent =
+ | MetricsViewerMetricAddedEvent
+ | MetricsViewerMetricRemovedEvent
+ | MetricsViewerFilterAddedEvent
+ | MetricsViewerFilterEditedEvent
+ | MetricsViewerFilterRemovedEvent
+ | MetricsViewerDimensionTabAddedEvent
+ | MetricsViewerDimensionTabSwitchedEvent
+ | MetricsViewerDimensionTabRemovedEvent;
+
export type SimpleEvent =
| CustomSMTPSetupClickedEvent
| CustomSMTPSetupSuccessEvent
@@ -792,4 +846,6 @@ export type SimpleEvent =
| RemoteSyncEvent
| ClickActionPerformedEvent
| DataStudioEvent
- | UnsavedChangesWarningDisplayedEvent;
+ | UnsavedChangesWarningDisplayedEvent
+ | MetricPageShowMoreClickedEvent
+ | MetricsViewerEvent;
diff --git a/frontend/src/metabase/browse/metrics/analytics.ts b/frontend/src/metabase/browse/metrics/analytics.ts
index e6278a71f4e..2815f42ca83 100644
--- a/frontend/src/metabase/browse/metrics/analytics.ts
+++ b/frontend/src/metabase/browse/metrics/analytics.ts
@@ -13,3 +13,10 @@ export const trackMetricBookmarked = () => {
triggered_from: "browse_metrics",
});
};
+
+export const trackMetricPageShowMoreClicked = (metricId: number) => {
+ trackSimpleEvent({
+ event: "metric_page_show_more_clicked",
+ target_id: metricId,
+ });
+};
diff --git a/frontend/src/metabase/metrics-viewer/analytics.ts b/frontend/src/metabase/metrics-viewer/analytics.ts
new file mode 100644
index 00000000000..e61a8e60200
--- /dev/null
+++ b/frontend/src/metabase/metrics-viewer/analytics.ts
@@ -0,0 +1,66 @@
+import { trackSimpleEvent } from "metabase/lib/analytics";
+
+export const trackMetricsViewerMetricAdded = (
+ targetId: number | null,
+ eventDetail: "metric" | "measure",
+) => {
+ trackSimpleEvent({
+ event: "metrics_viewer_metric_added",
+ target_id: targetId,
+ event_detail: eventDetail,
+ });
+};
+
+export const trackMetricsViewerMetricRemoved = (
+ targetId: number | null,
+ eventDetail: "metric" | "measure",
+) => {
+ trackSimpleEvent({
+ event: "metrics_viewer_metric_removed",
+ target_id: targetId,
+ event_detail: eventDetail,
+ });
+};
+
+type FilterSource = "metric_filter" | "dimension_filter";
+
+export const trackMetricsViewerFilterAdded = (triggeredFrom: FilterSource) => {
+ trackSimpleEvent({
+ event: "metrics_viewer_filter_added",
+ triggered_from: triggeredFrom,
+ });
+};
+
+export const trackMetricsViewerFilterEdited = (triggeredFrom: FilterSource) => {
+ trackSimpleEvent({
+ event: "metrics_viewer_filter_edited",
+ triggered_from: triggeredFrom,
+ });
+};
+
+export const trackMetricsViewerFilterRemoved = (
+ triggeredFrom: FilterSource,
+) => {
+ trackSimpleEvent({
+ event: "metrics_viewer_filter_removed",
+ triggered_from: triggeredFrom,
+ });
+};
+
+export const trackMetricsViewerDimensionTabAdded = () => {
+ trackSimpleEvent({
+ event: "metrics_viewer_dimension_tab_added",
+ });
+};
+
+export const trackMetricsViewerDimensionTabSwitched = () => {
+ trackSimpleEvent({
+ event: "metrics_viewer_dimension_tab_switched",
+ });
+};
+
+export const trackMetricsViewerDimensionTabRemoved = () => {
+ trackSimpleEvent({
+ event: "metrics_viewer_dimension_tab_removed",
+ });
+};
diff --git a/frontend/src/metabase/metrics-viewer/components/FilterPopover/FilterPopover.tsx b/frontend/src/metabase/metrics-viewer/components/FilterPopover/FilterPopover.tsx
index 4d2f9d58c54..1ca37517c3a 100644
--- a/frontend/src/metabase/metrics-viewer/components/FilterPopover/FilterPopover.tsx
+++ b/frontend/src/metabase/metrics-viewer/components/FilterPopover/FilterPopover.tsx
@@ -4,6 +4,7 @@ import { Box, Popover } from "metabase/ui";
import type { FilterClause, MetricDefinition } from "metabase-lib/metric";
import * as LibMetric from "metabase-lib/metric";
+import { trackMetricsViewerFilterAdded } from "../../analytics";
import type { MetricSourceId, SourceColorMap } from "../../types/viewer-state";
import S from "./FilterPopover.module.css";
@@ -41,6 +42,7 @@ export function FilterPopover({
}
const newDefinition = LibMetric.filter(source.definition, filter);
onUpdateDefinition(sourceId, newDefinition);
+ trackMetricsViewerFilterAdded("metric_filter");
setIsOpen(false);
setContentKey((key) => key + 1);
},
diff --git a/frontend/src/metabase/metrics-viewer/components/MetricControls/DimensionFilterButton/DimensionFilterButton.tsx b/frontend/src/metabase/metrics-viewer/components/MetricControls/DimensionFilterButton/DimensionFilterButton.tsx
index 01c6e063d66..485432546e1 100644
--- a/frontend/src/metabase/metrics-viewer/components/MetricControls/DimensionFilterButton/DimensionFilterButton.tsx
+++ b/frontend/src/metabase/metrics-viewer/components/MetricControls/DimensionFilterButton/DimensionFilterButton.tsx
@@ -2,6 +2,11 @@ import { useCallback, useMemo, useState } from "react";
import { t } from "ttag";
import { FilterPickerBody } from "metabase/metrics/components/FilterPicker/FilterPickerBody";
+import {
+ trackMetricsViewerFilterAdded,
+ trackMetricsViewerFilterEdited,
+ trackMetricsViewerFilterRemoved,
+} from "metabase/metrics-viewer/analytics";
import { Button, Icon, Popover } from "metabase/ui";
import type {
DimensionMetadata,
@@ -59,14 +64,20 @@ export function DimensionFilterButton({
const parsed = parseFilter(definition, filterClause);
if (parsed) {
onChange(parsed.value);
+ if (dimensionFilter) {
+ trackMetricsViewerFilterEdited("dimension_filter");
+ } else {
+ trackMetricsViewerFilterAdded("dimension_filter");
+ }
}
setIsOpen(false);
},
- [definition, onChange],
+ [definition, onChange, dimensionFilter],
);
const handleClear = useCallback(() => {
onChange(undefined);
+ trackMetricsViewerFilterRemoved("dimension_filter");
setIsOpen(false);
}, [onChange]);
diff --git a/frontend/src/metabase/metrics-viewer/components/MetricsFilterPills/MetricsFilterPillPopover.tsx b/frontend/src/metabase/metrics-viewer/components/MetricsFilterPills/MetricsFilterPillPopover.tsx
index c6d3ffd2f62..1d56b7771b3 100644
--- a/frontend/src/metabase/metrics-viewer/components/MetricsFilterPills/MetricsFilterPillPopover.tsx
+++ b/frontend/src/metabase/metrics-viewer/components/MetricsFilterPills/MetricsFilterPillPopover.tsx
@@ -1,6 +1,10 @@
import { useState } from "react";
import { FilterPickerBody } from "metabase/metrics/components/FilterPicker/FilterPickerBody";
+import {
+ trackMetricsViewerFilterEdited,
+ trackMetricsViewerFilterRemoved,
+} from "metabase/metrics-viewer/analytics";
import type { IconName } from "metabase/ui";
import { Popover, Text } from "metabase/ui";
import * as LibMetric from "metabase-lib/metric";
@@ -34,11 +38,13 @@ export function MetricsFilterPillPopover({
const handleSelect = (newFilter: LibMetric.FilterClause) => {
onUpdate(newFilter);
+ trackMetricsViewerFilterEdited("metric_filter");
setIsOpened(false);
};
const handleRemove = () => {
onRemove();
+ trackMetricsViewerFilterRemoved("metric_filter");
setIsOpened(false);
};
diff --git a/frontend/src/metabase/metrics-viewer/components/MetricsViewerTabs/AddDimensionPopover/AddDimensionPopover.tsx b/frontend/src/metabase/metrics-viewer/components/MetricsViewerTabs/AddDimensionPopover/AddDimensionPopover.tsx
index 1e1d0000eb4..75e26b96ad8 100644
--- a/frontend/src/metabase/metrics-viewer/components/MetricsViewerTabs/AddDimensionPopover/AddDimensionPopover.tsx
+++ b/frontend/src/metabase/metrics-viewer/components/MetricsViewerTabs/AddDimensionPopover/AddDimensionPopover.tsx
@@ -2,6 +2,7 @@ import { useCallback, useMemo, useState } from "react";
import { t } from "ttag";
import { AccordionList } from "metabase/common/components/AccordionList";
+import { trackMetricsViewerDimensionTabAdded } from "metabase/metrics-viewer/analytics";
import type { TabInfo } from "metabase/metrics-viewer/utils/tabs";
import { ActionIcon, Icon, Popover } from "metabase/ui";
@@ -46,6 +47,7 @@ export function AddDimensionPopover({
const handleSelect = useCallback(
(item: DimensionPickerItem) => {
onAddTab(item.tabInfo);
+ trackMetricsViewerDimensionTabAdded();
setIsOpen(false);
},
[onAddTab],
diff --git a/frontend/src/metabase/metrics-viewer/components/MetricsViewerTabs/MetricsViewerTabs.tsx b/frontend/src/metabase/metrics-viewer/components/MetricsViewerTabs/MetricsViewerTabs.tsx
index 7e3e45b7bdc..dbfcef078fc 100644
--- a/frontend/src/metabase/metrics-viewer/components/MetricsViewerTabs/MetricsViewerTabs.tsx
+++ b/frontend/src/metabase/metrics-viewer/components/MetricsViewerTabs/MetricsViewerTabs.tsx
@@ -1,6 +1,10 @@
import { useCallback } from "react";
import { t } from "ttag";
+import {
+ trackMetricsViewerDimensionTabRemoved,
+ trackMetricsViewerDimensionTabSwitched,
+} from "metabase/metrics-viewer/analytics";
import type { TabInfo } from "metabase/metrics-viewer/utils/tabs";
import { ActionIcon, Icon, Skeleton, Tabs } from "metabase/ui";
@@ -43,10 +47,19 @@ export function MetricsViewerTabs({
(e: React.MouseEvent, tabId: string) => {
e.stopPropagation();
onRemoveTab(tabId);
+ trackMetricsViewerDimensionTabRemoved();
},
[onRemoveTab],
);
+ const handleTabChange = useCallback(
+ (value: string) => {
+ onTabChange(value);
+ trackMetricsViewerDimensionTabSwitched();
+ },
+ [onTabChange],
+ );
+
const hasSharedDimensions = availableDimensions.shared.length > 0;
const hasAnySourceDimensions = sourceOrder.some(
(sourceId) => (availableDimensions.bySource[sourceId]?.length ?? 0) > 0,
@@ -61,7 +74,7 @@ export function MetricsViewerTabs({
return (
<Tabs
value={activeTabId}
- onChange={(value) => value && onTabChange(value)}
+ onChange={(value) => value && handleTabChange(value)}
w="auto"
>
<Tabs.List className={S.list} justify="flex-start">
diff --git a/frontend/src/metabase/metrics-viewer/pages/MetricsViewerPage/MetricsViewerPage.tsx b/frontend/src/metabase/metrics-viewer/pages/MetricsViewerPage/MetricsViewerPage.tsx
index 4dc87a601c2..513f5cee182 100644
--- a/frontend/src/metabase/metrics-viewer/pages/MetricsViewerPage/MetricsViewerPage.tsx
+++ b/frontend/src/metabase/metrics-viewer/pages/MetricsViewerPage/MetricsViewerPage.tsx
@@ -1,7 +1,12 @@
import type { Location } from "history";
+import { useCallback } from "react";
import { Box, Flex, Stack } from "metabase/ui";
+import {
+ trackMetricsViewerMetricAdded,
+ trackMetricsViewerMetricRemoved,
+} from "../../analytics";
import { BreakoutLegend } from "../../components/BreakoutLegend/BreakoutLegend";
import {
MetricsViewerEmptyState,
@@ -13,6 +18,7 @@ import {
MetricsViewerTabs,
} from "../../components/MetricsViewerTabs";
import { useMetricsViewer } from "../../hooks/use-metrics-viewer";
+import type { SelectedMetric } from "../../types/viewer-state";
import S from "./MetricsViewerPage.module.css";
@@ -49,6 +55,22 @@ export function MetricsViewerPage(props: MetricsViewerPageProps) {
setBreakoutDimension,
} = useMetricsViewer(props);
+ const handleAddMetric = useCallback(
+ (metric: SelectedMetric) => {
+ addMetric(metric);
+ trackMetricsViewerMetricAdded(metric.id, metric.sourceType);
+ },
+ [addMetric],
+ );
+
+ const handleRemoveMetric = useCallback(
+ (metricId: number, sourceType: "metric" | "measure") => {
+ removeMetric(metricId, sourceType);
+ trackMetricsViewerMetricRemoved(metricId, sourceType);
+ },
+ [removeMetric],
+ );
+
const hasDefinitions = definitions.length > 0;
const hasLoadedDefinitions = definitions.some(
(entry) => entry.definition != null,
@@ -61,8 +83,8 @@ export function MetricsViewerPage(props: MetricsViewerPageProps) {
selectedMetrics={selectedMetrics}
metricColors={sourceColors}
definitions={definitions}
- onAddMetric={addMetric}
- onRemoveMetric={removeMetric}
+ onAddMetric={handleAddMetric}
+ onRemoveMetric={handleRemoveMetric}
onSwapMetric={swapMetric}
onSetBreakout={setBreakoutDimension}
onUpdateDefinition={updateDefinition}
diff --git a/frontend/src/metabase/metrics/components/MetricDimensionGrid/MetricDimensionGrid.tsx b/frontend/src/metabase/metrics/components/MetricDimensionGrid/MetricDimensionGrid.tsx
index 890cad2df77..3225feef827 100644
--- a/frontend/src/metabase/metrics/components/MetricDimensionGrid/MetricDimensionGrid.tsx
+++ b/frontend/src/metabase/metrics/components/MetricDimensionGrid/MetricDimensionGrid.tsx
@@ -3,6 +3,7 @@ import { push } from "react-router-redux";
import { t } from "ttag";
import _ from "underscore";
+import { trackMetricPageShowMoreClicked } from "metabase/browse/metrics/analytics";
import { useDispatch } from "metabase/lib/redux";
import * as Urls from "metabase/lib/urls";
import { useMetricDimensionQuery } from "metabase/metrics/common/hooks";
@@ -76,7 +77,10 @@ export function MetricDimensionGrid({ metricId }: MetricDimensionGridProps) {
<Button
fullWidth
leftSection={<Icon name="chevrondown" />}
- onClick={showMore}
+ onClick={() => {
+ trackMetricPageShowMoreClicked(metricId);
+ showMore();
+ }}
>
{t`Show more`}
</Button>