The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Fixed no-literal-metabase-strings eslint rule for `export * from './MetabaseThing';` (#68411)
Sébastienf8551c980042
diff --git a/enterprise/frontend/src/embedding-sdk-package/components/public/MetabaseProvider/index.ts b/enterprise/frontend/src/embedding-sdk-package/components/public/MetabaseProvider/index.tsindex b31579b09e5..3367058d6b7 100644--- a/enterprise/frontend/src/embedding-sdk-package/components/public/MetabaseProvider/index.ts+++ b/enterprise/frontend/src/embedding-sdk-package/components/public/MetabaseProvider/index.ts@@ -1,2 +1 @@-// eslint-disable-next-line no-literal-metabase-strings -- Exportexport * from "./MetabaseProvider";diff --git a/frontend/lint/eslint-rules/no-literal-metabase-strings.js b/frontend/lint/eslint-rules/no-literal-metabase-strings.jsindex b99de7279e2..84713cd3bc7 100644--- a/frontend/lint/eslint-rules/no-literal-metabase-strings.js+++ b/frontend/lint/eslint-rules/no-literal-metabase-strings.js@@ -27,9 +27,11 @@ module.exports = {Literal(node) {if (typeof node.value !== "string" ||- ["ExportNamedDeclaration", "ImportDeclaration"].includes(- node.parent.type,- )+ [+ "ExportNamedDeclaration",+ "ImportDeclaration",+ "ExportAllDeclaration",+ ].includes(node.parent.type)) {return;}diff --git a/frontend/lint/tests/no-literal-metabase-strings.unit.spec.js b/frontend/lint/tests/no-literal-metabase-strings.unit.spec.jsindex 6a279c46fa6..4f8bac7a13f 100644--- a/frontend/lint/tests/no-literal-metabase-strings.unit.spec.js+++ b/frontend/lint/tests/no-literal-metabase-strings.unit.spec.js@@ -20,6 +20,11 @@ import OpenInMetabase from "../components/OpenInMetabase";`,// "Metabase in reexports"code: `export { MetabaseLinksToggleWidget } from "./MetabaseLinksToggleWidget";`,+ },+ {+ // "Metabase in * reexports"+ code: `+export * from "./MetabaseLinksToggleWidget";`,},{// "No Metabase string",diff --git a/frontend/src/metabase/embedding-sdk/theme/index.ts b/frontend/src/metabase/embedding-sdk/theme/index.tsindex 95b4670d24a..987f609a0ee 100644--- a/frontend/src/metabase/embedding-sdk/theme/index.ts+++ b/frontend/src/metabase/embedding-sdk/theme/index.ts@@ -1,5 +1,4 @@export * from "./default-component-theme";-// eslint-disable-next-line no-literal-metabase-strings -- file nameexport * from "./MetabaseTheme";export * from "./define-metabase-theme";