The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Do not show error when loading (#64082)
Romeo Van Snickf89073a6bd40
diff --git a/frontend/src/metabase/query_builder/components/VisualizationResult.jsx b/frontend/src/metabase/query_builder/components/VisualizationResult.jsxindex 0487ac49d54..92ffb671efe 100644--- a/frontend/src/metabase/query_builder/components/VisualizationResult.jsx+++ b/frontend/src/metabase/query_builder/components/VisualizationResult.jsx@@ -138,6 +138,7 @@ export default class VisualizationResult extends Component {isObjectDetail={false}isQueryBuilder={true}isShowingSummarySidebar={isShowingSummarySidebar}+ isRunning={isRunning}onEditSummary={onEditSummary}queryBuilderMode={queryBuilderMode}showTitle={false}diff --git a/frontend/src/metabase/visualizations/components/Visualization/Visualization.tsx b/frontend/src/metabase/visualizations/components/Visualization/Visualization.tsxindex eda66add437..88228d2a651 100644--- a/frontend/src/metabase/visualizations/components/Visualization/Visualization.tsx+++ b/frontend/src/metabase/visualizations/components/Visualization/Visualization.tsx@@ -141,6 +141,7 @@ type VisualizationOwnProps = {isDashboard?: boolean;isDocument?: boolean;isMobile?: boolean;+ isRunning?: boolean;isShowingSummarySidebar?: boolean;isSlow?: CardSlownessStatus;isVisible?: boolean;@@ -602,6 +603,7 @@ class Visualization extends PureComponent<isPreviewing,isRawTable,isQueryBuilder,+ isRunning,isSettings,isShowingDetailsOnlyColumns,isShowingSummarySidebar,@@ -795,7 +797,7 @@ class Visualization extends PureComponent<replacementContent) : isDashboard && noResults ? (<NoResultsView isSmall={small} />- ) : error ? (+ ) : error && !isRunning ? (<ErrorViewerror={errorMessageOverride ?? error}icon={errorIcon}diff --git a/frontend/src/metabase/visualizations/components/Visualization/Visualization.unit.spec.js b/frontend/src/metabase/visualizations/components/Visualization/Visualization.unit.spec.jsindex 77b463bf144..5a6ae07bf50 100644--- a/frontend/src/metabase/visualizations/components/Visualization/Visualization.unit.spec.js+++ b/frontend/src/metabase/visualizations/components/Visualization/Visualization.unit.spec.js@@ -247,4 +247,16 @@ describe("Visualization", () => {});});});++ it("should not show loader and error at the same time (metabase#63410)", async () => {+ await renderViz(undefined, {+ error: new Error("This is my error message"),+ isRunning: true,+ });++ expect(+ screen.queryByText("This is my error message"),+ ).not.toBeInTheDocument();+ expect(screen.getByTestId("loading-indicator")).toBeInTheDocument();+ });});