Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Keep bars with 100% height when hiding a segment in a 100% stacked chart (#66477)

Andersonf8d9445828c6
diff --git a/frontend/src/metabase/visualizations/echarts/cartesian/model/stack.ts b/frontend/src/metabase/visualizations/echarts/cartesian/model/stack.ts
index a0bfee863ac..78a8f873997 100644
--- a/frontend/src/metabase/visualizations/echarts/cartesian/model/stack.ts
+++ b/frontend/src/metabase/visualizations/echarts/cartesian/model/stack.ts
@@ -13,8 +13,12 @@ export const getStackModels = (
return [];
}
+ const visibleSeriesModels = seriesModels.filter(
+ (seriesModel) => seriesModel.visible,
+ );
+
const seriesModelsByDisplay = _.groupBy(
- seriesModels,
+ visibleSeriesModels,
(seriesModel) =>
settings.series(seriesModel.legacySeriesSettingsObjectKey).display,
);
diff --git a/frontend/src/metabase/visualizations/echarts/cartesian/model/stack.unit.spec.ts b/frontend/src/metabase/visualizations/echarts/cartesian/model/stack.unit.spec.ts
new file mode 100644
index 00000000000..3eccb0d3242
--- /dev/null
+++ b/frontend/src/metabase/visualizations/echarts/cartesian/model/stack.unit.spec.ts
@@ -0,0 +1,23 @@
+import { createMockSeriesModel } from "__support__/echarts";
+import type { ComputedVisualizationSettings } from "metabase/visualizations/types";
+
+import { getStackModels } from "./stack";
+
+describe("getStackModels", () => {
+ it("should exclude hidden series from stack models (#66149)", () => {
+ const seriesModels = [
+ createMockSeriesModel({ dataKey: "series1", visible: true }),
+ createMockSeriesModel({ dataKey: "series2", visible: false }),
+ createMockSeriesModel({ dataKey: "series3", visible: true }),
+ ];
+ const mockSettings: ComputedVisualizationSettings = {
+ "stackable.stack_type": "stacked",
+ series: () => ({ display: "bar" }),
+ };
+
+ const result = getStackModels(seriesModels, mockSettings);
+
+ expect(result).toHaveLength(1);
+ expect(result[0].seriesKeys).toEqual(["series1", "series3"]);
+ });
+});