The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Implement read-only on Library & Data Structure pages (#68209)
Andersonfa924880ad64
diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/CreateMenu.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/CreateMenu.tsxindex 7af4ffaa079..d31ed795452 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/CreateMenu.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/CreateMenu.tsx@@ -12,6 +12,7 @@ import {getUserIsAdmin,} from "metabase/selectors/user";import { Button, FixedSizeIcon, Icon, Menu } from "metabase/ui";+import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";import type { CollectionId } from "metabase-types/api";import { PublishTableModal } from "./PublishTableModal";@@ -30,6 +31,11 @@ export const CreateMenu = ({const isAdmin = useSelector(getUserIsAdmin);const hasNativeWrite = useSelector(canUserCreateNativeQueries);const hasDataAccess = useSelector(canUserCreateQueries);+ const remoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);++ if (remoteSyncReadOnly) {+ return null;+ }const canCreateMetric =hasDataAccess && metricCollectionId && canWriteToMetricCollection;diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/CreateMenu.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/CreateMenu.unit.spec.tsxindex d3deaeb954a..7bf67cc7037 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/CreateMenu.unit.spec.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/CreateMenu.unit.spec.tsx@@ -3,6 +3,7 @@ import userEvent from "@testing-library/user-event";import { setupEnterprisePlugins } from "__support__/enterprise";import { mockSettings } from "__support__/settings";import { renderWithProviders, screen } from "__support__/ui";+import type { EnterpriseSettings } from "metabase-types/api";import {createMockTokenFeatures,createMockUser,@@ -15,17 +16,29 @@ import { CreateMenu } from "./CreateMenu";interface SetupOptions {user?: Partial<User>;canWriteToMetricCollection?: boolean;+ remoteSyncType?: EnterpriseSettings["remote-sync-type"];}+const fullPermissionsUser: Partial<User> = {+ is_superuser: true,+ permissions: {+ can_create_queries: true,+ can_create_native_queries: true,+ },+};+const setup = ({user,canWriteToMetricCollection = true,+ remoteSyncType,}: SetupOptions = {}) => {const state = createMockState({settings: mockSettings({"token-features": createMockTokenFeatures({snippet_collections: true,}),+ "remote-sync-type": remoteSyncType,+ "remote-sync-enabled": !!remoteSyncType,}),currentUser: createMockUser(user),});@@ -79,15 +92,7 @@ describe("CreateMenu", () => {});it("renders all options when user has full permissions", async () => {- setup({- user: {- is_superuser: true,- permissions: {- can_create_queries: true,- can_create_native_queries: true,- },- },- });+ setup({ user: fullPermissionsUser });await userEvent.click(screen.getByRole("button", { name: /New/ }));@@ -100,4 +105,11 @@ describe("CreateMenu", () => {"New snippet folder",]);});++ it("renders nothing if remote sync is set to read-only", () => {+ setup({ user: fullPermissionsUser, remoteSyncType: "read-only" });+ expect(+ screen.queryByRole("button", { name: /New/ }),+ ).not.toBeInTheDocument();+ });});diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/RootSnippetsCollectionMenu.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/RootSnippetsCollectionMenu.tsxindex 99b9942bd14..3473c0d1af2 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/RootSnippetsCollectionMenu.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/RootSnippetsCollectionMenu.tsx@@ -3,6 +3,7 @@ import { t } from "ttag";import { useSelector } from "metabase/lib/redux";import { getUserIsAdmin } from "metabase/selectors/user";import { ActionIcon, FixedSizeIcon, Menu, Tooltip } from "metabase/ui";+import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";import type { CollectionId } from "metabase-types/api";export const RootSnippetsCollectionMenu = ({@@ -11,8 +12,9 @@ export const RootSnippetsCollectionMenu = ({setPermissionsCollectionId: (id: CollectionId) => void;}) => {const isAdmin = useSelector(getUserIsAdmin);+ const remoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);- if (!isAdmin) {+ if (!isAdmin || remoteSyncReadOnly) {return null;}diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/RootSnippetsCollectionMenu.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/RootSnippetsCollectionMenu.unit.spec.tsxnew file mode 100644index 00000000000..6b9d163098d--- /dev/null+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/RootSnippetsCollectionMenu.unit.spec.tsx@@ -0,0 +1,84 @@+import userEvent from "@testing-library/user-event";++import { mockSettings } from "__support__/settings";+import { renderWithProviders, screen } from "__support__/ui";+import type { EnterpriseSettings } from "metabase-types/api";+import { createMockUser } from "metabase-types/api/mocks";+import { createMockState } from "metabase-types/store/mocks/state";++import { RootSnippetsCollectionMenu } from "./RootSnippetsCollectionMenu";++interface SetupOptions {+ isSuperuser?: boolean;+ remoteSyncType?: EnterpriseSettings["remote-sync-type"];+}++const setPermissionsCollectionId = jest.fn();++const setup = ({ isSuperuser = true, remoteSyncType }: SetupOptions = {}) => {+ const state = createMockState({+ settings: mockSettings({+ "remote-sync-type": remoteSyncType,+ "remote-sync-enabled": !!remoteSyncType,+ }),+ currentUser: createMockUser({ is_superuser: isSuperuser }),+ });+ return renderWithProviders(+ <RootSnippetsCollectionMenu+ setPermissionsCollectionId={setPermissionsCollectionId}+ />,+ {+ storeInitialState: state,+ },+ );+};++describe("RootSnippetsCollectionMenu", () => {+ beforeEach(() => {+ jest.clearAllMocks();+ });++ it("renders snippets options menu", () => {+ setup();+ expect(+ screen.getByRole("button", { name: "Snippet collection options" }),+ ).toBeInTheDocument();+ });++ it("renders nothing if user is not a superuser", () => {+ setup({ isSuperuser: false });+ expect(+ screen.queryByRole("button", { name: "Snippet collection options" }),+ ).not.toBeInTheDocument();+ });++ it("renders nothing if remote sync is set to read-only", () => {+ setup({ remoteSyncType: "read-only" });+ expect(+ screen.queryByRole("button", { name: "Snippet collection options" }),+ ).not.toBeInTheDocument();+ });++ describe("show permissions options", () => {+ it("is rendered on menu click", async () => {+ setup();+ await userEvent.click(+ screen.getByRole("button", { name: "Snippet collection options" }),+ );+ expect(+ screen.getByRole("menuitem", { name: /Change permissions/ }),+ ).toBeInTheDocument();+ });++ it("calls setPermissionsCollectionId on click", async () => {+ setup();+ await userEvent.click(+ screen.getByRole("button", { name: "Snippet collection options" }),+ );+ await userEvent.click(+ screen.getByRole("menuitem", { name: /Change permissions/ }),+ );+ expect(setPermissionsCollectionId).toHaveBeenCalledWith("root");+ });+ });+});diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/MeasureList.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/MeasureList.tsxindex b9773c2e2af..e858bb8e38b 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/MeasureList.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/MeasureList.tsx@@ -2,8 +2,10 @@ import { t } from "ttag";import EmptyState from "metabase/common/components/EmptyState";import { ForwardRefLink } from "metabase/common/components/Link";+import { useSelector } from "metabase/lib/redux";import * as Urls from "metabase/lib/urls";import { Button, Group, Icon, Stack } from "metabase/ui";+import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";import type { Table } from "metabase-types/api";import { MeasureItem } from "./MeasureItem";@@ -21,24 +23,27 @@ export function MeasureList({ table }: MeasureListProps) {tableId: table.id,measureId,});+ const remoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);return (<Stack gap="md" data-testid="table-measures-page">- <Group gap="md" justify="flex-start" wrap="nowrap">- <Button- component={ForwardRefLink}- to={Urls.newDataStudioDataModelMeasure({- databaseId: table.db_id,- schemaName: table.schema,- tableId: table.id,- })}- h={32}- px="sm"- py="xs"- size="xs"- leftSection={<Icon name="add" />}- >{t`New measure`}</Button>- </Group>+ {!remoteSyncReadOnly && (+ <Group gap="md" justify="flex-start" wrap="nowrap">+ <Button+ component={ForwardRefLink}+ to={Urls.newDataStudioDataModelMeasure({+ databaseId: table.db_id,+ schemaName: table.schema,+ tableId: table.id,+ })}+ h={32}+ px="sm"+ py="xs"+ size="xs"+ leftSection={<Icon name="add" />}+ >{t`New measure`}</Button>+ </Group>+ )}{measures.length === 0 ? (<EmptyStatediff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/MeasureList.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/MeasureList.unit.spec.tsxindex 90c8a8dc525..7c7d50b497c 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/MeasureList.unit.spec.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/MeasureList.unit.spec.tsx@@ -1,7 +1,8 @@import { Route } from "react-router";+import { mockSettings } from "__support__/settings";import { renderWithProviders, screen } from "__support__/ui";-import type { Measure, Table } from "metabase-types/api";+import type { EnterpriseSettings, Measure, Table } from "metabase-types/api";import { createMockMeasure, createMockTable } from "metabase-types/api/mocks";import { MeasureList } from "./MeasureList";@@ -9,9 +10,10 @@ import { MeasureList } from "./MeasureList";type SetupOpts = {measures?: Measure[];table?: Partial<Table>;+ remoteSyncType?: EnterpriseSettings["remote-sync-type"];};-function setup({ measures = [], table = {} }: SetupOpts = {}) {+function setup({ measures = [], table = {}, remoteSyncType }: SetupOpts = {}) {const mockTable = createMockTable({id: 1,db_id: 1,@@ -22,7 +24,15 @@ function setup({ measures = [], table = {} }: SetupOpts = {}) {renderWithProviders(<Route path="/" component={() => <MeasureList table={mockTable} />} />,- { withRouter: true },+ {+ withRouter: true,+ storeInitialState: {+ settings: mockSettings({+ "remote-sync-type": remoteSyncType,+ "remote-sync-enabled": !!remoteSyncType,+ }),+ },+ },);}@@ -63,4 +73,18 @@ describe("MeasureList", () => {"/data-studio/data/database/1/schema/1:PUBLIC/table/1/measures/1",);});++ it("should render a 'New measure' button", () => {+ setup();+ expect(+ screen.getByRole("link", { name: /New measure/i }),+ ).toBeInTheDocument();+ });++ it("should not render 'New measure' button when remote sync is set to read-only", () => {+ setup({ remoteSyncType: "read-only" });+ expect(+ screen.queryByRole("link", { name: /New measure/i }),+ ).not.toBeInTheDocument();+ });});diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/SegmentList.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/SegmentList.tsxindex f12c5bbeafd..69c753a6486 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/SegmentList.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/SegmentList.tsx@@ -6,6 +6,7 @@ import { useSelector } from "metabase/lib/redux";import * as Urls from "metabase/lib/urls";import { getUserCanWriteSegments } from "metabase/selectors/user";import { Button, Group, Icon, Stack } from "metabase/ui";+import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";import type { Table } from "metabase-types/api";import { SegmentItem } from "./SegmentItem";@@ -24,10 +25,11 @@ export function SegmentList({ table }: SegmentListProps) {tableId: table.id,segmentId,});+ const remoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);return (<Stack gap="md" data-testid="table-segments-page">- {canCreateSegment && (+ {canCreateSegment && !remoteSyncReadOnly && (<Group gap="md" justify="flex-start" wrap="nowrap"><Buttoncomponent={ForwardRefLink}diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/SegmentList.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/SegmentList.unit.spec.tsxindex cb0b0d0c75d..a4ffafdcc61 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/SegmentList.unit.spec.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/SegmentList.unit.spec.tsx@@ -1,7 +1,8 @@import { Route } from "react-router";+import { mockSettings } from "__support__/settings";import { renderWithProviders, screen } from "__support__/ui";-import type { Segment, Table } from "metabase-types/api";+import type { EnterpriseSettings, Segment, Table } from "metabase-types/api";import {createMockSegment,createMockTable,@@ -14,9 +15,15 @@ type SetupOpts = {segments?: Segment[];table?: Partial<Table>;isAdmin?: boolean;+ remoteSyncType?: EnterpriseSettings["remote-sync-type"];};-function setup({ segments = [], table = {}, isAdmin = true }: SetupOpts = {}) {+function setup({+ segments = [],+ table = {},+ isAdmin = true,+ remoteSyncType,+}: SetupOpts = {}) {const mockTable = createMockTable({id: 1,db_id: 1,@@ -31,6 +38,10 @@ function setup({ segments = [], table = {}, isAdmin = true }: SetupOpts = {}) {withRouter: true,storeInitialState: {currentUser: createMockUser({ is_superuser: isAdmin }),+ settings: mockSettings({+ "remote-sync-type": remoteSyncType,+ "remote-sync-enabled": !!remoteSyncType,+ }),},},);@@ -58,6 +69,14 @@ describe("SegmentList", () => {).not.toBeInTheDocument();});+ it("should not render 'New segment' button when remote sync is set to read-only", () => {+ setup({ segments: [], isAdmin: true, remoteSyncType: "read-only" });++ expect(+ screen.queryByRole("link", { name: /New segment/i }),+ ).not.toBeInTheDocument();+ });+it("should render segment items", () => {const segments = [createMockSegment({diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableSection.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableSection.tsxindex 9021c3b36ae..7920f0fe1e5 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableSection.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableSection.tsx@@ -35,6 +35,7 @@ import {import { CreateLibraryModal } from "metabase-enterprise/data-studio/common/components/CreateLibraryModal";import { PublishTablesModal } from "metabase-enterprise/data-studio/common/components/PublishTablesModal";import { UnpublishTablesModal } from "metabase-enterprise/data-studio/common/components/UnpublishTablesModal";+import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";import type { FieldId, Table, TableFieldOrder } from "metabase-types/api";import { MeasureList } from "./MeasureList";@@ -72,6 +73,7 @@ const TableSectionBase = ({useMetadataToasts();const [isSorting, setIsSorting] = useState(false);const hasFields = Boolean(table.fields && table.fields.length > 0);+ const remoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);const getFieldHref = (fieldId: FieldId) => {return Urls.dataStudioData({@@ -215,7 +217,7 @@ const TableSectionBase = ({</Box><Group justify="stretch" gap="sm">- {isAdmin && (+ {isAdmin && !remoteSyncReadOnly && (<Buttonflex="1"p="sm"diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableSection.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableSection.unit.spec.tsxindex 96b4b86cff3..39aa979d04a 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableSection.unit.spec.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableSection.unit.spec.tsx@@ -4,9 +4,10 @@ import {setupUserKeyValueEndpoints,setupUsersEndpoints,} from "__support__/server-mocks";+import { mockSettings } from "__support__/settings";import { renderWithProviders, screen } from "__support__/ui";import type { DataStudioTableMetadataTab } from "metabase/lib/urls/data-studio";-import type { Segment, Table } from "metabase-types/api";+import type { EnterpriseSettings, Segment, Table } from "metabase-types/api";import {createMockSegment,createMockTable,@@ -23,6 +24,7 @@ type SetupOpts = {activeTab?: DataStudioTableMetadataTab;segments?: Segment[];isAdmin?: boolean;+ remoteSyncType?: EnterpriseSettings["remote-sync-type"];};function setup({@@ -30,10 +32,14 @@ function setup({activeTab = "field",segments,isAdmin = true,+ remoteSyncType,}: SetupOpts = {}) {const onSyncOptionsClick = jest.fn();-const tableWithSegments = segments ? { ...table, segments } : table;+ const settings = mockSettings({+ "remote-sync-type": remoteSyncType,+ "remote-sync-enabled": !!remoteSyncType,+ });setupUsersEndpoints([createMockUser()]);setupUserKeyValueEndpoints({@@ -58,6 +64,7 @@ function setup({withRouter: true,storeInitialState: {currentUser: createMockUser({ is_superuser: isAdmin }),+ settings,},},);@@ -89,6 +96,17 @@ describe("TableSection", () => {).not.toBeInTheDocument();});+ it("should not render publish button when remote sync is set to read-only", () => {+ setup({ remoteSyncType: "read-only" });++ expect(+ screen.queryByRole("button", { name: /Publish/i }),+ ).not.toBeInTheDocument();+ expect(+ screen.queryByRole("button", { name: /Unpublish/i }),+ ).not.toBeInTheDocument();+ });+describe("tabs", () => {it("should render Fields and Segments tabs", () => {setup({ activeTab: "field" });diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/measures/components/MeasureEditor/MeasureEditor.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/measures/components/MeasureEditor/MeasureEditor.tsxindex c373a58e093..73cfce32502 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/measures/components/MeasureEditor/MeasureEditor.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/measures/components/MeasureEditor/MeasureEditor.tsx@@ -11,6 +11,7 @@ type MeasureEditorProps = {description: string;onQueryChange: (query: Lib.Query) => void;onDescriptionChange: (description: string) => void;+ readOnly?: boolean;};export function MeasureEditor({@@ -18,12 +19,17 @@ export function MeasureEditor({description,onQueryChange,onDescriptionChange,+ readOnly,}: MeasureEditorProps) {return (<Card withBorder p="xl"><Stack flex={1} gap="xl" p={0} className={S.scrollable}>{query && (- <MeasureAggregationPicker query={query} onChange={onQueryChange} />+ <MeasureAggregationPicker+ onChange={onQueryChange}+ query={query}+ readOnly={readOnly}+ />)}<TextInputlabel={t`Give it a description`}@@ -34,6 +40,7 @@ export function MeasureEditor({classNames={{label: S.descriptionLabel,}}+ readOnly={readOnly}/></Stack></Card>diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/measures/components/MeasureEditor/MeasureEditor.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/measures/components/MeasureEditor/MeasureEditor.unit.spec.tsxnew file mode 100644index 00000000000..6fed72779e6--- /dev/null+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/measures/components/MeasureEditor/MeasureEditor.unit.spec.tsx@@ -0,0 +1,48 @@+import { renderWithProviders, screen } from "__support__/ui";+import { createQuery } from "metabase-lib/test-helpers";++import { MeasureEditor } from "./MeasureEditor";++describe("MeasureEditor", () => {+ const query = createQuery();+ const description = "A sample description";+ const onQueryChange = jest.fn();+ const onDescriptionChange = jest.fn();++ it("renders editable inputs when not read-only", () => {+ renderWithProviders(+ <MeasureEditor+ query={query}+ description={description}+ onQueryChange={onQueryChange}+ onDescriptionChange={onDescriptionChange}+ />,+ );++ expect(screen.getByLabelText("Give it a description")).not.toHaveAttribute(+ "readonly",+ );+ expect(+ screen.getByText("Pick an aggregation function"),+ ).toBeInTheDocument();+ });++ it("disables inputs when read-only", () => {+ renderWithProviders(+ <MeasureEditor+ query={query}+ description={description}+ onQueryChange={onQueryChange}+ onDescriptionChange={onDescriptionChange}+ readOnly+ />,+ );++ expect(screen.getByLabelText("Give it a description")).toHaveAttribute(+ "readonly",+ );+ expect(+ screen.queryByText("Pick an aggregation function"),+ ).not.toBeInTheDocument();+ });+});diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/measures/components/MeasureHeader/MeasureHeader.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/measures/components/MeasureHeader/MeasureHeader.tsxindex 62703eb08ef..f84fc204b86 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/measures/components/MeasureHeader/MeasureHeader.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/measures/components/MeasureHeader/MeasureHeader.tsx@@ -24,6 +24,7 @@ type MeasureHeaderProps = {onNameChange?: (name: string) => void;breadcrumbs?: ReactNode;actions?: ReactNode;+ readOnly?: boolean;};export function MeasureHeader({@@ -34,16 +35,26 @@ export function MeasureHeader({onNameChange,breadcrumbs,actions,+ readOnly,}: MeasureHeaderProps) {return (<Stack gap={0}><PaneHeaderdata-testid="measure-pane-header"title={- <MeasureNameInput measure={measure} onNameChange={onNameChange} />+ <MeasureNameInput+ measure={measure}+ onNameChange={onNameChange}+ readOnly={readOnly}+ />}icon="sum"- menu={<MeasureMoreMenu previewUrl={previewUrl} onRemove={onRemove} />}+ menu={+ <MeasureMoreMenu+ previewUrl={previewUrl}+ onRemove={readOnly ? undefined : onRemove}+ />+ }tabs={<EntityDetailTabs urls={tabUrls} />}actions={actions}breadcrumbs={breadcrumbs}@@ -55,9 +66,14 @@ export function MeasureHeader({type MeasureNameInputProps = {measure: Measure;onNameChange?: (name: string) => void;+ readOnly?: boolean;};-function MeasureNameInput({ measure, onNameChange }: MeasureNameInputProps) {+function MeasureNameInput({+ measure,+ onNameChange,+ readOnly,+}: MeasureNameInputProps) {const [updateMeasure] = useUpdateMeasureMutation();const { sendSuccessToast, sendErrorToast } = useMetadataToasts();@@ -88,6 +104,7 @@ function MeasureNameInput({ measure, onNameChange }: MeasureNameInputProps) {maxLength={MEASURE_NAME_MAX_LENGTH}onChange={handleChange}onContentChange={onNameChange}+ readOnly={readOnly}/>);}diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/measures/components/MeasureHeader/MeasureHeader.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/measures/components/MeasureHeader/MeasureHeader.unit.spec.tsxnew file mode 100644index 00000000000..cc649e994cc--- /dev/null+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/measures/components/MeasureHeader/MeasureHeader.unit.spec.tsx@@ -0,0 +1,72 @@+import userEvent from "@testing-library/user-event";++import { renderWithProviders, screen } from "__support__/ui";+import { createMockMeasure } from "metabase-types/api/mocks";++import { MeasureHeader } from "./MeasureHeader";++type SetupOpts = {+ readOnly?: boolean;+};++const setup = ({ readOnly }: SetupOpts = {}) => {+ const tabUrls = {+ definition: "/measures/1/definition",+ revisions: "/measures/1/revisions",+ dependencies: "/measures/1/dependencies",+ };+ const measure = createMockMeasure({ name: "Order count" });++ renderWithProviders(+ <MeasureHeader+ measure={measure}+ onRemove={jest.fn()}+ readOnly={readOnly}+ tabUrls={tabUrls}+ previewUrl="/measures/1/preview"+ />,+ );+};++describe("MeasureHeader", () => {+ it("renders an input with the measure name", () => {+ setup();+ expect(screen.getByPlaceholderText("New measure")).toBeEnabled();+ expect(screen.getByPlaceholderText("New measure")).toHaveValue(+ "Order count",+ );+ });++ it("shows preview and remove options in the actions menu", async () => {+ setup();+ await userEvent.click(+ screen.getByRole("button", { name: "Measure actions" }),+ );+ expect(+ screen.getByRole("menuitem", { name: /Preview/ }),+ ).toBeInTheDocument();+ expect(+ screen.getByRole("menuitem", { name: /Remove measure/ }),+ ).toBeInTheDocument();+ });++ describe("when read-only", () => {+ it("disables the name input", () => {+ setup({ readOnly: true });+ expect(screen.getByPlaceholderText("New measure")).toBeDisabled();+ });++ it("does not render the remove measure menu option", async () => {+ setup({ readOnly: true });+ await userEvent.click(+ screen.getByRole("button", { name: "Measure actions" }),+ );+ expect(+ screen.getByRole("menuitem", { name: /Preview/ }),+ ).toBeInTheDocument();+ expect(+ screen.queryByRole("menuitem", { name: /Remove measure/ }),+ ).not.toBeInTheDocument();+ });+ });+});diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/measures/pages/MeasureDetailPage/MeasureDetailPage.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/measures/pages/MeasureDetailPage/MeasureDetailPage.tsxindex 78178333dd6..65245fbe1e0 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/measures/pages/MeasureDetailPage/MeasureDetailPage.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/measures/pages/MeasureDetailPage/MeasureDetailPage.tsx@@ -11,6 +11,7 @@ import { getMetadata } from "metabase/selectors/metadata";import { Button, Group } from "metabase/ui";import { PageContainer } from "metabase-enterprise/data-studio/common/components/PageContainer";import { getDatasetQueryPreviewUrl } from "metabase-enterprise/data-studio/common/utils/get-dataset-query-preview-url";+import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";import * as Lib from "metabase-lib";import type { Measure } from "metabase-types/api";@@ -35,6 +36,7 @@ export function MeasureDetailPage({onRemove,}: MeasureDetailPageProps) {const metadata = useSelector(getMetadata);+ const remoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);const { sendSuccessToast, sendErrorToast } = useMetadataToasts();const [description, setDescription] = useState(measure.description ?? "");@@ -117,12 +119,14 @@ export function MeasureDetailPage({</Group>)}+ readOnly={remoteSyncReadOnly}/><MeasureEditorquery={query}description={description}onQueryChange={setQuery}onDescriptionChange={setDescription}+ readOnly={remoteSyncReadOnly}/><LeaveRouteConfirmModalkey={measure.id}diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/segments/pages/SegmentDetailPage/SegmentDetailPage.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/segments/pages/SegmentDetailPage/SegmentDetailPage.tsxindex 84fb8addac0..dfc1cbdbd4b 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/segments/pages/SegmentDetailPage/SegmentDetailPage.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/segments/pages/SegmentDetailPage/SegmentDetailPage.tsx@@ -12,6 +12,7 @@ import { getUserCanWriteSegments } from "metabase/selectors/user";import { Button, Group } from "metabase/ui";import { PageContainer } from "metabase-enterprise/data-studio/common/components/PageContainer";import { getDatasetQueryPreviewUrl } from "metabase-enterprise/data-studio/common/utils/get-dataset-query-preview-url";+import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";import * as Lib from "metabase-lib";import type { Segment } from "metabase-types/api";@@ -35,8 +36,9 @@ export function SegmentDetailPage({breadcrumbs,onRemove,}: SegmentDetailPageProps) {- const canEditSegments = useSelector(getUserCanWriteSegments);+ const canWriteSegments = useSelector(getUserCanWriteSegments);const metadata = useSelector(getMetadata);+ const remoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);const { sendSuccessToast, sendErrorToast } = useMetadataToasts();const [description, setDescription] = useState(segment.description ?? "");@@ -44,6 +46,7 @@ export function SegmentDetailPage({const [savedSegment, setSavedSegment] = useState(segment);const { query, filters } = useSegmentQuery(definition, metadata);+ const canEditSegments = canWriteSegments && !remoteSyncReadOnly;const isDirty = useMemo(() =>diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/segments/pages/SegmentDetailPage/SegmentDetailPage.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/segments/pages/SegmentDetailPage/SegmentDetailPage.unit.spec.tsxindex 23784f5e0bd..152db42c632 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/segments/pages/SegmentDetailPage/SegmentDetailPage.unit.spec.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/segments/pages/SegmentDetailPage/SegmentDetailPage.unit.spec.tsx@@ -6,10 +6,11 @@ import {setupSchemaEndpoints,setupSegmentEndpoint,} from "__support__/server-mocks";+import { mockSettings } from "__support__/settings";import { createMockEntitiesState } from "__support__/store";import { renderWithProviders, screen, waitFor } from "__support__/ui";import { checkNotNull } from "metabase/lib/types";-import type { Segment, Table } from "metabase-types/api";+import type { EnterpriseSettings, Segment, Table } from "metabase-types/api";import {createMockDatabase,createMockField,@@ -73,12 +74,14 @@ type SetupOpts = {segment?: Segment;table?: Table;isAdmin?: boolean;+ remoteSyncType?: EnterpriseSettings["remote-sync-type"];};function setup({segment = TEST_SEGMENT,table = TEST_TABLE,isAdmin = true,+ remoteSyncType,}: SetupOpts = {}) {setupSegmentEndpoint(segment);setupSchemaEndpoints(checkNotNull(table.db));@@ -116,6 +119,10 @@ function setup({databases: [TEST_DATABASE],tables: [table],}),+ settings: mockSettings({+ "remote-sync-type": remoteSyncType,+ "remote-sync-enabled": !!remoteSyncType,+ }),},},);@@ -283,4 +290,41 @@ describe("SegmentDetailPage", () => {).not.toBeInTheDocument();});});++ describe("readonly state for read-only remote sync", () => {+ it("has readonly segment name input", async () => {+ setup({ remoteSyncType: "read-only" });++ const nameInput = screen.getByDisplayValue("High Value Orders");+ expect(nameInput).toBeDisabled();+ });++ it("shows description as plain text", async () => {+ setup({ remoteSyncType: "read-only" });++ expect(screen.getByText("Description")).toBeInTheDocument();+ expect(screen.getByText("Orders with total > 100")).toBeInTheDocument();+ expect(+ screen.queryByLabelText("Give it a description"),+ ).not.toBeInTheDocument();+ });++ it("hides description section when there is no description", async () => {+ setup({+ remoteSyncType: "read-only",+ segment: createMockSegment({ ...TEST_SEGMENT, description: "" }),+ });++ expect(screen.queryByText("Description")).not.toBeInTheDocument();+ });++ it("does not show Remove segment option in actions menu", async () => {+ setup({ remoteSyncType: "read-only" });++ await userEvent.click(screen.getByLabelText("Segment actions"));++ expect(screen.getByText("Preview")).toBeInTheDocument();+ expect(screen.queryByText("Remove segment")).not.toBeInTheDocument();+ });+ });});diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/tables/components/TableHeader/TableMoreMenu/TableMoreMenu.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/tables/components/TableHeader/TableMoreMenu/TableMoreMenu.tsxindex effbe3aefff..d8faceb4e31 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/tables/components/TableHeader/TableMoreMenu/TableMoreMenu.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/tables/components/TableHeader/TableMoreMenu/TableMoreMenu.tsx@@ -3,10 +3,11 @@ import { push } from "react-router-redux";import { c, t } from "ttag";import { ForwardRefLink } from "metabase/common/components/Link";-import { useDispatch } from "metabase/lib/redux";+import { useDispatch, useSelector } from "metabase/lib/redux";import * as Urls from "metabase/lib/urls";import { ActionIcon, Icon, Menu } from "metabase/ui";import { UnpublishTablesModal } from "metabase-enterprise/data-studio/common/components/UnpublishTablesModal";+import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";import type { Table } from "metabase-types/api";type TableModalType = "unpublish";@@ -18,6 +19,7 @@ type TableMoreMenuProps = {export function TableMoreMenu({ table }: TableMoreMenuProps) {const dispatch = useDispatch();const [modalType, setModalType] = useState<TableModalType>();+ const remoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);const handleUnpublish = () => {setModalType(undefined);@@ -28,7 +30,7 @@ export function TableMoreMenu({ table }: TableMoreMenuProps) {<><Menu><Menu.Target>- <ActionIcon size="sm">+ <ActionIcon size="sm" aria-label={t`Show table options`}><Icon name="ellipsis" /></ActionIcon></Menu.Target>@@ -41,12 +43,14 @@ export function TableMoreMenu({ table }: TableMoreMenuProps) {>{c("A verb, not a noun").t`View`}</Menu.Item>- <Menu.Item- leftSection={<Icon name="unpublish" />}- onClick={() => setModalType("unpublish")}- >- {t`Unpublish`}- </Menu.Item>+ {!remoteSyncReadOnly && (+ <Menu.Item+ leftSection={<Icon name="unpublish" />}+ onClick={() => setModalType("unpublish")}+ >+ {t`Unpublish`}+ </Menu.Item>+ )}</Menu.Dropdown></Menu><UnpublishTablesModaldiff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/tables/components/TableHeader/TableMoreMenu/TableMoreMenu.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/tables/components/TableHeader/TableMoreMenu/TableMoreMenu.unit.spec.tsxnew file mode 100644index 00000000000..217a878fef7--- /dev/null+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/tables/components/TableHeader/TableMoreMenu/TableMoreMenu.unit.spec.tsx@@ -0,0 +1,58 @@+import userEvent from "@testing-library/user-event";+import { Route } from "react-router";++import { mockSettings } from "__support__/settings";+import { renderWithProviders, screen } from "__support__/ui";+import type { EnterpriseSettings } from "metabase-types/api";+import { createMockTable } from "metabase-types/api/mocks";++import { TableMoreMenu } from "./TableMoreMenu";++type SetupOpts = {+ remoteSyncType?: EnterpriseSettings["remote-sync-type"];+};++const setup = ({ remoteSyncType }: SetupOpts = {}) => {+ const mockTable = createMockTable({+ id: 1,+ db_id: 1,+ schema: "PUBLIC",+ });++ renderWithProviders(+ <Route path="/" component={() => <TableMoreMenu table={mockTable} />} />,+ {+ withRouter: true,+ storeInitialState: {+ settings: mockSettings({+ "remote-sync-type": remoteSyncType,+ "remote-sync-enabled": !!remoteSyncType,+ }),+ },+ },+ );+};++describe("TableMoreMenu", () => {+ it("renders the View and the Unpublish menu options", async () => {+ setup();+ await userEvent.click(+ screen.getByRole("button", { name: "Show table options" }),+ );+ expect(screen.getByRole("menuitem", { name: /View/ })).toBeInTheDocument();+ expect(+ screen.getByRole("menuitem", { name: /Unpublish/ }),+ ).toBeInTheDocument();+ });++ it("does not render the Unpublish option when remote sync is set to read-only", async () => {+ setup({ remoteSyncType: "read-only" });+ await userEvent.click(+ screen.getByRole("button", { name: "Show table options" }),+ );+ expect(screen.getByRole("menuitem", { name: /View/ })).toBeInTheDocument();+ expect(+ screen.queryByRole("menuitem", { name: /Unpublish/ }),+ ).not.toBeInTheDocument();+ });+});diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/tables/pages/TableMeasuresPage/TableMeasures.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/tables/pages/TableMeasuresPage/TableMeasures.tsxindex 6da2ad03a02..015f297ddf3 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/tables/pages/TableMeasuresPage/TableMeasures.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/tables/pages/TableMeasuresPage/TableMeasures.tsx@@ -1,7 +1,9 @@import { t } from "ttag";+import { useSelector } from "metabase/lib/redux";import * as Urls from "metabase/lib/urls";import { Flex } from "metabase/ui";+import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";import type { Table } from "metabase-types/api";import {@@ -14,7 +16,15 @@ type TableMeasuresProps = {};export function TableMeasures({ table }: TableMeasuresProps) {+ const remoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);const measures = table.measures ?? [];+ let newButtonLabel: string | undefined;+ let newButtonUrl: string | undefined;++ if (!remoteSyncReadOnly) {+ newButtonLabel = t`New measure`;+ newButtonUrl = Urls.dataStudioPublishedTableMeasureNew(table.id);+ }return (<Flex direction="column" flex={1}>@@ -26,8 +36,8 @@ export function TableMeasures({ table }: TableMeasuresProps) {title: t`No measures yet`,message: t`Create a measure to define aggregations for this table.`,}}- newButtonLabel={t`New measure`}- newButtonUrl={Urls.dataStudioPublishedTableMeasureNew(table.id)}+ newButtonLabel={newButtonLabel}+ newButtonUrl={newButtonUrl}renderItem={(measure) => (<EntityListItemkey={measure.id}diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/tables/pages/TableMeasuresPage/TableMeasures.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/tables/pages/TableMeasuresPage/TableMeasures.unit.spec.tsxnew file mode 100644index 00000000000..bee08dc3556--- /dev/null+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/tables/pages/TableMeasuresPage/TableMeasures.unit.spec.tsx@@ -0,0 +1,53 @@+import { Route } from "react-router";++import { mockSettings } from "__support__/settings";+import { renderWithProviders, screen } from "__support__/ui";+import type { EnterpriseSettings } from "metabase-types/api";+import { createMockTable } from "metabase-types/api/mocks";++import { TableMeasures } from "./TableMeasures";++type SetupOpts = {+ remoteSyncType?: EnterpriseSettings["remote-sync-type"];+};++const setup = ({ remoteSyncType }: SetupOpts = {}) => {+ const mockTable = createMockTable({+ id: 1,+ db_id: 1,+ schema: "PUBLIC",+ });++ renderWithProviders(+ <Route path="/" component={() => <TableMeasures table={mockTable} />} />,+ {+ withRouter: true,+ storeInitialState: {+ settings: mockSettings({+ "remote-sync-type": remoteSyncType,+ "remote-sync-enabled": !!remoteSyncType,+ }),+ },+ },+ );+};++describe("TablesMeasures", () => {+ it("renders the new measure button", () => {+ setup();+ expect(+ screen.getByRole("link", { name: /New measure/ }),+ ).toBeInTheDocument();+ expect(screen.getByRole("link", { name: /New measure/ })).toHaveAttribute(+ "href",+ "/data-studio/library/tables/1/measures/new",+ );+ });++ it("does not render the new measure button if remote sync is set to read-only", () => {+ setup({ remoteSyncType: "read-only" });+ expect(+ screen.queryByRole("link", { name: /New measure/ }),+ ).not.toBeInTheDocument();+ });+});diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/tables/pages/TableSegmentsPage/TableSegments.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/tables/pages/TableSegmentsPage/TableSegments.tsxindex ddfc3b50be2..43e3e6cf9d7 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/tables/pages/TableSegmentsPage/TableSegments.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/tables/pages/TableSegmentsPage/TableSegments.tsx@@ -4,6 +4,7 @@ import { useSelector } from "metabase/lib/redux";import * as Urls from "metabase/lib/urls";import { getUserCanWriteSegments } from "metabase/selectors/user";import { Flex } from "metabase/ui";+import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";import type { Table } from "metabase-types/api";import {@@ -17,7 +18,15 @@ type TableSegmentsProps = {export function TableSegments({ table }: TableSegmentsProps) {const canWriteSegments = useSelector(getUserCanWriteSegments);+ const remoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);const segments = table.segments ?? [];+ let newButtonLabel: string | undefined;+ let newButtonUrl: string | undefined;++ if (!remoteSyncReadOnly && canWriteSegments) {+ newButtonLabel = t`New segment`;+ newButtonUrl = Urls.dataStudioPublishedTableSegmentNew(table.id);+ }return (<Flex direction="column" flex={1}>@@ -29,12 +38,8 @@ export function TableSegments({ table }: TableSegmentsProps) {title: t`No segments yet`,message: t`Create a segment to filter rows in this table.`,}}- newButtonLabel={canWriteSegments ? t`New segment` : undefined}- newButtonUrl={- canWriteSegments- ? Urls.dataStudioPublishedTableSegmentNew(table.id)- : undefined- }+ newButtonLabel={newButtonLabel}+ newButtonUrl={newButtonUrl}renderItem={(segment) => (<EntityListItemkey={segment.id}diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/tables/pages/TableSegmentsPage/TableSegments.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/tables/pages/TableSegmentsPage/TableSegments.unit.spec.tsxnew file mode 100644index 00000000000..ce117515adf--- /dev/null+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/tables/pages/TableSegmentsPage/TableSegments.unit.spec.tsx@@ -0,0 +1,62 @@+import { Route } from "react-router";++import { mockSettings } from "__support__/settings";+import { renderWithProviders, screen } from "__support__/ui";+import type { EnterpriseSettings } from "metabase-types/api";+import { createMockTable, createMockUser } from "metabase-types/api/mocks";++import { TableSegments } from "./TableSegments";++type SetupOpts = {+ isAdmin?: boolean;+ remoteSyncType?: EnterpriseSettings["remote-sync-type"];+};++const setup = ({ isAdmin = true, remoteSyncType }: SetupOpts = {}) => {+ const mockTable = createMockTable({+ id: 1,+ db_id: 1,+ schema: "PUBLIC",+ });++ renderWithProviders(+ <Route path="/" component={() => <TableSegments table={mockTable} />} />,+ {+ withRouter: true,+ storeInitialState: {+ settings: mockSettings({+ "remote-sync-type": remoteSyncType,+ "remote-sync-enabled": !!remoteSyncType,+ }),+ currentUser: createMockUser({ is_superuser: isAdmin }),+ },+ },+ );+};++describe("TableSegments", () => {+ it("renders the new segment button", () => {+ setup();+ expect(+ screen.getByRole("link", { name: /New segment/ }),+ ).toBeInTheDocument();+ expect(screen.getByRole("link", { name: /New segment/ })).toHaveAttribute(+ "href",+ "/data-studio/library/tables/1/segments/new",+ );+ });++ it("does not render the new segment button if remote sync is set to read-only", () => {+ setup({ remoteSyncType: "read-only" });+ expect(+ screen.queryByRole("link", { name: /New segment/ }),+ ).not.toBeInTheDocument();+ });++ it("does not render the new segment button if the user is not an admin", () => {+ setup({ isAdmin: false });+ expect(+ screen.queryByRole("link", { name: /New segment/ }),+ ).not.toBeInTheDocument();+ });+});diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/selectors.ts b/enterprise/frontend/src/metabase-enterprise/remote_sync/selectors.tsindex 22aeb793fba..42c51447692 100644--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/selectors.ts+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/selectors.ts@@ -1,5 +1,6 @@import { createSelector } from "@reduxjs/toolkit";+import { getSetting } from "metabase/selectors/settings";import { remoteSyncApi } from "metabase-enterprise/api";import type { State } from "metabase-types/store";@@ -56,3 +57,13 @@ export const getHasPendingMutation = createSelector();},);++/**+ * Checks if the remote sync is enabled and in read-only mode.+ */+export function getIsRemoteSyncReadOnly(state: State): boolean {+ return !!(+ getSetting(state, "remote-sync-enabled") &&+ getSetting(state, "remote-sync-type") === "read-only"+ );+}diff --git a/enterprise/frontend/src/metabase-enterprise/snippets/components/SnippetCollectionMenu/SnippetCollectionMenu.tsx b/enterprise/frontend/src/metabase-enterprise/snippets/components/SnippetCollectionMenu/SnippetCollectionMenu.tsxindex 89eebb7b558..a035948a67d 100644--- a/enterprise/frontend/src/metabase-enterprise/snippets/components/SnippetCollectionMenu/SnippetCollectionMenu.tsx+++ b/enterprise/frontend/src/metabase-enterprise/snippets/components/SnippetCollectionMenu/SnippetCollectionMenu.tsx@@ -14,6 +14,7 @@ import {Menu,Tooltip,} from "metabase/ui";+import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";export function SnippetCollectionMenu({collection,@@ -24,11 +25,12 @@ export function SnippetCollectionMenu({const isAdmin = useSelector(getUserIsAdmin);const [updateCollection] = useUpdateCollectionMutation();+ const remoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);const isRoot = isRootCollection(collection);const isArchived = collection.archived;- if (!collection.can_write) {+ if (!collection.can_write || remoteSyncReadOnly) {return null;}diff --git a/enterprise/frontend/src/metabase-enterprise/snippets/components/SnippetCollectionMenu/SnippetCollectionMenu.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/snippets/components/SnippetCollectionMenu/SnippetCollectionMenu.unit.spec.tsxnew file mode 100644index 00000000000..16e0516c6ed--- /dev/null+++ b/enterprise/frontend/src/metabase-enterprise/snippets/components/SnippetCollectionMenu/SnippetCollectionMenu.unit.spec.tsx@@ -0,0 +1,59 @@+import { mockSettings } from "__support__/settings";+import { renderWithProviders, screen } from "__support__/ui";+import type { Collection, EnterpriseSettings } from "metabase-types/api";+import { createMockCollection, createMockUser } from "metabase-types/api/mocks";+import { createMockState } from "metabase-types/store/mocks/state";++import { SnippetCollectionMenu } from "./SnippetCollectionMenu";++interface SetupOptions {+ remoteSyncType?: EnterpriseSettings["remote-sync-type"];+ collection?: Partial<Collection>;+}++const onEditDetails = jest.fn();+const onChangePermissions = jest.fn();++const setup = ({ remoteSyncType, collection }: SetupOptions = {}) => {+ const state = createMockState({+ settings: mockSettings({+ "remote-sync-type": remoteSyncType,+ "remote-sync-enabled": !!remoteSyncType,+ }),+ currentUser: createMockUser(),+ });++ return renderWithProviders(+ <SnippetCollectionMenu+ collection={createMockCollection(collection)}+ onChangePermissions={onChangePermissions}+ onEditDetails={onEditDetails}+ />,+ {+ storeInitialState: state,+ },+ );+};++describe("RootSnippetsCollectionMenu", () => {+ it("renders snippet collection options menu", () => {+ setup();+ expect(+ screen.getByRole("button", { name: "Snippet folder options" }),+ ).toBeInTheDocument();+ });++ it("renders nothing if collection is not writable", () => {+ setup({ collection: { can_write: false } });+ expect(+ screen.queryByRole("button", { name: "Snippet folder options" }),+ ).not.toBeInTheDocument();+ });++ it("renders nothing if remote sync is set to read-only", () => {+ setup({ remoteSyncType: "read-only" });+ expect(+ screen.queryByRole("button", { name: "Snippet folder options" }),+ ).not.toBeInTheDocument();+ });+});