Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

add background-secondary to setup settingspage (#74037)

Maz Amelifaaa8db9467a
diff --git a/frontend/src/metabase/setup/components/InactiveStep/InactiveStep.styled.tsx b/frontend/src/metabase/setup/components/InactiveStep/InactiveStep.styled.tsx
index a4259eb9d58..077d82ebeae 100644
--- a/frontend/src/metabase/setup/components/InactiveStep/InactiveStep.styled.tsx
+++ b/frontend/src/metabase/setup/components/InactiveStep/InactiveStep.styled.tsx
@@ -14,8 +14,7 @@ export const StepRoot = styled.section<Props>`
border-radius: 0.5rem;
padding: 1rem 2rem;
margin-bottom: 1.75rem;
- background-color: ${(props) =>
- color(props.isCompleted ? "background-primary" : "background-secondary")};
+ background-color: ${color("background-primary")};
`;
export const StepTitle = styled.div<Props>`
diff --git a/frontend/src/metabase/setup/components/SettingsPage/SettingsPage.module.css b/frontend/src/metabase/setup/components/SettingsPage/SettingsPage.module.css
index f27ca22ee55..ae3cfcf0d84 100644
--- a/frontend/src/metabase/setup/components/SettingsPage/SettingsPage.module.css
+++ b/frontend/src/metabase/setup/components/SettingsPage/SettingsPage.module.css
@@ -1,7 +1,17 @@
+.Page {
+ background-color: var(--mb-color-background-secondary);
+ min-height: 100vh;
+}
+
+:global(main):has(> .Page) {
+ background-color: var(--mb-color-background-secondary);
+}
+
.PageHeader {
margin-bottom: 4rem;
padding: 1rem;
border-bottom: 1px solid var(--mb-color-border);
+ background-color: var(--mb-color-background-primary);
}
.Decoy {
diff --git a/frontend/src/metabase/setup/components/SettingsPage/SettingsPage.tsx b/frontend/src/metabase/setup/components/SettingsPage/SettingsPage.tsx
index 2e8102df39e..4649685552d 100644
--- a/frontend/src/metabase/setup/components/SettingsPage/SettingsPage.tsx
+++ b/frontend/src/metabase/setup/components/SettingsPage/SettingsPage.tsx
@@ -44,7 +44,7 @@ export const SettingsPage = (): JSX.Element => {
);
return (
- <div data-testid="setup-forms">
+ <div data-testid="setup-forms" className={S.Page}>
<Box component="header" className={S.PageHeader}>
<Flex align="center" justify="space-between">
<Box w={SELECT_WIDTH} className={S.Decoy} />