Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Move NewItemMenu integration spec next to NewModals (#79797)

Romeo Van Snickfb8cf2d72442
diff --git a/frontend/lint/module-boundaries.mjs b/frontend/lint/module-boundaries.mjs
index 9f30eee1f67..62ca96602ba 100644
--- a/frontend/lint/module-boundaries.mjs
+++ b/frontend/lint/module-boundaries.mjs
@@ -341,9 +341,6 @@ const elements = [
"frontend/src/metabase/routes-public.tsx",
"frontend/src/metabase/AppThemeProvider.tsx",
"frontend/src/metabase/AppColorSchemeProvider.tsx",
- // NewItemMenu's spec mounts app-tier NewModals to assert menu clicks open modals,
- // so the test is app-tier too.
- "frontend/src/metabase/common/components/NewItemMenu/NewItemMenu.unit.spec.tsx",
// Entry point for the static-viz bundle (server-side chart rendering in
// GraalJS) - like app.tsx, it composes OSS + EE code for a build artifact.
// Full-mode entries match before folder patterns, whatever the order.
diff --git a/frontend/src/metabase/common/components/NewItemMenu/NewItemMenu.unit.spec.tsx b/frontend/src/metabase/new/components/NewModals/NewItemMenu.unit.spec.tsx
similarity index 97%
rename from frontend/src/metabase/common/components/NewItemMenu/NewItemMenu.unit.spec.tsx
rename to frontend/src/metabase/new/components/NewModals/NewItemMenu.unit.spec.tsx
index 1a8b39c8546..f16bebdc338 100644
--- a/frontend/src/metabase/common/components/NewItemMenu/NewItemMenu.unit.spec.tsx
+++ b/frontend/src/metabase/new/components/NewModals/NewItemMenu.unit.spec.tsx
@@ -8,7 +8,7 @@ import {
} from "__support__/server-mocks";
import { mockSettings } from "__support__/settings";
import { renderWithProviders, screen } from "__support__/ui";
-import { NewModals } from "metabase/new/components/NewModals/NewModals";
+import { NewItemMenu } from "metabase/common/components/NewItemMenu";
import { createMockState } from "metabase/redux/store/mocks";
import { Route } from "metabase/router";
import type { Database } from "metabase-types/api";
@@ -19,7 +19,7 @@ import {
} from "metabase-types/api/mocks";
import { createSampleDatabase } from "metabase-types/api/mocks/presets";
-import { NewItemMenu } from "./NewItemMenu";
+import { NewModals } from "./NewModals";
console.warn = jest.fn();
console.error = jest.fn();