Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Delete dead SandboxedPortal and unused formatting barrel exports (#79864)

Fraserfbb89ab47ac7
diff --git a/frontend/src/metabase/common/components/SandboxedPortal/SandboxedPortal.tsx b/frontend/src/metabase/common/components/SandboxedPortal/SandboxedPortal.tsx
deleted file mode 100644
index 3cd7d454b7e..00000000000
--- a/frontend/src/metabase/common/components/SandboxedPortal/SandboxedPortal.tsx
+++ /dev/null
@@ -1,21 +0,0 @@
-import ReactDOM from "react-dom";
-
-import { EventSandbox } from "metabase/common/components/EventSandbox";
-
-import type { EventSandboxProps } from "../EventSandbox/EventSandbox";
-
-// Prevent DOM events from bubbling through the React component tree
-// See https://reactjs.org/docs/portals.html#event-bubbling-through-portals
-export const SandboxedPortal = ({
- children,
- container,
- ...props
-}: {
- children: React.ReactNode;
- container: Element;
-} & EventSandboxProps) => {
- return ReactDOM.createPortal(
- <EventSandbox {...props}>{children}</EventSandbox>,
- container,
- );
-};
diff --git a/frontend/src/metabase/common/components/SandboxedPortal/index.tsx b/frontend/src/metabase/common/components/SandboxedPortal/index.tsx
deleted file mode 100644
index 36af89cbf0a..00000000000
--- a/frontend/src/metabase/common/components/SandboxedPortal/index.tsx
+++ /dev/null
@@ -1 +0,0 @@
-export { SandboxedPortal } from "./SandboxedPortal";
diff --git a/frontend/src/metabase/utils/formatting/index.ts b/frontend/src/metabase/utils/formatting/index.ts
index 886c7bb20fd..901d461736d 100644
--- a/frontend/src/metabase/utils/formatting/index.ts
+++ b/frontend/src/metabase/utils/formatting/index.ts
@@ -1,7 +1,5 @@
export { FK_SYMBOL } from "./constants";
export {
- COMPACT_CURRENCY_OPTIONS,
- type CompactCurrencyOptions,
type Currency,
type CurrencyOption,
type CurrencyStyleOption,
@@ -28,7 +26,6 @@ export {
formatNumber,
formatPercent,
numberFormatterForOptions,
- roundFloat,
} from "./numbers";
export {
capitalize,