Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Bump clj-kondo (#72019)

Oleksandr Yakushevfcc50c8ab37e
diff --git a/.clj-kondo/config.edn b/.clj-kondo/config.edn
index 5564415583e..47645c1383e 100644
--- a/.clj-kondo/config.edn
+++ b/.clj-kondo/config.edn
@@ -52,6 +52,7 @@
:redundant-ignore {:level :off} ; lots of false positives, see https://github.com/clj-kondo/clj-kondo/issues/2414
:unexpected-recur {:level :off} ; TODO (cam): I think we just need to tell it how to handle MBQL match and we can enable this?
+ :redundant-primitive-coercion {:level :off} ; there are many defensive boolean coercions, kondo looks too much into it
;;
;; globally-enabled custom linters
diff --git a/deps.edn b/deps.edn
index ffc94981636..e1074187023 100644
--- a/deps.edn
+++ b/deps.edn
@@ -256,7 +256,7 @@
{cider/cider-nrepl {:mvn/version "0.58.0"} ; nREPL server for CIDER
clj-http-fake/clj-http-fake {:mvn/version "1.0.4"
:exclusions [slingshot/slingshot]}
- clj-kondo/clj-kondo {:mvn/version "2025.10.23"} ; included here mainly to facilitate working on the stuff in `.clj-kondo/src`
+ clj-kondo/clj-kondo {:mvn/version "2026.04.15"} ; included here mainly to facilitate working on the stuff in `.clj-kondo/src`
cloverage/cloverage {:mvn/version "1.2.4"}
com.clojure-goes-fast/clj-async-profiler
{:mvn/version "1.6.2"} ; Enables local profiling and heat map generation
@@ -522,7 +522,7 @@
;; Use this to only run Kondo against specific files.
:kondo
{:replace-deps
- {clj-kondo/clj-kondo {:mvn/version "2025.10.23"}}
+ {clj-kondo/clj-kondo {:mvn/version "2026.04.15"}}
:main-opts
["-m" "clj-kondo.main"]}
diff --git a/enterprise/backend/src/metabase_enterprise/advanced_config/file/api_keys.clj b/enterprise/backend/src/metabase_enterprise/advanced_config/file/api_keys.clj
index 4d8ce473eeb..466439f7713 100644
--- a/enterprise/backend/src/metabase_enterprise/advanced_config/file/api_keys.clj
+++ b/enterprise/backend/src/metabase_enterprise/advanced_config/file/api_keys.clj
@@ -65,7 +65,7 @@
unhashed-key (u.secret/secret key)
_ (when-not (and (<= 11 (count key) 254)
(re-matches #"mb_[A-Za-z0-9+/=]+" key))
- (throw (ex-info (format "Invalid API key format. Key must be between 11-254 characters and start with 'mb_'.")
+ (throw (ex-info "Invalid API key format. Key must be between 11-254 characters and start with 'mb_'."
{:name name})))
prefix (api-key/prefix (u.secret/expose unhashed-key))
creator (get-admin-user-by-email creator)]
diff --git a/enterprise/backend/src/metabase_enterprise/analytics/stats.clj b/enterprise/backend/src/metabase_enterprise/analytics/stats.clj
index b626b1e6b45..dd6e2b1b123 100644
--- a/enterprise/backend/src/metabase_enterprise/analytics/stats.clj
+++ b/enterprise/backend/src/metabase_enterprise/analytics/stats.clj
@@ -28,7 +28,7 @@
:enabled (t2/exists? :model/Sandbox)}
{:name :email-allow-list
:available (premium-features/enable-email-allow-list?)
- :enabled (boolean (some? (advanced-config.settings/subscription-allowed-domains)))}
+ :enabled (some? (advanced-config.settings/subscription-allowed-domains))}
{:name :semantic-search
:available (premium-features/enable-semantic-search?)
:enabled (semantic-search/supported?)}])
diff --git a/enterprise/backend/src/metabase_enterprise/semantic_search/index_metadata.clj b/enterprise/backend/src/metabase_enterprise/semantic_search/index_metadata.clj
index 032f5631088..b4cf72bcc59 100644
--- a/enterprise/backend/src/metabase_enterprise/semantic_search/index_metadata.clj
+++ b/enterprise/backend/src/metabase_enterprise/semantic_search/index_metadata.clj
@@ -237,7 +237,7 @@
the indexes metadata row."
[pgvector index-metadata index-id]
(assert index-id)
- (assert (nat-int? index-id) (format "expected an integer id (hint do not pass the index map!)"))
+ (assert (nat-int? index-id) "expected an integer id (hint do not pass the index map!)")
(let [{:keys [control-table-name]} index-metadata
;; only one row, no traditional WHERE for now
activation-sql (-> {:update (keyword control-table-name)
diff --git a/enterprise/backend/src/metabase_enterprise/serialization/cmd.clj b/enterprise/backend/src/metabase_enterprise/serialization/cmd.clj
index a11a9713aa6..145662b1b2d 100644
--- a/enterprise/backend/src/metabase_enterprise/serialization/cmd.clj
+++ b/enterprise/backend/src/metabase_enterprise/serialization/cmd.clj
@@ -1,5 +1,4 @@
(ns metabase-enterprise.serialization.cmd
- (:refer-clojure :exclude [load])
(:require
[clojure.java.io :as io]
[clojure.string :as str]
diff --git a/enterprise/backend/test/metabase_enterprise/advanced_config/file/databases_test.clj b/enterprise/backend/test/metabase_enterprise/advanced_config/file/databases_test.clj
index 011d862e1ec..a2b5eb288f8 100644
--- a/enterprise/backend/test/metabase_enterprise/advanced_config/file/databases_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/advanced_config/file/databases_test.clj
@@ -180,7 +180,7 @@
(let [sync-future (@#'advanced-config.file.databases/init-from-config-file! {:name test-db-name
:engine "h2"
:details (:details (mt/db))})]
- (is nil? sync-future)
+ (is (nil? sync-future))
(let [db (t2/select-one :model/Database :name test-db-name)]
(is (partial= {:engine :h2}
db))
diff --git a/enterprise/backend/test/metabase_enterprise/scim/v2/api_test.clj b/enterprise/backend/test/metabase_enterprise/scim/v2/api_test.clj
index d2cb102532f..d26029e494a 100644
--- a/enterprise/backend/test/metabase_enterprise/scim/v2/api_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/scim/v2/api_test.clj
@@ -427,7 +427,7 @@
:displayName group-name
:members [{:value (t2/select-one-fn :entity_id :model/User :id (mt/user->id :rasta))}]}]
(try
- (let [response (scim-client :post 201 (format "ee/scim/v2/Groups") new-group)]
+ (let [response (scim-client :post 201 "ee/scim/v2/Groups" new-group)]
(is (malli= scim-api/SCIMGroup response))
(let [mb-group (t2/select-one :model/PermissionsGroup :entity_id (:id response))]
(is (= group-name (:name mb-group)))
diff --git a/enterprise/backend/test/metabase_enterprise/serialization/v2/e2e_test.clj b/enterprise/backend/test/metabase_enterprise/serialization/v2/e2e_test.clj
index 62e720a28a3..3b86b60115a 100644
--- a/enterprise/backend/test/metabase_enterprise/serialization/v2/e2e_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/serialization/v2/e2e_test.clj
@@ -850,11 +850,11 @@
(mt/db)
(mt/$ids nil
(testing "Column ids are different in different dbs")
- (is (not= @old-ids
- {:people.name %people.name
+ (is (not= {:people.name %people.name
:orders.user_id %orders.user_id
:products.title %products.title
- :orders.product_id %orders.product_id}))
+ :orders.product_id %orders.product_id}
+ @old-ids))
(serdes.load/load-metabase! (ingest/ingest-yaml dump-dir))
diff --git a/enterprise/backend/test/metabase_enterprise/sso/integrations/jwt_test.clj b/enterprise/backend/test/metabase_enterprise/sso/integrations/jwt_test.clj
index d6dd8785117..a2cd9c0cfec 100644
--- a/enterprise/backend/test/metabase_enterprise/sso/integrations/jwt_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/sso/integrations/jwt_test.clj
@@ -998,7 +998,7 @@
result (client/client-real-response :get 400 "/auth/sso"
{:request-options {:headers {"x-metabase-client" "embedding-sdk-react"}}}
:jwt jwt-payload)]
- (is result nil))))))
+ (is result))))))
(deftest jwt-token-embedding-disabled-test
(testing "should not return a session token when embedding is disabled"
@@ -1018,7 +1018,7 @@
result (client/client-real-response :get 402 "/auth/sso"
{:request-options {:headers {"x-metabase-client" "embedding-sdk-react"}}}
:jwt jwt-payload)]
- (is result nil))))))
+ (is result))))))
(deftest jwt-token-no-hash-test
(testing "should not return a session token when token=false"
@@ -1039,7 +1039,7 @@
{:request-options {:redirect-strategy :none}}
:return_to default-redirect-uri
:jwt jwt-payload)]
- (is result nil))))))
+ (is result))))))
(deftest tenant-user-assigned-to-tenant-group-via-mapping-test
(testing "JWT user with tenant claim can be assigned to tenant user groups via group mapping"
diff --git a/modules/drivers/clickhouse/test/metabase/driver/clickhouse_impersonation_test.clj b/modules/drivers/clickhouse/test/metabase/driver/clickhouse_impersonation_test.clj
index 472f8078eb5..4ad1939f635 100644
--- a/modules/drivers/clickhouse/test/metabase/driver/clickhouse_impersonation_test.clj
+++ b/modules/drivers/clickhouse/test/metabase/driver/clickhouse_impersonation_test.clj
@@ -47,11 +47,11 @@
(driver/set-role! :clickhouse conn default-role)
(with-open [stmt (.prepareStatement conn "SELECT * FROM `metabase_test_role_db`.`some_table` ORDER BY i ASC;")
rset (.executeQuery stmt)]
- (is (.next rset) true)
- (is (.getInt rset 1) 42)
- (is (.next rset) true)
- (is (.getInt rset 1) 144)
- (is (.next rset) false)))))
+ (is (true? (.next rset)))
+ (is (= 42 (.getInt rset 1)))
+ (is (true? (.next rset)))
+ (is (= 144 (.getInt rset 1)))
+ (is (false? (.next rset)))))))
(is true))))
(defn- set-role-throws-test!
diff --git a/modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj b/modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj
index 9f838cabc9d..1ce354eaff8 100644
--- a/modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj
+++ b/modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj
@@ -1261,28 +1261,28 @@
(testing "password takes precedence if use-password is true"
(when (and password use-password)
(is (= :password (first result))
- [idxs result])))
+ (str [idxs result]))))
(testing "password comes last if use-password is false or nil"
(when (and password (not use-password))
(is (= :password (last result))
- [idxs result])))
+ (str [idxs result]))))
(testing "path is preferred if options is local"
(when (and (= "local" options) private-key-value private-key-path)
(is (= :private-key-path (m/find-first #{:private-key-path :private-key-value} result))
- [idxs result])))
+ (str [idxs result]))))
(testing "value is preferred if options is nil or uploaded"
(when (and (not= "local" options) private-key-value private-key-path)
(is (= :private-key-value (m/find-first #{:private-key-path :private-key-value} result))
- [idxs result])))
+ (str [idxs result]))))
(testing "ID is checked last if path or value exists"
(when (or (and private-key-value private-key-id)
(and private-key-path private-key-id))
(is (= :private-key-id (m/find-first #{:private-key-path :private-key-value :private-key-id} (reverse result)))
- [idxs result])))))))
+ (str [idxs result]))))))))
(deftest have-select-privelege?-timeout-test
(mt/test-driver :snowflake
diff --git a/src/metabase/actions/actions.clj b/src/metabase/actions/actions.clj
index fc2fa2546ad..f0215b4db44 100644
--- a/src/metabase/actions/actions.clj
+++ b/src/metabase/actions/actions.clj
@@ -18,7 +18,7 @@
^{:clj-kondo/ignore [:deprecated-namespace :discouraged-namespace]} [metabase.query-processor.store :as qp.store]
[metabase.settings.core :as setting]
[metabase.util :as u]
- [metabase.util.i18n :as i18n :refer [tru]]
+ [metabase.util.i18n :refer [tru]]
[metabase.util.log :as log]
[metabase.util.malli :as mu]
[metabase.util.malli.registry :as mr]
@@ -78,14 +78,14 @@
known-actions (known-implicit-actions)]
;; return 404 if the action doesn't exist.
(when-not (contains? known-actions action)
- (throw (ex-info (i18n/tru "Unknown Action {0}. Valid Actions are: {1}"
- action
- (pr-str known-actions))
+ (throw (ex-info (tru "Unknown Action {0}. Valid Actions are: {1}"
+ action
+ (pr-str known-actions))
{:status-code 404})))
;; return 400 if the action does exist but is not supported by this DB
- (throw (ex-info (i18n/tru "Action {0} is not supported for {1} Databases."
- action
- (pr-str driver))
+ (throw (ex-info (tru "Action {0} is not supported for {1} Databases."
+ action
+ (pr-str driver))
{:status-code 400}))))
(def ^:dynamic *misc-value-cache*
@@ -116,14 +116,14 @@
"Throws an appropriate error if actions are unsupported or disabled for a database, otherwise returns nil."
[{db-id :id driver :engine db-name :name :as db}]
(when-not (driver.u/supports? driver :actions db)
- (throw (ex-info (i18n/tru "{0} Database {1} does not support actions."
- (u/qualified-name driver)
- (format "%d %s" db-id (pr-str db-name)))
+ (throw (ex-info (tru "{0} Database {1} does not support actions."
+ (u/qualified-name driver)
+ (format "%d %s" db-id (pr-str db-name)))
{:status-code 400, :database-id db-id})))
(setting/with-database db
(when-not (actions.settings/database-enable-actions)
- (throw (ex-info (i18n/tru "Actions are not enabled.")
+ (throw (ex-info (tru "Actions are not enabled.")
{:status-code 400, :database-id db-id}))))
nil)
@@ -132,14 +132,14 @@
"Throws an appropriate error if editing is unsupported or disabled for a database, otherwise returns nil."
[{db-id :id driver :engine db-name :name :as db}]
(when-not (driver.u/supports? driver :actions/data-editing db)
- (throw (ex-info (i18n/tru "{0} Database {1} does not support data editing."
- (u/qualified-name driver)
- (format "%d %s" db-id (pr-str db-name)))
+ (throw (ex-info (tru "{0} Database {1} does not support data editing."
+ (u/qualified-name driver)
+ (format "%d %s" db-id (pr-str db-name)))
{:status-code 400, :database-id db-id})))
(setting/with-database db
(when-not (actions.settings/database-enable-table-editing)
- (throw (ex-info (i18n/tru "Data editing is not enabled.")
+ (throw (ex-info (tru "Data editing is not enabled.")
{:status-code 400, :database-id db-id}))))
nil)
@@ -313,7 +313,7 @@
(do
;; TODO more granular controls
(when-not (api/check-superuser)
- (throw (ex-info (i18n/tru "You don''t have permissions to do that.") {:status-code 403})))
+ (throw (ex-info (tru "You don''t have permissions to do that.") {:status-code 403})))
(check-data-editing-enabled-for-database! db))))
(log/with-context {:db-id (:id db)}
(binding [*misc-value-cache* (atom {:databases (zipmap (map :id dbs) dbs)})]
diff --git a/src/metabase/activity_feed/api.clj b/src/metabase/activity_feed/api.clj
index c8c957a4b79..6d506f7b224 100644
--- a/src/metabase/activity_feed/api.clj
+++ b/src/metabase/activity_feed/api.clj
@@ -172,7 +172,7 @@
"Get the most recently viewed dashboard for the current user. Returns a 204 if the user has not viewed any dashboards
in the last 24 hours."
[]
- (if-let [dashboard-id (recent-views/most-recently-viewed-dashboard-id api/*current-user-id*)]
+ (if-let [dashboard-id (recent-views/most-recently-viewed-dashboard-id *current-user-id*)]
(let [dashboard (-> (t2/select-one :model/Dashboard :id dashboard-id)
api/check-404
(t2/hydrate [:collection :is_personal]))]
diff --git a/src/metabase/app_db/custom_migrations.clj b/src/metabase/app_db/custom_migrations.clj
index 052eb677611..b71c1bfdf67 100644
--- a/src/metabase/app_db/custom_migrations.clj
+++ b/src/metabase/app_db/custom_migrations.clj
@@ -996,7 +996,7 @@
:let [is-pg-specical-case? (= [db-type table column]
[:postgres :core_user :updated_at])]]
(when is-pg-specical-case?
- (t2/query [(format "DROP VIEW IF EXISTS v_users;")]))
+ (t2/query ["DROP VIEW IF EXISTS v_users;"]))
(t2/query [(alter-table-column-type-sql db-type (name table) (name column) target-type nullable?)])
(when is-pg-specical-case?
(t2/query [(slurp (io/resource "migrations/instance_analytics_views/users/v1/postgres-users.sql"))])))))
diff --git a/src/metabase/channel/email/messages.clj b/src/metabase/channel/email/messages.clj
index 69d2102a669..bb7a8151314 100644
--- a/src/metabase/channel/email/messages.clj
+++ b/src/metabase/channel/email/messages.clj
@@ -417,7 +417,7 @@
(cond-> param
(coll? value)
(update :value #(i18n/join-strings-with-conjunction
- (i18n/tru "or")
+ (tru "or")
%))))
bad-parameters)
:affectedUsers (map
diff --git a/src/metabase/channel/template/handlebars_helper.clj b/src/metabase/channel/template/handlebars_helper.clj
index 27a3687503a..8ce063a442f 100644
--- a/src/metabase/channel/template/handlebars_helper.clj
+++ b/src/metabase/channel/template/handlebars_helper.clj
@@ -1,5 +1,4 @@
(ns metabase.channel.template.handlebars-helper
- (:refer-clojure :exclude [hash])
(:require
[clojure.string :as str]
[java-time.api :as t]
diff --git a/src/metabase/cmd/core.clj b/src/metabase/cmd/core.clj
index 9c87def6090..2f84bc5b80b 100644
--- a/src/metabase/cmd/core.clj
+++ b/src/metabase/cmd/core.clj
@@ -14,7 +14,7 @@
You can see what commands are available by running the command `help`. This command uses the docstrings and arglists
associated with each command's entrypoint function to generate descriptions for each command."
- (:refer-clojure :exclude [load import])
+ (:refer-clojure :exclude [import])
(:require
[clojure.string :as str]
[clojure.tools.cli :as cli]
diff --git a/src/metabase/collections/models/collection.clj b/src/metabase/collections/models/collection.clj
index 0e96e0126fe..8f6cec1df3f 100644
--- a/src/metabase/collections/models/collection.clj
+++ b/src/metabase/collections/models/collection.clj
@@ -7,9 +7,7 @@
[clojure.set :as set]
[clojure.string :as str]
[metabase.api-keys.core :as api-key]
- [metabase.api.common
- :as api
- :refer [*current-user-id*]]
+ [metabase.api.common :as api]
[metabase.app-db.core :as mdb]
[metabase.audit-app.core :as audit]
[metabase.collections.models.collection.root :as collection.root]
@@ -571,9 +569,8 @@
(mu/defn is-dedicated-tenant-collection-or-descendant? :- :boolean
"Is `collection` a Tenant Collection, or a descendant of one?"
[collection :- CollectionWithNamespace]
- (boolean
- ;; If collection has namespace = "tenant-specific" we know it's in the dedicated tenant namespace
- (= (some-> (:namespace collection) name) "tenant-specific")))
+ ;; If collection has namespace = "tenant-specific" we know it's in the dedicated tenant namespace
+ (= (some-> (:namespace collection) name) "tenant-specific"))
(mu/defn user->existing-personal-collection :- [:maybe (ms/InstanceOf :model/Collection)]
"For a `user-or-id`, return their personal Collection, if it already exists.
@@ -1080,7 +1077,7 @@
;; cluttered with Personal Collections belonging to other users
[:or
[:= :personal_owner_id nil]
- [:= :personal_owner_id *current-user-id*]]
+ [:= :personal_owner_id api/*current-user-id*]]
additional-honeysql-where-clauses)})
[]))
diff --git a/src/metabase/driver.clj b/src/metabase/driver.clj
index 3114635a7e6..d4906419a2b 100644
--- a/src/metabase/driver.clj
+++ b/src/metabase/driver.clj
@@ -7,7 +7,7 @@
SQL-based drivers can use the `:sql` driver as a parent, and JDBC-based SQL drivers can use `:sql-jdbc`. Both of
these drivers define additional multimethods that child drivers should implement; see [[metabase.driver.sql]] and
[[metabase.driver.sql-jdbc]] for more details."
- (:refer-clojure :exclude [some mapv empty?])
+ (:refer-clojure :exclude [mapv empty?])
#_{:clj-kondo/ignore [:metabase/modules]}
(:require
[clojure.java.io :as io]
diff --git a/src/metabase/driver/common/parameters/dates.clj b/src/metabase/driver/common/parameters/dates.clj
index 8f92d310390..53002ec47a4 100644
--- a/src/metabase/driver/common/parameters/dates.clj
+++ b/src/metabase/driver/common/parameters/dates.clj
@@ -8,7 +8,7 @@
in [[metabase.query-processor.parameters.dates]], we should remove the version here to encourage migration to that
namespace."
{:deprecated "0.57.0"}
- (:refer-clojure :exclude [every? some get-in])
+ (:refer-clojure :exclude [every? get-in])
(:require
[clojure.string :as str]
[java-time.api :as t]
diff --git a/src/metabase/driver/impl.clj b/src/metabase/driver/impl.clj
index 6d4d7096a9f..6ac393a9430 100644
--- a/src/metabase/driver/impl.clj
+++ b/src/metabase/driver/impl.clj
@@ -109,7 +109,7 @@
"Check to make sure we're not trying to change the abstractness of an already registered driver"
[driver new-abstract?]
(when (registered? driver)
- (let [old-abstract? (boolean (abstract? driver))
+ (let [old-abstract? (abstract? driver)
new-abstract? (boolean new-abstract?)]
(when (not= old-abstract? new-abstract?)
(throw (Exception. (tru "Error: attempting to change {0} property `:abstract?` from {1} to {2}."
diff --git a/src/metabase/driver/sql/parameters/substitute.clj b/src/metabase/driver/sql/parameters/substitute.clj
index b879c3a119a..54736833556 100644
--- a/src/metabase/driver/sql/parameters/substitute.clj
+++ b/src/metabase/driver/sql/parameters/substitute.clj
@@ -59,8 +59,6 @@
(sql.params.substitution/->replacement-snippet-info driver/*driver* v)]
[(str sql replacement-snippet) (concat args prepared-statement-args) missing])))))
-(declare substitute*)
-
(defn- substitute-optional [param->value [sql args missing] {subclauses :args}]
(let [[opt-sql opt-args opt-missing] (substitute* param->value subclauses true)]
(if (seq opt-missing)
diff --git a/src/metabase/driver/util.clj b/src/metabase/driver/util.clj
index 0e30be1323c..1221efa86bb 100644
--- a/src/metabase/driver/util.clj
+++ b/src/metabase/driver/util.clj
@@ -1,6 +1,6 @@
(ns metabase.driver.util
"Utility functions for common operations on drivers."
- (:refer-clojure :exclude [mapv empty?])
+ (:refer-clojure :exclude [mapv empty? some])
(:require
[clojure.core.memoize :as memoize]
[clojure.set :as set]
@@ -23,7 +23,7 @@
[metabase.util.log :as log]
[metabase.util.malli :as mu]
^{:clj-kondo/ignore [:discouraged-namespace]} [metabase.util.malli.schema :as ms]
- [metabase.util.performance :as perf :refer [mapv empty?]])
+ [metabase.util.performance :refer [mapv empty? some]])
(:import
(java.io ByteArrayInputStream)
(java.security KeyFactory KeyStore PrivateKey)
@@ -480,9 +480,9 @@
%1 (:visible-if %2))
{} props*)
visible-keys (keys all-visible-ifs)
- transitive-props (perf/mapv (comp (partial get props-by-name) ->str) visible-keys)
+ transitive-props (mapv (comp (partial get props-by-name) ->str) visible-keys)
next-acc (into acc all-visible-ifs)]
- (if-not (perf/some #(contains? acc %) visible-keys)
+ (if-not (some #(contains? acc %) visible-keys)
(recur transitive-props next-acc)
(let [cyclic-props (set/intersection (set visible-keys)
(set (keys acc)))]
diff --git a/src/metabase/legacy_mbql/schema.cljc b/src/metabase/legacy_mbql/schema.cljc
index 0ed19df4fd6..a675e4bfbcf 100644
--- a/src/metabase/legacy_mbql/schema.cljc
+++ b/src/metabase/legacy_mbql/schema.cljc
@@ -42,7 +42,7 @@
[metabase.util :as u]
[metabase.util.malli :as mu]
[metabase.util.malli.registry :as mr]
- [metabase.util.performance :as perf :refer [every? select-keys #?(:clj doseq) some mapv update-keys empty? not-empty]]
+ [metabase.util.performance :refer [every? select-keys #?(:clj doseq) some mapv update-keys empty? not-empty]]
[metabase.util.time :as u.time]))
(defn infer-mbql-clause-schema
@@ -298,7 +298,7 @@
(lib.schema.common/disallowed-keys {:lib/uuid "MBQL 4 refs should not have :lib/uuid"})
[:fn
{:error/message "MBQL 4 :expression options should not be empty, use a nil map instead"
- :decode/normalize perf/not-empty}
+ :decode/normalize not-empty}
seq]])
(mr/def ::ExpressionName
@@ -341,7 +341,7 @@
(lib.schema.common/disallowed-keys {:lib/uuid "MBQL 4 refs should not have :lib/uuid"})
[:fn
{:error/message "MBQL 4 :field ref options should not be empty, use nil instead"
- :decode/normalize perf/not-empty}
+ :decode/normalize not-empty}
seq]]])
(mr/def ::require-base-type-for-field-name
@@ -2120,7 +2120,7 @@
(defclause* dimension
[:and
- [:fn {:error/message "must be a `:dimension` clause"} (partial helpers/is-clause? :dimension)]
+ [:fn {:error/message "must be a `:dimension` clause"} (partial is-clause? :dimension)]
[:catn
[:tag [:= :dimension]]
[:target [:schema [:or [:ref ::FieldOrExpressionRef] [:ref ::template-tag]]]]
diff --git a/src/metabase/legacy_mbql/util.cljc b/src/metabase/legacy_mbql/util.cljc
index 7ea82f60808..4fa3c3d963a 100644
--- a/src/metabase/legacy_mbql/util.cljc
+++ b/src/metabase/legacy_mbql/util.cljc
@@ -3,7 +3,7 @@
DEPRECATED: Use [[metabase.lib.core]] for MBQL manipulation in all new code."
{:deprecated "0.57.0"}
- (:refer-clojure :exclude [replace some mapv every? not-empty get-in #?(:clj for)])
+ (:refer-clojure :exclude [some mapv every? not-empty get-in #?(:clj for)])
(:require
#?@(:clj
[[metabase.legacy-mbql.jvm-util :as mbql.jvm-u]])
diff --git a/src/metabase/lib/aggregation.cljc b/src/metabase/lib/aggregation.cljc
index d7c246998f1..0627cebc96b 100644
--- a/src/metabase/lib/aggregation.cljc
+++ b/src/metabase/lib/aggregation.cljc
@@ -1,5 +1,6 @@
(ns metabase.lib.aggregation
- (:refer-clojure :exclude [count distinct max min var select-keys mapv empty? not-empty #?(:clj doseq) #?(:clj for)])
+ {:clj-kondo/ignore [:unused-excluded-var]}
+ (:refer-clojure :exclude [count distinct max min select-keys mapv empty? not-empty #?(:clj doseq) #?(:clj for)])
(:require
[clojure.string :as str]
[medley.core :as m]
diff --git a/src/metabase/lib/core.cljc b/src/metabase/lib/core.cljc
index 76b2e6471a1..6e279f9c287 100644
--- a/src/metabase/lib/core.cljc
+++ b/src/metabase/lib/core.cljc
@@ -49,8 +49,9 @@
existing calls when practical. Will be unexported when there are no callers left. Docstrings should suggest an
alternative to calling these functions.
- **Deprecated:** Stronger than Leak - the function should be removed altogether, not just unexported."
+ {:clj-kondo/ignore [:unused-excluded-var]}
(:refer-clojure :exclude [filter remove replace and or not = < <= > ->> >= not-empty case count distinct max min
- + - * / time abs concat replace ref var float])
+ + - * / time abs concat replace ref float])
(:require
[metabase.lib.aggregation :as lib.aggregation]
[metabase.lib.binning :as lib.binning]
diff --git a/src/metabase/lib/expression.cljc b/src/metabase/lib/expression.cljc
index 2443b03290a..7560b88167c 100644
--- a/src/metabase/lib/expression.cljc
+++ b/src/metabase/lib/expression.cljc
@@ -1,5 +1,5 @@
(ns metabase.lib.expression
- (:refer-clojure :exclude [+ - * / case coalesce abs time concat replace float mapv some select-keys not-empty get-in every?
+ (:refer-clojure :exclude [+ - * / case abs time concat replace float mapv some select-keys not-empty get-in every?
#?(:clj doseq) #?(:clj for)])
(:require
[clojure.string :as str]
diff --git a/src/metabase/lib/filter.cljc b/src/metabase/lib/filter.cljc
index 9c9b07ae8b1..fca9e6eabfb 100644
--- a/src/metabase/lib/filter.cljc
+++ b/src/metabase/lib/filter.cljc
@@ -1,5 +1,5 @@
(ns metabase.lib.filter
- (:refer-clojure :exclude [filter and or not = < <= > >= not-empty case every? some mapv empty? not-empty
+ (:refer-clojure :exclude [filter and or not = < <= > >= not-empty every? some mapv empty? not-empty
#?(:clj doseq) #?(:clj for)])
(:require
[clojure.string :as str]
diff --git a/src/metabase/lib/js/metadata.cljc b/src/metabase/lib/js/metadata.cljc
index 8376b87961a..227a9170b86 100644
--- a/src/metabase/lib/js/metadata.cljc
+++ b/src/metabase/lib/js/metadata.cljc
@@ -1,5 +1,4 @@
(ns metabase.lib.js.metadata
- (:refer-clojure :exclude [keywordize-keys])
(:require
#?@(:clj (#_{:clj-kondo/ignore [:discouraged-namespace]}
[metabase.legacy-mbql.normalize :as legacy-mbql.normalize])
diff --git a/src/metabase/lib/query.cljc b/src/metabase/lib/query.cljc
index 5d36c54073b..376b1362825 100644
--- a/src/metabase/lib/query.cljc
+++ b/src/metabase/lib/query.cljc
@@ -1,5 +1,5 @@
(ns metabase.lib.query
- (:refer-clojure :exclude [remove some select-keys mapv empty? #?(:clj for)])
+ (:refer-clojure :exclude [some select-keys mapv empty? #?(:clj for)])
(:require
[medley.core :as m]
;; allowed since this is needed to convert legacy queries to MBQL 5
diff --git a/src/metabase/lib/query/test_spec.cljc b/src/metabase/lib/query/test_spec.cljc
index 475872eb12e..769fefe6595 100644
--- a/src/metabase/lib/query/test_spec.cljc
+++ b/src/metabase/lib/query/test_spec.cljc
@@ -1,5 +1,5 @@
(ns metabase.lib.query.test-spec
- (:refer-clojure :exclude [mapv name empty?])
+ (:refer-clojure :exclude [mapv name])
(:require
[malli.core :as mc]
[malli.transform :as mtx]
diff --git a/src/metabase/lib/types/isa.cljc b/src/metabase/lib/types/isa.cljc
index 10f594f1e5c..eec1fda6b3a 100644
--- a/src/metabase/lib/types/isa.cljc
+++ b/src/metabase/lib/types/isa.cljc
@@ -1,6 +1,6 @@
(ns metabase.lib.types.isa
"Ported from frontend/src/metabase-lib/types/utils/isa.js"
- (:refer-clojure :exclude [isa? any? boolean? number? string? integer? some])
+ (:refer-clojure :exclude [isa? any? boolean? string? integer? some])
(:require
[metabase.lib.types.constants :as lib.types.constants]
[metabase.types.core]
diff --git a/src/metabase/lib/util/match.cljs b/src/metabase/lib/util/match.cljs
index a3a2fef3dcb..a5113869eb2 100644
--- a/src/metabase/lib/util/match.cljs
+++ b/src/metabase/lib/util/match.cljs
@@ -1,5 +1,4 @@
(ns metabase.lib.util.match
- (:refer-clojure :exclude [replace])
(:require
[clojure.core.match]
[metabase.lib.util.match.impl])
diff --git a/src/metabase/llm/settings.clj b/src/metabase/llm/settings.clj
index cee522968d5..f10e4c22512 100644
--- a/src/metabase/llm/settings.clj
+++ b/src/metabase/llm/settings.clj
@@ -38,7 +38,7 @@
:visibility :public
:setter :none
:export? false
- :getter #(boolean (some? (llm-anthropic-api-key)))
+ :getter #(some? (llm-anthropic-api-key))
:doc false)
(defsetting llm-anthropic-model
@@ -149,7 +149,7 @@
:visibility :settings-manager
:export? false
:setter :none
- :getter #(boolean (some? (llm-proxy-base-url)))
+ :getter #(some? (llm-proxy-base-url))
:doc false)
;;; -------------------------------------------------- General --------------------------------------------------
diff --git a/src/metabase/premium_features/defenterprise.clj b/src/metabase/premium_features/defenterprise.clj
index 25230ed6b48..4b8d8976eaf 100644
--- a/src/metabase/premium_features/defenterprise.clj
+++ b/src/metabase/premium_features/defenterprise.clj
@@ -94,7 +94,7 @@
(let [oss-or-ee (if (in-ee?) :ee :oss)]
(case oss-or-ee
:ee (validate-ee-args options)
- :oss (validate-oss-args '~ee-ns options))
+ :oss (validate-oss-args ee-ns options))
`(let [ee-ns# '~(or ee-ns (ns-name *ns*))
ee-fn-name# (symbol (str ee-ns# "/" '~fn-name))
oss-or-ee-fn# ~(if schema?
diff --git a/src/metabase/query_processor/middleware/add_implicit_joins.clj b/src/metabase/query_processor/middleware/add_implicit_joins.clj
index 87dc29664f5..d171e0061df 100644
--- a/src/metabase/query_processor/middleware/add_implicit_joins.clj
+++ b/src/metabase/query_processor/middleware/add_implicit_joins.clj
@@ -1,7 +1,7 @@
(ns metabase.query-processor.middleware.add-implicit-joins
"Middleware that creates corresponding `:joins` for Tables referred to by `:field` clauses with `:source-field` info
in the options and adds `:join-alias` info to those `:field` clauses."
- (:refer-clojure :exclude [alias mapv some empty? not-empty get-in])
+ (:refer-clojure :exclude [mapv some empty? not-empty get-in])
(:require
[better-cond.core :as b]
[clojure.set :as set]
diff --git a/src/metabase/query_processor/middleware/large_int.clj b/src/metabase/query_processor/middleware/large_int.clj
index f07c949ff5a..6583d25e6bd 100644
--- a/src/metabase/query_processor/middleware/large_int.clj
+++ b/src/metabase/query_processor/middleware/large_int.clj
@@ -3,7 +3,7 @@
(:refer-clojure :exclude [mapv])
(:require
^{:clj-kondo/ignore [:deprecated-namespace]} [metabase.query-processor.store :as qp.store]
- [metabase.util.performance :as perf :refer [mapv]])
+ [metabase.util.performance :refer [mapv]])
(:import
(clojure.lang BigInt)
(java.math BigDecimal BigInteger)))
@@ -61,7 +61,7 @@
"Converts all large integer row values to strings."
[column-index-mask rf]
((map (fn [row]
- (perf/mapv #(if %2 (maybe-large-int->string %1) %1) row column-index-mask)))
+ (mapv #(if %2 (maybe-large-int->string %1) %1) row column-index-mask)))
rf))
(defn- maybe-integer-column?
diff --git a/src/metabase/query_processor/middleware/resolve_joins.clj b/src/metabase/query_processor/middleware/resolve_joins.clj
index 68bb9804f2c..1c73d1b8b4c 100644
--- a/src/metabase/query_processor/middleware/resolve_joins.clj
+++ b/src/metabase/query_processor/middleware/resolve_joins.clj
@@ -1,7 +1,7 @@
(ns metabase.query-processor.middleware.resolve-joins
"Middleware that fetches tables that will need to be joined, referred to by `:field` clauses with `:source-field`
options, and adds information to the query about what joins should be done and how they should be performed."
- (:refer-clojure :exclude [alias every? mapv empty?])
+ (:refer-clojure :exclude [every? mapv empty?])
(:require
[clojure.string :as str]
[medley.core :as m]
diff --git a/src/metabase/query_processor/preprocess.clj b/src/metabase/query_processor/preprocess.clj
index 61313a6483d..3c81e60ebe0 100644
--- a/src/metabase/query_processor/preprocess.clj
+++ b/src/metabase/query_processor/preprocess.clj
@@ -142,7 +142,7 @@
[query <>])))
;; make sure the middleware returns a valid query... this should be dev-facing only so no need to i18n
(when-not (map? <>)
- (throw (ex-info (format "Middleware did not return a valid query.")
+ (throw (ex-info "Middleware did not return a valid query."
{:fn middleware-fn, :query query, :result <>, :type qp.error-type/qp})))))
(catch Throwable e
(let [middleware-fn middleware-fn]
diff --git a/src/metabase/query_processor/streaming/csv.clj b/src/metabase/query_processor/streaming/csv.clj
index 241ed1f3ea3..77ce0868541 100644
--- a/src/metabase/query_processor/streaming/csv.clj
+++ b/src/metabase/query_processor/streaming/csv.clj
@@ -9,7 +9,7 @@
[metabase.query-processor.settings :as qp.settings]
[metabase.query-processor.streaming.common :as streaming.common]
[metabase.query-processor.streaming.interface :as qp.si]
- [metabase.util.performance :as perf :refer [mapv]])
+ [metabase.util.performance :refer [mapv]])
(:import
(java.io BufferedWriter OutputStream OutputStreamWriter)
(java.nio.charset StandardCharsets)))
@@ -131,15 +131,15 @@
(if pivot-group
;; Non-pivoted pivot table: we have to remove the pivot-grouping column
(when (= qp.pivot.postprocess/non-pivot-row-group (int pivot-group))
- (let [formatted-row (->> (perf/mapv (fn [formatter r]
- (formatter (streaming.common/format-value r)))
- @ordered-formatters ordered-row)
+ (let [formatted-row (->> (mapv (fn [formatter r]
+ (formatter (streaming.common/format-value r)))
+ @ordered-formatters ordered-row)
(m/remove-nth pivot-grouping-index))]
(write-csv writer [formatted-row])))
;; All other results: write directly to the CSV
- (let [formatted-row (perf/mapv (fn [formatter r]
- (formatter (streaming.common/format-value r)))
- @ordered-formatters ordered-row)]
+ (let [formatted-row (mapv (fn [formatter r]
+ (formatter (streaming.common/format-value r)))
+ @ordered-formatters ordered-row)]
(write-csv writer [formatted-row]))))))
(finish! [_ _]
diff --git a/src/metabase/query_processor/util/add_alias_info.clj b/src/metabase/query_processor/util/add_alias_info.clj
index d3d035a9b37..7f324cdcd5a 100644
--- a/src/metabase/query_processor/util/add_alias_info.clj
+++ b/src/metabase/query_processor/util/add_alias_info.clj
@@ -40,7 +40,7 @@
If this clause is 'selected' (i.e., appears in `:fields`, `:aggregation`, or `:breakout`), select the clause `AS`
this alias. This alias is guaranteed to be unique."
- (:refer-clojure :exclude [mapv ref select-keys some empty? not-empty get-in])
+ (:refer-clojure :exclude [mapv select-keys some empty? not-empty get-in])
(:require
[medley.core :as m]
[metabase.config.core :as config]
diff --git a/src/metabase/request/session.clj b/src/metabase/request/session.clj
index a315c3580f1..06875441874 100644
--- a/src/metabase/request/session.clj
+++ b/src/metabase/request/session.clj
@@ -1,8 +1,6 @@
(ns metabase.request.session
(:require
- [metabase.api.common
- :as api
- :refer [*current-user* *current-user-id* *current-user-permissions-set* *is-group-manager?* *is-superuser?* *is-data-analyst?*]]
+ [metabase.api.common :refer [*current-user* *current-user-id* *current-user-permissions-set* *is-group-manager?* *is-superuser?* *is-data-analyst?*]]
[metabase.permissions.core :as perms]
[metabase.request.schema :as request.schema]
[metabase.settings.core :as setting]
@@ -77,7 +75,7 @@
[thunk]
(do-with-current-user
(merge
- (with-current-user-fetch-user-for-id api/*current-user-id*)
+ (with-current-user-fetch-user-for-id *current-user-id*)
{:is-superuser? true
:permissions-set #{"/"}
:user-locale i18n/*user-locale*})
diff --git a/src/metabase/search/impl.clj b/src/metabase/search/impl.clj
index 6e44871d8c1..b2da6d81d79 100644
--- a/src/metabase/search/impl.clj
+++ b/src/metabase/search/impl.clj
@@ -445,7 +445,7 @@
(mu/defn search
"Builds a search query that includes all the searchable entities, and runs it."
- [search-ctx :- search.config/SearchContext]
+ [search-ctx :- SearchContext]
(tracing/with-span :search "search.execute" {:search/engine (name (:search-engine search-ctx))
:search/query-length (count (:search-string search-ctx))
:search/model-count (count (:models search-ctx))}
diff --git a/src/metabase/util/encryption.clj b/src/metabase/util/encryption.clj
index ecfc678784f..3cfafbca3f0 100644
--- a/src/metabase/util/encryption.clj
+++ b/src/metabase/util/encryption.clj
@@ -208,7 +208,7 @@
(if (nil? b)
false
(u/ignore-exceptions
- (when-let [byte-length (alength b)]
+ (let [byte-length (alength b)]
(zero? (mod (- byte-length aes256-tag-length)
aes256-block-size))))))
diff --git a/src/metabase/util/i18n.clj b/src/metabase/util/i18n.clj
index 4049c536380..81a0fd9263b 100644
--- a/src/metabase/util/i18n.clj
+++ b/src/metabase/util/i18n.clj
@@ -248,7 +248,7 @@
;; number of {n} placeholders in format string *not* including ones you make have skipped. e.g. "{0} {2}" -> 2
num-args (count (.getFormats message-format))]
(assert (and (<= num-args-by-index 1) (<= num-args 1))
- (format "(deferred-)trsn/trun only supports a single {0} placeholder for the value `n`"))))]
+ "(deferred-)trsn/trun only supports a single {0} placeholder for the value `n`")))]
(validate format-string)
(validate format-string-pl)))
diff --git a/src/metabase/util/log.clj b/src/metabase/util/log.clj
index 9946a4d70a1..a34ab954ce7 100644
--- a/src/metabase/util/log.clj
+++ b/src/metabase/util/log.clj
@@ -2,6 +2,7 @@
"Common logging interface that wraps clojure.tools.logging in JVM Clojure and Glogi in CLJS.
The interface is the same as [[clojure.tools.logging]]."
+ {:clj-kondo/ignore [:unquote-not-syntax-quoted]}
(:require
[clojure.edn :as edn]
[clojure.java.io :as io]
diff --git a/src/metabase/util/malli/registry.cljc b/src/metabase/util/malli/registry.cljc
index eea10eef694..d8269e5a34c 100644
--- a/src/metabase/util/malli/registry.cljc
+++ b/src/metabase/util/malli/registry.cljc
@@ -1,5 +1,4 @@
(ns metabase.util.malli.registry
- (:refer-clojure :exclude [declare def])
(:require
#?(:clj [metabase.config.core :as config])
#?@(:clj ([malli.experimental.time :as malli.time]
diff --git a/test/metabase/app_db/internal_user_test.clj b/test/metabase/app_db/internal_user_test.clj
index 43dbb93dfcf..22c36da4fbe 100644
--- a/test/metabase/app_db/internal_user_test.clj
+++ b/test/metabase/app_db/internal_user_test.clj
@@ -14,7 +14,7 @@
:user_group_memberships
(->> (map :id)))
all-users-id (t2/select-one-pk :model/PermissionsGroup :name "All Users")]
- (is [all-users-id] memberships))))
+ (is all-users-id memberships))))
(deftest internal-user-is-unmodifiable-via-api-test
(testing "GET /api/user"
diff --git a/test/metabase/collections/models/collection_test.clj b/test/metabase/collections/models/collection_test.clj
index 3574e255757..c99025ee8cb 100644
--- a/test/metabase/collections/models/collection_test.clj
+++ b/test/metabase/collections/models/collection_test.clj
@@ -1,5 +1,5 @@
(ns metabase.collections.models.collection-test
- (:refer-clojure :exclude [ancestors descendants])
+ (:refer-clojure :exclude [descendants])
(:require
[clojure.math.combinatorics :as math.combo]
[clojure.set :as set]
diff --git a/test/metabase/dashboards_rest/api_test.clj b/test/metabase/dashboards_rest/api_test.clj
index 57aecb150af..f33219220a4 100644
--- a/test/metabase/dashboards_rest/api_test.clj
+++ b/test/metabase/dashboards_rest/api_test.clj
@@ -3598,7 +3598,7 @@
(deftest ^:parallel valid-filter-fields-test
(testing "GET /api/dashboard/params/valid-filter-fields"
(letfn [(result= [expected {:keys [filtered filtering]}]
- (testing (format "\nGET dashboard/params/valid-filter-fields")
+ (testing "\nGET dashboard/params/valid-filter-fields"
(is (= expected
(mt/user-http-request :rasta :get 200 "dashboard/params/valid-filter-fields"
:filtered filtered :filtering filtering)))))]
diff --git a/test/metabase/driver/sql_jdbc/connection_test.clj b/test/metabase/driver/sql_jdbc/connection_test.clj
index f675b159d59..3a05e1debdd 100644
--- a/test/metabase/driver/sql_jdbc/connection_test.clj
+++ b/test/metabase/driver/sql_jdbc/connection_test.clj
@@ -244,7 +244,7 @@
(get props "dataSourceName"))]
(is (some? db-nm))
;; ensure that, for any sql-jdbc driver anyway, we found *some* DB name to use in this String
- (is (not= db-nm "null"))))))
+ (is (not= "null" db-nm))))))
(deftest ^:parallel same-connection-details-result-in-equal-specs-test
(testing "Two JDBC specs created with the same details must be considered equal for the connection pool cache to work correctly"
@@ -308,7 +308,7 @@
(testing "hash value calculated correctly for new pooled conn"
(is (some? pool-spec-1))
(is (integer? db-hash-1))
- (is (not= db-hash-1 0)))
+ (is (not= 0 db-hash-1)))
(testing "changing DB details results in hash value changing and connection being invalidated"
(let [db-perturbed (perturb-db-details db)]
(testing "The calculated hash should be different"
@@ -335,7 +335,7 @@
(is (some? pool-spec-2))
(is (= 1 @hash-change-called-times) "One hash change should have been logged")
(is (integer? db-hash-2))
- (is (not= db-hash-2 0))
+ (is (not= 0 db-hash-2))
(is (not= db-hash-1 db-hash-2)))))))
(finally
;; restore the original test DB details, no matter what just happened
diff --git a/test/metabase/driver/test_util.clj b/test/metabase/driver/test_util.clj
index 4dd8666987b..001027721bd 100644
--- a/test/metabase/driver/test_util.clj
+++ b/test/metabase/driver/test_util.clj
@@ -44,6 +44,6 @@
.start)]
sshd)
(catch Throwable e
- (throw (ex-info (format "Error starting SSH mock server with password")
+ (throw (ex-info "Error starting SSH mock server with password"
{:username username :password password}
e)))))
diff --git a/test/metabase/embedding_rest/api/embed_test.clj b/test/metabase/embedding_rest/api/embed_test.clj
index 4ab15f67f10..e8feecef04a 100644
--- a/test/metabase/embedding_rest/api/embed_test.clj
+++ b/test/metabase/embedding_rest/api/embed_test.clj
@@ -178,8 +178,8 @@
(with-embedding-enabled-and-new-secret-key!
(let [card-url (str "embed/card/" (sign {:resource {:question "8"}
:params {}}))]
- (is #(re-matches #"Invalid input:.+value must be an integer greater than zero.+got.+8"
- (client/client :get 400 card-url))))))
+ (is (re-find #"Invalid input:.+value must be an integer greater than zero.+got.+8"
+ (client/client :get 400 card-url))))))
(deftest check-that-the-endpoint-doesn-t-work-if-embedding-isn-t-enabled
(mt/with-temporary-setting-values [enable-embedding false]
diff --git a/test/metabase/events/recent_views_test.clj b/test/metabase/events/recent_views_test.clj
index 2b20fca0205..b7b1dc94d86 100644
--- a/test/metabase/events/recent_views_test.clj
+++ b/test/metabase/events/recent_views_test.clj
@@ -52,7 +52,7 @@
(mt/with-temp [:model/Dashboard dashboard {:creator_id (mt/user->id :rasta)}]
(mt/with-test-user :rasta
(events/publish-event! :event/dashboard-read {:object-id (:id dashboard) :user-id (mt/user->id :rasta)})
- (is (partial
+ (is (=
{:user_id (mt/user->id :rasta)
:model "dashboard"
:model_id (:id dashboard)}
diff --git a/test/metabase/pulse/dashboard_subscription_test.clj b/test/metabase/pulse/dashboard_subscription_test.clj
index 9369725d594..21622270350 100644
--- a/test/metabase/pulse/dashboard_subscription_test.clj
+++ b/test/metabase/pulse/dashboard_subscription_test.clj
@@ -860,12 +860,12 @@
{:text (format "### [New Dashboard name](%s/dashboard/%d)\nLinked Dashboard desc" site-url dashboard-id)}
{:text (format "### [New Card name](%s/question/%d)\nLinked card desc" site-url card-id)}
{:text (format "### [New Card name](%s/question/%d)\nLinked model desc" site-url model-id)}
- {:text (format "### [https://metabase.com](https://metabase.com)")}]
+ {:text "### [https://metabase.com](https://metabase.com)"}]
(execute-dashboard (:id dashboard) collection-owner-id nil))))
(testing "it should filter out models that current users does not have permission to read"
(is (=? [{:text (format "### [New Database name](%s/browse/%d)\nLinked database desc" site-url database-id)}
{:text (format "### [Linked table dname](%s/question?db=%d&table=%d)\nLinked table desc" site-url database-id table-id)}
- {:text (format "### [https://metabase.com](https://metabase.com)")}]
+ {:text "### [https://metabase.com](https://metabase.com)"}]
(execute-dashboard (:id dashboard) (mt/user->id :lucky) nil)))))))))
(deftest iframe-cards-are-skipped-test
@@ -911,13 +911,13 @@
{:text (format "### [New Dashboard name](%s/dashboard/%d)\nLinked Dashboard desc" site-url dashboard-id)}
{:text (format "### [New Card name](%s/question/%d)\nLinked card desc" site-url card-id)}
{:text (format "### [New Card name](%s/question/%d)\nLinked model desc" site-url model-id)}
- {:text (format "### [https://metabase.com](https://metabase.com)")}]
+ {:text "### [https://metabase.com](https://metabase.com)"}]
(execute-dashboard (:id dashboard) collection-owner-id nil))))
(testing "it should filter out models that current users does not have permission to read"
(is (=? [{:text (format "### [New Database name](%s/browse/%d)\nLinked database desc" site-url database-id)}
{:text (format "### [Linked table dname](%s/question?db=%d&table=%d)\nLinked table desc" site-url database-id table-id)}
- {:text (format "### [https://metabase.com](https://metabase.com)")}]
+ {:text "### [https://metabase.com](https://metabase.com)"}]
(execute-dashboard (:id dashboard) (mt/user->id :lucky) nil)))))))))
(deftest execute-dashboard-with-tabs-test
diff --git a/test/metabase/query_processor/parameters_test.clj b/test/metabase/query_processor/parameters_test.clj
index f4cf86463d3..47171ea3ff0 100644
--- a/test/metabase/query_processor/parameters_test.clj
+++ b/test/metabase/query_processor/parameters_test.clj
@@ -628,7 +628,7 @@
(is (= "Organic"
people-source)))
(testing "state != OR"
- (is (not= people-state "OR")))))
+ (is (not= "OR" people-state)))))
(testing "Should contain row with 'Emilie Goyette'"
(is (some (fn [[_orders-id _orders-created-at _people-state people-name _people-source :as _row]]
(= people-name "Emilie Goyette"))
diff --git a/test/metabase/query_processor/remapping_test.clj b/test/metabase/query_processor/remapping_test.clj
index 57380aae73a..8d1f9fff776 100644
--- a/test/metabase/query_processor/remapping_test.clj
+++ b/test/metabase/query_processor/remapping_test.clj
@@ -562,7 +562,7 @@
(qp/process-query query))))))))
(deftest ^:parallel fk-remapped-should-remap-test
- (testing (format "Check that we return the title when it's remapped")
+ (testing "Check that we return the title when it's remapped"
(let [mp (-> (mt/metadata-provider)
(lib.tu/remap-metadata-provider (mt/id :orders :product_id)
(mt/id :products :title)))
diff --git a/test/metabase/task_history/api_test.clj b/test/metabase/task_history/api_test.clj
index ff9b1ad879f..1dd0bbd5f9b 100644
--- a/test/metabase/task_history/api_test.clj
+++ b/test/metabase/task_history/api_test.clj
@@ -495,8 +495,8 @@
:status :success)]
(is (= 2 (-> response :total)))
(is (= 1 (-> response :data count)))
- (is [{:duration 10000}]
- (-> response :data vec)))))))
+ (is (=? [{:duration 10000}]
+ (-> response :data vec))))))))
;;; +----------------------------------------------------------------------------------------------------------------+
;;; | Task Runs API tests |
diff --git a/test/metabase/task_test.clj b/test/metabase/task_test.clj
index b28e5d2b63c..d5c99e34942 100644
--- a/test/metabase/task_test.clj
+++ b/test/metabase/task_test.clj
@@ -120,7 +120,7 @@
(deftest start-scheduler-no-op-with-env-var-test
(tu/do-with-unstarted-temp-scheduler!
(^:once fn* []
- (testing (format "task/start-scheduler! should no-op When MB_DISABLE_SCHEDULER is set")
+ (testing "task/start-scheduler! should no-op When MB_DISABLE_SCHEDULER is set"
(testing "Sanity check"
(is (not (qs/started? (#'task/scheduler)))))
(mt/with-temp-env-var-value! ["MB_DISABLE_SCHEDULER" "TRUE"]
diff --git a/test/metabase/warehouse_schema_rest/api/table_test.clj b/test/metabase/warehouse_schema_rest/api/table_test.clj
index 1fc3a696b32..0eee595e35b 100644
--- a/test/metabase/warehouse_schema_rest/api/table_test.clj
+++ b/test/metabase/warehouse_schema_rest/api/table_test.clj
@@ -742,7 +742,7 @@
:database_id (mt/id)
:dataset_query {:database (mt/id)
:type :native
- :native {:query (format "SELECT NAME, ID, PRICE, LATITUDE FROM VENUES")}}}]
+ :native {:query "SELECT NAME, ID, PRICE, LATITUDE FROM VENUES"}}}]
;; run the Card which will populate its result_metadata column
(mt/user-http-request :crowberto :post 202 (format "card/%d/query" (u/the-id card)))
;; Now fetch the metadata for this "table"
@@ -858,7 +858,7 @@
:database_id (mt/id)
:dataset_query {:database (mt/id)
:type :native
- :native {:query (format "SELECT NAME, LAST_LOGIN FROM USERS")}}}]
+ :native {:query "SELECT NAME, LAST_LOGIN FROM USERS"}}}]
(let [card-virtual-table-id (str "card__" (u/the-id card))]
;; run the Card which will populate its result_metadata column
(mt/user-http-request :crowberto :post 202 (format "card/%d/query" (u/the-id card)))
diff --git a/test/metabase/warehouses/models/database_test.clj b/test/metabase/warehouses/models/database_test.clj
index f84c7f0fa3a..3cf6ad6a7a3 100644
--- a/test/metabase/warehouses/models/database_test.clj
+++ b/test/metabase/warehouses/models/database_test.clj
@@ -356,7 +356,7 @@
(database/maybe-test-and-migrate-details! db)))
(is (= (:details db)
(t2/select-one-fn :details :model/Database (:id db)))
- [(:id db) "query"])))))))
+ (str [(:id db) "query"]))))))))
(deftest maybe-test-and-migrate-details!-password-test
(mt/with-driver
diff --git a/test/metabase/warehouses_rest/api_test.clj b/test/metabase/warehouses_rest/api_test.clj
index 4b9b769e634..a8af32d5b74 100644
--- a/test/metabase/warehouses_rest/api_test.clj
+++ b/test/metabase/warehouses_rest/api_test.clj
@@ -124,7 +124,7 @@
:database_id (mt/id)
:dataset_query {:database (mt/id)
:type :native
- :native {:query (format "SELECT * FROM VENUES")}}}
+ :native {:query "SELECT * FROM VENUES"}}}
kvs))
(defn- card-with-mbql-query [card-name & {:as inner-query-clauses}]
@@ -2982,27 +2982,27 @@
(mt/with-temp [:model/Database {id :id} {}]
(is (mt/user-http-request :crowberto :get 400 (str "database/" id "/healthcheck?connection-type=invalid")))))))
-(setting/defsetting api-test-missing-premium-feature
+(defsetting api-test-missing-premium-feature
"A feature used for testing /settings-available (1)"
:type :boolean
:database-local :only
:feature :forever-withheld-feature)
-(setting/defsetting api-test-missing-driver-feature
+(defsetting api-test-missing-driver-feature
"A feature used for testing /settings-available (2)"
:type :boolean
:database-local :only
;; Something h2 will never support
:driver-feature :test/jvm-timezone-setting)
-(setting/defsetting api-test-disabled-for-database
+(defsetting api-test-disabled-for-database
"A feature used for testing /settings-available (3)"
:type :boolean
:default false
:database-local :only
:enabled-for-db? (constantly false))
-(setting/defsetting api-test-disabled-for-custom-reasons
+(defsetting api-test-disabled-for-custom-reasons
"A feature used for testing /settings-available (4)"
:type :boolean
:database-local :only
@@ -3010,7 +3010,7 @@
(setting/custom-disabled-reasons! [{:key :custom/one, :type :warning, :message "Because..."}
{:key :custom/two, :type :warning, :message "Also..."}])))
-(setting/defsetting api-test-disabled-for-multiple-reasons
+(defsetting api-test-disabled-for-multiple-reasons
"A feature used for testing /settings-available (5)"
:type :boolean
:database-local :only
diff --git a/test/metabase/xrays/test_util/automagic_dashboards.clj b/test/metabase/xrays/test_util/automagic_dashboards.clj
index 9e69601cdf1..0f821660c7f 100644
--- a/test/metabase/xrays/test_util/automagic_dashboards.clj
+++ b/test/metabase/xrays/test_util/automagic_dashboards.clj
@@ -48,7 +48,7 @@
Tests that the dashboard has (the correct number of) cards, the queries for those cards are valid,
all related URLs are valid, and that it has correct metadata."
[dashboard cardinality]
- (testing (format "Dashboard should be valid")
+ (testing "Dashboard should be valid"
(testing (format "\nDashboard =\n%s\n" (u/pprint-to-str dashboard))
(testing "Dashboard should have a name"
(is (some? (:name dashboard))))