The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
More generic error message on transform timeout (#76071)
Nicola Momettofe44abd20ae1
diff --git a/src/metabase/transforms/models/job_run.clj b/src/metabase/transforms/models/job_run.cljindex 2e04451af2b..ef107d4dd3e 100644--- a/src/metabase/transforms/models/job_run.clj+++ b/src/metabase/transforms/models/job_run.clj@@ -89,7 +89,7 @@{:model :model/TransformJobRun:active [:= :is_active true]:stale [:< :last_heartbeat (rt/cutoff stale-minutes :minute)]- :terminal {:status "timeout" :end_time :%now :is_active nil :message "Timed out: no heartbeat"}+ :terminal {:status "timeout" :end_time :%now :is_active nil :message "Timed out: crashed"}:metrics {:total-metric :metabase-transforms/timeouts-total:latency-metric :metabase-transforms/timeout-detection-latency-ms:tags {:type "job"}diff --git a/src/metabase/transforms/models/transform_run.clj b/src/metabase/transforms/models/transform_run.cljindex fbb61e714ed..3179e76a186 100644--- a/src/metabase/transforms/models/transform_run.clj+++ b/src/metabase/transforms/models/transform_run.clj@@ -192,7 +192,7 @@"Time out active runs whose `last_heartbeat` is older than `stale-minutes` (their owning process ispresumed dead). Returns the rows that were timed out."[stale-minutes]- (reap-transform-runs! :last_heartbeat stale-minutes :minute "Timed out: no heartbeat"))+ (reap-transform-runs! :last_heartbeat stale-minutes :minute "Timed out: crashed"))(defn cancel-old-canceling-runs!"Atomically force-cancels active runs whose cancelation requests are older than `age` `unit`. Returns thediff --git a/test/metabase/transforms/heartbeat_test.clj b/test/metabase/transforms/heartbeat_test.cljindex ef76ce2d143..1a1bcb89e3b 100644--- a/test/metabase/transforms/heartbeat_test.clj+++ b/test/metabase/transforms/heartbeat_test.clj@@ -111,7 +111,7 @@(is (= :timeout (t2/select-one-fn :status :model/TransformRun :id stale-id)))(is (= :started (t2/select-one-fn :status :model/TransformRun :id fresh-id)))(testing "reaped row carries the distinguishing message"- (is (= "Timed out: no heartbeat"+ (is (= "Timed out: crashed"(t2/select-one-fn :message :model/TransformRun :id stale-id))))))(testing "a second sweep finds nothing (row already inactive)"(is (empty? (transform-run/reap-orphaned-runs! 5))))))))@@ -171,7 +171,7 @@(is (= [stale-id] (mapv :id reaped)))(is (= :timeout (t2/select-one-fn :status :model/TransformJobRun :id stale-id)))(is (= :started (t2/select-one-fn :status :model/TransformJobRun :id fresh-id)))- (is (= "Timed out: no heartbeat"+ (is (= "Timed out: crashed"(t2/select-one-fn :message :model/TransformJobRun :id stale-id)))))(testing "a second sweep finds nothing (row already inactive)"(is (empty? (job-run/reap-orphaned-runs! 5))))))))diff --git a/test/metabase/transforms/jobs_test.clj b/test/metabase/transforms/jobs_test.cljindex a96f02e668e..f06263ac7f2 100644--- a/test/metabase/transforms/jobs_test.clj+++ b/test/metabase/transforms/jobs_test.clj@@ -303,7 +303,7 @@(#'jobs/reap-orphaned-runs!)(is (=? {:status :timeout:is_active nil- :message "Timed out: no heartbeat"}+ :message "Timed out: crashed"}(t2/select-one :model/TransformJobRun :id (:id run)))))))))(deftest job-run-with-tranform-run-failure-test