The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Restore admin-permissions.cy.spec.js e2e test file (#66765)
Andersonfe84b44bb389
diff --git a/e2e/test/scenarios/permissions/admin-permissions.cy.spec.js b/e2e/test/scenarios/permissions/admin-permissions.cy.spec.jsnew file mode 100644index 00000000000..114db7a7e1c--- /dev/null+++ b/e2e/test/scenarios/permissions/admin-permissions.cy.spec.js@@ -0,0 +1,762 @@+const { H } = cy;+import { SAMPLE_DB_ID, USER_GROUPS } from "e2e/support/cypress_data";+import {+ ORDERS_DASHBOARD_ID,+ ORDERS_QUESTION_ID,+} from "e2e/support/cypress_sample_instance_data";++const { ALL_USERS_GROUP, ADMIN_GROUP, COLLECTION_GROUP, DATA_GROUP } =+ USER_GROUPS;++const COLLECTION_ACCESS_PERMISSION_INDEX = 0;++const NATIVE_QUERIES_PERMISSION_INDEX = 0;++describe("scenarios > admin > permissions", { tags: "@OSS" }, () => {+ beforeEach(() => {+ H.restore();+ cy.signInAsAdmin();+ });++ it("shows hidden tables", () => {+ H.DataModel.visit({ databaseId: SAMPLE_DB_ID });+ cy.icon("eye_crossed_out").eq(0).click();++ cy.visit(+ `admin/permissions/data/group/${ALL_USERS_GROUP}/database/${SAMPLE_DB_ID}`,+ );++ H.assertPermissionTable([+ ["Accounts", "No"],+ ["Analytic Events", "No"],+ ["Feedback", "No"],+ ["Invoices", "No"],+ ["Orders", "No"],+ ["People", "No"],+ ["Products", "No"],+ ["Reviews", "No"],+ ]);+ });++ it("should not show view data column on OSS", () => {+ cy.visit(`/admin/permissions/data/group/${ALL_USERS_GROUP}`);++ cy.findByTestId("permission-table").within(() => {+ cy.findByText("Database name").should("exist");+ cy.findByText("View data").should("not.exist");+ cy.findByText("Create queries").should("exist");+ });+ });++ it("should display error on failed save", () => {+ // revoke some permissions+ cy.visit(`/admin/permissions/data/group/${ALL_USERS_GROUP}`);+ cy.icon("close").first().click();+ cy.findAllByRole("option").contains("Query builder and native").click();++ // stub out the PUT and save+ cy.intercept("PUT", "/api/permissions/graph", (req) => {+ req.reply(500, "Server error");+ });+ // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ cy.contains("Save changes").click();+ cy.contains("button", "Yes").click();++ // see error modal+ // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ cy.contains("Server error");+ // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ cy.contains("There was an error saving");+ });++ context("collection permissions", () => {+ it("warns about leaving with unsaved changes", () => {+ cy.visit("/admin/permissions/collections");++ H.selectSidebarItem("First collection");++ H.modifyPermission(+ "All Users",+ COLLECTION_ACCESS_PERMISSION_INDEX,+ "View",+ true,+ );++ // Navigation to other collection should not show any warnings+ H.selectSidebarItem("Our analytics");++ H.modal().should("not.exist");++ // Switching to data permissions page+ cy.get("label").contains("Data").click();++ H.modal().within(() => {+ cy.findByText("Discard your changes?");+ cy.findByText(+ "Your changes haven't been saved, so you'll lose them if you navigate away.",+ );++ cy.button("Cancel").click();+ });++ cy.url().should("include", "/admin/permissions/collections/root");++ // Switching to data permissions page again+ cy.get("label").contains("Data").click();++ H.modal().button("Discard changes").click();++ cy.url().should("include", "/admin/permissions/data/group");+ });++ it("allows to view and edit permissions", () => {+ cy.visit("/admin/permissions/collections");++ const collections = ["Our analytics", "First collection"];+ H.assertSidebarItems(collections);++ H.selectSidebarItem("First collection");+ H.assertSidebarItems([...collections, "Second collection"]);++ H.selectSidebarItem("Second collection");++ H.assertPermissionTable([+ ["Administrators", "Curate"],+ ["All Users", "No access"],+ ["collection", "Curate"],+ ["data", "No access"],+ ["nosql", "No access"],+ ["readonly", "View"],+ ]);++ H.modifyPermission(+ "All Users",+ COLLECTION_ACCESS_PERMISSION_INDEX,+ "View",+ true,+ );++ // Navigate to children+ H.selectSidebarItem("Third collection");++ H.assertPermissionTable([+ ["Administrators", "Curate"],+ ["All Users", "View"], // Check permission has been propagated+ ["collection", "Curate"],+ ["data", "No access"],+ ["nosql", "No access"],+ ["readonly", "View"],+ ]);++ // Navigate to parent+ H.selectSidebarItem("First collection");++ H.assertPermissionTable([+ ["Administrators", "Curate"],+ ["All Users", "No access"],+ ["collection", "Curate"],+ ["data", "No access"],+ ["nosql", "No access"],+ ["readonly", "View"],+ ]);++ H.modifyPermission(+ "All Users",+ COLLECTION_ACCESS_PERMISSION_INDEX,+ "Curate",+ false,+ );++ H.selectSidebarItem("Second collection");++ H.assertPermissionTable([+ ["Administrators", "Curate"],+ ["All Users", "View"], // Check permission has not been propagated+ ["collection", "Curate"],+ ["data", "No access"],+ ["nosql", "No access"],+ ["readonly", "View"],+ ]);++ cy.button("Save changes").click();++ H.modal().within(() => {+ cy.findByText("Save permissions?");+ cy.findByText("Are you sure you want to do this?");+ cy.button("Yes").click();+ });++ // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ cy.findByText("Save changes").should("not.exist");++ H.assertPermissionTable([+ ["Administrators", "Curate"],+ ["All Users", "View"],+ ["collection", "Curate"],+ ["data", "No access"],+ ["nosql", "No access"],+ ["readonly", "View"],+ ]);+ });+ });++ it("don't propagate permissions after turning off 'Also change sub-collections' toggle (#30494)", () => {+ cy.visit("/admin/permissions/collections");++ const collections = ["Our analytics", "First collection"];+ H.assertSidebarItems(collections);++ H.selectSidebarItem("First collection");+ H.assertSidebarItems([...collections, "Second collection"]);++ H.selectSidebarItem("Second collection");++ H.assertPermissionTable([+ ["Administrators", "Curate"],+ ["All Users", "No access"],+ ["collection", "Curate"],+ ["data", "No access"],+ ["nosql", "No access"],+ ["readonly", "View"],+ ]);++ H.modifyPermission(+ "All Users",+ COLLECTION_ACCESS_PERMISSION_INDEX,+ "View",+ true, // Turn 'Also change sub-collections' toggle on+ );++ H.modifyPermission(+ "All Users",+ COLLECTION_ACCESS_PERMISSION_INDEX,+ null,+ false, // Turn 'Also change sub-collections' toggle off+ );++ // Navigate to children+ H.selectSidebarItem("Third collection");++ H.assertPermissionTable([+ ["Administrators", "Curate"],+ ["All Users", "No access"], // Check permission hasn't been propagated+ ["collection", "Curate"],+ ["data", "No access"],+ ["nosql", "No access"],+ ["readonly", "View"],+ ]);+ });++ it("show selected option for the collection with children", () => {+ cy.visit("/admin/permissions/collections");++ const collections = ["Our analytics", "First collection"];+ H.assertSidebarItems(collections);++ H.selectSidebarItem("First collection");+ H.assertSidebarItems([...collections, "Second collection"]);++ H.selectSidebarItem("Second collection");+ H.selectPermissionRow("All Users", COLLECTION_ACCESS_PERMISSION_INDEX);+ H.assertPermissionOptions(["Curate", "View", "No access"]);++ H.selectSidebarItem("Third collection");+ H.selectPermissionRow("All Users", COLLECTION_ACCESS_PERMISSION_INDEX);++ H.assertPermissionOptions(["Curate", "View"]);+ });++ context("data permissions", () => {+ it("warns about leaving with unsaved changes", () => {+ cy.visit("/admin/permissions");++ H.selectSidebarItem("All Users");++ H.modifyPermission(+ "Sample Database",+ NATIVE_QUERIES_PERMISSION_INDEX,+ "Query builder and native",+ );++ // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ cy.findByText("You've made changes to permissions.");++ // Switching to databases focus should not show any warnings+ cy.get("label").contains("Databases").click();++ cy.url().should("include", "/admin/permissions/data/database");+ H.modal().should("not.exist");++ // Switching to collection permissions page+ cy.get("label").contains("Collection").click();++ H.modal().within(() => {+ cy.findByText("Discard your changes?");+ cy.findByText(+ "Your changes haven't been saved, so you'll lose them if you navigate away.",+ );++ cy.button("Cancel").click();+ });++ cy.url().should("include", "/admin/permissions/data/database");++ // Switching to collection permissions page again+ cy.get("label").contains("Collection").click();++ H.modal().button("Discard changes").click();++ cy.url().should("include", "/admin/permissions/collections");+ });++ context("group focused view", () => {+ it("shows filterable list of groups", () => {+ cy.visit("/admin/permissions");++ // no groups selected initially and it shows an empty state+ // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ cy.findByText("Select a group to see its data permissions");++ const groups = [+ "Administrators",+ "All Users",+ "collection",+ "data",+ "nosql",+ "readonly",+ ];++ H.assertSidebarItems(groups);++ // filter groups+ cy.findByPlaceholderText("Search for a group").type("a");++ const filteredGroups = [+ "Administrators",+ "All Users",+ "data",+ "readonly",+ ];++ // client filter debounce+ cy.wait(300);++ H.assertSidebarItems(filteredGroups);+ });++ it("allows to only view Administrators permissions", () => {+ cy.visit("/admin/permissions");++ H.selectSidebarItem("Administrators");++ cy.url().should(+ "include",+ `/admin/permissions/data/group/${ADMIN_GROUP}`,+ );++ // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ cy.findByText("Permissions for the Administrators group");+ // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ cy.findByText("1 person");++ H.assertPermissionTable([+ ["Sample Database", "Query builder and native"],+ ]);++ // Drill down to tables permissions+ cy.findByTextEnsureVisible("Sample Database").click();++ H.assertPermissionTable([+ ["Accounts", "Query builder and native"],+ ["Analytic Events", "Query builder and native"],+ ["Feedback", "Query builder and native"],+ ["Invoices", "Query builder and native"],+ ["Orders", "Query builder and native"],+ ["People", "Query builder and native"],+ ["Products", "Query builder and native"],+ ["Reviews", "Query builder and native"],+ ]);+ });++ it("should show a modal when a revision changes while an admin is editing", () => {+ cy.intercept("/api/permissions/graph/group/1").as("graph");+ cy.visit("/admin/permissions");++ H.selectSidebarItem("collection");++ H.modifyPermission(+ "Sample Database",+ NATIVE_QUERIES_PERMISSION_INDEX,+ "Query builder and native",+ );++ cy.get("@graph").then((data) => {+ cy.request("PUT", "/api/permissions/graph", {+ groups: {},+ revision: data.response.body.revision,+ }).then(() => {+ H.selectSidebarItem("data");++ H.modal().findByText("Someone just changed permissions");+ });+ });+ });+ });++ context("database focused view", () => {+ it("should show a modal when a revision changes while an admin is editing", () => {+ cy.intercept("/api/permissions/graph/group/1").as("graph");+ cy.visit("/admin/permissions/");++ H.selectSidebarItem("collection");++ H.modifyPermission(+ "Sample Database",+ NATIVE_QUERIES_PERMISSION_INDEX,+ "Query builder and native",+ );++ cy.get("@graph").then((data) => {+ cy.request("PUT", "/api/permissions/graph", {+ groups: {},+ revision: data.response.body.revision,+ }).then(() => {+ cy.get("label").contains("Databases").click();+ H.selectSidebarItem("Sample Database");++ H.modal().findByText("Someone just changed permissions");+ });+ });+ });+ });+ });+});++describe("scenarios > admin > permissions", () => {+ beforeEach(() => {+ H.restore();+ cy.signInAsAdmin();+ H.activateToken("pro-self-hosted");+ });++ it("Visualization and Settings query builder buttons are not visible for questions that use blocked data sources", () => {+ cy.updatePermissionsGraph({+ [ALL_USERS_GROUP]: {+ [SAMPLE_DB_ID]: {+ "view-data": "blocked",+ },+ },+ [COLLECTION_GROUP]: {+ [SAMPLE_DB_ID]: {+ "view-data": "blocked",+ },+ },+ });++ cy.signIn("nodata");+ H.visitQuestion(ORDERS_QUESTION_ID);++ H.queryBuilderMain().findByText(+ "Sorry, you don't have permission to run this query.",+ );+ H.queryBuilderFooter()+ .findByTestId("viz-settings-button")+ .should("not.exist");+ H.queryBuilderFooter().findByText("Visualization").should("not.exist");+ });++ it("shows permission error for cards that use blocked data sources", () => {+ cy.updatePermissionsGraph({+ [ALL_USERS_GROUP]: {+ [SAMPLE_DB_ID]: {+ "view-data": "blocked",+ },+ },+ [COLLECTION_GROUP]: {+ [SAMPLE_DB_ID]: {+ "view-data": "blocked",+ },+ },+ });++ cy.signIn("nodata");+ H.visitDashboard(ORDERS_DASHBOARD_ID);++ // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ cy.findByText("Sorry, you don't have permission to see this card.");+ });+});++describe("scenarios > admin > permissions", () => {+ beforeEach(() => {+ H.restore();+ cy.signInAsAdmin();+ });++ it("shows permissions help", () => {+ cy.visit("/admin/permissions");++ // Data permissions w/o `legacy-no-self-service` in graph+ cy.get("main").within(() => {+ cy.findByText("Permissions help").as("permissionHelpButton").click();+ cy.get("@permissionHelpButton").should("not.exist");+ });++ cy.findByLabelText("Permissions help reference").within(() => {+ cy.findByText("Data permissions");++ cy.findByText("Database ‘View data’ levels").click();+ cy.findByTestId("database-view-data-level").should(+ "not.contain",+ /No self-service/,+ );+ cy.findByText("Database ‘View data’ levels").click();++ cy.findByText(/Schema or table ‘View data’ levels/).click();+ cy.findByTestId("schema-table-level").should(+ "not.contain",+ /No self-service/,+ );+ cy.findByText(/Schema or table ‘View data’ levels/).click();++ cy.findByText("‘Create queries’ levels");++ cy.findByLabelText("Close").click();+ });++ // Data permissions w/ `legacy-no-self-service` in graph+ cy.visit("/admin/permissions");++ cy.intercept("GET", `/api/permissions/graph/group/${ALL_USERS_GROUP}`, {+ statusCode: 200,+ body: {+ revision: 1,+ groups: {+ 1: {+ 1: {+ "view-data": "legacy-no-self-service",+ "create-queries": "query-builder-and-native",+ download: { schemas: "full" },+ },+ },+ },+ },+ });++ cy.get("main").within(() => {+ cy.findByText("Permissions help").as("permissionHelpButton").click();+ cy.get("@permissionHelpButton").should("not.exist");+ });++ cy.findByLabelText("Permissions help reference")+ .as("permissionsHelpContent")+ .within(() => {+ cy.findByText("Database ‘View data’ levels").click();+ cy.findAllByText(/No self-service/);+ cy.findByLabelText("Close").click();+ });++ cy.get("main").within(() => {+ cy.findByText("Collections").click();+ cy.get("@permissionHelpButton").click();+ });++ // Collection permissions+ cy.get("@permissionsHelpContent").within(() => {+ cy.findByText("Collection permissions");+ cy.findByText("Collections Permission Levels");+ });++ // The help reference keeps being open when switching tabs+ cy.get("main").within(() => {+ cy.findByText("Data").click();+ });++ cy.get("@permissionsHelpContent").within(() => {+ cy.findByText("Data permissions");+ });+ });++ it("should show a dismissable modal and banner showing split permission changes (#metabase#45073", () => {+ // We need a way to pass true values for these settings in CI. Generally in CI, these values will always be false+ // because we always start with a fresh instance. However, to test the flow of someone who has upgraded from 49 -> current+ // we set them to false and ensure a modal is shown explaining the new permissions structure+ const tempState = {+ "show-updated-permission-modal": true,+ "show-updated-permission-banner": true,+ };++ // When the app calls for session properties, give them a modified API response+ cy.intercept("/api/session/properties", (req) => {+ req.continue((res) => {+ res.body = { ...res.body, ...tempState };+ });+ }).as("sessionProps");++ // These calls are setting the permission to false, so update the local state. When the settings are refreshed+ // from the browser, they will get the new values from local state+ cy.intercept("api/setting/show-updated-permission-modal", () => {+ tempState["show-updated-permission-modal"] = false;+ });++ cy.intercept("api/setting/show-updated-permission-banner", () => {+ tempState["show-updated-permission-banner"] = false;+ });++ cy.visit("/admin/permissions/");+ cy.wait("@sessionProps");++ cy.findByRole("dialog", { name: /permissions may look different/ })+ .findByRole("button", { name: "Got it" })+ .click();+ cy.wait("@sessionProps");++ cy.findByRole("menuitem", { name: "All Users" }).click();+ cy.findByRole("alert").should(+ "contain.text",+ "Your data permissions may look different",+ );+ cy.findByRole("alert").findByRole("button").click();++ //Cypress will error if the page refreshes while it's also intercepting a request+ cy.wait("@sessionProps");++ cy.reload();++ cy.findByRole("dialog", { name: /permissions may look different/ }).should(+ "not.exist",+ );+ cy.findByRole("alert").should("not.exist");+ });++ it("split permission change modal should dismiss even if network request fails", () => {+ // We need a way to pass true values for these settings in CI. Generally in CI, these values will always be false+ // because we always start with a fresh instance. However, to test the flow of someone who has upgraded from 49 -> current+ // we set them to false and ensure a modal is shown explaining the new permissions structure+ const tempState = {+ "show-updated-permission-modal": true,+ };++ // When the app calls for session properties, give them a modified API response+ cy.intercept("/api/session/properties", (req) => {+ req.continue((res) => {+ res.body = { ...res.body, ...tempState };+ });+ }).as("sessionProps");++ // These calls are setting the permission to false, so update the local state. When the settings are refreshed+ // from the browser, they will get the new values from local state+ cy.intercept("api/setting/show-updated-permission-modal", {+ statusCode: 500,+ });++ cy.visit("/admin/permissions/");+ cy.wait("@sessionProps");++ cy.findByRole("dialog", { name: /permissions may look different/ })+ .findByRole("button", { name: "Got it" })+ .click();+ cy.wait("@sessionProps");++ cy.findByRole("menuitem", { name: "All Users" }).click();+ });+});++describe("scenarios > admin > permissions", () => {+ beforeEach(() => {+ H.restore();+ cy.signInAsAdmin();+ });++ context("partial updates", () => {+ it("partial data permission updates should not remove permissions from other unmodified groups", () => {+ // check the we have an expected initial state+ cy.visit(`admin/permissions/data/group/${DATA_GROUP}`);+ H.assertPermissionTable([+ ["Sample Database", "Query builder and native"],+ ]);++ // make a change to the permissions of another group+ H.selectSidebarItem("nosql");+ H.assertPermissionTable([["Sample Database", "Query builder only"]]);+ H.modifyPermission(+ "Sample Database",+ NATIVE_QUERIES_PERMISSION_INDEX,+ "No",+ );++ // observe the save change request and assert that we don't get back+ // values for groups we did not modify+ cy.intercept("PUT", "/api/permissions/graph").as("updateGraph");++ // save changes+ cy.button("Save changes").click();+ H.modal().within(() => {+ cy.button("Yes").click();+ });++ cy.wait("@updateGraph").then((interception) => {+ const requestGroupIds = Object.keys(interception.request.body.groups);+ const responseGroupIds = Object.keys(interception.response.body.groups);+ expect(requestGroupIds).to.deep.equal(responseGroupIds);+ });++ // make sure that our other group's permission data did not get changed+ H.selectSidebarItem("data");+ H.assertPermissionTable([+ ["Sample Database", "Query builder and native"],+ ]);+ });++ it("partial collection permission updates should not prevent user from making further changes", () => {+ cy.visit("/admin/permissions/collections");++ H.selectSidebarItem("First collection");++ H.modifyPermission(+ "All Users",+ COLLECTION_ACCESS_PERMISSION_INDEX,+ "View",+ false,+ );++ cy.intercept("PUT", "/api/collection/graph?skip-graph=true").as(+ "updateGraph",+ );++ cy.button("Save changes").click();+ H.modal().within(() => {+ cy.button("Yes").click();+ });++ cy.wait("@updateGraph").then((interception) => {+ cy.log("should skip graph in request and response");+ expect(interception.response.body).to.not.haveOwnProperty("groups");+ });++ H.selectSidebarItem("First collection");++ H.modifyPermission(+ "nosql",+ COLLECTION_ACCESS_PERMISSION_INDEX,+ "Curate",+ false,+ );++ cy.button("Save changes").click();+ H.modal().within(() => {+ cy.button("Yes").click();+ });++ cy.wait("@updateGraph").then((interception) => {+ cy.log("should not send previously saved edits");+ expect(interception.request.body.groups).to.not.haveOwnProperty(+ USER_GROUPS.ALL_USERS_GROUP,+ );++ cy.log("should not fail when making multiple rounds of edits");+ expect(interception.response.statusCode).to.equal(200);+ });+ });+ });+});