Skip to content

armgit / mimik

Public Imported from GitHub
0

🎬 A browser extension and desktop app that turns your clicks into step-by-step guides with annotated screenshots πŸ“–

fix(editor): stop capping the length of a typed guide title

davbio1e246c5e73f4
diff --git a/AGENTS.md b/AGENTS.md
index 07cb113..58b562b 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -274,5 +274,5 @@ Font: Poppins (loaded via `@fontsource/poppins`).
- **Font loading** uses `@fontsource/poppins` (CSP-safe, no CDN dependency)
- **Cross-context sync** via BroadcastChannel β€” star/delete events update other views without full reload
- **Bundle export flattens before it ships** β€” `redact` annotations are drawn at render time, so `screenshot.blob` still holds the unblurred capture. `flattenScreenshot` burns redactions into the pixels and drops the annotation, and bakes an *explicit* crop (rebasing annotations and resolving `bounds` into an explicit target). The automatic zoom-to-target crop stays as data. Anything that ships a screenshot outside the browser must go through the renderer
-- **Guide titles are single-line**, normalised by `sanitizeGuideTitle` on every write path: `updateGuideTitle`, `importGuide`, `revertToSnapshot` and the AI meta path. Each renderer downstream already assumed it. The HTML and PDF covers clamp to `MAX_TITLE_LINES`, their running headers to one line, the video cover card wraps to two, the sidepanel truncates, and Markdown writes `# <title>`, where a newline ends the heading and spills the rest into the body. A fifth write path needs the same call. The 70-character cap is a UI affordance only and is deliberately *not* applied on write, so a title recorded before the cap keeps its full text instead of losing its tail to a focus and a blur
+- **Guide titles are single-line**, normalised by `sanitizeGuideTitle` on every write path: `updateGuideTitle`, `importGuide`, `revertToSnapshot` and the AI meta path. Each renderer downstream already assumed it. The HTML and PDF covers clamp to `MAX_TITLE_LINES`, their running headers to one line, the video cover card wraps to two, the sidepanel truncates, and Markdown writes `# <title>`, where a newline ends the heading and spills the rest into the body. A fifth write path needs the same call. `MAX_TITLE_LENGTH` bounds the AI-generated title only (`core/capture/ai/meta.ts`); a typed title is deliberately uncapped, since every renderer above already clamps and a silent stop at 70 characters gave the user no reason for it
- **Imports re-mint every id** β€” `importGuide` mints new guide/step/screenshot ids in one Dexie transaction. Reusing the ids in the file would let a shared guide overwrite one the recipient recorded. It also clears `aiPending`, which no background job will ever resolve for an imported step
diff --git a/src/ui/fullview/GuideContent.tsx b/src/ui/fullview/GuideContent.tsx
index 28c90da..915567f 100644
--- a/src/ui/fullview/GuideContent.tsx
+++ b/src/ui/fullview/GuideContent.tsx
@@ -14,7 +14,7 @@ import {
updateStepDescription,
} from '@/core/guides/service';
import type { SnapshotLike } from '@/core/guides/snapshot-diff';
-import { MAX_TITLE_LENGTH, sanitizeGuideTitle, stripTitleLineBreaks } from '@/core/guides/title';
+import { sanitizeGuideTitle, stripTitleLineBreaks } from '@/core/guides/title';
import type { Guide, Screenshot, Snapshot, Step } from '@/core/guides/types';
import type { ScreenshotEdits } from '@/core/screenshot/types';
import { localStorage, openSidebar } from '@/lib/browser-api';
@@ -363,7 +363,6 @@ export default function GuideContent({ guideId, initialStepId, initialTool }: Gu
}}
value={title}
rows={1}
- maxLength={Math.max(MAX_TITLE_LENGTH, title.length)}
onChange={(e) => {
const next = stripTitleLineBreaks(e.target.value);
setTitle(next);