Skip to content

armgit / mimik

Public Imported from GitHub
0

🎬 A browser extension and desktop app that turns your clicks into step-by-step guides with annotated screenshots 📖

fix: start a new capture from the dashboard's Start capture button

Luis Ortiz23f1371d338c
diff --git a/apps/extension/src/capture/start-insert-recording.ts b/apps/extension/src/capture/start-recording-in-tab.ts
similarity index 78%
rename from apps/extension/src/capture/start-insert-recording.ts
rename to apps/extension/src/capture/start-recording-in-tab.ts
index 6151719..d2f4f8e 100644
--- a/apps/extension/src/capture/start-insert-recording.ts
+++ b/apps/extension/src/capture/start-recording-in-tab.ts
@@ -1,3 +1,4 @@
+import type { CaptureInsert } from '@mimik/core/capture/capture-insert';
import { logger } from '@mimik/core/logger';
import { focusWindow } from '@/lib/browser-api/focus-window';
import { getTab } from '@/lib/browser-api/get-tab';
@@ -6,11 +7,7 @@ import { updateTab } from '@/lib/browser-api/update-tab';
import { sendMessage } from '@/lib/messaging';
import { isRecordableUrl } from './recordable-tabs';
-export async function startInsertRecording(
- guideId: string,
- insertAtIndex: number,
- tabId: number,
-): Promise<string | null> {
+export async function startRecordingInTab(tabId: number, insert?: CaptureInsert): Promise<string | null> {
if (!(await requestHostPermissions())) {
logger.warn('Host permissions not granted, cannot start recording');
return null;
@@ -28,8 +25,7 @@ export async function startInsertRecording(
try {
const res = await sendMessage('startRecording', {
url: tab?.url || '',
- insertTargetGuideId: guideId,
- insertAtIndex,
+ ...(insert && { insertTargetGuideId: insert.insertTargetGuideId, insertAtIndex: insert.insertAtIndex }),
});
return res.guideId ?? null;
} catch (err) {
diff --git a/apps/extension/src/ui/fullview/App.tsx b/apps/extension/src/ui/fullview/App.tsx
index b0ca164..8e001ac 100644
--- a/apps/extension/src/ui/fullview/App.tsx
+++ b/apps/extension/src/ui/fullview/App.tsx
@@ -2,7 +2,7 @@ import type { CaptureInsert } from '@mimik/core/capture/capture-insert';
import { AppFrame, GuidePage, LibraryContent, SearchModal, TooltipProvider, UpdateNotice, useRoute } from '@mimik/ui';
import { useState } from 'react';
import { browser } from '#imports';
-import { startInsertRecording } from '@/capture/start-insert-recording';
+import { startRecordingInTab } from '@/capture/start-recording-in-tab';
import { openSidebar } from '@/lib/browser-api/open-sidebar';
import { sendMessage } from '@/lib/messaging';
import { useUpdateNotice } from '@/ui/shared/hooks/use-update-notice';
@@ -11,14 +11,14 @@ import { CaptureTabDialog } from './components/CaptureTabDialog';
export function FullViewApp() {
const route = useRoute();
- const [pendingInsert, setPendingInsert] = useState<CaptureInsert | null>(null);
+ const [pendingCapture, setPendingCapture] = useState<{ insert?: CaptureInsert } | null>(null);
const updateNotice = useUpdateNotice();
return (
<TooltipProvider>
<AppFrame
route={route}
- onStartCapture={openSidebar}
+ onStartCapture={() => setPendingCapture({})}
onSettings={() => browser.runtime.openOptionsPage()}
settingsExternal
>
@@ -36,7 +36,7 @@ export function FullViewApp() {
guideId={route.guideId}
initialStepId={route.stepId}
initialTool={route.tool}
- onCaptureMore={setPendingInsert}
+ onCaptureMore={(insert) => setPendingCapture({ insert })}
onGuideMe={(guideId) => {
openSidebar();
void sendMessage('startGuideMe', { guideId });
@@ -45,14 +45,15 @@ export function FullViewApp() {
)}
<CaptureTabDialog
- open={pendingInsert !== null}
- onCancel={() => setPendingInsert(null)}
+ open={pendingCapture !== null}
+ inserting={pendingCapture?.insert !== undefined}
+ onCancel={() => setPendingCapture(null)}
onStart={(tabId) => {
- const target = pendingInsert;
- setPendingInsert(null);
+ const target = pendingCapture;
+ setPendingCapture(null);
if (!target) return;
openSidebar();
- void startInsertRecording(target.insertTargetGuideId, target.insertAtIndex, tabId);
+ void startRecordingInTab(tabId, target.insert);
}}
/>
diff --git a/apps/extension/src/ui/fullview/components/CaptureTabDialog.tsx b/apps/extension/src/ui/fullview/components/CaptureTabDialog.tsx
index f680fdb..84d2043 100644
--- a/apps/extension/src/ui/fullview/components/CaptureTabDialog.tsx
+++ b/apps/extension/src/ui/fullview/components/CaptureTabDialog.tsx
@@ -6,11 +6,12 @@ import { getRecordableTabs, type RecordableTab } from '@/capture/recordable-tabs
interface CaptureTabDialogProps {
open: boolean;
+ inserting: boolean;
onCancel: () => void;
onStart: (tabId: number) => void;
}
-export function CaptureTabDialog({ open, onCancel, onStart }: CaptureTabDialogProps) {
+export function CaptureTabDialog({ open, inserting, onCancel, onStart }: CaptureTabDialogProps) {
const [tabs, setTabs] = useState<RecordableTab[]>([]);
const [selected, setSelected] = useState<number | null>(null);
@@ -24,8 +25,10 @@ export function CaptureTabDialog({ open, onCancel, onStart }: CaptureTabDialogPr
<Dialog open={open} onOpenChange={(next) => !next && onCancel()}>
<DialogContent className="sm:max-w-[400px]">
<DialogHeader>
- <DialogTitle>{i18n.t('capture.moreStepsTitle')}</DialogTitle>
- <DialogDescription>{i18n.t('capture.moreStepsBody')}</DialogDescription>
+ <DialogTitle>{i18n.t(inserting ? 'capture.moreStepsTitle' : 'capture.startCapture')}</DialogTitle>
+ <DialogDescription>
+ {i18n.t(inserting ? 'capture.moreStepsBody' : 'capture.newCaptureBody')}
+ </DialogDescription>
</DialogHeader>
<div className="max-h-[240px] overflow-y-auto flex flex-col gap-1.5">
{tabs.length === 0 ? (
diff --git a/packages/locales/de.yml b/packages/locales/de.yml
index 29cfab4..a2bab2e 100644
--- a/packages/locales/de.yml
+++ b/packages/locales/de.yml
@@ -365,6 +365,7 @@ capture:
recordSteps: "Schritte aufnehmen"
moreStepsTitle: Weitere Schritte aufnehmen
moreStepsBody: "Neue Schritte werden hier eingefügt. Wähle den Tab für die Aufnahme."
+ newCaptureBody: Wähle den Tab, in dem aufgenommen werden soll.
startCapture: Aufnahme starten
noRecordableTabs: "In diesem Fenster ist kein Tab zum Aufnehmen offen."
diff --git a/packages/locales/en.yml b/packages/locales/en.yml
index 06e2c7a..e5adc5b 100644
--- a/packages/locales/en.yml
+++ b/packages/locales/en.yml
@@ -365,6 +365,7 @@ capture:
recordSteps: Record steps
moreStepsTitle: Capture more steps
moreStepsBody: New steps are inserted here. Choose the tab to record in.
+ newCaptureBody: Choose the tab to record in.
startCapture: Start capture
noRecordableTabs: No recordable tabs are open in this window.
diff --git a/packages/locales/es.yml b/packages/locales/es.yml
index 96464d0..60b1a07 100644
--- a/packages/locales/es.yml
+++ b/packages/locales/es.yml
@@ -365,6 +365,7 @@ capture:
recordSteps: Grabar pasos
moreStepsTitle: Capturar más pasos
moreStepsBody: "Los nuevos pasos se insertan aquí. Elige la pestaña que quieres grabar."
+ newCaptureBody: Elige la pestaña en la que grabar.
startCapture: "Empezar a capturar"
noRecordableTabs: No hay pestañas grabables abiertas en esta ventana.
diff --git a/packages/locales/fr.yml b/packages/locales/fr.yml
index e9d81d9..d0239ad 100644
--- a/packages/locales/fr.yml
+++ b/packages/locales/fr.yml
@@ -365,6 +365,7 @@ capture:
recordSteps: "Enregistrer des étapes"
moreStepsTitle: "Capturer d'autres étapes"
moreStepsBody: "Les nouvelles étapes sont insérées ici. Choisissez l'onglet à enregistrer."
+ newCaptureBody: "Choisissez l'onglet à enregistrer."
startCapture: "Lancer la capture"
noRecordableTabs: "Aucun onglet enregistrable n'est ouvert dans cette fenêtre."
diff --git a/packages/locales/pt-BR.yml b/packages/locales/pt-BR.yml
index 8e21011..4a50454 100644
--- a/packages/locales/pt-BR.yml
+++ b/packages/locales/pt-BR.yml
@@ -365,6 +365,7 @@ capture:
recordSteps: "Gravar passos"
moreStepsTitle: "Capturar mais passos"
moreStepsBody: "Os novos passos entram aqui. Escolha a aba que quer gravar."
+ newCaptureBody: Escolha a aba em que gravar.
startCapture: "Começar a capturar"
noRecordableTabs: Nenhuma aba gravável está aberta nesta janela.
diff --git a/packages/locales/ru.yml b/packages/locales/ru.yml
index 0b25792..8ac9ff4 100644
--- a/packages/locales/ru.yml
+++ b/packages/locales/ru.yml
@@ -365,6 +365,7 @@ capture:
recordSteps: Записать шаги
moreStepsTitle: Записать ещё шаги
moreStepsBody: "Новые шаги будут вставлены сюда. Выберите вкладку, в которой записывать."
+ newCaptureBody: Выберите вкладку для записи.
startCapture: Начать запись
noRecordableTabs: "В этом окне нет вкладок, пригодных для записи."
diff --git a/packages/locales/zh-CN.yml b/packages/locales/zh-CN.yml
index ea2a572..f639a6d 100644
--- a/packages/locales/zh-CN.yml
+++ b/packages/locales/zh-CN.yml
@@ -365,6 +365,7 @@ capture:
recordSteps: 录制步骤
moreStepsTitle: 捕获更多步骤
moreStepsBody: 新步骤会插入到这里。请选择要录制的标签页。
+ newCaptureBody: 选择要录制的标签页。
startCapture: 开始捕获
noRecordableTabs: 当前窗口没有可录制的标签页。