Skip to content

armgit / mimik

Public Imported from GitHub
0

🎬 A browser extension and desktop app that turns your clicks into step-by-step guides with annotated screenshots πŸ“–

fix(desktop): serve the default logo to exports

Luis Ortiz3ac872f23bbc
diff --git a/apps/desktop/electron.vite.config.ts b/apps/desktop/electron.vite.config.ts
index 8a3c2bc..0c91574 100644
--- a/apps/desktop/electron.vite.config.ts
+++ b/apps/desktop/electron.vite.config.ts
@@ -51,6 +51,7 @@ export default defineConfig({
},
renderer: {
root: resolve(__dirname, 'src/renderer'),
+ publicDir: resolve(__dirname, '../../public'),
plugins: [yaml(), react(), tailwindcss()],
resolve: {
alias: {
diff --git a/apps/desktop/scripts/check-pipeline.ts b/apps/desktop/scripts/check-pipeline.ts
index 256fe30..d82fe82 100644
--- a/apps/desktop/scripts/check-pipeline.ts
+++ b/apps/desktop/scripts/check-pipeline.ts
@@ -581,6 +581,12 @@ app.whenReady().then(async () => {
});
const probeSrc = await ask<string | null>(win.webContents, 'mimik:check:screenshotSrc', activeGuide, 20_000);
+ const defaultLogo = await ask<boolean>(win.webContents, 'mimik:check:defaultLogo', undefined, 10_000);
+ results.push({
+ name: 'exports can load the default logo',
+ ok: defaultLogo === true,
+ detail: defaultLogo ? 'mimik-mark.png served beside the page' : 'mimik-mark.png did not load',
+ });
await ask(win.webContents, 'mimik:check:cleanup', [guideId, activeGuide], 30_000);
diff --git a/apps/desktop/src/renderer/check-pipeline.ts b/apps/desktop/src/renderer/check-pipeline.ts
index c398b9a..2240a6d 100644
--- a/apps/desktop/src/renderer/check-pipeline.ts
+++ b/apps/desktop/src/renderer/check-pipeline.ts
@@ -1,5 +1,6 @@
import './core-env';
import type { CaptureStepData } from '@mimik/core/capture/sink';
+import { assetUrl } from '@mimik/core/env';
import { exportGuideAsDOCX } from '@mimik/core/export/docx-export';
import { exportGuideAsHTML } from '@mimik/core/export/html-export';
import { exportGuideAsMarkdown } from '@mimik/core/export/markdown-export';
@@ -43,6 +44,12 @@ window.mimik.onRequest('mimik:check:screenshotSrc', async (payload) => {
window.mimik.onRequest('mimik:check:screenshotIds', () => allScreenshotIds());
+window.mimik.onRequest('mimik:check:defaultLogo', () =>
+ fetch(assetUrl('/mimik-mark.png'))
+ .then((response) => response.ok)
+ .catch(() => false),
+);
+
window.mimik.onRequest('mimik:check:cleanup', async (payload) => {
for (const id of payload as string[]) await permanentlyDeleteGuide(id);
return true;
diff --git a/apps/desktop/src/renderer/core-env.ts b/apps/desktop/src/renderer/core-env.ts
index 33bf229..d870465 100644
--- a/apps/desktop/src/renderer/core-env.ts
+++ b/apps/desktop/src/renderer/core-env.ts
@@ -22,7 +22,7 @@ configureCore({
client: 'desktop',
fetch: mainFetch,
t: (key, substitutions) => translate(en as Messages, key, substitutions),
- assetUrl: (path) => new URL(path, document.baseURI).href,
+ assetUrl: (path) => new URL(path.replace(/^\//, ''), document.baseURI).href,
storage: {
get: async <K extends SettingsKey>(keys: readonly K[]) => {
const out: Record<string, unknown> = {};