Skip to content

armgit / mimik

Public Imported from GitHub
0

🎬 A browser extension and desktop app that turns your clicks into step-by-step guides with annotated screenshots 📖

feat(settings): clear a saved api key from the field

Luis Ortiz3dbb039830d1
diff --git a/src/locales/de.yml b/src/locales/de.yml
index ff9e5ab..e17ae41 100644
--- a/src/locales/de.yml
+++ b/src/locales/de.yml
@@ -111,6 +111,7 @@ settings:
apiKey: API-Schlüssel
showKey: Schlüssel anzeigen
hideKey: Schlüssel verbergen
+ clearKey: Schlüssel löschen
aiLanguage: Sprache der Beschreibungen
voiceNarration: Sprachkommentar
voiceUsingAiKey: "Es ist kein Sprach-Schlüssel gesetzt, daher nutzt Mimik den OpenAI-Schlüssel aus den KI-Beschreibungen oben."
diff --git a/src/locales/en.yml b/src/locales/en.yml
index 7653e90..560cd05 100644
--- a/src/locales/en.yml
+++ b/src/locales/en.yml
@@ -99,6 +99,7 @@ settings:
apiKey: API Key
showKey: Show key
hideKey: Hide key
+ clearKey: Clear key
aiLanguage: Description Language
voiceNarration: Voice Narration
voiceUsingAiKey: "No voice key is set, so Mimik uses the OpenAI key from AI Descriptions above."
diff --git a/src/locales/es.yml b/src/locales/es.yml
index 6b1a59e..469fc27 100644
--- a/src/locales/es.yml
+++ b/src/locales/es.yml
@@ -99,6 +99,7 @@ settings:
apiKey: Clave API
showKey: Mostrar clave
hideKey: Ocultar clave
+ clearKey: Borrar clave
aiLanguage: Idioma de descripciones
voiceNarration: "Narración por voz"
voiceUsingAiKey: "No hay clave de voz, así que Mimik usa la clave de OpenAI de Descripciones con IA de arriba."
diff --git a/src/locales/fr.yml b/src/locales/fr.yml
index 43025f3..402263f 100644
--- a/src/locales/fr.yml
+++ b/src/locales/fr.yml
@@ -99,6 +99,7 @@ settings:
apiKey: "Clé API"
showKey: Afficher la clé
hideKey: Masquer la clé
+ clearKey: Effacer la clé
aiLanguage: Langue des descriptions
voiceNarration: "Narration vocale"
voiceUsingAiKey: "Aucune clé vocale n'est définie : Mimik utilise la clé OpenAI des descriptions IA ci-dessus."
diff --git a/src/locales/pt-BR.yml b/src/locales/pt-BR.yml
index 34d5e75..d532ae4 100644
--- a/src/locales/pt-BR.yml
+++ b/src/locales/pt-BR.yml
@@ -99,6 +99,7 @@ settings:
apiKey: Chave da API
showKey: Mostrar chave
hideKey: Ocultar chave
+ clearKey: Limpar chave
aiLanguage: "Idioma das descrições"
voiceNarration: "Narração por voz"
voiceUsingAiKey: "Não tem chave de voz, então o Mimik usa a chave da OpenAI das Descrições com IA lá de cima."
diff --git a/src/locales/zh-CN.yml b/src/locales/zh-CN.yml
index cb0887d..a168489 100644
--- a/src/locales/zh-CN.yml
+++ b/src/locales/zh-CN.yml
@@ -99,6 +99,7 @@ settings:
apiKey: API 密钥
showKey: 显示密钥
hideKey: 隐藏密钥
+ clearKey: 清除密钥
aiLanguage: 描述语言
voiceNarration: 语音讲解
voiceUsingAiKey: "未设置语音密钥,因此 Mimik 会使用上方 AI 描述中的 OpenAI 密钥。"
diff --git a/src/ui/shared/__tests__/key-check.test.tsx b/src/ui/shared/__tests__/key-check.test.tsx
index 64246fa..afb08a1 100644
--- a/src/ui/shared/__tests__/key-check.test.tsx
+++ b/src/ui/shared/__tests__/key-check.test.tsx
@@ -69,11 +69,11 @@ describe('SecretInput', () => {
const field = screen.getByPlaceholderText('sk-...');
expect(field).toHaveAttribute('type', 'password');
- fireEvent.click(screen.getByRole('button'));
+ fireEvent.click(screen.getByLabelText('settings.showKey'));
expect(field).toHaveAttribute('type', 'text');
expect(field).toHaveValue('sk-secret');
- fireEvent.click(screen.getByRole('button'));
+ fireEvent.click(screen.getByLabelText('settings.hideKey'));
expect(field).toHaveAttribute('type', 'password');
});
@@ -81,8 +81,24 @@ describe('SecretInput', () => {
const onChange = vi.fn();
render(<SecretInput value="" onChange={onChange} placeholder="sk-..." />);
- fireEvent.click(screen.getByRole('button'));
+ fireEvent.click(screen.getByLabelText('settings.showKey'));
fireEvent.change(screen.getByPlaceholderText('sk-...'), { target: { value: 'sk-typed' } });
expect(onChange).toHaveBeenCalledWith('sk-typed');
});
+
+ it('offers no way to clear a field that is already empty', () => {
+ render(<SecretInput value="" onChange={() => {}} placeholder="sk-..." />);
+
+ expect(screen.queryByLabelText('settings.clearKey')).toBeNull();
+ });
+
+ it('empties the key when cleared, without revealing it first', () => {
+ const onChange = vi.fn();
+ render(<SecretInput value="sk-secret" onChange={onChange} placeholder="sk-..." />);
+
+ fireEvent.click(screen.getByLabelText('settings.clearKey'));
+
+ expect(onChange).toHaveBeenCalledWith('');
+ expect(screen.getByPlaceholderText('sk-...')).toHaveAttribute('type', 'password');
+ });
});
diff --git a/src/ui/shared/key-check.tsx b/src/ui/shared/key-check.tsx
index 7b17c3d..a59c6e7 100644
--- a/src/ui/shared/key-check.tsx
+++ b/src/ui/shared/key-check.tsx
@@ -1,4 +1,4 @@
-import { Check, Eye, EyeOff, TriangleAlert } from 'lucide-react';
+import { Check, Eye, EyeOff, TriangleAlert, X } from 'lucide-react';
import { useCallback, useRef, useState } from 'react';
import { i18n } from '#imports';
import { sendMessage } from '@/lib/messaging';
@@ -138,6 +138,7 @@ export function SecretInput({
}) {
const [revealed, setRevealed] = useState(false);
const Icon = revealed ? EyeOff : Eye;
+ const iconButton = `top-1/2 -translate-y-1/2 text-muted-foreground hover:text-foreground transition-colors ${buttonClassName ?? ''}`;
return (
<div className="relative flex-1 min-w-0">
<Input
@@ -145,15 +146,26 @@ export function SecretInput({
value={value}
onChange={(e) => onChange(e.target.value)}
placeholder={placeholder}
- className={`pr-8 ${className ?? ''}`}
+ className={`${value ? 'pr-14' : 'pr-8'} ${className ?? ''}`}
/>
+ {value && (
+ <button
+ type="button"
+ onClick={() => onChange('')}
+ aria-label={i18n.t('settings.clearKey')}
+ title={i18n.t('settings.clearKey')}
+ className={`absolute right-8 ${iconButton}`}
+ >
+ <X size={13} />
+ </button>
+ )}
<button
type="button"
onClick={() => setRevealed((on) => !on)}
aria-pressed={revealed}
aria-label={i18n.t(revealed ? 'settings.hideKey' : 'settings.showKey')}
title={i18n.t(revealed ? 'settings.hideKey' : 'settings.showKey')}
- className={`absolute right-2 top-1/2 -translate-y-1/2 text-muted-foreground hover:text-foreground transition-colors ${buttonClassName ?? ''}`}
+ className={`absolute right-2 ${iconButton}`}
>
<Icon size={13} />
</button>