Skip to content

armgit / mimik

Public Imported from GitHub
0

🎬 A browser extension and desktop app that turns your clicks into step-by-step guides with annotated screenshots πŸ“–

refactor(screenshot): move dominantRatio out of the placeholder component

Luis Ortiz53ff73f00f1f
diff --git a/src/ui/shared/__tests__/image-placeholder.test.ts b/src/core/screenshot/__tests__/dominant-ratio.test.ts
similarity index 98%
rename from src/ui/shared/__tests__/image-placeholder.test.ts
rename to src/core/screenshot/__tests__/dominant-ratio.test.ts
index 8e0e4ee..6afa58a 100644
--- a/src/ui/shared/__tests__/image-placeholder.test.ts
+++ b/src/core/screenshot/__tests__/dominant-ratio.test.ts
@@ -1,6 +1,6 @@
import { describe, expect, it } from 'vitest';
import type { Screenshot } from '@/core/guides/types';
-import { dominantRatio } from '@/ui/shared/ImagePlaceholder';
+import { dominantRatio } from '@/core/screenshot/geometry';
function makeScreenshot(id: string, overrides: Partial<Screenshot> = {}): Screenshot {
return {
diff --git a/src/core/screenshot/geometry.ts b/src/core/screenshot/geometry.ts
index 3173d99..944c56f 100644
--- a/src/core/screenshot/geometry.ts
+++ b/src/core/screenshot/geometry.ts
@@ -54,6 +54,28 @@ export function resolveViewport(screenshot: Screenshot): ScreenshotBounds {
};
}
+const RATIO_BUCKET_PRECISION = 100;
+
+export function dominantRatio(screenshots: Map<string, Screenshot>): number | undefined {
+ const buckets = new Map<number, { ratio: number; count: number }>();
+
+ for (const screenshot of screenshots.values()) {
+ const viewport = resolveViewport(screenshot);
+ if (!viewport.width || !viewport.height) continue;
+ const ratio = viewport.width / viewport.height;
+ const key = Math.round(ratio * RATIO_BUCKET_PRECISION) / RATIO_BUCKET_PRECISION;
+ const bucket = buckets.get(key);
+ if (bucket) bucket.count += 1;
+ else buckets.set(key, { ratio, count: 1 });
+ }
+
+ let winner: { ratio: number; count: number } | undefined;
+ for (const bucket of buckets.values()) {
+ if (!winner || bucket.count > winner.count) winner = bucket;
+ }
+ return winner?.ratio;
+}
+
const MIN_VIEWPORT = 40;
const MIN_ANNOTATION = 8;
diff --git a/src/ui/fullview/components/GuideStepList.tsx b/src/ui/fullview/components/GuideStepList.tsx
index 41a67fc..4afa0cb 100644
--- a/src/ui/fullview/components/GuideStepList.tsx
+++ b/src/ui/fullview/components/GuideStepList.tsx
@@ -4,6 +4,7 @@ import { i18n } from '#imports';
import { isBlock, stepNumbers } from '@/core/guides/blocks';
import { createSnapshot, deleteSteps, insertBlock, reorderSteps } from '@/core/guides/service';
import type { BlockType, Screenshot, Step } from '@/core/guides/types';
+import { dominantRatio } from '@/core/screenshot/geometry';
import { logger } from '@/lib/logger';
import { useFullview } from '@/stores/fullview';
import { Button } from '@/ui/components/ui/button';
@@ -11,7 +12,6 @@ import BlockCard from '@/ui/shared/BlockCard';
import CaptureTabDialog from '@/ui/shared/CaptureTabDialog';
import ConfirmDialog from '@/ui/shared/ConfirmDialog';
import EmptyGuideState from '@/ui/shared/EmptyGuideState';
-import { dominantRatio } from '@/ui/shared/ImagePlaceholder';
import InsertBlockMenu from '@/ui/shared/InsertBlockMenu';
import StepCard from '@/ui/sidepanel/StepCard';
diff --git a/src/ui/shared/ImagePlaceholder.tsx b/src/ui/shared/ImagePlaceholder.tsx
index 1ad8fdb..82de863 100644
--- a/src/ui/shared/ImagePlaceholder.tsx
+++ b/src/ui/shared/ImagePlaceholder.tsx
@@ -1,8 +1,6 @@
import { ImageUp } from 'lucide-react';
import { useState } from 'react';
import { i18n } from '#imports';
-import type { Screenshot } from '@/core/guides/types';
-import { resolveViewport } from '@/core/screenshot/geometry';
import MascotIcon from '@/ui/shared/MascotIcon';
import ReplaceImageDialog from '@/ui/shared/ReplaceImageDialog';
@@ -53,25 +51,3 @@ export default function ImagePlaceholder({
</div>
);
}
-
-const RATIO_BUCKET_PRECISION = 100;
-
-export function dominantRatio(screenshots: Map<string, Screenshot>): number | undefined {
- const buckets = new Map<number, { ratio: number; count: number }>();
-
- for (const screenshot of screenshots.values()) {
- const viewport = resolveViewport(screenshot);
- if (!viewport.width || !viewport.height) continue;
- const ratio = viewport.width / viewport.height;
- const key = Math.round(ratio * RATIO_BUCKET_PRECISION) / RATIO_BUCKET_PRECISION;
- const bucket = buckets.get(key);
- if (bucket) bucket.count += 1;
- else buckets.set(key, { ratio, count: 1 });
- }
-
- let winner: { ratio: number; count: number } | undefined;
- for (const bucket of buckets.values()) {
- if (!winner || bucket.count > winner.count) winner = bucket;
- }
- return winner?.ratio;
-}
diff --git a/src/ui/sidepanel/GuideEditor.tsx b/src/ui/sidepanel/GuideEditor.tsx
index 85561ef..53d2036 100644
--- a/src/ui/sidepanel/GuideEditor.tsx
+++ b/src/ui/sidepanel/GuideEditor.tsx
@@ -4,6 +4,7 @@ import { i18n } from '#imports';
import { actionSteps, isBlock, stepNumbers } from '@/core/guides/blocks';
import { getGuide, onGuidesChanged } from '@/core/guides/service';
import type { Guide, Screenshot, Step } from '@/core/guides/types';
+import { dominantRatio } from '@/core/screenshot/geometry';
import { createTab, focusWindow, getExtensionURL, queryTabs, updateTab } from '@/lib/browser-api';
import { sendMessage } from '@/lib/messaging';
import { getMostCommonDomain } from '@/lib/utils';
@@ -11,7 +12,6 @@ import { Tooltip, TooltipContent, TooltipTrigger } from '@/ui/components/ui/tool
import BlockCard from '@/ui/shared/BlockCard';
import EmptyGuideState from '@/ui/shared/EmptyGuideState';
import FaviconImg from '@/ui/shared/FaviconImg';
-import { dominantRatio } from '@/ui/shared/ImagePlaceholder';
import StepCard from './StepCard';
interface GuideEditorProps {