Skip to content

armgit / mimik

Public Imported from GitHub
0

🎬 A browser extension and desktop app that turns your clicks into step-by-step guides with annotated screenshots πŸ“–

fix(extension): make discard delete the recording instead of finishing it

Luis Ortiz6d93708cf5b0
diff --git a/src/entrypoints/background/voice.ts b/src/entrypoints/background/voice.ts
index b25858b..7852e64 100644
--- a/src/entrypoints/background/voice.ts
+++ b/src/entrypoints/background/voice.ts
@@ -7,6 +7,7 @@ import { readTranscriptionSettings } from '@/core/capture/voice/read-transcripti
import { applyNarrationToSteps, findExistingStepIds, getStepsForGuide, saveTranscript } from '@/core/guides/service';
import { localStorage } from '@/lib/browser-api/local-storage';
import { onMessage as onRuntimeMessage } from '@/lib/browser-api/on-message';
+import { abortVoiceCapture } from '@/lib/offscreen/abort-voice-capture';
import { closeVoiceHost } from '@/lib/offscreen/close-voice-host';
import { closeVoiceHostIfIdle } from '@/lib/offscreen/close-voice-host-if-idle';
import { ensureVoiceHost } from '@/lib/offscreen/ensure-voice-host';
@@ -262,6 +263,13 @@ export async function flushNarrationForStep(guideId: string, stepId: string, tim
}
}
+export async function abortVoiceNarration(): Promise<void> {
+ if (!supportsVoice()) return;
+ await abortVoiceCapture().catch(() => undefined);
+ report({ phase: 'idle' });
+ await closeVoiceHostIfIdle();
+}
+
export async function stopVoiceNarration(guideId: string): Promise<void> {
if (!supportsVoice()) return;
try {
diff --git a/src/lib/messaging.ts b/src/lib/messaging.ts
index 7b6dce0..695fa18 100644
--- a/src/lib/messaging.ts
+++ b/src/lib/messaging.ts
@@ -35,6 +35,10 @@ export interface StopRecordingResponse {
inserted?: boolean;
}
+export interface DiscardRecordingResponse {
+ discarded: boolean;
+}
+
export interface StartGuideMeData {
guideId: string;
}
@@ -121,6 +125,7 @@ interface MimikProtocol {
getState(): GetStateResponse;
startRecording(data: StartRecordingData): StartRecordingResponse;
stopRecording(): StopRecordingResponse;
+ discardRecording(): DiscardRecordingResponse;
captureStep(data: CaptureStepData): CaptureStepResponse;
updateInputStep(data: UpdateInputStepData): UpdateInputStepResponse;
finalizeInputStep(data: FinalizeInputStepData): FinalizeInputStepResponse;
diff --git a/src/ui/sidepanel/App.tsx b/src/ui/sidepanel/App.tsx
index 2af68a2..8accf18 100644
--- a/src/ui/sidepanel/App.tsx
+++ b/src/ui/sidepanel/App.tsx
@@ -166,12 +166,23 @@ export function App() {
}
}, []);
+ const handleDiscardRecording = useCallback(async () => {
+ try {
+ await sendMessage('discardRecording', undefined);
+ setIsRecording(false);
+ setView({ name: 'library' });
+ } catch (err) {
+ logger.error(' DISCARD_RECORDING error', err);
+ }
+ }, []);
+
function renderView() {
if (view.name === 'recording') {
return (
<RecordingView
guideId={view.guideId}
onStop={handleStopRecording}
+ onDiscard={handleDiscardRecording}
voice={voice}
aiFailure={aiFailure}
paused={paused}
diff --git a/src/ui/sidepanel/RecordingView.tsx b/src/ui/sidepanel/RecordingView.tsx
index df59cd3..ac09f46 100644
--- a/src/ui/sidepanel/RecordingView.tsx
+++ b/src/ui/sidepanel/RecordingView.tsx
@@ -26,6 +26,7 @@ import { VoiceStatus } from './VoiceStatus';
interface RecordingViewProps {
guideId: string;
onStop: () => void;
+ onDiscard: () => void;
voice: PanelVoiceUpdate;
aiFailure: PanelAiUpdate | null;
paused: boolean;
@@ -37,7 +38,15 @@ interface LiveStep {
screenshot?: Screenshot;
}
-export function RecordingView({ guideId, onStop, voice, aiFailure, paused, pauseReason }: RecordingViewProps) {
+export function RecordingView({
+ guideId,
+ onStop,
+ onDiscard,
+ voice,
+ aiFailure,
+ paused,
+ pauseReason,
+}: RecordingViewProps) {
const [steps, setSteps] = useState<LiveStep[]>([]);
const [siteUrl, setSiteUrl] = useState('');
const [voiceEnabled, setVoiceEnabled] = useState(false);
@@ -252,7 +261,7 @@ export function RecordingView({ guideId, onStop, voice, aiFailure, paused, pause
<Tooltip>
<TooltipTrigger asChild>
<button
- onClick={onStop}
+ onClick={onDiscard}
className="w-9 h-9 shrink-0 rounded-full border border-border flex items-center justify-center transition-colors text-purple hover:border-destructive/30 hover:text-destructive"
>
<X size={16} />