Skip to content

armgit / mimik

Public Imported from GitHub
0

🎬 A browser extension and desktop app that turns your clicks into step-by-step guides with annotated screenshots 📖

feat(desktop): always read typed text from the field and leave key steps off by default

Luis Ortiz88abd43fee04
diff --git a/apps/desktop/scripts/check-pipeline.ts b/apps/desktop/scripts/check-pipeline.ts
index 0eb85a4..46b0a72 100644
--- a/apps/desktop/scripts/check-pipeline.ts
+++ b/apps/desktop/scripts/check-pipeline.ts
@@ -76,7 +76,7 @@ app.whenReady().then(async () => {
return Promise.resolve({ png: image.toPNG(), width, height, scaleFactor: scale, displayId: display.id });
}
- const REGION_MODE = { ...DEFAULT_CAPTURE_SETTINGS, captureMode: 'region' as const };
+ const REGION_MODE = { ...DEFAULT_CAPTURE_SETTINGS, captureMode: 'region' as const, recordKeys: true };
let settings = { ...REGION_MODE };
let activeGuide = '';
const recorder = new DesktopRecorder(
@@ -116,7 +116,6 @@ app.whenReady().then(async () => {
captureOutsideClicks: true,
captureKeys: false,
captureTyping: false,
- typingSmartDetection: false,
});
results.push({
name: 'settings saved under the old names carry over',
@@ -124,7 +123,6 @@ app.whenReady().then(async () => {
legacy.keepClicksBeyondArea &&
!legacy.recordKeys &&
!legacy.recordTyping &&
- !legacy.readFieldText &&
normaliseSettings({ recordTyping: true, captureTyping: false }).recordTyping,
detail: 'each old key maps onto its new name, and the new name wins when both are present',
});
diff --git a/apps/desktop/src/main/capture/recorder.ts b/apps/desktop/src/main/capture/recorder.ts
index 70384cd..ea96dff 100644
--- a/apps/desktop/src/main/capture/recorder.ts
+++ b/apps/desktop/src/main/capture/recorder.ts
@@ -413,7 +413,7 @@ export class DesktopRecorder {
await this.write('input', where, Promise.resolve(field), shot);
return;
}
- const typed = typedTextFor(field, buffer, this.settings().readFieldText && (seen?.fresh ?? true));
+ const typed = typedTextFor(field, buffer, seen?.fresh ?? true);
if (!typed) return;
await this.write('input', where, Promise.resolve(field), shot, typed);
}
diff --git a/apps/desktop/src/main/capture/settings.ts b/apps/desktop/src/main/capture/settings.ts
index f7a8d76..705e76d 100644
--- a/apps/desktop/src/main/capture/settings.ts
+++ b/apps/desktop/src/main/capture/settings.ts
@@ -25,7 +25,6 @@ export interface CaptureSettings {
recordKeys: boolean;
recordTyping: boolean;
typingDebounceMs: number;
- readFieldText: boolean;
zoomLevel: number | null;
shortcuts: CaptureShortcuts;
}
@@ -34,10 +33,9 @@ export const DEFAULT_CAPTURE_SETTINGS: CaptureSettings = {
captureMode: 'window',
screenshotDelayMs: 0,
keepClicksBeyondArea: false,
- recordKeys: true,
+ recordKeys: false,
recordTyping: true,
- typingDebounceMs: 1200,
- readFieldText: true,
+ typingDebounceMs: 1000,
zoomLevel: null,
shortcuts: {
startStop: 'Alt+Shift+R',
@@ -75,9 +73,7 @@ function snapZoom(zoom: number): number {
return Math.min(Math.max(Math.round(zoom / ZOOM_STEP) * ZOOM_STEP, MIN_ZOOM), MAX_ZOOM);
}
-type LegacySettings = Partial<
- Record<'captureOutsideClicks' | 'captureKeys' | 'captureTyping' | 'typingSmartDetection', unknown>
->;
+type LegacySettings = Partial<Record<'captureOutsideClicks' | 'captureKeys' | 'captureTyping', unknown>>;
export function normaliseSettings(input: Partial<CaptureSettings> & LegacySettings): CaptureSettings {
const delay = Number(input.screenshotDelayMs);
@@ -96,7 +92,6 @@ export function normaliseSettings(input: Partial<CaptureSettings> & LegacySettin
typingDebounceMs: Number.isFinite(debounce)
? Math.min(Math.max(Math.round(debounce), MIN_TYPING_DEBOUNCE_MS), MAX_TYPING_DEBOUNCE_MS)
: DEFAULT_CAPTURE_SETTINGS.typingDebounceMs,
- readFieldText: flag(input.readFieldText ?? input.typingSmartDetection, DEFAULT_CAPTURE_SETTINGS.readFieldText),
zoomLevel: Number.isFinite(Number(input.zoomLevel)) ? snapZoom(Number(input.zoomLevel)) : null,
shortcuts: shortcuts(input.shortcuts),
};
diff --git a/apps/desktop/src/renderer/settings/SettingsPanel.tsx b/apps/desktop/src/renderer/settings/SettingsPanel.tsx
index 7b7d504..5580269 100644
--- a/apps/desktop/src/renderer/settings/SettingsPanel.tsx
+++ b/apps/desktop/src/renderer/settings/SettingsPanel.tsx
@@ -129,14 +129,6 @@ export function SettingsPanel() {
onChange={(recordTyping) => save({ recordTyping })}
/>
</Row>
- <Row label={i18n.t('desktop_readFieldText')} hint={i18n.t('desktop_readFieldTextHint')}>
- <Switch
- checked={settings.readFieldText}
- label={i18n.t('desktop_readFieldText')}
- disabled={!settings.recordTyping}
- onChange={(readFieldText) => save({ readFieldText })}
- />
- </Row>
<Row label={i18n.t('desktop_typingDebounce')} hint={i18n.t('desktop_typingDebounceHint')}>
<Slider
label={i18n.t('desktop_typingDebounce')}
diff --git a/src/locales/de.yml b/src/locales/de.yml
index 8ce6e03..23d308c 100644
--- a/src/locales/de.yml
+++ b/src/locales/de.yml
@@ -180,8 +180,6 @@ desktop:
recordKeys: "Kürzel und benannte Tasten aufzeichnen"
recordTyping: "Eingaben aufzeichnen"
typingDebounce: "Eingabeschritt beenden nach"
- readFieldText: "Den Feldtext lesen, wenn möglich"
- readFieldTextHint: "Andernfalls werden die Tastenanschläge aufgezeichnet"
cardScreenshotsHint: "Was jeder Schritt aufnimmt"
cardKeyboardHint: "Was die Tastatur zur Anleitung beiträgt"
captureModeHint: "Fenster folgt der App, die du anklickst."
diff --git a/src/locales/en.yml b/src/locales/en.yml
index 0f0f4ce..d03006e 100644
--- a/src/locales/en.yml
+++ b/src/locales/en.yml
@@ -180,8 +180,6 @@ desktop:
recordKeys: "Record shortcuts and named keys"
recordTyping: "Record what you type"
typingDebounce: "Close a typing step after"
- readFieldText: "Read the field's own text when it can"
- readFieldTextHint: "Off means the guide records your keystrokes instead"
cardScreenshotsHint: "What each step captures"
cardKeyboardHint: "What the keyboard adds to a guide"
captureModeHint: "Window follows the app you click."
diff --git a/src/locales/es.yml b/src/locales/es.yml
index 41d196d..4509fe9 100644
--- a/src/locales/es.yml
+++ b/src/locales/es.yml
@@ -180,8 +180,6 @@ desktop:
recordKeys: "Registrar atajos y teclas con nombre"
recordTyping: "Registrar lo que escribes"
typingDebounce: "Cerrar el paso de escritura tras"
- readFieldText: "Leer el texto del propio campo cuando se pueda"
- readFieldTextHint: "Si se desactiva, la guía registra tus pulsaciones"
cardScreenshotsHint: "Qué captura cada paso"
cardKeyboardHint: "Lo que el teclado añade a una guía"
captureModeHint: "Ventana sigue a la app en la que haces clic."
diff --git a/src/locales/fr.yml b/src/locales/fr.yml
index b479958..bd69e78 100644
--- a/src/locales/fr.yml
+++ b/src/locales/fr.yml
@@ -180,8 +180,6 @@ desktop:
recordKeys: "Enregistrer les raccourcis et touches nommées"
recordTyping: "Enregistrer ce que vous tapez"
typingDebounce: "Clôturer l'étape de saisie après"
- readFieldText: "Lire le texte du champ lorsque c’est possible"
- readFieldTextHint: "Sinon, le guide enregistre vos frappes"
cardScreenshotsHint: "Ce que capture chaque étape"
cardKeyboardHint: "Ce que le clavier ajoute au guide"
captureModeHint: "Fenêtre suit l’application sur laquelle vous cliquez."
diff --git a/src/locales/pt-BR.yml b/src/locales/pt-BR.yml
index 81cdb30..70ca949 100644
--- a/src/locales/pt-BR.yml
+++ b/src/locales/pt-BR.yml
@@ -180,8 +180,6 @@ desktop:
recordKeys: "Registrar atalhos e teclas nomeadas"
recordTyping: "Registrar o que você digita"
typingDebounce: "Encerrar a etapa de digitação após"
- readFieldText: "Ler o texto do próprio campo quando possível"
- readFieldTextHint: "Se desligado, o guia registra suas teclas"
cardScreenshotsHint: "O que cada passo captura"
cardKeyboardHint: "O que o teclado adiciona ao guia"
captureModeHint: "Janela acompanha o app em que você clica."
diff --git a/src/locales/zh-CN.yml b/src/locales/zh-CN.yml
index 1b727ba..48edb10 100644
--- a/src/locales/zh-CN.yml
+++ b/src/locales/zh-CN.yml
@@ -180,8 +180,6 @@ desktop:
recordKeys: "记录快捷键和命名按键"
recordTyping: "记录输入内容"
typingDebounce: "输入步骤结束延迟"
- readFieldText: "尽可能读取输入框自身的文本"
- readFieldTextHint: "关闭时改为记录按键"
cardScreenshotsHint: "每一步截取的内容"
cardKeyboardHint: "键盘为指南添加的内容"
captureModeHint: "窗口模式跟随你点击的应用。"