Skip to content

armgit / mimik

Public Imported from GitHub
0

🎬 A browser extension and desktop app that turns your clicks into step-by-step guides with annotated screenshots πŸ“–

fix(desktop): drop the settings close button the header already provides

Luis Ortizcb229d06cc41
diff --git a/AGENTS.md b/AGENTS.md
index 832449d..ab4aa96 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -857,10 +857,12 @@ identical on both surfaces, so `AiSettings` lives in `packages/ui` and each app
`validate` function β€” the desktop passes core's `validateApiKey` directly, and the extension goes
through its background messaging, which is the only part that differs.
-The pane carries no heading of its own. The left nav already names the section, and a title repeating
-the highlighted nav item is the same word twice on one screen. Closing is an X in the pane's top
-right, as in `CaptureSheet`; it was briefly a "Close" entry under the three sections, styled like
-them, which read as a fourth section that happens to quit.
+The pane carries no heading and no close button. The left nav already names the section, so a title
+repeating the highlighted item is the same word twice on one screen; and `TopNav` stays visible and
+mounted the whole time settings is open, so All Guides, Starred, Trash and the wordmark are all exits
+already. Both were tried and removed β€” first a "Close" entry under the three sections, styled like
+them, which read as a fourth section that happens to quit, then an X in the pane corner, which by
+then duplicated the header it sat beneath.
`AiSettings` is the extension's own AI card, lifted out of `SettingsView` rather than rewritten. A
parallel implementation was tried first and the wording immediately drifted β€” the extension said
diff --git a/apps/desktop/src/renderer/App.tsx b/apps/desktop/src/renderer/App.tsx
index d3c1723..4beea09 100644
--- a/apps/desktop/src/renderer/App.tsx
+++ b/apps/desktop/src/renderer/App.tsx
@@ -34,7 +34,7 @@ export default function App() {
/>
{settingsOpen ? (
<main className="flex-1 min-h-0">
- <SettingsPanel onClose={() => setSettingsOpen(false)} />
+ <SettingsPanel />
</main>
) : route.page === 'guide' ? (
<main className="flex-1 py-10 px-6">
diff --git a/apps/desktop/src/renderer/SettingsPanel.tsx b/apps/desktop/src/renderer/SettingsPanel.tsx
index 40cff19..6e1932e 100644
--- a/apps/desktop/src/renderer/SettingsPanel.tsx
+++ b/apps/desktop/src/renderer/SettingsPanel.tsx
@@ -3,7 +3,6 @@ import { i18n } from '@mimik/core/env';
import { CURSOR_STYLES } from '@mimik/core/screenshot/types';
import AiSettings from '@mimik/ui/shared/AiSettings';
import { useKeyCheck } from '@mimik/ui/shared/key-status';
-import { X } from 'lucide-react';
import { useEffect, useState } from 'react';
import type { CaptureSettings, CaptureShortcuts } from '../main/capture/settings';
import ShortcutRecorder from './ShortcutRecorder';
@@ -51,7 +50,7 @@ function Toggle({
);
}
-export default function SettingsPanel({ onClose }: { onClose(): void }) {
+export default function SettingsPanel() {
const [section, setSection] = useState<Section>('capture');
const keyCheck = useKeyCheck(validateApiKey);
const [settings, setSettings] = useState<CaptureSettings | null>(null);
@@ -88,17 +87,6 @@ export default function SettingsPanel({ onClose }: { onClose(): void }) {
<div className="min-w-0 flex-1 overflow-y-auto px-10 py-8">
<div className="mx-auto flex max-w-[640px] flex-col gap-5">
- <div className="flex justify-end">
- <button
- type="button"
- aria-label={i18n.t('common_close')}
- onClick={onClose}
- className="rounded-lg p-1.5 text-muted-foreground transition-colors hover:bg-secondary hover:text-foreground"
- >
- <X size={17} />
- </button>
- </div>
-
{section === 'ai' && <AiSettings keyCheck={keyCheck} />}
{section === 'capture' && settings && (