π¬ A browser extension and desktop app that turns your clicks into step-by-step guides with annotated screenshots π
TypeScript browser-extensionchrome-extensiondocumentationfirefox-extensionguide-generatorlocal-firstmanifest-v3privacy-firstproductivityreactscreenshotstep-by-step-guidetutorialtypescriptworkflowwxt
test(capture): cover sensitive fields and shadow-dom targets
Luis Ortizfc882b99ba16
diff --git a/src/core/capture/dom/__tests__/element-utils.test.ts b/src/core/capture/dom/__tests__/element-utils.test.tsindex a276b4f..a5ef440 100644--- a/src/core/capture/dom/__tests__/element-utils.test.ts+++ b/src/core/capture/dom/__tests__/element-utils.test.ts@@ -1,6 +1,13 @@// @vitest-environment happy-domimport { beforeEach, describe, expect, it } from 'vitest';-import { isTooLarge } from '../element-utils';+import {+ eventTarget,+ findFocusableAncestor,+ getFieldLabel,+ getFieldValue,+ isSensitiveField,+ isTooLarge,+} from '../element-utils';const VIEWPORT_WIDTH = 1000;const VIEWPORT_HEIGHT = 800;@@ -39,3 +46,152 @@ describe('isTooLarge', () => {expect(isTooLarge(makeElement(VIEWPORT_WIDTH * 0.81, 40))).toBe(true);});});++describe('getFieldValue', () => {+ function makeInput(type: string, value: string): HTMLInputElement {+ const el = document.createElement('input');+ el.type = type;+ el.value = value;+ return el;+ }++ it('returns nothing for a password field so the typed value is never captured', () => {+ expect(getFieldValue(makeInput('password', 'hunter2'))).toBe('');+ });++ it('still returns the value for an ordinary text field', () => {+ expect(getFieldValue(makeInput('text', '[email protected]'))).toBe('[email protected]');+ });++ it('returns the value for a contenteditable element', () => {+ const el = document.createElement('div');+ el.setAttribute('contenteditable', 'true');+ el.textContent = ' notes ';+ expect(getFieldValue(el)).toBe('notes');+ });+});++describe('isSensitiveField', () => {+ it('reports a password input as sensitive', () => {+ const el = document.createElement('input');+ el.type = 'password';+ expect(isSensitiveField(el)).toBe(true);+ });++ it('does not report a text input as sensitive', () => {+ const el = document.createElement('input');+ el.type = 'text';+ expect(isSensitiveField(el)).toBe(false);+ });++ it('does not report a textarea as sensitive', () => {+ expect(isSensitiveField(document.createElement('textarea'))).toBe(false);+ });+});++describe('eventTarget', () => {+ function retargeted(host: Element, inner: Element): Event {+ return { target: host, composedPath: () => [inner, host, document.body] } as unknown as Event;+ }++ it('returns the inner field rather than the web component wrapping it', () => {+ const host = document.createElement('faceplate-text-input');+ const inner = document.createElement('input');+ inner.type = 'password';+ expect(eventTarget(retargeted(host, inner))).toBe(inner);+ });++ it('leaves an ordinary target untouched', () => {+ const button = document.createElement('button');+ expect(eventTarget({ target: button, composedPath: () => [button] } as unknown as Event)).toBe(button);+ });++ it('falls back to target when composedPath is unavailable', () => {+ const button = document.createElement('button');+ expect(eventTarget({ target: button } as unknown as Event)).toBe(button);+ });++ it('returns null when there is no element to resolve', () => {+ expect(eventTarget({ target: null } as unknown as Event)).toBe(null);+ });+});++describe('findFocusableAncestor', () => {+ function wrappedInput(type: string) {+ const host = document.createElement('faceplate-text-input');+ const shadow = host.attachShadow({ mode: 'open' });+ const label = document.createElement('label');+ const outer = document.createElement('span');+ const decoration = document.createElement('span');+ const input = document.createElement('input');+ input.type = type;+ input.id = `field-${type}`;+ label.htmlFor = input.id;+ outer.appendChild(decoration);+ outer.appendChild(input);+ label.appendChild(outer);+ shadow.appendChild(label);+ document.body.appendChild(host);+ return { host, decoration, input };+ }++ it('resolves a decorative span inside a web component to the control it labels', () => {+ const { host, decoration, input } = wrappedInput('text');+ expect(findFocusableAncestor(decoration)).toBe(input);+ host.remove();+ });++ it('resolves to the password control so the sensitive guard sees it', () => {+ const { host, decoration, input } = wrappedInput('password');+ expect(findFocusableAncestor(decoration)).toBe(input);+ expect(isSensitiveField(findFocusableAncestor(decoration))).toBe(true);+ host.remove();+ });++ it('still returns the nearest focusable ancestor on an ordinary page', () => {+ const button = document.createElement('button');+ const span = document.createElement('span');+ button.appendChild(span);+ document.body.appendChild(button);+ expect(findFocusableAncestor(span)).toBe(button);+ button.remove();+ });+});++describe('getFieldLabel', () => {+ function slottedField(labelText: string) {+ const host = document.createElement('faceplate-text-input');+ host.textContent = labelText;+ const shadow = host.attachShadow({ mode: 'open' });+ const label = document.createElement('label');+ const marker = document.createElement('span');+ marker.textContent = '*';+ const input = document.createElement('input');+ input.type = 'text';+ input.id = 'slotted-field';+ label.htmlFor = input.id;+ label.appendChild(marker);+ label.appendChild(input);+ shadow.appendChild(label);+ document.body.appendChild(host);+ return { host, input };+ }++ it('uses the slotted host text rather than the required marker', () => {+ const { host, input } = slottedField('Email or username');+ expect(getFieldLabel(input)).toBe('Email or username');+ host.remove();+ });++ it('prefers an explicit aria-label over everything else', () => {+ const input = document.createElement('input');+ input.setAttribute('aria-label', 'Search');+ expect(getFieldLabel(input)).toBe('Search');+ });++ it('falls back to the name when nothing readable is available', () => {+ const input = document.createElement('input');+ input.setAttribute('name', 'username');+ expect(getFieldLabel(input)).toBe('username');+ });+});