Ministack: Free, open-source local AWS emulator - 60+ services, Terraform compatible, real databases. Free forever. MIT licensed.
Python awsaws-emulatoraws-localaws-sdkdevtoolsdockerdynamodbec2emulatorlambdalocalstacklocalstack-alternativeministackmock-awsopen-sourcepythons3sqsterraform
fix(eventbridge): substitute reserved input-transformer variables (#900)
Abdelrahman Hassan2ae3bd8da57d
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex 51b4de78..a116f608 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -8,6 +8,7 @@ Versioning follows [Semantic Versioning](https://semver.org/).## [Unreleased]### Fixed+- **EventBridge — input transformer reserved variables** — substitute `<aws.events.event.json>`, `<aws.events.event>`, `<aws.events.rule-name>`, `<aws.events.rule-arn>`, and `<aws.events.event.ingestion-time>` so CDK-style templates that embed the source event deliver valid JSON.- **CloudFormation — `GetTemplateSummary` now returns `Capabilities` and `CapabilitiesReason`** — the handler already accepted `TemplateBody` and returned `Parameters` / `ResourceTypes` correctly, but omitted the `Capabilities` and `CapabilitiesReason` fields. These are now computed from the template: `CAPABILITY_NAMED_IAM` for IAM resources with explicit name properties (`RoleName`, `UserName`, etc.), `CAPABILITY_IAM` for unnamed IAM resources, and `CAPABILITY_AUTO_EXPAND` for templates with a `Transform`. `CapabilitiesReason` uses the format confirmed against the AWS API: `"The following resource(s) require capabilities: [<type>]"`. Contributed by @maximoosemine.- **Lambda - CreateEventSourceMapping persists FilterCriteria** — CreateEventSourceMapping was silently dropping the FilterCriteria parameter, so any filter specified at creation time was never applied.- **ECS — `RunTask` now applies `containerOverrides.command` to the launched Docker container** — Overridden commands (including an explicit empty command) were ignored at runtime because the Docker `containers.run(...)` call still used the task-definition command. The effective container definition now carries the matched override command into Docker, while non-overridden containers keep their defaults.diff --git a/ministack/services/eventbridge.py b/ministack/services/eventbridge.pyindex da9536de..58dfc9ca 100644--- a/ministack/services/eventbridge.py+++ b/ministack/services/eventbridge.py@@ -930,7 +930,7 @@ def _invoke_target(target, event, rule):input_transformer = target.get("InputTransformer")if input_transformer:- event_payload = _apply_input_transformer(input_transformer, event)+ event_payload = _apply_input_transformer(input_transformer, event, rule)elif target.get("Input"):event_payload = target["Input"]elif target.get("InputPath"):@@ -960,7 +960,7 @@ def _invoke_target(target, event, rule):logger.error("EventBridge target dispatch error for %s: %s", arn, e)-def _apply_input_transformer(transformer, event):+def _apply_input_transformer(transformer, event, rule=None):input_paths = transformer.get("InputPathsMap", {})template = transformer.get("InputTemplate", "")@@ -970,6 +970,7 @@ def _apply_input_transformer(transformer, event):full = {}event_envelope = {+ "version": "0","source": event.get("Source", ""),"detail-type": event.get("DetailType", ""),"detail": full,@@ -992,6 +993,17 @@ def _apply_input_transformer(transformer, event):except (KeyError, TypeError, IndexError):replacements[var_name] = ""+ reserved = {+ "aws.events.event.json": json.dumps(event_envelope),+ "aws.events.event": json.dumps({k: v for k, v in event_envelope.items() if k != "detail"}),+ "aws.events.event.ingestion-time": event_envelope.get("time", ""),+ }+ if rule:+ reserved["aws.events.rule-name"] = rule.get("Name", "")+ reserved["aws.events.rule-arn"] = rule.get("Arn", "")+ for k, v in reserved.items():+ replacements.setdefault(k, v)+result = templatefor var_name, val in replacements.items():result = result.replace(f"<{var_name}>", str(val))diff --git a/tests/test_eventbridge.py b/tests/test_eventbridge.pyindex ff7e816c..2cb46b70 100644--- a/tests/test_eventbridge.py+++ b/tests/test_eventbridge.py@@ -1745,3 +1745,233 @@ def test_eventbridge_anything_but_wildcard_excludes_matching(eb, sqs):QueueUrl=q_url, MaxNumberOfMessages=10, WaitTimeSeconds=1)["Messages"]ids = [json.loads(m["Body"])["detail"]["id"] for m in msgs]assert ids == ["prod-app-1"]+++# ---------------------------------------------------------------------------+# Reserved input-transformer variables+# ---------------------------------------------------------------------------++def test_eventbridge_input_transformer_event_json(eb, sqs):+ """<aws.events.event.json> embeds the full event envelope as a raw JSON object."""+ bus_name = "qa-eb-reserved-evtjson-bus"+ eb.create_event_bus(Name=bus_name)+ q_url = sqs.create_queue(QueueName="qa-eb-reserved-evtjson-q")["QueueUrl"]+ q_arn = sqs.get_queue_attributes(QueueUrl=q_url, AttributeNames=["QueueArn"])["Attributes"]["QueueArn"]+ eb.put_rule(+ Name="qa-eb-reserved-evtjson-rule",+ EventBusName=bus_name,+ EventPattern=json.dumps({"source": ["myapp.reserved"]}),+ State="ENABLED",+ )+ eb.put_targets(+ Rule="qa-eb-reserved-evtjson-rule",+ EventBusName=bus_name,+ Targets=[+ {+ "Id": "t1",+ "Arn": q_arn,+ "InputTransformer": {+ "InputPathsMap": {},+ "InputTemplate": '{"sourceEvent": <aws.events.event.json>}',+ },+ }+ ],+ )+ eb.put_events(+ Entries=[+ {+ "Source": "myapp.reserved",+ "DetailType": "TestEvent",+ "Detail": json.dumps({"foo": "bar"}),+ "EventBusName": bus_name,+ }+ ]+ )+ msgs = sqs.receive_message(QueueUrl=q_url, MaxNumberOfMessages=1, WaitTimeSeconds=1)+ assert len(msgs.get("Messages", [])) == 1+ body = json.loads(msgs["Messages"][0]["Body"])+ assert body["sourceEvent"]["source"] == "myapp.reserved"+ assert body["sourceEvent"]["detail-type"] == "TestEvent"+ assert body["sourceEvent"]["detail"] == {"foo": "bar"}+ assert body["sourceEvent"]["version"] == "0"+++def test_eventbridge_input_transformer_event_escaped(eb, sqs):+ """<aws.events.event> embeds the event as a JSON object with the detail field removed."""+ bus_name = "qa-eb-reserved-evtesc-bus"+ eb.create_event_bus(Name=bus_name)+ q_url = sqs.create_queue(QueueName="qa-eb-reserved-evtesc-q")["QueueUrl"]+ q_arn = sqs.get_queue_attributes(QueueUrl=q_url, AttributeNames=["QueueArn"])["Attributes"]["QueueArn"]+ eb.put_rule(+ Name="qa-eb-reserved-evtesc-rule",+ EventBusName=bus_name,+ EventPattern=json.dumps({"source": ["myapp.escaped"]}),+ State="ENABLED",+ )+ eb.put_targets(+ Rule="qa-eb-reserved-evtesc-rule",+ EventBusName=bus_name,+ Targets=[+ {+ "Id": "t1",+ "Arn": q_arn,+ "InputTransformer": {+ "InputPathsMap": {},+ "InputTemplate": '{"evt": <aws.events.event>}',+ },+ }+ ],+ )+ eb.put_events(+ Entries=[+ {+ "Source": "myapp.escaped",+ "DetailType": "EscTest",+ "Detail": json.dumps({"x": 1}),+ "EventBusName": bus_name,+ }+ ]+ )+ msgs = sqs.receive_message(QueueUrl=q_url, MaxNumberOfMessages=1, WaitTimeSeconds=1)+ assert len(msgs.get("Messages", [])) == 1+ body = json.loads(msgs["Messages"][0]["Body"])+ # <aws.events.event> renders a JSON object (not an escaped string) with detail removed+ assert isinstance(body["evt"], dict)+ assert body["evt"]["source"] == "myapp.escaped"+ assert body["evt"]["detail-type"] == "EscTest"+ assert body["evt"]["version"] == "0"+ assert "detail" not in body["evt"]+++def test_eventbridge_input_transformer_rule_name_and_arn(eb, sqs):+ """<aws.events.rule-name> and <aws.events.rule-arn> resolve to the rule's Name and Arn."""+ bus_name = "qa-eb-reserved-rn-bus"+ rule_name = "qa-eb-reserved-rn-rule"+ eb.create_event_bus(Name=bus_name)+ q_url = sqs.create_queue(QueueName="qa-eb-reserved-rn-q")["QueueUrl"]+ q_arn = sqs.get_queue_attributes(QueueUrl=q_url, AttributeNames=["QueueArn"])["Attributes"]["QueueArn"]+ put_rule_resp = eb.put_rule(+ Name=rule_name,+ EventBusName=bus_name,+ EventPattern=json.dumps({"source": ["myapp.rname"]}),+ State="ENABLED",+ )+ expected_rule_arn = put_rule_resp["RuleArn"]+ eb.put_targets(+ Rule=rule_name,+ EventBusName=bus_name,+ Targets=[+ {+ "Id": "t1",+ "Arn": q_arn,+ "InputTransformer": {+ "InputPathsMap": {},+ "InputTemplate": '{"rn": "<aws.events.rule-name>", "ra": "<aws.events.rule-arn>"}',+ },+ }+ ],+ )+ eb.put_events(+ Entries=[+ {+ "Source": "myapp.rname",+ "DetailType": "RnTest",+ "Detail": "{}",+ "EventBusName": bus_name,+ }+ ]+ )+ msgs = sqs.receive_message(QueueUrl=q_url, MaxNumberOfMessages=1, WaitTimeSeconds=1)+ assert len(msgs.get("Messages", [])) == 1+ body = json.loads(msgs["Messages"][0]["Body"])+ assert body["rn"] == rule_name+ assert body["ra"] == expected_rule_arn+++def test_eventbridge_input_transformer_setdefault_precedence(eb, sqs):+ """An explicit InputPathsMap entry named like a reserved var must win over the reserved value."""+ bus_name = "qa-eb-reserved-prec-bus"+ rule_name = "qa-eb-reserved-prec-rule"+ eb.create_event_bus(Name=bus_name)+ q_url = sqs.create_queue(QueueName="qa-eb-reserved-prec-q")["QueueUrl"]+ q_arn = sqs.get_queue_attributes(QueueUrl=q_url, AttributeNames=["QueueArn"])["Attributes"]["QueueArn"]+ eb.put_rule(+ Name=rule_name,+ EventBusName=bus_name,+ EventPattern=json.dumps({"source": ["myapp.prec"]}),+ State="ENABLED",+ )+ eb.put_targets(+ Rule=rule_name,+ EventBusName=bus_name,+ Targets=[+ {+ "Id": "t1",+ "Arn": q_arn,+ "InputTransformer": {+ # explicitly map the reserved key name to $.source — must win+ "InputPathsMap": {"aws.events.rule-name": "$.source"},+ "InputTemplate": '{"rn": "<aws.events.rule-name>"}',+ },+ }+ ],+ )+ eb.put_events(+ Entries=[+ {+ "Source": "myapp.prec",+ "DetailType": "PrecTest",+ "Detail": "{}",+ "EventBusName": bus_name,+ }+ ]+ )+ msgs = sqs.receive_message(QueueUrl=q_url, MaxNumberOfMessages=1, WaitTimeSeconds=1)+ assert len(msgs.get("Messages", [])) == 1+ body = json.loads(msgs["Messages"][0]["Body"])+ # explicit InputPathsMap maps $.source → "myapp.prec", not the rule name+ assert body["rn"] == "myapp.prec"+++def test_eventbridge_input_transformer_ingestion_time(eb, sqs):+ """<aws.events.event.ingestion-time> is substituted with a non-empty time string."""+ bus_name = "qa-eb-reserved-itime-bus"+ eb.create_event_bus(Name=bus_name)+ q_url = sqs.create_queue(QueueName="qa-eb-reserved-itime-q")["QueueUrl"]+ q_arn = sqs.get_queue_attributes(QueueUrl=q_url, AttributeNames=["QueueArn"])["Attributes"]["QueueArn"]+ eb.put_rule(+ Name="qa-eb-reserved-itime-rule",+ EventBusName=bus_name,+ EventPattern=json.dumps({"source": ["myapp.itime"]}),+ State="ENABLED",+ )+ eb.put_targets(+ Rule="qa-eb-reserved-itime-rule",+ EventBusName=bus_name,+ Targets=[+ {+ "Id": "t1",+ "Arn": q_arn,+ "InputTransformer": {+ "InputPathsMap": {},+ "InputTemplate": '{"it": "<aws.events.event.ingestion-time>"}',+ },+ }+ ],+ )+ eb.put_events(+ Entries=[+ {+ "Source": "myapp.itime",+ "DetailType": "ItTest",+ "Detail": "{}",+ "EventBusName": bus_name,+ }+ ]+ )+ msgs = sqs.receive_message(QueueUrl=q_url, MaxNumberOfMessages=1, WaitTimeSeconds=1)+ assert len(msgs.get("Messages", [])) == 1+ body = json.loads(msgs["Messages"][0]["Body"])+ # substituted (not the literal placeholder) and non-empty; time is the event's stored value+ assert body["it"] != "<aws.events.event.ingestion-time>"+ assert body["it"] != ""