Skip to content

Ministack: Free, open-source local AWS emulator - 60+ services, Terraform compatible, real databases. Free forever. MIT licensed.

feat(kms): add UpdateKeyDescription (#1315)

António Salgado311bbfc2a58f
diff --git a/ministack/services/kms.py b/ministack/services/kms.py
index 4e559297..0f96bbcd 100644
--- a/ministack/services/kms.py
+++ b/ministack/services/kms.py
@@ -1187,6 +1187,15 @@ def _disable_key(data):
return json_response({})
+def _update_key_description(data):
+ rec = _resolve_key(data.get("KeyId", ""))
+ if not rec:
+ return error_response_json("NotFoundException", f"Key {data.get('KeyId', '')} not found", 400)
+ # An explicit empty string clears the description, which is how AWS removes it.
+ rec["Description"] = data.get("Description", "")
+ return json_response({})
+
+
def _schedule_key_deletion(data):
rec = _resolve_key(data.get("KeyId", ""))
if not rec:
@@ -1280,6 +1289,7 @@ async def handle_request(method, path, headers, body, query_params):
"ListKeyPolicies": _list_key_policies,
"EnableKey": _enable_key,
"DisableKey": _disable_key,
+ "UpdateKeyDescription": _update_key_description,
"ScheduleKeyDeletion": _schedule_key_deletion,
"CancelKeyDeletion": _cancel_key_deletion,
"TagResource": _tag_resource,
diff --git a/tests/test_kms.py b/tests/test_kms.py
index 91e97e79..5f13d09c 100644
--- a/tests/test_kms.py
+++ b/tests/test_kms.py
@@ -84,6 +84,35 @@ def test_kms_describe_key(kms_client):
assert resp["KeyMetadata"]["Description"] == "describe me"
assert resp["KeyMetadata"]["KeyId"] == key_id
+def test_kms_update_key_description(kms_client):
+ """UpdateKeyDescription changes the description DescribeKey reports.
+
+ terraform-provider-aws calls this on any aws_kms_key description drift, so a
+ missing action fails the whole update: 'InvalidAction: Unknown action'.
+ """
+ created = kms_client.create_key(KeySpec="SYMMETRIC_DEFAULT", Description="before")
+ key_id = created["KeyMetadata"]["KeyId"]
+
+ kms_client.update_key_description(KeyId=key_id, Description="after")
+ assert kms_client.describe_key(KeyId=key_id)["KeyMetadata"]["Description"] == "after"
+
+
+def test_kms_update_key_description_by_arn_and_cleared(kms_client):
+ """The key accepts an ARN, and an empty description clears it (AWS behavior)."""
+ created = kms_client.create_key(KeySpec="SYMMETRIC_DEFAULT", Description="before")
+ arn = created["KeyMetadata"]["Arn"]
+
+ kms_client.update_key_description(KeyId=arn, Description="")
+ assert kms_client.describe_key(KeyId=arn)["KeyMetadata"]["Description"] == ""
+
+
+def test_kms_update_key_description_unknown_key(kms_client):
+ with pytest.raises(ClientError) as exc:
+ kms_client.update_key_description(
+ KeyId="00000000-0000-0000-0000-000000000000", Description="x")
+ assert exc.value.response["Error"]["Code"] == "NotFoundException"
+
+
def test_kms_describe_key_by_arn(kms_client):
created = kms_client.create_key(KeySpec="SYMMETRIC_DEFAULT")
arn = created["KeyMetadata"]["Arn"]