Skip to content

Ministack: Free, open-source local AWS emulator - 60+ services, Terraform compatible, real databases. Free forever. MIT licensed.

fix(rds): emit Source element for cluster parameter group describe responses (#617)

Jay Janssen32f33ae279eb
diff --git a/CHANGELOG.md b/CHANGELOG.md
index ef25e4f4..359baf3c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,8 @@ Versioning follows [Semantic Versioning](https://semver.org/).
## [Unreleased]
+- **RDS `DescribeDBClusterParameters` emits `<Source>` element** — the cluster-parameter response XML omitted the `<Source>` element entirely, so botocore materialized `Parameters[].Source` as `None` for every entry, including parameters set explicitly via `ModifyDBClusterParameterGroup` (which real AWS reports as `Source: "user"`). The instance-level `DescribeDBParameters` path was already correct; only the cluster path was broken. Each emitted `<Parameter>` now includes `<Source>user</Source>`, matching the existing instance-level behavior. Surfaced by brownfield-import diffing against a real-AWS captured Aurora cluster parameter group. Contributed by @jayjanssen.
+
### Added
- **Cost & Usage Reports** — 7 of 7 CUR API actions supported.
## [1.3.35] — 2026-05-11
@@ -18,6 +20,7 @@ Versioning follows [Semantic Versioning](https://semver.org/).
- **SNS FIFO topic → standard SQS queue subscription** — MiniStack rejected the subscribe with `InvalidParameterException: Topic with FIFO requires a subscription to a FIFO SQS Queue`, which was the AWS rule until 2023-09-14 when AWS added support for FIFO topics fanning out to standard SQS queues. The stale validation is removed; the existing fanout path already attaches `MessageGroupId` / `MessageDeduplicationId` to delivered messages and SQS standard queues ignore those fields, matching real AWS where consumers of a standard queue subscribed to a FIFO topic "may receive messages out of order, and more than once." Contributed by @ellouzeskandercs.
- **RDS `CreateDBInstance` honors `PreferredMaintenanceWindow`** — the field was hardcoded to `sun:05:00-sun:06:00` on the instance record at creation time, silently discarding any caller-supplied value. `ModifyDBInstance` and cluster-level `PreferredMaintenanceWindow` already worked, so the divergence was per-instance only on create. The create path now reads the user value and falls back to the default only when none is supplied. Surfaced by Terraform `aws_rds_cluster_instance.preferred_maintenance_window` round-trip diffing against a real-AWS capture. Contributed by @jayjanssen.
+
---
## [1.3.34] — 2026-05-11
diff --git a/ministack/services/rds.py b/ministack/services/rds.py
index 57b16cde..b8143012 100644
--- a/ministack/services/rds.py
+++ b/ministack/services/rds.py
@@ -1483,6 +1483,7 @@ def _describe_db_cluster_parameters(p):
f"<Parameter>"
f"<ParameterName>{pname}</ParameterName>"
f"<ParameterValue>{pvalue}</ParameterValue>"
+ f"<Source>user</Source>"
f"<ApplyMethod>{apply_method}</ApplyMethod>"
f"<IsModifiable>true</IsModifiable>"
f"<ApplyType>dynamic</ApplyType>"
diff --git a/tests/test_rds.py b/tests/test_rds.py
index 51b5a38b..759c1ad9 100644
--- a/tests/test_rds.py
+++ b/tests/test_rds.py
@@ -607,6 +607,36 @@ def test_rds_modify_and_describe_cluster_parameters(rds):
assert len(resp2["Parameters"]) == 0
+def test_rds_describe_cluster_parameters_emits_source(rds):
+ """DescribeDBClusterParameters must emit Source=user for modified params.
+
+ Regression test for omission of <Source> in the cluster parameter
+ response XML, which caused botocore to materialize Source as None.
+ """
+ rds.create_db_cluster_parameter_group(
+ DBClusterParameterGroupName="test-cparam-source",
+ DBParameterGroupFamily="aurora-mysql8.0",
+ Description="cluster param source test",
+ )
+ rds.modify_db_cluster_parameter_group(
+ DBClusterParameterGroupName="test-cparam-source",
+ Parameters=[
+ {
+ "ParameterName": "binlog_format",
+ "ParameterValue": "ROW",
+ "ApplyMethod": "pending-reboot",
+ },
+ ],
+ )
+ resp = rds.describe_db_cluster_parameters(
+ DBClusterParameterGroupName="test-cparam-source"
+ )
+ p = next(
+ p for p in resp["Parameters"] if p["ParameterName"] == "binlog_format"
+ )
+ assert p.get("Source") == "user"
+
+
def test_rds_reset_cluster_parameters(rds):
"""ResetDBClusterParameterGroup clears targeted overrides and full group state."""
rds.create_db_cluster_parameter_group(