Ministack: Free, open-source local AWS emulator - 60+ services, Terraform compatible, real databases. Free forever. MIT licensed.
Python awsaws-emulatoraws-localaws-sdkdevtoolsdockerdynamodbec2emulatorlambdalocalstacklocalstack-alternativeministackmock-awsopen-sourcepythons3sqsterraform
fix(kms): tags and policy not saved on key creation (#183)
Johannes Grumböck96daa1bb7abf
diff --git a/ministack/services/kms.py b/ministack/services/kms.pyindex e29d98fb..c4d259bf 100644--- a/ministack/services/kms.py+++ b/ministack/services/kms.py@@ -156,6 +156,18 @@ def _create_key(data):key_spec = data.get("KeySpec", data.get("CustomerMasterKeySpec", "SYMMETRIC_DEFAULT"))key_usage = data.get("KeyUsage", "ENCRYPT_DECRYPT")description = data.get("Description", "")+ tags = data.get("Tags", [])+ policy = data.get("Policy", json.dumps({+ "Version": "2012-10-17",+ "Id": "key-default-1",+ "Statement": [{+ "Sid": "Enable IAM User Permissions",+ "Effect": "Allow",+ "Principal": {"AWS": f"arn:aws:iam::{ACCOUNT_ID}:root"},+ "Action": "kms:*",+ "Resource": "*",+ }],+ }))rec = {"KeyId": key_id,@@ -167,6 +179,8 @@ def _create_key(data):"Description": description,"CreationDate": time.time(),"Origin": "AWS_KMS",+ "Tags": tags,+ "Policy": policy,}if key_spec == "SYMMETRIC_DEFAULT":@@ -693,17 +707,7 @@ def _get_key_policy(data):rec = _resolve_key(data.get("KeyId", ""))if not rec:return error_response_json("NotFoundException", f"Key {data.get('KeyId', '')} not found", 400)- policy = rec.get("Policy", json.dumps({- "Version": "2012-10-17",- "Id": "key-default-1",- "Statement": [{- "Sid": "Enable IAM User Permissions",- "Effect": "Allow",- "Principal": {"AWS": f"arn:aws:iam::{ACCOUNT_ID}:root"},- "Action": "kms:*",- "Resource": "*",- }],- }))+ policy = rec.get("Policy")return json_response({"Policy": policy, "PolicyName": "default"})diff --git a/tests/test_services.py b/tests/test_services.pyindex 66f81e2f..bfd2ca4b 100644--- a/tests/test_services.py+++ b/tests/test_services.py@@ -17732,6 +17732,8 @@ def test_kms_create_symmetric_key(kms_client):KeySpec="SYMMETRIC_DEFAULT",KeyUsage="ENCRYPT_DECRYPT",Description="test symmetric key",+ Tags=[{"TagKey": "env", "TagValue": "test"}],+ Policy="{}",)meta = resp["KeyMetadata"]assert meta["KeyId"]@@ -17740,6 +17742,13 @@ def test_kms_create_symmetric_key(kms_client):assert meta["KeyUsage"] == "ENCRYPT_DECRYPT"assert meta["Enabled"] is Trueassert meta["KeyState"] == "Enabled"+ assert meta["Description"] == "test symmetric key"++ tags = kms_client.list_resource_tags(KeyId=meta["KeyId"])["Tags"]+ assert {"TagKey": "env", "TagValue": "test"} in tags++ policy = kms_client.get_key_policy(KeyId=meta["KeyId"], PolicyName="default")["Policy"]+ assert policy == "{}"def test_kms_create_rsa_2048_sign_key(kms_client):