Skip to content

Ministack: Free, open-source local AWS emulator - 60+ services, Terraform compatible, real databases. Free forever. MIT licensed.

fix(autoscaling): add DescribeScalingActivities action (#317)

alexanderkrum-next9a74979d661a
diff --git a/ministack/services/autoscaling.py b/ministack/services/autoscaling.py
index c149aad4..979595e8 100644
--- a/ministack/services/autoscaling.py
+++ b/ministack/services/autoscaling.py
@@ -5,7 +5,7 @@ All in-memory, no actual instance scaling.
Supports:
ASG: CreateAutoScalingGroup, DescribeAutoScalingGroups, UpdateAutoScalingGroup,
- DeleteAutoScalingGroup, DescribeAutoScalingInstances
+ DeleteAutoScalingGroup, DescribeAutoScalingInstances, DescribeScalingActivities
LC: CreateLaunchConfiguration, DescribeLaunchConfigurations, DeleteLaunchConfiguration
Policies: PutScalingPolicy, DescribePolicies, DeletePolicy
Hooks: PutLifecycleHook, DescribeLifecycleHooks, DeleteLifecycleHook,
@@ -208,6 +208,11 @@ def _describe_asg_instances(p):
"<DescribeAutoScalingInstancesResult><AutoScalingInstances/></DescribeAutoScalingInstancesResult>")
+def _describe_scaling_activities(p):
+ return _xml(200, "DescribeScalingActivitiesResponse",
+ "<DescribeScalingActivitiesResult><Activities/></DescribeScalingActivitiesResult>")
+
+
# ---------------------------------------------------------------------------
# LaunchConfiguration
# ---------------------------------------------------------------------------
@@ -465,6 +470,7 @@ _ACTION_MAP = {
"UpdateAutoScalingGroup": _update_asg,
"DeleteAutoScalingGroup": _delete_asg,
"DescribeAutoScalingInstances": _describe_asg_instances,
+ "DescribeScalingActivities": _describe_scaling_activities,
"CreateLaunchConfiguration": _create_lc,
"DescribeLaunchConfigurations": _describe_lcs,
"DeleteLaunchConfiguration": _delete_lc,
diff --git a/tests/conftest.py b/tests/conftest.py
index 15f69432..6627033b 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -284,3 +284,7 @@ def sd():
@pytest.fixture(scope="session")
def codebuild():
return make_client("codebuild")
+
[email protected](scope="session")
+def autoscaling():
+ return make_client("autoscaling")
diff --git a/tests/test_autoscaling.py b/tests/test_autoscaling.py
new file mode 100644
index 00000000..2440536f
--- /dev/null
+++ b/tests/test_autoscaling.py
@@ -0,0 +1,44 @@
+from botocore.exceptions import ClientError
+
+
+def test_autoscaling_describe_scaling_activities_empty(autoscaling):
+ """DescribeScalingActivities returns an empty list when no ASG exists."""
+ resp = autoscaling.describe_scaling_activities()
+ assert resp["Activities"] == []
+
+
+def test_autoscaling_create_and_describe_asg(autoscaling):
+ name = "test-asg-basic"
+ autoscaling.create_auto_scaling_group(
+ AutoScalingGroupName=name,
+ MinSize=0,
+ MaxSize=1,
+ DesiredCapacity=0,
+ AvailabilityZones=["us-east-1a"],
+ LaunchConfigurationName="dummy-lc",
+ )
+ resp = autoscaling.describe_auto_scaling_groups(AutoScalingGroupNames=[name])
+ groups = resp["AutoScalingGroups"]
+ assert len(groups) == 1
+ assert groups[0]["AutoScalingGroupName"] == name
+ assert groups[0]["MinSize"] == 0
+ assert groups[0]["MaxSize"] == 1
+
+ autoscaling.delete_auto_scaling_group(AutoScalingGroupName=name)
+
+
+def test_autoscaling_describe_scaling_activities_after_create(autoscaling):
+ """Terraform polls DescribeScalingActivities right after ASG creation."""
+ name = "test-asg-activities"
+ autoscaling.create_auto_scaling_group(
+ AutoScalingGroupName=name,
+ MinSize=0,
+ MaxSize=1,
+ DesiredCapacity=0,
+ AvailabilityZones=["us-east-1a"],
+ LaunchConfigurationName="dummy-lc",
+ )
+ resp = autoscaling.describe_scaling_activities(AutoScalingGroupName=name)
+ assert resp["Activities"] == []
+
+ autoscaling.delete_auto_scaling_group(AutoScalingGroupName=name)