Skip to content

Ministack: Free, open-source local AWS emulator - 60+ services, Terraform compatible, real databases. Free forever. MIT licensed.

fix(rds): honor PreferredMaintenanceWindow on CreateDBInstance (#613)

Jay Janssendabce3a01d96
diff --git a/CHANGELOG.md b/CHANGELOG.md
index afa94d6c..06f8af61 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,13 @@ Versioning follows [Semantic Versioning](https://semver.org/).
---
+## [Unreleased]
+
+### Fixed
+- **RDS `CreateDBInstance` honors `PreferredMaintenanceWindow`** — the field was hardcoded to `sun:05:00-sun:06:00` on the instance record at creation time, silently discarding any caller-supplied value. `ModifyDBInstance` already honored it, and the cluster-level `PreferredMaintenanceWindow` already worked, so the divergence was per-instance only and only on create. The create path now reads the user value and only falls back to `sun:05:00-sun:06:00` when none is supplied. Closes #612. Surfaced by Terraform `aws_rds_cluster_instance.preferred_maintenance_window` round-trip diffing against a real-AWS capture.
+
+---
+
## [1.3.34] — 2026-05-11
### Added
diff --git a/ministack/services/rds.py b/ministack/services/rds.py
index 417ccfd2..57b16cde 100644
--- a/ministack/services/rds.py
+++ b/ministack/services/rds.py
@@ -469,7 +469,7 @@ def _create_db_instance(p):
}],
"AvailabilityZone": _p(p, "AvailabilityZone") or f"{get_region()}a",
"DBSubnetGroup": subnet_group,
- "PreferredMaintenanceWindow": "sun:05:00-sun:06:00",
+ "PreferredMaintenanceWindow": _p(p, "PreferredMaintenanceWindow") or "sun:05:00-sun:06:00",
"PendingModifiedValues": {},
"LatestRestorableTime": _format_time(now_ts),
"MultiAZ": _p(p, "MultiAZ") == "true",
diff --git a/tests/test_rds.py b/tests/test_rds.py
index 2121d8cd..51b5a38b 100644
--- a/tests/test_rds.py
+++ b/tests/test_rds.py
@@ -119,6 +119,36 @@ def test_rds_modify_instance_v2(rds):
assert inst["DBInstanceClass"] == "db.t3.small"
assert inst["AllocatedStorage"] == 50
+def test_rds_create_instance_honors_preferred_maintenance_window(rds):
+ # Regression: CreateDBInstance previously hardcoded
+ # PreferredMaintenanceWindow to "sun:05:00-sun:06:00", silently
+ # discarding any user-supplied value.
+ rds.create_db_instance(
+ DBInstanceIdentifier="rds-pmw-v2",
+ DBInstanceClass="db.t3.micro",
+ Engine="postgres",
+ MasterUsername="admin",
+ MasterUserPassword="pass",
+ AllocatedStorage=20,
+ PreferredMaintenanceWindow="tue:03:00-tue:04:00",
+ )
+ resp = rds.describe_db_instances(DBInstanceIdentifier="rds-pmw-v2")
+ inst = resp["DBInstances"][0]
+ assert inst["PreferredMaintenanceWindow"] == "tue:03:00-tue:04:00"
+
+def test_rds_create_instance_default_preferred_maintenance_window(rds):
+ rds.create_db_instance(
+ DBInstanceIdentifier="rds-pmw-default-v2",
+ DBInstanceClass="db.t3.micro",
+ Engine="postgres",
+ MasterUsername="admin",
+ MasterUserPassword="pass",
+ AllocatedStorage=20,
+ )
+ resp = rds.describe_db_instances(DBInstanceIdentifier="rds-pmw-default-v2")
+ inst = resp["DBInstances"][0]
+ assert inst["PreferredMaintenanceWindow"] == "sun:05:00-sun:06:00"
+
def test_rds_create_cluster_v2(rds):
resp = rds.create_db_cluster(
DBClusterIdentifier="rds-cc-v2",