☕️ Classic, reliable, trusted test framework for Node.js and the browser
Fixing the clone() function in Suite, adding specs
Attila Domokos0d7249a5e89e
diff --git a/lib/suite.js b/lib/suite.jsindex 486bcb6b..f2a19927 100644--- a/lib/suite.js+++ b/lib/suite.js@@ -72,7 +72,7 @@ Suite.prototype.clone = function(){var suite = new Suite(this.title);debug('clone');suite.timeout(this.timeout());- suite.bail(this._bail());+ suite.bail(this.bail());return suite;};@@ -85,7 +85,7 @@ Suite.prototype.clone = function(){*/Suite.prototype.timeout = function(ms){- if (0 == arguments.length) return this._timeout;+ if (0 === arguments.length) return this._timeout;if (String(ms).match(/s$/)) ms = parseFloat(ms) * 1000;debug('timeout %d', ms);this._timeout = parseInt(ms, 10);@@ -101,7 +101,7 @@ Suite.prototype.timeout = function(ms){*/Suite.prototype.bail = function(bail){- if (0 == arguments.length) return this._bail;+ if (0 === arguments.length) return this._bail;debug('bail %s', bail);this._bail = bail;return this;diff --git a/test/suite.js b/test/suite.jsnew file mode 100644index 00000000..f208e6d2--- /dev/null+++ b/test/suite.js@@ -0,0 +1,105 @@+var mocha = require('../')+ , Suite = mocha.Suite;++describe('Suite', function() {+ describe('when initialized', function() {+ beforeEach(function() {+ this.suite = new Suite('A Suite');+ });++ it('is initialized with a title', function() {+ this.suite.title.should.equal('A Suite');+ });++ it('the suites array is empty', function() {+ this.suite.suites.length.should.equal(0);+ });++ it('the tests array is empty', function() {+ this.suite.tests.length.should.equal(0);+ });++ it('the _beforeEach array is empty', function() {+ this.suite._beforeEach.length.should.equal(0);+ });++ it('the _beforeAll array is empty', function() {+ this.suite._beforeEach.length.should.equal(0);+ });++ it('the _afterEach array is empty', function() {+ this.suite._afterEach.length.should.equal(0);+ });++ it('the _afterAll array is empty', function() {+ this.suite._afterAll.length.should.equal(0);+ });++ it('the root is false', function() {+ this.suite.root.should.equal(false);+ });++ it('the _timeout is 2000', function() {+ this.suite._timeout.should.equal(2000);+ });++ it('the _bail is false', function() {+ this.suite._bail.should.equal(false);+ });+ });++ describe('cloning', function() {+ beforeEach(function() {+ this.suite = new Suite('To be cloned');+ this.suite._timeout = 3043;+ this.suite._bail = true;+ this.suite.suites.push(1);+ this.suite.tests.push('hello');+ this.suite._beforeEach.push(2);+ this.suite._beforeAll.push(3);+ this.suite._afterEach.push(4);+ this.suite._afterAll.push(5);+ });++ describe('copies', function() {+ it('the title', function() {+ this.suite.clone().title.should.equal('To be cloned');+ });++ it('the timeout value', function() {+ this.suite.clone().timeout().should.equal(3043);+ });++ it('the bail value', function() {+ this.suite.clone().bail().should.equal(true);+ });+ });++ describe('does NOT copy', function() {+ it('the values from the suites array', function() {+ this.suite.clone().suites.length.should.equal(0);+ });++ it('the values from the tests array', function() {+ this.suite.clone().tests.length.should.equal(0);+ });++ it('the values from the _beforeEach array', function() {+ this.suite.clone()._beforeEach.length.should.equal(0);+ });++ it('the values from the _beforeAll array', function() {+ this.suite.clone()._beforeAll.length.should.equal(0);+ });++ it('the values from the _afterEach array', function() {+ this.suite.clone()._afterEach.length.should.equal(0);+ });++ it('the valurs from the _afterAll array', function() {+ this.suite.clone()._afterAll.length.should.equal(0);+ });+ });++ });+});