Skip to content

armgit / mocha

Public Imported from GitHub
0

☕️ Classic, reliable, trusted test framework for Node.js and the browser

fix insanity in http tests

Christopher Hiller838b95f4364e
diff --git a/test/http.meta.2.js b/test/http.meta.2.js
index 31b77932..fe9662b2 100644
--- a/test/http.meta.2.js
+++ b/test/http.meta.2.js
@@ -1,5 +1,7 @@
var http = require('http');
+var PORT = 8899;
+
var server = http.createServer(function(req, res){
var accept = req.headers.accept || ''
, json = ~accept.indexOf('json');
@@ -18,15 +20,13 @@ var server = http.createServer(function(req, res){
}
})
-server.listen(8899);
-
function get(url) {
var fields
, expected
, header = {};
function request(done) {
- http.get({ path: url, port: 8899, headers: header }, function(res){
+ http.get({ path: url, port: PORT, headers: header }, function(res){
var buf = '';
res.should.have.property('statusCode', 200);
res.setEncoding('utf8');
@@ -67,6 +67,15 @@ function get(url) {
}
describe('http server', function(){
+
+ before(function(done) {
+ server.listen(PORT, done);
+ });
+
+ after(function() {
+ server.close();
+ });
+
get('/')
.should
.respond('hello')
diff --git a/test/http.meta.js b/test/http.meta.js
index 00c3f9c8..5d1fb675 100644
--- a/test/http.meta.js
+++ b/test/http.meta.js
@@ -1,5 +1,7 @@
var http = require('http');
+var PORT = 8889;
+
var server = http.createServer(function(req, res){
var accept = req.headers.accept || ''
, json = ~accept.indexOf('json');
@@ -16,13 +18,12 @@ var server = http.createServer(function(req, res){
}
break;
}
-})
+});
-server.listen(8889);
function get(url, body, header) {
return function(done){
- http.get({ path: url, port: 8889, headers: header }, function(res){
+ http.get({ path: url, port: PORT, headers: header || {}}, function(res){
var buf = '';
res.should.have.property('statusCode', 200);
res.setEncoding('utf8');
@@ -35,8 +36,17 @@ function get(url, body, header) {
}
}
-describe('http requests', function(){
- describe('GET /', function(){
+describe('http requests', function () {
+
+ before(function(done) {
+ server.listen(PORT, done);
+ });
+
+ after(function() {
+ server.close();
+ });
+
+ describe('GET /', function () {
it('should respond with hello',
get('/', 'hello'))
})