☕️ Classic, reliable, trusted test framework for Node.js and the browser
fix(reporter/base): explicitly ignore showDiff #1614
Ariel Mashraki88fa08f200f1
diff --git a/lib/reporters/base.js b/lib/reporters/base.jsindex c253c11f..9cae455b 100644--- a/lib/reporters/base.js+++ b/lib/reporters/base.js@@ -179,7 +179,7 @@ exports.list = function(failures){msg = 'Uncaught ' + msg;}// explicitly show diff- if (err.showDiff && sameType(actual, expected)) {+ if (err.showDiff !== false && sameType(actual, expected)) {if ('string' !== typeof actual) {escape = false;diff --git a/test/reporters/base.js b/test/reporters/base.jsindex d285bf88..d8ca2c7b 100644--- a/test/reporters/base.js+++ b/test/reporters/base.js@@ -1,40 +1,90 @@-var Base = require('../../lib/reporters/base');+var Base = require('../../lib/reporters/base')+ , Assert = require('assert').AssertionError;describe('Base reporter', function () {- it('should show diffs with showDiff property set', function () {- var err = new Error('test'),- stdout = [],- stdoutWrite = process.stdout.write,- errOut;-- err.actual = "a1";- err.expected = "e1";- err.showDiff = true;- var test = {- err: err,- fullTitle: function () {- return 'title';- }- };-- process.stdout.write = function (string) {- stdout.push(string);- };-- Base.list([test]);-- process.stdout.write = stdoutWrite;-- errOut = stdout.join('\n');-- errOut.should.match(/test/);- errOut.should.match(/actual/);- errOut.should.match(/expected/);-+ describe('showDiff', function() {+ it('should show diffs by default', function () {+ var err = new Assert({ actual: 'foo', expected: 'bar' })+ , stdout = []+ , stdoutWrite = process.stdout.write+ , errOut;++ var test = {+ err: err,+ fullTitle: function () {+ return 'test title';+ }+ };++ process.stdout.write = function (string) {+ stdout.push(string);+ };++ Base.list([test]);++ process.stdout.write = stdoutWrite;++ errOut = stdout.join('\n');+ errOut.should.match(/actual/);+ errOut.should.match(/expected/);+ });++ it('should show diffs if property set to `true`', function () {+ var err = new Assert({ actual: 'foo', expected: 'bar' })+ , stdout = []+ , stdoutWrite = process.stdout.write+ , errOut;++ err.showDiff = true;+ var test = {+ err: err,+ fullTitle: function () {+ return 'test title';+ }+ };++ process.stdout.write = function (string) {+ stdout.push(string);+ };++ Base.list([test]);++ process.stdout.write = stdoutWrite;++ errOut = stdout.join('\n');+ errOut.should.match(/actual/);+ errOut.should.match(/expected/);+ });++ it('should not show diffs when showDiff property set to `false`', function () {+ var err = new Assert({ actual: 'foo', expected: 'bar' })+ , stdout = []+ , stdoutWrite = process.stdout.write+ , errOut;++ err.showDiff = false;+ var test = {+ err: err,+ fullTitle: function () {+ return 'test title';+ }+ };++ process.stdout.write = function (string) {+ stdout.push(string);+ };++ Base.list([test]);++ process.stdout.write = stdoutWrite;++ errOut = stdout.join('\n');+ errOut.should.not.match(/actual/);+ errOut.should.not.match(/expected/);+ });});-it('should not stringify strings', function () {var err = new Error('test'),stdout = [],@@ -99,38 +149,5 @@ describe('Base reporter', function () {errOut.should.match(/test/);errOut.should.match(/actual/);errOut.should.match(/expected/);-- });-- it('should not show diffs when showDiff property set', function () {- var err = new Error('test'),- stdout = [],- stdoutWrite = process.stdout.write,- errOut;-- err.actual = "a1";- err.expected = "e1";- err.showDiff = false;- var test = {- err: err,- fullTitle: function () {- return 'title';- }- };-- process.stdout.write = function (string) {- stdout.push(string);- };-- Base.list([test]);-- process.stdout.write = stdoutWrite;-- errOut = stdout.join('\n');-- errOut.should.match(/test/);- errOut.should.not.match(/actual/);- errOut.should.not.match(/expected/);-});});